40329 2010-06-08 13:28:16 -0700 postMessage should serialise dom objects to null by default 2010-06-17 15:21:50 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC All ASSIGNED P2 Normal --- 39757 1 kim.1.gronholm oliver hausmann kim.1.gronholm laszlo.gombos oliver oldest_to_newest 235481 0 kim.1.gronholm 2010-06-08 13:28:16 -0700 Internal structured cloning algorithm should result in null when attempting to serialise Dom objects that are not real JS objects. This is not the case currently as can be seen in the test: LayoutTests/fast/dom/Window/window-postmessage-clone.html Also the expected output of the layout test is wrong. 235487 1 kim.1.gronholm 2010-06-08 13:35:32 -0700 *** Bug 40232 has been marked as a duplicate of this bug. *** 238989 2 58911 kim.1.gronholm 2010-06-16 11:31:10 -0700 Created attachment 58911 Removes the test case with wrong expected output Temporarily disabling the postMessage(window, "*") test as the expected result and the behavior are both wrong. This doesn't fix the actual issue but prevents the test case from failing due to any unrelated changes. The test case should be enabled again with correct expected output after the bug has been fixed. 239597 3 ap 2010-06-17 15:17:18 -0700 From IRC discussion: - currently, the subtest raises "TypeError: Cannot post cyclic structures"; - with an unrelated patch, a different exception is raised, because the order of traversal changes; - the correct behavior is to return null. 239600 4 58911 ap 2010-06-17 15:21:50 -0700 Comment on attachment 58911 Removes the test case with wrong expected output It's best to keep this subtest to make sure that we don't break window serialization even more (e.g. that we don't start to crash). I think that the best way to proceed is to change this subtest's results in the same unrelated change that will affect it. 58911 2010-06-16 11:31:10 -0700 2010-06-17 15:21:50 -0700 Removes the test case with wrong expected output tmp-removetest-40329 text/plain 2466 kim.1.gronholm ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzMGU2ZmRiLi5iZDVlYWY4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMDYt MTYgIEtpbSBHcsO2bmhvbG0gIDxraW0uMS5ncm9uaG9sbUBub2tpYS5jb20+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgcG9zdE1lc3NhZ2Ugc2hvdWxk IHNlcmlhbGlzZSBkb20gb2JqZWN0cyB0byBudWxsIGJ5IGRlZmF1bHQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwMzI5CisKKyAgICAgICAgVGVtcG9y YXJpbHkgZGlzYWJsaW5nIHRoZSBwb3N0TWVzc2FnZSh3aW5kb3csICIqIikgdGVzdCBhcyB0aGUg ZXhwZWN0ZWQKKyAgICAgICAgcmVzdWx0IGFuZCB0aGUgYmVoYXZpb3IgYXJlIGJvdGggd3Jvbmcu IFRoaXMgZG9lc24ndCBmaXggdGhlIGFjdHVhbAorICAgICAgICBpc3N1ZSBidXQgcHJldmVudHMg dGhlIGludmFsaWQgdGVzdCBjYXNlIGZyb20gZmFpbGluZyBkdWUgdG8gYW55CisgICAgICAgIHVu cmVsYXRlZCBjaGFuZ2VzLiBUaGUgdGVzdCBjYXNlIHNob3VsZCBiZSBlbmFibGVkIGFnYWluIHdp dGggY29ycmVjdAorICAgICAgICBleHBlY3RlZCBvdXRwdXQgYWZ0ZXIgdGhlIGJ1ZyBoYXMgYmVl biBmaXhlZC4KKworICAgICAgICAqIGZhc3QvZG9tL1dpbmRvdy93aW5kb3ctcG9zdG1lc3NhZ2Ut Y2xvbmUtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZhc3QvZG9tL1dpbmRvdy93aW5kb3ctcG9z dG1lc3NhZ2UtY2xvbmUuaHRtbDoKKwogMjAxMC0wNi0wNiAgTU9SSVRBIEhhamltZSAgPG1vcnJp dGFAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW50IFRhbXVyYS4KZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL1dpbmRvdy93aW5kb3ctcG9zdG1lc3NhZ2UtY2xv bmUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L3dpbmRvdy1wb3N0 bWVzc2FnZS1jbG9uZS1leHBlY3RlZC50eHQKaW5kZXggNmRmMjVhZi4uYmE1MmFjZCAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L3dpbmRvdy1wb3N0bWVzc2FnZS1jbG9u ZS1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L3dpbmRvdy1w b3N0bWVzc2FnZS1jbG9uZS1leHBlY3RlZC50eHQKQEAgLTIsNyArMiw2IEBAIFRlc3RzIHRoYXQg d2UgY2xvbmUgb2JqZWN0IGhpZXJhcmNoaWVzCiBQQVNTOiAncG9zdE1lc3NhZ2UoY3ljbGljT2Jq ZWN0KScgdGhyZXcgVHlwZUVycm9yOiBDYW5ub3QgcG9zdCBjeWNsaWMgc3RydWN0dXJlcy4KIFBB U1M6ICdwb3N0TWVzc2FnZShjeWNsaWNBcnJheSknIHRocmV3IFR5cGVFcnJvcjogQ2Fubm90IHBv c3QgY3ljbGljIHN0cnVjdHVyZXMuCiBQQVNTOiAncG9zdE1lc3NhZ2UocmVhbGx5RGVlcEFycmF5 KScgdGhyZXcgUmFuZ2VFcnJvcjogTWF4aW11bSBjYWxsIHN0YWNrIHNpemUgZXhjZWVkZWQuCi1Q QVNTOiAncG9zdE1lc3NhZ2Uod2luZG93KScgdGhyZXcgVHlwZUVycm9yOiBDYW5ub3QgcG9zdCBj eWNsaWMgc3RydWN0dXJlcy4KIFBBU1M6IGV2ZW50RGF0YSBpcyBudWxsIG9mIHR5cGUgb2JqZWN0 CiBQQVNTOiBldmVudERhdGEgaXMgdW5kZWZpbmVkIG9mIHR5cGUgdW5kZWZpbmVkCiBQQVNTOiBl dmVudERhdGEgaXMgMSBvZiB0eXBlIG51bWJlcgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFz dC9kb20vV2luZG93L3dpbmRvdy1wb3N0bWVzc2FnZS1jbG9uZS5odG1sIGIvTGF5b3V0VGVzdHMv ZmFzdC9kb20vV2luZG93L3dpbmRvdy1wb3N0bWVzc2FnZS1jbG9uZS5odG1sCmluZGV4IGU3NTVm NGEuLmMyMzgyOWIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL1dpbmRvdy93aW5k b3ctcG9zdG1lc3NhZ2UtY2xvbmUuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5k b3cvd2luZG93LXBvc3RtZXNzYWdlLWNsb25lLmh0bWwKQEAgLTE0NCw3ICsxNDQsOSBAQCByZWFs bHlEZWVwQXJyYXk9W107CiBmb3IgKHZhciBpID0gMDsgaSA8IDEwMDAwMDsgaSsrKQogICAgIHJl YWxseURlZXBBcnJheT1bcmVhbGx5RGVlcEFycmF5XTsKIHRyeVBvc3RNZXNzYWdlKCdyZWFsbHlE ZWVwQXJyYXknLCB0cnVlKTsKLXRyeVBvc3RNZXNzYWdlKCd3aW5kb3cnLCB0cnVlKTsKKworLy8g RGlzYWJsZWQgZHVlIHRvOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NDAzMjkKKy8vdHJ5UG9zdE1lc3NhZ2UoJ3dpbmRvdycsIHRydWUpOwogCiBpZiAod2luZG93LmV2 ZW50U2VuZGVyKSB7CiAgICAgdmFyIGZpbGVJbnB1dCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlk KCJmaWxlSW5wdXQiKTsK