40324 2010-06-08 12:35:32 -0700 [Qt] DRT EventSender support to graphics context events 2010-06-15 06:32:40 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt P2 Normal --- 40014 1 diegohcg diegohcg abarth commit-queue eric hausmann kenneth tonikitoo webkit.review.bot oldest_to_newest 235435 0 diegohcg 2010-06-08 12:35:32 -0700 Make possible to run context menu test in graphics based view mode 236938 1 58490 diegohcg 2010-06-11 11:32:50 -0700 Created attachment 58490 Patch 236943 2 tonikitoo 2010-06-11 11:40:13 -0700 (In reply to comment #1) > Created an attachment (id=58490) [details] > Patch lgtm 237125 3 58490 kenneth 2010-06-11 16:35:09 -0700 Comment on attachment 58490 Patch WebKitTools/DumpRenderTree/qt/EventSenderQt.cpp:347 + WebCore::WebViewGraphicsBased* view = qobject_cast<WebCore::WebViewGraphicsBased*>(m_page->view()); as you sure this is right? We normally do not set the view when dealing with QGraphicsWebView. And even if you set it, it seems like a hack. It would be nice to do this in another way Anyway, looks fine. 237823 4 58490 diegohcg 2010-06-14 08:01:11 -0700 Comment on attachment 58490 Patch Just to do some tests 238347 5 58490 commit-queue 2010-06-15 06:21:55 -0700 Comment on attachment 58490 Patch Clearing flags on attachment: 58490 Committed r61184: <http://trac.webkit.org/changeset/61184> 238348 6 commit-queue 2010-06-15 06:22:02 -0700 All reviewed patches have been landed. Closing bug. 238350 7 webkit.review.bot 2010-06-15 06:28:06 -0700 http://trac.webkit.org/changeset/61184 might have broken Qt Linux Release minimal 238353 8 tonikitoo 2010-06-15 06:32:40 -0700 (In reply to comment #7) > http://trac.webkit.org/changeset/61184 might have broken Qt Linux Release minimal diego, you possibly need this #ifndef QT_NO_CONTEXTMENU wrapping the code 58490 2010-06-11 11:32:50 -0700 2010-06-15 06:21:54 -0700 Patch 0001-Qt-DRT-EventSender-support-to-graphics-context-events.diff text/plain 2324 diegohcg RnJvbSA0N2EyZWFkNTgxOGEzMjUzZjZjZWRmNTJiY2VkZDU2NzE1MzAwZjhlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEaWVnbyBHb256YWxleiA8ZGllZ29oY2dAd2Via2l0Lm9yZz4K RGF0ZTogRnJpLCAxMSBKdW4gMjAxMCAxNDozMToxOCAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIFtR dF0gRFJUIEV2ZW50U2VuZGVyIHN1cHBvcnQgdG8gZ3JhcGhpY3MgY29udGV4dCBldmVudHMKIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDMyNAoKUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCgoqIER1bXBSZW5kZXJUcmVlL3F0L0V2ZW50U2VuZGVyUXQuY3BwOgoo RXZlbnRTZW5kZXI6OmNvbnRleHRDbGljayk6Ci0tLQogV2ViS2l0VG9vbHMvQ2hhbmdlTG9nICAg ICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDEwICsrKysrKysrKysKIFdlYktpdFRvb2xzL0R1 bXBSZW5kZXJUcmVlL3F0L0V2ZW50U2VuZGVyUXQuY3BwIHwgICAxNCArKysrKysrKysrKystLQog MiBmaWxlcyBjaGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxvZwppbmRl eCA2ZjA4NzE3Li5iYTljZTg4IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VMb2cKKysr IGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDYtMTEgIERp ZWdvIEdvbnphbGV6ICA8ZGllZ29oY2dAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIERSVCBFdmVudFNlbmRlciBzdXBwb3J0 IHRvIGdyYXBoaWNzIGNvbnRleHQgZXZlbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD00MDMyNAorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvcXQv RXZlbnRTZW5kZXJRdC5jcHA6CisgICAgICAgIChFdmVudFNlbmRlcjo6Y29udGV4dENsaWNrKToK KwogMjAxMC0wNi0xMSAgWWFlbCBBaGFyb24gIDx5YWVsLmFoYXJvbkBub2tpYS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgTGFzemxvIEdvbWJvcy4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xz L0R1bXBSZW5kZXJUcmVlL3F0L0V2ZW50U2VuZGVyUXQuY3BwIGIvV2ViS2l0VG9vbHMvRHVtcFJl bmRlclRyZWUvcXQvRXZlbnRTZW5kZXJRdC5jcHAKaW5kZXggN2VjNTA1Zi4uOTAyMjZkMCAxMDA2 NDQKLS0tIGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRXZlbnRTZW5kZXJRdC5jcHAK KysrIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRXZlbnRTZW5kZXJRdC5jcHAKQEAg LTMzOSw4ICszMzksMTggQEAgdm9pZCBFdmVudFNlbmRlcjo6Y29udGV4dENsaWNrKCkKICAgICBz ZW5kRXZlbnQobV9wYWdlLCAmZXZlbnQpOwogICAgIFFNb3VzZUV2ZW50IGV2ZW50MihRRXZlbnQ6 Ok1vdXNlQnV0dG9uUmVsZWFzZSwgbV9tb3VzZVBvcywgUXQ6OlJpZ2h0QnV0dG9uLCBRdDo6Umln aHRCdXR0b24sIFF0OjpOb01vZGlmaWVyKTsKICAgICBzZW5kRXZlbnQobV9wYWdlLCAmZXZlbnQy KTsKLSAgICBRQ29udGV4dE1lbnVFdmVudCBldmVudDMoUUNvbnRleHRNZW51RXZlbnQ6Ok1vdXNl LCBtX21vdXNlUG9zKTsKLSAgICBzZW5kRXZlbnQobV9wYWdlLT52aWV3KCksICZldmVudDMpOwor CisgICAgaWYgKGlzR3JhcGhpY3NCYXNlZCgpKSB7CisgICAgICAgIFFHcmFwaGljc1NjZW5lQ29u dGV4dE1lbnVFdmVudCBjdHhFdmVudChRRXZlbnQ6OkdyYXBoaWNzU2NlbmVDb250ZXh0TWVudSk7 CisgICAgICAgIGN0eEV2ZW50LnNldFJlYXNvbihRR3JhcGhpY3NTY2VuZUNvbnRleHRNZW51RXZl bnQ6Ok1vdXNlKTsKKyAgICAgICAgY3R4RXZlbnQuc2V0UG9zKG1fbW91c2VQb3MpOworICAgICAg ICBXZWJDb3JlOjpXZWJWaWV3R3JhcGhpY3NCYXNlZCogdmlldyA9IHFvYmplY3RfY2FzdDxXZWJD b3JlOjpXZWJWaWV3R3JhcGhpY3NCYXNlZCo+KG1fcGFnZS0+dmlldygpKTsKKyAgICAgICAgaWYg KHZpZXcpCisgICAgICAgICAgICBzZW5kRXZlbnQodmlldy0+Z3JhcGhpY3NWaWV3KCksICZjdHhF dmVudCk7CisgICAgfSBlbHNlIHsKKyAgICAgICAgUUNvbnRleHRNZW51RXZlbnQgY3R4RXZlbnQo UUNvbnRleHRNZW51RXZlbnQ6Ok1vdXNlLCBtX21vdXNlUG9zKTsKKyAgICAgICAgc2VuZEV2ZW50 KG1fcGFnZS0+dmlldygpLCAmY3R4RXZlbnQpOworICAgIH0KIH0KIAogdm9pZCBFdmVudFNlbmRl cjo6c2NoZWR1bGVBc3luY2hyb25vdXNDbGljaygpCi0tIAoxLjcuMC40Cgo=