40317 2010-06-08 11:58:10 -0700 [Chromium] Pass <video> full screen calls to Chromium port client 2010-06-09 21:26:45 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 boliu webkit-unassigned commit-queue scherkus oldest_to_newest 235410 0 boliu 2010-06-08 11:58:10 -0700 Start work on supporting full screen <video> elements. First pass calls for full screen controls to the Chromium client. Corresponding patch for Chromium at http://codereview.chromium.org/2775001/show 235424 1 58168 boliu 2010-06-08 12:14:46 -0700 Created attachment 58168 Patch 235526 2 58168 levin 2010-06-08 14:27:18 -0700 Comment on attachment 58168 Patch Looks good to me plus Andrew Scherkus said it looked good. 236148 3 58168 commit-queue 2010-06-09 21:26:40 -0700 Comment on attachment 58168 Patch Clearing flags on attachment: 58168 Committed r60934: <http://trac.webkit.org/changeset/60934> 236149 4 commit-queue 2010-06-09 21:26:45 -0700 All reviewed patches have been landed. Closing bug. 58168 2010-06-08 12:14:46 -0700 2010-06-09 21:26:40 -0700 Patch bug-40317-20100608121445.patch text/plain 3450 boliu ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDAzYjFjZDE2YzhkOWQ1ZTM4YzViNTBjNjE1Y2EzNmYwZmIyZGUxYzku Ljk3MmI4ZWE0OGMxOWFjNWUyNmYwODIxMmViZTBhYWYzZDg3NjdlMWUgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDIwIEBACisyMDEwLTA2LTA4ICBCbyBMaXUgIDxib2xpdUBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0Nocm9t aXVtXSBQYXNzIDx2aWRlbz4gZnVsbCBzY3JlZW4gY2FsbHMgdG8gQ2hyb21pdW0gcG9ydCBjbGll bnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwMzE3 CisKKyAgICAgICAgKiBwdWJsaWMvV2ViVmlld0NsaWVudC5oOgorICAgICAgICAoV2ViS2l0OjpX ZWJWaWV3Q2xpZW50OjpzdXBwb3J0c0Z1bGxzY3JlZW4pOgorICAgICAgICAoV2ViS2l0OjpXZWJW aWV3Q2xpZW50OjplbnRlckZ1bGxzY3JlZW5Gb3JOb2RlKToKKyAgICAgICAgKFdlYktpdDo6V2Vi Vmlld0NsaWVudDo6ZXhpdEZ1bGxzY3JlZW5Gb3JOb2RlKToKKyAgICAgICAgKiBzcmMvQ2hyb21l Q2xpZW50SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkNocm9tZUNsaWVudEltcGw6OnN1cHBv cnRzRnVsbHNjcmVlbkZvck5vZGUpOgorICAgICAgICAoV2ViS2l0OjpDaHJvbWVDbGllbnRJbXBs OjplbnRlckZ1bGxzY3JlZW5Gb3JOb2RlKToKKyAgICAgICAgKFdlYktpdDo6Q2hyb21lQ2xpZW50 SW1wbDo6ZXhpdEZ1bGxzY3JlZW5Gb3JOb2RlKToKKyAgICAgICAgKiBzcmMvQ2hyb21lQ2xpZW50 SW1wbC5oOgorCiAyMDEwLTA2LTA4ICBZdXJ5IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4uCmRpZmYgLS1naXQgYS9X ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlZpZXdDbGllbnQuaCBiL1dlYktpdC9jaHJvbWl1bS9w dWJsaWMvV2ViVmlld0NsaWVudC5oCmluZGV4IDRhNzkxYzI2YjA0YmY4Yzk2NGZkYzhmNjlkYTZi MzNkNWQyMjI4MGUuLmYwMjVlMDg0MjIyMTEwMDdhNTcxOTU2ZDUwZGIwZDcwYjhkZjU3YzEgMTAw NjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVmlld0NsaWVudC5oCisrKyBiL1dl YktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVmlld0NsaWVudC5oCkBAIC0yMDIsNiArMjAyLDkgQEAg cHVibGljOgogICAgIHZpcnR1YWwgYm9vbCBydW5Nb2RhbEJlZm9yZVVubG9hZERpYWxvZygKICAg ICAgICAgV2ViRnJhbWUqLCBjb25zdCBXZWJTdHJpbmcmIG1lc3NhZ2UpIHsgcmV0dXJuIHRydWU7 IH0KIAorICAgIHZpcnR1YWwgYm9vbCBzdXBwb3J0c0Z1bGxzY3JlZW4oKSB7IHJldHVybiBmYWxz ZTsgfQorICAgIHZpcnR1YWwgdm9pZCBlbnRlckZ1bGxzY3JlZW5Gb3JOb2RlKGNvbnN0IFdlYk5v ZGUmKSB7IH0KKyAgICB2aXJ0dWFsIHZvaWQgZXhpdEZ1bGxzY3JlZW5Gb3JOb2RlKGNvbnN0IFdl Yk5vZGUmKSB7IH0KIAogICAgIC8vIFVJIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogCmRpZmYgLS1naXQgYS9XZWJLaXQv Y2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9D aHJvbWVDbGllbnRJbXBsLmNwcAppbmRleCA2NTkxMGY4MzFiYzc0MDA0MjM3ZTIxZjZkNDRjMjkz NzFmNjY3OWJjLi5hOTQ0ZDQ4ZTU5NzQwMmYwZmM2YTVhNmFhMWJmODI0NmM3ZjMyMjcyIDEwMDY0 NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwCisrKyBiL1dl YktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAKQEAgLTcyOSw0ICs3MjksMjMg QEAgdm9pZCBDaHJvbWVDbGllbnRJbXBsOjpzY2hlZHVsZUNvbXBvc2l0aW5nTGF5ZXJTeW5jKCkK IH0KICNlbmRpZgogCitib29sIENocm9tZUNsaWVudEltcGw6OnN1cHBvcnRzRnVsbHNjcmVlbkZv ck5vZGUoY29uc3QgV2ViQ29yZTo6Tm9kZSogbm9kZSkKK3sKKyAgICBpZiAobV93ZWJWaWV3LT5j bGllbnQoKSAmJiBub2RlLT5oYXNUYWdOYW1lKFdlYkNvcmU6OkhUTUxOYW1lczo6dmlkZW9UYWcp KQorICAgICAgICByZXR1cm4gbV93ZWJWaWV3LT5jbGllbnQoKS0+c3VwcG9ydHNGdWxsc2NyZWVu KCk7CisgICAgcmV0dXJuIGZhbHNlOworfQorCit2b2lkIENocm9tZUNsaWVudEltcGw6OmVudGVy RnVsbHNjcmVlbkZvck5vZGUoV2ViQ29yZTo6Tm9kZSogbm9kZSkKK3sKKyAgICBpZiAobV93ZWJW aWV3LT5jbGllbnQoKSkKKyAgICAgICAgbV93ZWJWaWV3LT5jbGllbnQoKS0+ZW50ZXJGdWxsc2Ny ZWVuRm9yTm9kZShXZWJOb2RlKG5vZGUpKTsKK30KKwordm9pZCBDaHJvbWVDbGllbnRJbXBsOjpl eGl0RnVsbHNjcmVlbkZvck5vZGUoV2ViQ29yZTo6Tm9kZSogbm9kZSkKK3sKKyAgICBpZiAobV93 ZWJWaWV3LT5jbGllbnQoKSkKKyAgICAgICAgbV93ZWJWaWV3LT5jbGllbnQoKS0+ZXhpdEZ1bGxz Y3JlZW5Gb3JOb2RlKFdlYk5vZGUobm9kZSkpOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQK ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5oIGIvV2Vi S2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmgKaW5kZXggM2I1ZWJkNTJiMDJiYmY5 YzJiYWIzNGFhNjkwMjk2OGUwYTkxMmI1Ni4uODQzNTVjMzk5ZTRlZWZlMmYwYzk0ZTZjZDQ5MzZl MDMyYzRkZDQwNSAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJ bXBsLmgKKysrIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmgKQEAgLTE0 Niw2ICsxNDYsMTAgQEAgcHVibGljOgogICAgIC8vIHRvIGRvIGFuIGVhZ2VyIGxheW91dCBiZWZv cmUgdGhlIGRyYXdpbmcuCiAgICAgdmlydHVhbCB2b2lkIHNjaGVkdWxlQ29tcG9zaXRpbmdMYXll clN5bmMoKTsKICNlbmRpZgorICAgIHZpcnR1YWwgYm9vbCBzdXBwb3J0c0Z1bGxzY3JlZW5Gb3JO b2RlKGNvbnN0IFdlYkNvcmU6Ok5vZGUqKTsKKyAgICB2aXJ0dWFsIHZvaWQgZW50ZXJGdWxsc2Ny ZWVuRm9yTm9kZShXZWJDb3JlOjpOb2RlKik7CisgICAgdmlydHVhbCB2b2lkIGV4aXRGdWxsc2Ny ZWVuRm9yTm9kZShXZWJDb3JlOjpOb2RlKik7CisKICAgICAvLyBDaHJvbWVDbGllbnRDaHJvbWl1 bSBtZXRob2RzOgogICAgIHZpcnR1YWwgdm9pZCBwb3B1cE9wZW5lZChXZWJDb3JlOjpQb3B1cENv bnRhaW5lciogcG9wdXBDb250YWluZXIsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNv bnN0IFdlYkNvcmU6OkludFJlY3QmIGJvdW5kcywK