40315 2010-06-08 11:47:40 -0700 Vertex attributes enabled as arrays but not bound to buffers must generate INVALID_OPERATION 2010-06-11 05:16:35 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kbr zmo cmarrin commit-queue dglazkov oliver zmo oldest_to_newest 235405 0 kbr 2010-06-08 11:47:40 -0700 Per recent WebGL specification changes, if a vertex attribute is enabled as an array but has not been bound to a buffer object by a pair of calls to bindBuffer / vertexAttribPointer, calls to drawArrays and drawElements must generate an INVALID_OPERATION error. 236434 1 58386 zmo 2010-06-10 10:47:51 -0700 Created attachment 58386 patch 236596 2 58386 kbr 2010-06-10 17:23:26 -0700 Comment on attachment 58386 patch Looks good. 236670 3 58386 dglazkov 2010-06-10 21:33:08 -0700 Comment on attachment 58386 patch ok, with a clean-up suggestion: WebCore/html/canvas/WebGLRenderingContext.cpp:2936 + m_vertexAttribState[indx].bufferBinding = m_boundArrayBuffer; Typically, we try not to abbreviate names. 236789 4 58386 commit-queue 2010-06-11 05:16:29 -0700 Comment on attachment 58386 patch Clearing flags on attachment: 58386 Committed r61006: <http://trac.webkit.org/changeset/61006> 236790 5 commit-queue 2010-06-11 05:16:35 -0700 All reviewed patches have been landed. Closing bug. 58386 2010-06-10 10:47:51 -0700 2010-06-11 05:16:28 -0700 patch va.patch text/plain 5188 zmo SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MDk2NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDYtMTAgIFpoZW55YW8gTW8gIDx6bW9AZ29vZ2xlLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBWZXJ0ZXgg YXR0cmlidXRlcyBlbmFibGVkIGFzIGFycmF5cyBidXQgbm90IGJvdW5kIHRvIGJ1ZmZlcnMgbXVz dCBnZW5lcmF0ZSBJTlZBTElEX09QRVJBVElPTgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDAzMTUKKworICAgICAgICAqIGh0bWwvY2FudmFzL1dlYkdM UmVuZGVyaW5nQ29udGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXZWJHTFJlbmRlcmluZ0Nv bnRleHQ6OnZhbGlkYXRlUmVuZGVyaW5nU3RhdGUpOiBDaGVjayBpZiBhbiBlbmFibGVkIHZlcnRl eHQgYXR0cmlicyBpcyBib3VuZCB0byBhIGJ1ZmZlci4KKyAgICAgICAgKFdlYkNvcmU6OldlYkdM UmVuZGVyaW5nQ29udGV4dDo6dmVydGV4QXR0cmliUG9pbnRlcik6IFNldCBib3VuZCBidWZmZXIg aW4gdmVydGV4IGF0dHJpYiBzdGF0ZS4KKyAgICAgICAgKiBodG1sL2NhbnZhcy9XZWJHTFJlbmRl cmluZ0NvbnRleHQuaDogQWRkIGEgbWVtYmVyIGluIHZlcnRleCBhdHRyaWIgc3RhdGUgdG8gdHJh Y2sgYm91bmQgYnVmZmVyLgorCiAyMDEwLTA2LTEwICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtp dC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBXZWJDb3Jl L2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwCShyZXZpc2lvbiA2MDky NykKKysrIFdlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcAkod29y a2luZyBjb3B5KQpAQCAtNzU1LDcgKzc1NSwxNCBAQCBib29sIFdlYkdMUmVuZGVyaW5nQ29udGV4 dDo6dmFsaWRhdGVSZW5kCiAgICAgaWYgKCFtX2N1cnJlbnRQcm9ncmFtKQogICAgICAgICByZXR1 cm4gZmFsc2U7CiAKLSAgICAvLyBMb29rIGluIGVhY2ggZW5hYmxlZCB2ZXJ0ZXggYXR0cmliIGFu ZCBmaW5kIHRoZSBzbWFsbGVzdCBidWZmZXIgc2l6ZQorICAgIC8vIExvb2sgaW4gZWFjaCBlbmFi bGVkIHZlcnRleCBhdHRyaWIgYW5kIGNoZWNrIGlmIHRoZXkndmUgYmVlbiBib3VuZCB0byBhIGJ1 ZmZlci4KKyAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IG1fdmVydGV4QXR0cmliU3RhdGUuc2l6 ZSgpOyArK2kpIHsKKyAgICAgICAgaWYgKG1fdmVydGV4QXR0cmliU3RhdGVbaV0uZW5hYmxlZAor ICAgICAgICAgICAgJiYgKCFtX3ZlcnRleEF0dHJpYlN0YXRlW2ldLmJ1ZmZlckJpbmRpbmcgfHwg IW1fdmVydGV4QXR0cmliU3RhdGVbaV0uYnVmZmVyQmluZGluZy0+b2JqZWN0KCkpKQorICAgICAg ICAgICAgcmV0dXJuIGZhbHNlOworICAgIH0KKworICAgIC8vIExvb2sgaW4gZWFjaCBjb25zdW1l ZCB2ZXJ0ZXggYXR0cmliIChieSB0aGUgY3VycmVudCBwcm9ncmFtKSBhbmQgZmluZCB0aGUgc21h bGxlc3QgYnVmZmVyIHNpemUKICAgICBsb25nIHNtYWxsZXN0TnVtRWxlbWVudHMgPSBMT05HX01B WDsKICAgICBpbnQgbnVtQWN0aXZlQXR0cmliTG9jYXRpb25zID0gbV9jdXJyZW50UHJvZ3JhbS0+ bnVtQWN0aXZlQXR0cmliTG9jYXRpb25zKCk7CiAgICAgaW50IG51bUF0dHJpYlN0YXRlcyA9IHN0 YXRpY19jYXN0PGludD4obV92ZXJ0ZXhBdHRyaWJTdGF0ZS5zaXplKCkpOwpAQCAtMjkyNSw3ICsy OTMyLDggQEAgdm9pZCBXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OnZlcnRleEF0dHJpYgogICAgICAg ICAKICAgICAgICAgdmFsaWRhdGVkU3RyaWRlID0gc3RyaWRlOwogICAgIH0KLSAgICAgICAgCisK KyAgICBtX3ZlcnRleEF0dHJpYlN0YXRlW2luZHhdLmJ1ZmZlckJpbmRpbmcgPSBtX2JvdW5kQXJy YXlCdWZmZXI7CiAgICAgLy8gQXZvaWQgb2ZmLWJ5LW9uZSBlcnJvcnMgaW4gbnVtRWxlbWVudHMg Y29tcHV0YXRpb24uCiAgICAgLy8gRm9yIHRoZSBsYXN0IGVsZW1lbnQsIHdlIHdpbGwgb25seSB0 b3VjaCB0aGUgZGF0YSBmb3IgdGhlCiAgICAgLy8gZWxlbWVudCBhbmQgbm90aGluZyBiZXlvbmQg aXQuCkluZGV4OiBXZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmgJ KHJldmlzaW9uIDYwOTI3KQorKysgV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0Nv bnRleHQuaAkod29ya2luZyBjb3B5KQpAQCAtMzQwLDYgKzM0MCw3IEBAIGNsYXNzIFdlYktpdENT U01hdHJpeDsKICAgICAgICAgICAgIFZlcnRleEF0dHJpYlN0YXRlKCkgOiBlbmFibGVkKGZhbHNl KSwgbnVtRWxlbWVudHMoMCkgeyB9CiAgICAgICAgICAgICBib29sIGVuYWJsZWQ7CiAgICAgICAg ICAgICBsb25nIG51bUVsZW1lbnRzOworICAgICAgICAgICAgUmVmUHRyPFdlYkdMQnVmZmVyPiBi dWZmZXJCaW5kaW5nOwogICAgICAgICB9OwogICAgICAgICAKICAgICAgICAgVmVjdG9yPFZlcnRl eEF0dHJpYlN0YXRlPiBtX3ZlcnRleEF0dHJpYlN0YXRlOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNjA5 NjQpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwx MyBAQAorMjAxMC0wNi0xMCAgWmhlbnlhbyBNbyAgPHptb0Bnb29nbGUuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFZlcnRleCBhdHRyaWJ1dGVz IGVuYWJsZWQgYXMgYXJyYXlzIGJ1dCBub3QgYm91bmQgdG8gYnVmZmVycyBtdXN0IGdlbmVyYXRl IElOVkFMSURfT1BFUkFUSU9OCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD00MDMxNQorCisgICAgICAgICogZmFzdC9jYW52YXMvd2ViZ2wvaW5kZXgtdmFs aWRhdGlvbi1leHBlY3RlZC50eHQ6IEdlbmVyYXRlIElOVkFMSURfRVJST1Igd2hlbiBhbiBlbmFi bGVkIHZlcnRleCBhdHRyaWIgaXMgbm90IGJvdW5kIHRvIGFueSBidWZmZXIgaW4gZHJhd0VsZW1l bnRzKCkuCisgICAgICAgICogZmFzdC9jYW52YXMvd2ViZ2wvc2NyaXB0LXRlc3RzL2luZGV4LXZh bGlkYXRpb24uanM6IERpdHRvLgorCiAyMDEwLTA2LTEwICBDaGFuZyBTaHUgIDxjaGFuZy5zaHVA bm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFu c2VuLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvaW5kZXgtdmFsaWRhdGlv bi1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2Vi Z2wvaW5kZXgtdmFsaWRhdGlvbi1leHBlY3RlZC50eHQJKHJldmlzaW9uIDYwOTI3KQorKysgTGF5 b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvaW5kZXgtdmFsaWRhdGlvbi1leHBlY3RlZC50eHQJ KHdvcmtpbmcgY29weSkKQEAgLTIwLDcgKzIwLDcgQEAgVGVzdCB3aXRoIGVuYWJsZWQgYXR0cmli dXRlIHRoYXQgZG9lcyBubwogRW5hYmxlIGFuIGV4dHJhIGF0dHJpYnV0ZSB3aXRoIG51bGwKIFBB U1MgZ2wuZ2V0RXJyb3IoKSBpcyAwCiBQQVNTIGdsLmRyYXdFbGVtZW50cyhnbC5UUklBTkdMRVMs IDMsIGdsLlVOU0lHTkVEX1NIT1JULCAwKSBpcyB1bmRlZmluZWQuCi1QQVNTIGdsLmdldEVycm9y KCkgaXMgMAorUEFTUyBnbC5nZXRFcnJvcigpIGlzIGdsLklOVkFMSURfT1BFUkFUSU9OCiBFbmFi bGUgYW4gZXh0cmEgYXR0cmlidXRlIHdpdGggaW5zdWZmaWNpZW50IGRhdGEgYnVmZmVyCiBQQVNT IGdsLmdldEVycm9yKCkgaXMgMAogUEFTUyBnbC5kcmF3RWxlbWVudHMoZ2wuVFJJQU5HTEVTLCAz LCBnbC5VTlNJR05FRF9TSE9SVCwgMCkgaXMgdW5kZWZpbmVkLgpJbmRleDogTGF5b3V0VGVzdHMv ZmFzdC9jYW52YXMvd2ViZ2wvc2NyaXB0LXRlc3RzL2luZGV4LXZhbGlkYXRpb24uanMKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvc2NyaXB0LXRlc3RzL2luZGV4 LXZhbGlkYXRpb24uanMJKHJldmlzaW9uIDYwOTI3KQorKysgTGF5b3V0VGVzdHMvZmFzdC9jYW52 YXMvd2ViZ2wvc2NyaXB0LXRlc3RzL2luZGV4LXZhbGlkYXRpb24uanMJKHdvcmtpbmcgY29weSkK QEAgLTY0LDcgKzY0LDcgQEAgZ2wuZW5hYmxlVmVydGV4QXR0cmliQXJyYXkoZXh0cmFMb2MpOwog ZGVidWcoIkVuYWJsZSBhbiBleHRyYSBhdHRyaWJ1dGUgd2l0aCBudWxsIik7CiBzaG91bGRCZSgn Z2wuZ2V0RXJyb3IoKScsICcwJyk7CiBzaG91bGRCZVVuZGVmaW5lZCgnZ2wuZHJhd0VsZW1lbnRz KGdsLlRSSUFOR0xFUywgMywgZ2wuVU5TSUdORURfU0hPUlQsIDApJyk7Ci1zaG91bGRCZSgnZ2wu Z2V0RXJyb3IoKScsICcwJyk7CitzaG91bGRCZSgnZ2wuZ2V0RXJyb3IoKScsICdnbC5JTlZBTElE X09QRVJBVElPTicpOwogZGVidWcoIkVuYWJsZSBhbiBleHRyYSBhdHRyaWJ1dGUgd2l0aCBpbnN1 ZmZpY2llbnQgZGF0YSBidWZmZXIiKTsKIGdsLnZlcnRleEF0dHJpYlBvaW50ZXIoZXh0cmFMb2Ms IDMsIGdsLkZMT0FULCBmYWxzZSwgNyAqIGdsLnNpemVJbkJ5dGVzKGdsLkZMT0FUKSwgNCAqIGds LnNpemVJbkJ5dGVzKGdsLkZMT0FUKSk7CiBzaG91bGRCZSgnZ2wuZ2V0RXJyb3IoKScsICcwJyk7 Cg==