40311 2010-06-08 10:46:16 -0700 video-timeupdate-duringplayback.html missing closing angle 2010-06-09 10:50:05 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 39259 1 tonyg tonyg abarth eric oldest_to_newest 235344 0 tonyg 2010-06-08 10:46:16 -0700 video-timeupdate-duringplayback.html missing closing angle 235369 1 58160 tonyg 2010-06-08 11:04:20 -0700 Created attachment 58160 Patch 235375 2 tonyg 2010-06-08 11:08:27 -0700 We shouldn't land this until verifying there is an appropriate parser test. I figured I'd check with you first to see if you know where it is off-hand. If not, I'll dig around and/or add one. 235381 3 eric 2010-06-08 11:14:05 -0700 You can always add another test. fast/invalid doesn't seem to cover this exact case, but I would expect html5lib/resources/* does. I would just add another test to html5lib/resources/webkit01.dat to be sure. :) 235460 4 58173 tonyg 2010-06-08 13:00:15 -0700 Created attachment 58173 Patch 235471 5 58173 eric 2010-06-08 13:13:59 -0700 Comment on attachment 58173 Patch Your added test does not test anything interesting. I think you meant (From update of attachment 58173 [details]) > Your added test does not test anything interesting. I think you meant ". The bug with the other test was that in "foo</p<script ...>", we were ignoring the <script>. The point of this test is to ensure the second shows up. The HTML5 parser currently produces: <html> <head> <body> "Test" "Test2" I'm checking for: <html> <head> <body> "Test" "Test2" 235489 7 eric 2010-06-08 13:40:59 -0700 Did you check the HTML5 spec/ Mozilla minefield to see which behavior is correct? 235505 8 58173 abarth 2010-06-08 13:51:42 -0700 Comment on attachment 58173 Patch ok 235591 9 tonyg 2010-06-08 17:10:15 -0700 (In reply to comment #8) > (From update of attachment 58173 [details]) > ok (In reply to comment #7) > Did you check the HTML5 spec/ Mozilla minefield to see which behavior is correct? Both minefield and the spec don't allow for </foo<bar> to be parsed as the closing of foo and the opening of bar. However, the legacy webkit parser does. So I'd like to fix the video-timeupdate-duringplayback.html layout test so that it doesn't have this bad markup because that isn't at all the point of the test. But I think it is important to track this difference somehow. Should I update the expectation to pass with the HTML5 parser and fail with the legacy parser? 235845 10 tonyg 2010-06-09 10:05:59 -0700 (In reply to comment #9) > (In reply to comment #8) > > (From update of attachment 58173 [details] [details]) > > ok > > (In reply to comment #7) > > Did you check the HTML5 spec/ Mozilla minefield to see which behavior is correct? > > Both minefield and the spec don't allow for </foo<bar> to be parsed as the closing of foo and the opening of bar. However, the legacy webkit parser does. > > So I'd like to fix the video-timeupdate-duringplayback.html layout test so that it doesn't have this bad markup because that isn't at all the point of the test. But I think it is important to track this difference somehow. Should I update the expectation to pass with the HTML5 parser and fail with the legacy parser? I see you r+'d this. But I'm not sure the test expectation is set correctly. Should it be set based on [1] the spec (less compatible, old parser fails, new one passes) or based on [2] the old behavior (more compatible, old parser passes, new one fails)? Currently this patch does #2. 235855 11 abarth 2010-06-09 10:19:01 -0700 The #document field of the HTML5lib tests should be set to what the spec says to do. The -expected.txt should be set to the current behavior of the old parser (so the bots stay green). the -html5-expected.txt should be set to the current behavior of the HTML5 parser so we can track regressions. I'll fix the expectations before landing. 235859 12 58173 abarth 2010-06-09 10:31:57 -0700 Comment on attachment 58173 Patch The new tests fails in the HTML5 parser. Interestingly, the test passes in Minefield. That means one of us is not following the spec. :) Test 15 of 15 in resources/webkit01.dat failed. Input: Test</pTest2 Got: | <html> | <head> | <body> | | "Test" | "Test2" Expected: | <html> | <head> | <body> | | "Test" | | "Test2" 235862 13 58173 abarth 2010-06-09 10:40:38 -0700 Comment on attachment 58173 Patch Sorry for the confusion. I was running Minefield on the wrong instance of the tests. We match Minefield, as expected. I'll land with the corrected expectations. 235869 14 58258 abarth 2010-06-09 10:47:01 -0700 Created attachment 58258 Patch for landing 235871 15 abarth 2010-06-09 10:50:05 -0700 Committed r60900: <http://trac.webkit.org/changeset/60900> 58160 2010-06-08 11:04:20 -0700 2010-06-08 13:00:11 -0700 Patch bug-40311-20100608110419.patch text/plain 1288 tonyg ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhNjQzZjI2NDRjNmE3YjI1MWY2MTIyODMxMTYxNTU2YzY1MzFlOGRkLi5hMmE1MGI4 YTdiNjAyNDk1ZWZkZGRiY2ZiNGYwMjYxZTI4NjU5Zjg2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTAtMDYtMDggIFRvbnkgR2VudGlsY29yZSAgPHRvbnlnQGNocm9taXVtLm9yZz4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICB2aWRlby10aW1ldXBk YXRlLWR1cmluZ3BsYXliYWNrLmh0bWwgbWlzc2luZyBjbG9zaW5nIGFuZ2xlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDMxMQorCisgICAgICAgIFRo ZSBwb2ludCBvZiB0aGlzIHRlc3QgaXMgbm90IHRvIHRlc3QgaW52YWxpZCBtYXJrdXAuIFRoYXQg aXMgdGhlCisgICAgICAgIGZ1bmN0aW9uIG9mIGEgdG9rZW5pemVyL3BhcnNlciB0ZXN0LgorCisg ICAgICAgICogbWVkaWEvdmlkZW8tdGltZXVwZGF0ZS1kdXJpbmctcGxheWJhY2suaHRtbDoKKwog MjAxMC0wNi0wOCAgU3RlcGhlbiBXaGl0ZSAgPHNlbm9yYmxhbmNvQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBVbnJldmlld2VkOyBleHBlY3RhdGlvbnMgZml4LgpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvbWVkaWEvdmlkZW8tdGltZXVwZGF0ZS1kdXJpbmctcGxheWJhY2suaHRtbCBiL0xheW91 dFRlc3RzL21lZGlhL3ZpZGVvLXRpbWV1cGRhdGUtZHVyaW5nLXBsYXliYWNrLmh0bWwKaW5kZXgg ZGQxMWE1YzlmOGI5OTgzNjRkNmI3MGMyNDVhYzBlMGQ2YWZhZGEzMi4uMTNhNTJkZWMyZDRhNWQ2 MjE2OTg2NGQwN2UwNjcyYmQ4ZWIwY2ZhMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvbWVkaWEv dmlkZW8tdGltZXVwZGF0ZS1kdXJpbmctcGxheWJhY2suaHRtbAorKysgYi9MYXlvdXRUZXN0cy9t ZWRpYS92aWRlby10aW1ldXBkYXRlLWR1cmluZy1wbGF5YmFjay5odG1sCkBAIC01LDcgKzUsNyBA QAogCiAgICAgPHA+CiAgICAgVGVzdCAndGltZXVwZGF0ZScgZXZlbnRzIGFyZSBwb3N0ZWQgd2hp bGUgcGxheWluZyBidXQgbm90IHdoaWxlIHBhdXNlZC4KLSAgICA8L3AKKyAgICA8L3A+CiAgICAg PHNjcmlwdCBzcmM9bWVkaWEtZmlsZS5qcz48L3NjcmlwdD4KICAgICA8c2NyaXB0IHNyYz12aWRl by10ZXN0LmpzPjwvc2NyaXB0PgogICAgIDxzY3JpcHQ+Cg== 58173 2010-06-08 13:00:15 -0700 2010-06-09 10:46:56 -0700 Patch bug-40311-20100608130014.patch text/plain 1999 tonyg ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhNjQzZjI2NDRjNmE3YjI1MWY2MTIyODMxMTYxNTU2YzY1MzFlOGRkLi5mMGZjMWY3 OWJkYzBhYTdlOGJjN2E1ZjkzMWNhNTFkMDIxOWY0Y2E2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAK KzIwMTAtMDYtMDggIFRvbnkgR2VudGlsY29yZSAgPHRvbnlnQGNocm9taXVtLm9yZz4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICB2aWRlby10aW1ldXBk YXRlLWR1cmluZ3BsYXliYWNrLmh0bWwgbWlzc2luZyBjbG9zaW5nIGFuZ2xlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDMxMQorCisgICAgICAgIFRo aXMgcGF0Y2ggcmVtb3ZlcyBpbnZhbGlkIG1hcmt1cCBmcm9tIHZpZGVvLXRpbWV1cGRhdGUtZHVy aW5nLXBsYXliYWNrLmh0bWwKKyAgICAgICAgYmVjYXVzZSB0aGF0IGlzIG5vdCB0aGUgcG9pbnQg b2YgdGhhdCB0ZXN0LiBJdCBhZGRzIGEgbmV3IHRlc3Qgd2l0aAorICAgICAgICB0aGUgc2FtZSBt YXJrdXAgdG8gd2Via2l0MDEuZGF0LiBOZXcgdGVzdCBmYWlscyB3aXRoIC0taHRtbDUtcGFyc2Vy LgorCisgICAgICAgICogaHRtbDVsaWIvcmVzb3VyY2VzL3dlYmtpdDAxLmRhdDoKKyAgICAgICAg KiBtZWRpYS92aWRlby10aW1ldXBkYXRlLWR1cmluZy1wbGF5YmFjay5odG1sOgorCiAyMDEwLTA2 LTA4ICBTdGVwaGVuIFdoaXRlICA8c2Vub3JibGFuY29AY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFVucmV2aWV3ZWQ7IGV4cGVjdGF0aW9ucyBmaXguCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9o dG1sNWxpYi9yZXNvdXJjZXMvd2Via2l0MDEuZGF0IGIvTGF5b3V0VGVzdHMvaHRtbDVsaWIvcmVz b3VyY2VzL3dlYmtpdDAxLmRhdAppbmRleCBkNTFiYzQ1YWJmZWMxMTg3MjBkYmVhZjA5NDI0MWQ5 NzJlOGZjMzVmLi41Y2ZhYTJlODViODc0ZTQyMGZlZGY5YmQxNmRlODJhMjAwYmQ1YTg2IDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9odG1sNWxpYi9yZXNvdXJjZXMvd2Via2l0MDEuZGF0CisrKyBi L0xheW91dFRlc3RzL2h0bWw1bGliL3Jlc291cmNlcy93ZWJraXQwMS5kYXQKQEAgLTE3NywzICsx NzcsMTUgQEAgY29uc29sZS5sb2coIkZPTzxzcGFuPkJBUjwvc3Bhbj5CQVoiKTsKIHwgICAgICAg Zm9vPSIiCiB8ICAgICAgIDxpbWc+CiB8ICAgICAgIDxpbWc+CisKKyNkYXRhCis8cD5UZXN0PC9w PHA+VGVzdDI8L3A+CisjZXJyb3JzCisjZG9jdW1lbnQKK3wgPGh0bWw+Cit8ICAgPGhlYWQ+Cit8 ICAgPGJvZHk+Cit8ICAgICA8cD4KK3wgICAgICAgIlRlc3QiCit8ICAgICA8cD4KK3wgICAgICAg IlRlc3QyIgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tdGltZXVwZGF0ZS1k dXJpbmctcGxheWJhY2suaHRtbCBiL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLXRpbWV1cGRhdGUt ZHVyaW5nLXBsYXliYWNrLmh0bWwKaW5kZXggZGQxMWE1YzlmOGI5OTgzNjRkNmI3MGMyNDVhYzBl MGQ2YWZhZGEzMi4uMTNhNTJkZWMyZDRhNWQ2MjE2OTg2NGQwN2UwNjcyYmQ4ZWIwY2ZhMCAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tdGltZXVwZGF0ZS1kdXJpbmctcGxheWJh Y2suaHRtbAorKysgYi9MYXlvdXRUZXN0cy9tZWRpYS92aWRlby10aW1ldXBkYXRlLWR1cmluZy1w bGF5YmFjay5odG1sCkBAIC01LDcgKzUsNyBAQAogCiAgICAgPHA+CiAgICAgVGVzdCAndGltZXVw ZGF0ZScgZXZlbnRzIGFyZSBwb3N0ZWQgd2hpbGUgcGxheWluZyBidXQgbm90IHdoaWxlIHBhdXNl ZC4KLSAgICA8L3AKKyAgICA8L3A+CiAgICAgPHNjcmlwdCBzcmM9bWVkaWEtZmlsZS5qcz48L3Nj cmlwdD4KICAgICA8c2NyaXB0IHNyYz12aWRlby10ZXN0LmpzPjwvc2NyaXB0PgogICAgIDxzY3Jp cHQ+Cg== 58258 2010-06-09 10:47:01 -0700 2010-06-09 10:47:01 -0700 Patch for landing bug-40311-20100609104700.patch text/plain 2655 abarth SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDYwODk5KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDYtMDkgIFRvbnkgR2VudGlsY29yZSAg PHRvbnlnQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgor CisgICAgICAgIHZpZGVvLXRpbWV1cGRhdGUtZHVyaW5ncGxheWJhY2suaHRtbCBtaXNzaW5nIGNs b3NpbmcgYW5nbGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTQwMzExCisKKyAgICAgICAgVGhpcyBwYXRjaCByZW1vdmVzIGludmFsaWQgbWFya3VwIGZy b20gdmlkZW8tdGltZXVwZGF0ZS1kdXJpbmctcGxheWJhY2suaHRtbAorICAgICAgICBiZWNhdXNl IHRoYXQgaXMgbm90IHRoZSBwb2ludCBvZiB0aGF0IHRlc3QuIEl0IGFkZHMgYSBuZXcgdGVzdCB3 aXRoCisgICAgICAgIHRoZSBzYW1lIG1hcmt1cCB0byB3ZWJraXQwMS5kYXQuIE5ldyB0ZXN0IGZh aWxzIHdpdGggLS1odG1sNS1wYXJzZXIuCisKKyAgICAgICAgKiBodG1sNWxpYi9yZXNvdXJjZXMv d2Via2l0MDEuZGF0OgorICAgICAgICAqIG1lZGlhL3ZpZGVvLXRpbWV1cGRhdGUtZHVyaW5nLXBs YXliYWNrLmh0bWw6CisKIDIwMTAtMDYtMDkgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCkluZGV4OiBMYXlvdXRUZXN0cy9o dG1sNWxpYi9ydW5uZXItZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2h0 bWw1bGliL3J1bm5lci1leHBlY3RlZC50eHQJKHJldmlzaW9uIDYwODk5KQorKysgTGF5b3V0VGVz dHMvaHRtbDVsaWIvcnVubmVyLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMzk5LDYg KzM5OSw3IEBAIHJlc291cmNlcy90ZXN0czE2LmRhdDoKIAogcmVzb3VyY2VzL3dlYmtpdDAxLmRh dDoKIDEzCisxNQogCiByZXNvdXJjZXMvZG9jdHlwZTAxLmRhdDoKIDIKSW5kZXg6IExheW91dFRl c3RzL2h0bWw1bGliL3dlYmtpdC1yZXN1bWVyLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9odG1sNWxpYi93ZWJraXQtcmVzdW1lci1leHBlY3RlZC50eHQJKHJldmlzaW9u IDYwODk5KQorKysgTGF5b3V0VGVzdHMvaHRtbDVsaWIvd2Via2l0LXJlc3VtZXItZXhwZWN0ZWQu dHh0CSh3b3JraW5nIGNvcHkpCkBAIC0xNjQsMyArMTY0LDI0IEBAIHJlc291cmNlcy93ZWJraXQw MS5kYXQ6CiA1MjEuNQogNTIyLjYKIDUyMy43Cis1NDkuMQorNTUwLjIKKzU1MS4zCis1NTIuNAor NTUzLjUKKzU1NC42Cis1NTUuNworNTU2LjgKKzU1Ny45Cis1NTguMTAKKzU1OS4xMQorNTYwLjEy Cis1NjEuMTMKKzU2Mi4xNAorNTYzLjE1Cis1NjQuMTYKKzU2NS4xNworNTY2LjE4Cis1NjcuMTkK KzU2OC4yMAorNTY5LjIxCkluZGV4OiBMYXlvdXRUZXN0cy9odG1sNWxpYi9yZXNvdXJjZXMvd2Vi a2l0MDEuZGF0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2h0bWw1bGliL3Jlc291cmNlcy93 ZWJraXQwMS5kYXQJKHJldmlzaW9uIDYwODk5KQorKysgTGF5b3V0VGVzdHMvaHRtbDVsaWIvcmVz b3VyY2VzL3dlYmtpdDAxLmRhdAkod29ya2luZyBjb3B5KQpAQCAtMTc3LDMgKzE3NywxNCBAQCBj b25zb2xlLmxvZygiRk9PPHNwYW4+QkFSPC9zcGFuPkJBWiIpOwogfCAgICAgICBmb289IiIKIHwg ICAgICAgPGltZz4KIHwgICAgICAgPGltZz4KKworI2RhdGEKKzxwPlRlc3Q8L3A8cD5UZXN0Mjwv cD4KKyNlcnJvcnMKKyNkb2N1bWVudAorfCA8aHRtbD4KK3wgICA8aGVhZD4KK3wgICA8Ym9keT4K K3wgICAgIDxwPgorfCAgICAgICAiVGVzdCIKK3wgICAgICAgIlRlc3QyIgpJbmRleDogTGF5b3V0 VGVzdHMvbWVkaWEvdmlkZW8tdGltZXVwZGF0ZS1kdXJpbmctcGxheWJhY2suaHRtbAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9tZWRpYS92aWRlby10aW1ldXBkYXRlLWR1cmluZy1wbGF5YmFj ay5odG1sCShyZXZpc2lvbiA2MDg5OSkKKysrIExheW91dFRlc3RzL21lZGlhL3ZpZGVvLXRpbWV1 cGRhdGUtZHVyaW5nLXBsYXliYWNrLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTUsNyArNSw3IEBA CiAKICAgICA8cD4KICAgICBUZXN0ICd0aW1ldXBkYXRlJyBldmVudHMgYXJlIHBvc3RlZCB3aGls ZSBwbGF5aW5nIGJ1dCBub3Qgd2hpbGUgcGF1c2VkLgotICAgIDwvcAorICAgIDwvcD4KICAgICA8 c2NyaXB0IHNyYz1tZWRpYS1maWxlLmpzPjwvc2NyaXB0PgogICAgIDxzY3JpcHQgc3JjPXZpZGVv LXRlc3QuanM+PC9zY3JpcHQ+CiAgICAgPHNjcmlwdD4K