40293 2010-06-08 05:48:28 -0700 Fix the length of instruction stream controlled by constant pool 2010-06-24 00:48:59 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other All RESOLVED FIXED P2 Normal --- 1 loki webkit-unassigned barraclough eric oliver oldest_to_newest 235223 0 loki 2010-06-08 05:48:28 -0700 In AssemblerBufferWithConstantPool the initial/maximum length of instruction stream (m_maxDistance) was set by the constructor and the flushConstantPool, but the m_maxDistance was decreased by all put functions. Although there is no problem when the m_maxDistance is a negative value while the number of constant is zero. If a constant is placed onto the pool while the m_maxDistance is negative, the flushConstantPool will be invoked. This is not correct. The m_maxDistance should be set when the first constant arrives. It can lead to an error. If an uninterrupted sequence comes after m_maxDistance is negative and number of constant is zero, the pool will be placed into the sequence. I am going to upload a fix for this. 235224 1 58133 loki 2010-06-08 05:50:46 -0700 Created attachment 58133 Fix the length of instruction stream controlled by constant pool 242364 2 loki 2010-06-24 00:48:59 -0700 Committed revision 61745. 58133 2010-06-08 05:50:46 -0700 2010-06-23 23:19:47 -0700 Fix the length of instruction stream controlled by constant pool 0001-Fix-the-length-of-instruction-stream-controlled-by-c.patch text/plain 2046 loki RnJvbSA1NDUwMDQ2MjhkMWJiMzcxODE4ZWUwNGI0ZTJlYmU4MWU5MWY1NThlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHYWJvciBMb2tpIDxsb2tpQGluZi51LXN6ZWdlZC5odT4KRGF0 ZTogVHVlLCA4IEp1biAyMDEwIDE0OjQ4OjU0ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gRml4IHRo ZSBsZW5ndGggb2YgaW5zdHJ1Y3Rpb24gc3RyZWFtIGNvbnRyb2xsZWQgYnkgY29uc3RhbnQgcG9v bAoKU2lnbmVkLW9mZi1ieTogR2Fib3IgTG9raSA8bG9raUBpbmYudS1zemVnZWQuaHU+Ci0tLQog SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE0 ICsrKysrKysrKysrKysrCiAuLi4vYXNzZW1ibGVyL0Fzc2VtYmxlckJ1ZmZlcldpdGhDb25zdGFu dFBvb2wuaCAgICB8ICAgIDMgKystCiAyIGZpbGVzIGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyks IDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGNjMmMzYjAuLjU0OGM3YjcgMTAwNjQ0Ci0t LSBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wNi0wOCAgR2Fib3IgTG9raSAgPGxva2lAd2Via2l0 Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBG aXggdGhlIGxlbmd0aCBvZiBpbnN0cnVjdGlvbiBzdHJlYW0gY29udHJvbGxlZCBieSBjb25zdGFu dCBwb29sCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00 MDI5MworCisgICAgICAgIFRoZSBpbml0aWFsL21heGltdW0gbGVuZ3RoIG9mIGluc3RydWN0aW9u IHN0cmVhbSAobV9tYXhEaXN0YW5jZSkgc2hvdWxkCisgICAgICAgIGJlIHNldCB3aGVuIHRoZSBm aXJzdCBjb25zdGFudCBhcnJpdmVzIHRvIHRoZSBjb25zdGFudCBwb29sLiBPdGhlcndpc2UKKyAg ICAgICAgdGhlIGNvbnN0YW50IHBvb2wgY291bGQgYmUgcGxhY2VkIGludG8gYW4gdW5pbnRlcnJ1 cHRlZCBzZXF1ZW5jZS4KKworICAgICAgICAqIGFzc2VtYmxlci9Bc3NlbWJsZXJCdWZmZXJXaXRo Q29uc3RhbnRQb29sLmg6CisgICAgICAgIChKU0M6Oik6CisKIDIwMTAtMDYtMDcgIE1PUklUQSBI YWppbWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+CiAgICAgICAgIAogICAgICAgICBSZXZpZXdlZCBi eSBLZW50IFRhbXVyYS4KZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9Bc3Nl bWJsZXJCdWZmZXJXaXRoQ29uc3RhbnRQb29sLmggYi9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIv QXNzZW1ibGVyQnVmZmVyV2l0aENvbnN0YW50UG9vbC5oCmluZGV4IGIxYzUzN2UuLjU5OWJlMTQg MTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9Bc3NlbWJsZXJCdWZmZXJXaXRo Q29uc3RhbnRQb29sLmgKKysrIGIvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0Fzc2VtYmxlckJ1 ZmZlcldpdGhDb25zdGFudFBvb2wuaApAQCAtMTkwLDYgKzE5MCw4IEBAIHB1YmxpYzoKIAogICAg IHZvaWQgcHV0SW50V2l0aENvbnN0YW50SW50KHVpbnQzMl90IGluc24sIHVpbnQzMl90IGNvbnN0 YW50LCBib29sIGlzUmV1c2FibGUgPSBmYWxzZSkKICAgICB7CisgICAgICAgIGlmICghbV9udW1D b25zdHMpCisgICAgICAgICAgICBtX21heERpc3RhbmNlID0gbWF4UG9vbFNpemU7CiAgICAgICAg IGZsdXNoSWZOb1NwYWNlRm9yKDQsIDQpOwogCiAgICAgICAgIG1fbG9hZE9mZnNldHMuYXBwZW5k KEFzc2VtYmxlckJ1ZmZlcjo6c2l6ZSgpKTsKQEAgLTI3OSw3ICsyODEsNiBAQCBwcml2YXRlOgog CiAgICAgICAgIG1fbG9hZE9mZnNldHMuY2xlYXIoKTsKICAgICAgICAgbV9udW1Db25zdHMgPSAw OwotICAgICAgICBtX21heERpc3RhbmNlID0gbWF4UG9vbFNpemU7CiAgICAgfQogCiAgICAgdm9p ZCBmbHVzaElmTm9TcGFjZUZvcihpbnQgbmV4dEluc25TaXplKQotLSAKMS41LjQuMwoK