40261 2010-06-07 13:07:16 -0700 [Qt] SmartReplaceQt.cpp has coding-style errors 2011-04-06 01:53:07 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED EasyFix, Qt, QtTriaged P5 Trivial --- 1 agbakken webkit-unassigned abarth benjamin commit-queue eric jedrzej.nowacki webkit.review.bot oldest_to_newest 235018 0 agbakken 2010-06-07 13:07:16 -0700 [Qt] SmartReplaceQt.cpp has coding-style errors 235019 1 58079 agbakken 2010-06-07 13:07:47 -0700 Created attachment 58079 Patch 235819 2 58079 levin 2010-06-09 09:14:16 -0700 Comment on attachment 58079 Patch >+ No new tests. (OOPS!) :( 238325 3 jedrzej.nowacki 2010-06-15 04:37:42 -0700 I don't like it, it destroys history of changes. I think it is not in the we work with webkit, general policy is that code shouldn't be changed only for a style reason. Personally I preferred previous version, but you are right, it is not webkit style. If you do want to make a fix, please change comments, they should be full phrases with point at the end. (In reply to comment #2) > (From update of attachment 58079 [details]) > >+ No new tests. (OOPS!) > :( The change don't need tests. 379617 4 88247 rafael.lobo 2011-04-05 09:13:40 -0700 Created attachment 88247 Fixing previous patch submitted by Anders Bakken to fix the coding-style on SmartReplaceQt.cpp 380191 5 88247 commit-queue 2011-04-06 00:46:43 -0700 Comment on attachment 88247 Fixing previous patch submitted by Anders Bakken to fix the coding-style on SmartReplaceQt.cpp Clearing flags on attachment: 88247 Committed r83029: <http://trac.webkit.org/changeset/83029> 380192 6 commit-queue 2011-04-06 00:46:48 -0700 All reviewed patches have been landed. Closing bug. 380196 7 commit-queue 2011-04-06 00:56:51 -0700 The commit-queue encountered the following flaky tests while processing attachment 88247: animations/suspend-resume-animation.html bug 48161 (author: cmarrin@apple.com) The commit-queue is continuing to process your patch. 380220 8 webkit.review.bot 2011-04-06 01:53:07 -0700 http://trac.webkit.org/changeset/83029 might have broken GTK Linux 32-bit Debug 58079 2010-06-07 13:07:47 -0700 2010-06-09 16:27:42 -0700 Patch bug-40261-20100607130628.patch text/plain 3123 agbakken ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTllMmFiMDg5ZGEwZjk5ZGE5ZWI4MWQ1MzBhY2JkZmI2MzkwYmVjNy4uYzU2MWRkNDVmZTk5YWUy ZTlhZjgzY2M5NzljYjNlMTc5Y2EzNDk4MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNi0wNyAgQW5k ZXJzIEJha2tlbiAgPGFnYmFra2VuQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFNtYXJ0UmVwbGFjZVF0LmNwcCBoYXMgY29k aW5nLXN0eWxlIGVycm9ycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDAyNjEKKworICAgICAgICBObyBuZXcgdGVzdHMuIChPT1BTISkKKworICAgICAg ICAqIGVkaXRpbmcvcXQvU21hcnRSZXBsYWNlUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6aXND aGFyYWN0ZXJTbWFydFJlcGxhY2VFeGVtcHQpOgorCiAyMDEwLTA2LTA3ICBBbmRyZWkgUG9wZXNj dSAgPGFuZHJlaXBAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBKZXJlbXkgT3Js b3cuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2VkaXRpbmcvcXQvU21hcnRSZXBsYWNlUXQuY3BwIGIv V2ViQ29yZS9lZGl0aW5nL3F0L1NtYXJ0UmVwbGFjZVF0LmNwcAppbmRleCAxNDM2YWZlZTY1ZWRl YmNkMTYxZGZkYTAwN2YzZDMwY2EyZTBiYmY5Li5kY2Q4YmY3Mjc1NjVjNTdlYjYwYzIwZTkyZTJl ZmIwNGNiYzM0MzIzIDEwMDY0NAotLS0gYS9XZWJDb3JlL2VkaXRpbmcvcXQvU21hcnRSZXBsYWNl UXQuY3BwCisrKyBiL1dlYkNvcmUvZWRpdGluZy9xdC9TbWFydFJlcGxhY2VRdC5jcHAKQEAgLTQw LDE1ICs0MCwxNSBAQCBib29sIGlzQ2hhcmFjdGVyU21hcnRSZXBsYWNlRXhlbXB0KFVDaGFyMzIg YywgYm9vbCBpc1ByZXZpb3VzQ2hhcmFjdGVyKQogICAgIGlmICghaXNQcmV2aW91c0NoYXJhY3Rl ciAmJiBkLmlzUHVuY3QoKSkKICAgICAgICAgcmV0dXJuIHRydWU7CiAKLSAgICBpZiAoKGMgPj0g MHgxMTAwICYmIGMgPD0gKDB4MTEwMCArIDI1NikpICAgICAgICAgIC8vIEhhbmd1bCBKYW1vICgw eDExMDAgLSAweDExRkYpCi0gICAgICAgIHx8IChjID49IDB4MkU4MCAmJiBjIDw9ICgweDJFODAg KyAzNTIpKSAgICAgICAvLyBDSksgJiBLYW5neGkgUmFkaWNhbHMgKDB4MkU4MCAtIDB4MkZERikK LSAgICAgICAgfHwgKGMgPj0gMHgyRkYwICYmIGMgPD0gKDB4MkZGMCArIDQ2NCkpICAgICAgIC8v IElkZW9ncmFwaCBEZXNlcmlwdGlvbnMsIENKSyBTeW1ib2xzLCBIaXJhZ2FuYSwgS2F0YWthbmEs IEJvcG9tb2ZvLCBIYW5ndWwgQ29tcGF0aWJpbGl0eSBKYW1vLCBLYW5idW4sICYgQm9wb21vZm8g RXh0ICgweDJGRjAgLSAweDMxQkYpCi0gICAgICAgIHx8IChjID49IDB4MzIwMCAmJiBjIDw9ICgw eDMyMDAgKyAyOTM5MikpICAgICAvLyBFbmNsb3NlZCBDSkssIENKSyBJZGVvZ3JhcGhzIChVbmkg SGFuICYgRXh0IEEpLCAmIFlpICgweDMyMDAgLSAweEE0Q0YpCi0gICAgICAgIHx8IChjID49IDB4 QUMwMCAmJiBjIDw9ICgweEFDMDAgKyAxMTE4MykpICAgICAvLyBIYW5ndWwgU3lsbGFibGVzICgw eEFDMDAgLSAweEQ3QUYpCi0gICAgICAgIHx8IChjID49IDB4RjkwMCAmJiBjIDw9ICgweEY5MDAg KyAzNTIpKSAgICAgICAvLyBDSksgQ29tcGF0aWJpbGl0eSBJZGVvZ3JhcGhzICgweEY5MDAgLSAw eEZBNUYpCi0gICAgICAgIHx8IChjID49IDB4RkUzMCAmJiBjIDw9ICgweEZFMzAgKyAzMikpICAg ICAgICAvLyBDSksgQ29tcGF0aWJpbGl0eSBGcm9tICgweEZFMzAgLSAweEZFNEYpCi0gICAgICAg IHx8IChjID49IDB4RkYwMCAmJiBjIDw9ICgweEZGMDAgKyAyNDApKSAgICAgICAvLyBIYWxmL0Z1 bGwgV2lkdGggRm9ybSAoMHhGRjAwIC0gMHhGRkVGKQotICAgICAgICB8fCAoYyA+PSAweDIwMDAw ICYmIGMgPD0gKDB4MjAwMDAgKyAweEE2RDcpKSAgLy8gQ0pLIElkZW9ncmFwaCBFeG50ZW5zaW9u IEIKKyAgICBpZiAoKGMgPj0gMHgxMTAwICYmIGMgPD0gKDB4MTEwMCArIDI1NikpIC8vIEhhbmd1 bCBKYW1vICgweDExMDAgLSAweDExRkYpCisgICAgICAgIHx8IChjID49IDB4MkU4MCAmJiBjIDw9 ICgweDJFODAgKyAzNTIpKSAvLyBDSksgJiBLYW5neGkgUmFkaWNhbHMgKDB4MkU4MCAtIDB4MkZE RikKKyAgICAgICAgfHwgKGMgPj0gMHgyRkYwICYmIGMgPD0gKDB4MkZGMCArIDQ2NCkpIC8vIElk ZW9ncmFwaCBEZXNlcmlwdGlvbnMsIENKSyBTeW1ib2xzLCBIaXJhZ2FuYSwgS2F0YWthbmEsIEJv cG9tb2ZvLCBIYW5ndWwgQ29tcGF0aWJpbGl0eSBKYW1vLCBLYW5idW4sICYgQm9wb21vZm8gRXh0 ICgweDJGRjAgLSAweDMxQkYpCisgICAgICAgIHx8IChjID49IDB4MzIwMCAmJiBjIDw9ICgweDMy MDAgKyAyOTM5MikpIC8vIEVuY2xvc2VkIENKSywgQ0pLIElkZW9ncmFwaHMgKFVuaSBIYW4gJiBF eHQgQSksICYgWWkgKDB4MzIwMCAtIDB4QTRDRikKKyAgICAgICAgfHwgKGMgPj0gMHhBQzAwICYm IGMgPD0gKDB4QUMwMCArIDExMTgzKSkgLy8gSGFuZ3VsIFN5bGxhYmxlcyAoMHhBQzAwIC0gMHhE N0FGKQorICAgICAgICB8fCAoYyA+PSAweEY5MDAgJiYgYyA8PSAoMHhGOTAwICsgMzUyKSkgLy8g Q0pLIENvbXBhdGliaWxpdHkgSWRlb2dyYXBocyAoMHhGOTAwIC0gMHhGQTVGKQorICAgICAgICB8 fCAoYyA+PSAweEZFMzAgJiYgYyA8PSAoMHhGRTMwICsgMzIpKSAvLyBDSksgQ29tcGF0aWJpbGl0 eSBGcm9tICgweEZFMzAgLSAweEZFNEYpCisgICAgICAgIHx8IChjID49IDB4RkYwMCAmJiBjIDw9 ICgweEZGMDAgKyAyNDApKSAvLyBIYWxmL0Z1bGwgV2lkdGggRm9ybSAoMHhGRjAwIC0gMHhGRkVG KQorICAgICAgICB8fCAoYyA+PSAweDIwMDAwICYmIGMgPD0gKDB4MjAwMDAgKyAweEE2RDcpKSAv LyBDSksgSWRlb2dyYXBoIEV4bnRlbnNpb24gQgogICAgICAgICB8fCAoYyA+PSAweDJGODAwICYm IGMgPD0gKDB4MkY4MDAgKyAweDAyMUUpKSkgLy8gQ0pLIENvbXBhdGliaWxpdHkgSWRlb2dyYXBo cyAoMHgyRjgwMCAtIDB4MkZBMUQpCiAgICAgICAgcmV0dXJuIHRydWU7CiAK 88247 2011-04-05 09:13:40 -0700 2011-04-06 00:46:42 -0700 Fixing previous patch submitted by Anders Bakken to fix the coding-style on SmartReplaceQt.cpp patch.diff text/plain 3067 rafael.lobo ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkM2JlMDg5Li45NTQ1OGJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDQtMDUgIEFuZGVycyBCYWtrZW4gIDxhZ2Jha2tlbkBnbWFpbC5jb20+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBTbWFydFJl cGxhY2VRdC5jcHAgaGFzIGNvZGluZy1zdHlsZSBlcnJvcnMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwMjYxCisKKyAgICAgICAgVGhpcyBwYXRjaCBk b2VzIG5vdCByZXF1aXJlIG5ldyB0ZXN0IGNhc2VzLgorCisgICAgICAgICogZWRpdGluZy9xdC9T bWFydFJlcGxhY2VRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjppc0NoYXJhY3RlclNtYXJ0UmVw bGFjZUV4ZW1wdCk6CisKIDIwMTEtMDQtMDUgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBs ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9lZGl0aW5nL3F0L1NtYXJ0UmVwbGFjZVF0LmNwcCBiL1NvdXJjZS9XZWJD b3JlL2VkaXRpbmcvcXQvU21hcnRSZXBsYWNlUXQuY3BwCmluZGV4IDE0MzZhZmUuLmRjZDhiZjcg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvcXQvU21hcnRSZXBsYWNlUXQuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvcXQvU21hcnRSZXBsYWNlUXQuY3BwCkBAIC00 MCwxNSArNDAsMTUgQEAgYm9vbCBpc0NoYXJhY3RlclNtYXJ0UmVwbGFjZUV4ZW1wdChVQ2hhcjMy IGMsIGJvb2wgaXNQcmV2aW91c0NoYXJhY3RlcikKICAgICBpZiAoIWlzUHJldmlvdXNDaGFyYWN0 ZXIgJiYgZC5pc1B1bmN0KCkpCiAgICAgICAgIHJldHVybiB0cnVlOwogCi0gICAgaWYgKChjID49 IDB4MTEwMCAmJiBjIDw9ICgweDExMDAgKyAyNTYpKSAgICAgICAgICAvLyBIYW5ndWwgSmFtbyAo MHgxMTAwIC0gMHgxMUZGKQotICAgICAgICB8fCAoYyA+PSAweDJFODAgJiYgYyA8PSAoMHgyRTgw ICsgMzUyKSkgICAgICAgLy8gQ0pLICYgS2FuZ3hpIFJhZGljYWxzICgweDJFODAgLSAweDJGREYp Ci0gICAgICAgIHx8IChjID49IDB4MkZGMCAmJiBjIDw9ICgweDJGRjAgKyA0NjQpKSAgICAgICAv LyBJZGVvZ3JhcGggRGVzZXJpcHRpb25zLCBDSksgU3ltYm9scywgSGlyYWdhbmEsIEthdGFrYW5h LCBCb3BvbW9mbywgSGFuZ3VsIENvbXBhdGliaWxpdHkgSmFtbywgS2FuYnVuLCAmIEJvcG9tb2Zv IEV4dCAoMHgyRkYwIC0gMHgzMUJGKQotICAgICAgICB8fCAoYyA+PSAweDMyMDAgJiYgYyA8PSAo MHgzMjAwICsgMjkzOTIpKSAgICAgLy8gRW5jbG9zZWQgQ0pLLCBDSksgSWRlb2dyYXBocyAoVW5p IEhhbiAmIEV4dCBBKSwgJiBZaSAoMHgzMjAwIC0gMHhBNENGKQotICAgICAgICB8fCAoYyA+PSAw eEFDMDAgJiYgYyA8PSAoMHhBQzAwICsgMTExODMpKSAgICAgLy8gSGFuZ3VsIFN5bGxhYmxlcyAo MHhBQzAwIC0gMHhEN0FGKQotICAgICAgICB8fCAoYyA+PSAweEY5MDAgJiYgYyA8PSAoMHhGOTAw ICsgMzUyKSkgICAgICAgLy8gQ0pLIENvbXBhdGliaWxpdHkgSWRlb2dyYXBocyAoMHhGOTAwIC0g MHhGQTVGKQotICAgICAgICB8fCAoYyA+PSAweEZFMzAgJiYgYyA8PSAoMHhGRTMwICsgMzIpKSAg ICAgICAgLy8gQ0pLIENvbXBhdGliaWxpdHkgRnJvbSAoMHhGRTMwIC0gMHhGRTRGKQotICAgICAg ICB8fCAoYyA+PSAweEZGMDAgJiYgYyA8PSAoMHhGRjAwICsgMjQwKSkgICAgICAgLy8gSGFsZi9G dWxsIFdpZHRoIEZvcm0gKDB4RkYwMCAtIDB4RkZFRikKLSAgICAgICAgfHwgKGMgPj0gMHgyMDAw MCAmJiBjIDw9ICgweDIwMDAwICsgMHhBNkQ3KSkgIC8vIENKSyBJZGVvZ3JhcGggRXhudGVuc2lv biBCCisgICAgaWYgKChjID49IDB4MTEwMCAmJiBjIDw9ICgweDExMDAgKyAyNTYpKSAvLyBIYW5n dWwgSmFtbyAoMHgxMTAwIC0gMHgxMUZGKQorICAgICAgICB8fCAoYyA+PSAweDJFODAgJiYgYyA8 PSAoMHgyRTgwICsgMzUyKSkgLy8gQ0pLICYgS2FuZ3hpIFJhZGljYWxzICgweDJFODAgLSAweDJG REYpCisgICAgICAgIHx8IChjID49IDB4MkZGMCAmJiBjIDw9ICgweDJGRjAgKyA0NjQpKSAvLyBJ ZGVvZ3JhcGggRGVzZXJpcHRpb25zLCBDSksgU3ltYm9scywgSGlyYWdhbmEsIEthdGFrYW5hLCBC b3BvbW9mbywgSGFuZ3VsIENvbXBhdGliaWxpdHkgSmFtbywgS2FuYnVuLCAmIEJvcG9tb2ZvIEV4 dCAoMHgyRkYwIC0gMHgzMUJGKQorICAgICAgICB8fCAoYyA+PSAweDMyMDAgJiYgYyA8PSAoMHgz MjAwICsgMjkzOTIpKSAvLyBFbmNsb3NlZCBDSkssIENKSyBJZGVvZ3JhcGhzIChVbmkgSGFuICYg RXh0IEEpLCAmIFlpICgweDMyMDAgLSAweEE0Q0YpCisgICAgICAgIHx8IChjID49IDB4QUMwMCAm JiBjIDw9ICgweEFDMDAgKyAxMTE4MykpIC8vIEhhbmd1bCBTeWxsYWJsZXMgKDB4QUMwMCAtIDB4 RDdBRikKKyAgICAgICAgfHwgKGMgPj0gMHhGOTAwICYmIGMgPD0gKDB4RjkwMCArIDM1MikpIC8v IENKSyBDb21wYXRpYmlsaXR5IElkZW9ncmFwaHMgKDB4RjkwMCAtIDB4RkE1RikKKyAgICAgICAg fHwgKGMgPj0gMHhGRTMwICYmIGMgPD0gKDB4RkUzMCArIDMyKSkgLy8gQ0pLIENvbXBhdGliaWxp dHkgRnJvbSAoMHhGRTMwIC0gMHhGRTRGKQorICAgICAgICB8fCAoYyA+PSAweEZGMDAgJiYgYyA8 PSAoMHhGRjAwICsgMjQwKSkgLy8gSGFsZi9GdWxsIFdpZHRoIEZvcm0gKDB4RkYwMCAtIDB4RkZF RikKKyAgICAgICAgfHwgKGMgPj0gMHgyMDAwMCAmJiBjIDw9ICgweDIwMDAwICsgMHhBNkQ3KSkg Ly8gQ0pLIElkZW9ncmFwaCBFeG50ZW5zaW9uIEIKICAgICAgICAgfHwgKGMgPj0gMHgyRjgwMCAm JiBjIDw9ICgweDJGODAwICsgMHgwMjFFKSkpIC8vIENKSyBDb21wYXRpYmlsaXR5IElkZW9ncmFw aHMgKDB4MkY4MDAgLSAweDJGQTFEKQogICAgICAgIHJldHVybiB0cnVlOwogCg==