40260 2010-06-07 13:05:42 -0700 [Qt] EditorQt.cpp has coding-style errors 2011-04-05 09:19:07 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other All RESOLVED FIXED EasyFix, Qt, QtTriaged P5 Trivial --- 1 agbakken webkit-unassigned benjamin commit-queue jedrzej.nowacki oldest_to_newest 235016 0 agbakken 2010-06-07 13:05:42 -0700 [Qt] EditorQt.cpp has coding-style errors 235017 1 58078 agbakken 2010-06-07 13:06:05 -0700 Created attachment 58078 Patch 235821 2 58078 levin 2010-06-09 09:14:52 -0700 Comment on attachment 58078 Patch >+ No new tests. (OOPS!) :( 238295 3 jedrzej.nowacki 2010-06-15 01:28:34 -0700 (In reply to comment #2) > (From update of attachment 58078 [details]) > >+ No new tests. (OOPS!) > :( I don't think that you can test it :-) this is a coding style fix. 238315 4 jedrzej.nowacki 2010-06-15 04:15:32 -0700 I don't like it, it destroys history of changes. I think it is not in the we work with webkit, general policy is that code shouldn't be changed only for a style reason. 379552 5 88232 rafael.lobo 2011-04-05 07:45:02 -0700 Created attachment 88232 Fixing previous patch submitted by Anders Bakken to fix the coding-style on EditorQt.cpp 379558 6 88232 laszlo.gombos 2011-04-05 07:48:44 -0700 Comment on attachment 88232 Fixing previous patch submitted by Anders Bakken to fix the coding-style on EditorQt.cpp r=me. 379623 7 88232 commit-queue 2011-04-05 09:19:01 -0700 Comment on attachment 88232 Fixing previous patch submitted by Anders Bakken to fix the coding-style on EditorQt.cpp Clearing flags on attachment: 88232 Committed r82944: <http://trac.webkit.org/changeset/82944> 379624 8 commit-queue 2011-04-05 09:19:07 -0700 All reviewed patches have been landed. Closing bug. 58078 2010-06-07 13:06:05 -0700 2010-06-09 16:28:14 -0700 Patch bug-40260-20100607130447.patch text/plain 1087 agbakken ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTllMmFiMDg5ZGEwZjk5ZGE5ZWI4MWQ1MzBhY2JkZmI2MzkwYmVjNy4uOWNkMTg5Y2EyOTliOTUw OWJlNTJmOWFkZjBkNGUwNTQzZDc1NWM2NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wNi0wNyAgQW5k ZXJzIEJha2tlbiAgPGFnYmFra2VuQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIEVkaXRvclF0LmNwcCBoYXMgY29kaW5nLXN0 eWxlIGVycm9ycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NDAyNjAKKworICAgICAgICBObyBuZXcgdGVzdHMuIChPT1BTISkKKworICAgICAgICAqIGVk aXRpbmcvcXQvRWRpdG9yUXQuY3BwOgorCiAyMDEwLTA2LTA3ICBBbmRyZWkgUG9wZXNjdSAgPGFu ZHJlaXBAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBKZXJlbXkgT3Jsb3cuCmRp ZmYgLS1naXQgYS9XZWJDb3JlL2VkaXRpbmcvcXQvRWRpdG9yUXQuY3BwIGIvV2ViQ29yZS9lZGl0 aW5nL3F0L0VkaXRvclF0LmNwcAppbmRleCBlNzRlMmYzNmI5MjRkMTZlOTk1MzlmMDI0MmYzNzA1 ZjA0MDQ5MTYxLi5kMTEzMmUxYmU4OTI1MTU5NDAxMWNlNzJlZjQ4OGE2N2JmNTdhOWRkIDEwMDY0 NAotLS0gYS9XZWJDb3JlL2VkaXRpbmcvcXQvRWRpdG9yUXQuY3BwCisrKyBiL1dlYkNvcmUvZWRp dGluZy9xdC9FZGl0b3JRdC5jcHAKQEAgLTMxLDkgKzMxLDkgQEAKICNpbmNsdWRlICJDbGlwYm9h cmRRdC5oIgogI2luY2x1ZGUgIkRvY3VtZW50LmgiCiAjaW5jbHVkZSAiRWxlbWVudC5oIgotI2lu Y2x1ZGUgIlZpc2libGVTZWxlY3Rpb24uaCIKICNpbmNsdWRlICJTZWxlY3Rpb25Db250cm9sbGVy LmgiCiAjaW5jbHVkZSAiVGV4dEl0ZXJhdG9yLmgiCisjaW5jbHVkZSAiVmlzaWJsZVNlbGVjdGlv bi5oIgogI2luY2x1ZGUgImh0bWxlZGl0aW5nLmgiCiAjaW5jbHVkZSAidmlzaWJsZV91bml0cy5o IgogCg== 88232 2011-04-05 07:45:02 -0700 2011-04-05 09:19:01 -0700 Fixing previous patch submitted by Anders Bakken to fix the coding-style on EditorQt.cpp patch.diff text/plain 1039 rafael.lobo ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkM2JlMDg5Li44MjdiNTYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMDQtMDUgIEFuZGVycyBCYWtrZW4gIDxhZ2Jha2tlbkBnbWFpbC5jb20+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBFZGl0b3JR dC5jcHAgaGFzIGNvZGluZy1zdHlsZSBlcnJvcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTQwMjYwCisgICAgICAgIAorICAgICAgICBUaGlzIHBhdGNo IGRvZXMgbm90IHJlcXVpcmUgbmV3IHRlc3QgY2FzZXMuCisKKyAgICAgICAgKiBlZGl0aW5nL3F0 L0VkaXRvclF0LmNwcDoKKwogMjAxMS0wNC0wNSAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFw cGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvcXQvRWRpdG9yUXQuY3BwIGIvU291cmNlL1dlYkNvcmUv ZWRpdGluZy9xdC9FZGl0b3JRdC5jcHAKaW5kZXggN2ZiMzYzNC4uZmZiMjRlNyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9xdC9FZGl0b3JRdC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvZWRpdGluZy9xdC9FZGl0b3JRdC5jcHAKQEAgLTMxLDkgKzMxLDkgQEAKICNpbmNsdWRl ICJDbGlwYm9hcmRRdC5oIgogI2luY2x1ZGUgIkRvY3VtZW50LmgiCiAjaW5jbHVkZSAiRWxlbWVu dC5oIgotI2luY2x1ZGUgIlZpc2libGVTZWxlY3Rpb24uaCIKICNpbmNsdWRlICJTZWxlY3Rpb25D b250cm9sbGVyLmgiCiAjaW5jbHVkZSAiVGV4dEl0ZXJhdG9yLmgiCisjaW5jbHVkZSAiVmlzaWJs ZVNlbGVjdGlvbi5oIgogI2luY2x1ZGUgImh0bWxlZGl0aW5nLmgiCiAjaW5jbHVkZSAidmlzaWJs ZV91bml0cy5oIgogCg==