40259 2010-06-07 13:03:21 -0700 [Qt] EventHandlerQt.cpp has coding-style errors 2010-06-12 21:47:12 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED Qt P2 Normal --- 0 agbakken webkit-unassigned commit-queue webkit.review.bot oldest_to_newest 235014 0 agbakken 2010-06-07 13:03:21 -0700 [Qt] EventHandlerQt.cpp has coding-style errors 235015 1 58077 agbakken 2010-06-07 13:03:59 -0700 Created attachment 58077 Patch 235328 2 58077 laszlo.gombos 2010-06-08 10:34:36 -0700 Comment on attachment 58077 Patch Please remove "(OOPS!)" from the ChangeLog and perhaps mention why there is no new tests (e.g. "no new functionality" or "style change only"). Also I saw that you have quite a few changes up for review (with similar problems). I think you can combine some of these into a single patch (if all they do is style fixes for QtWebKit). Thanks. 235334 3 58157 agbakken 2010-06-08 10:37:30 -0700 Created attachment 58157 Patch 235339 4 webkit.review.bot 2010-06-08 10:41:16 -0700 Attachment 58157 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 235358 5 58159 agbakken 2010-06-08 10:55:05 -0700 Created attachment 58159 Patch 237475 6 58159 commit-queue 2010-06-12 21:47:08 -0700 Comment on attachment 58159 Patch Clearing flags on attachment: 58159 Committed r61078: <http://trac.webkit.org/changeset/61078> 237476 7 commit-queue 2010-06-12 21:47:12 -0700 All reviewed patches have been landed. Closing bug. 58077 2010-06-07 13:03:59 -0700 2010-06-08 10:37:26 -0700 Patch bug-40259-20100607130240.patch text/plain 1711 agbakken ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTllMmFiMDg5ZGEwZjk5ZGE5ZWI4MWQ1MzBhY2JkZmI2MzkwYmVjNy4uYzI1ZmViNzhlMDg0OGJm MDAxZTU1ZGZmOWRiZDZkNWRkZmU0Y2Q3ZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNi0wNyAgQW5k ZXJzIEJha2tlbiAgPGFnYmFra2VuQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIEV2ZW50SGFuZGxlclF0LmNwcCBoYXMgY29k aW5nLXN0eWxlIGVycm9ycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDAyNTkKKworICAgICAgICBObyBuZXcgdGVzdHMuIChPT1BTISkKKworICAgICAg ICAqIHBhZ2UvcXQvRXZlbnRIYW5kbGVyUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRI YW5kbGVyOjpldmVudEFjdGl2YXRlZFZpZXcpOgorCiAyMDEwLTA2LTA3ICBBbmRyZWkgUG9wZXNj dSAgPGFuZHJlaXBAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBKZXJlbXkgT3Js b3cuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BhZ2UvcXQvRXZlbnRIYW5kbGVyUXQuY3BwIGIvV2Vi Q29yZS9wYWdlL3F0L0V2ZW50SGFuZGxlclF0LmNwcAppbmRleCBhY2U4ZTU0NDNiMDg0MDkzNWZh ZWMxYWFkMDMzY2U2MjAwNzI5NGFjLi4xOGQ5YjczYzE4ZWZiNDQ4MWU1ZjQzODg2ZDYxMDliODc5 YjdhM2E4IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BhZ2UvcXQvRXZlbnRIYW5kbGVyUXQuY3BwCisr KyBiL1dlYkNvcmUvcGFnZS9xdC9FdmVudEhhbmRsZXJRdC5jcHAKQEAgLTQzLDEyICs0MywxMiBA QAogI2luY2x1ZGUgIkhpdFRlc3RSZXN1bHQuaCIKICNpbmNsdWRlICJLZXlib2FyZEV2ZW50Lmgi CiAjaW5jbHVkZSAiTW91c2VFdmVudFdpdGhIaXRUZXN0UmVzdWx0cy5oIgorI2luY2x1ZGUgIk5v dEltcGxlbWVudGVkLmgiCiAjaW5jbHVkZSAiUGFnZS5oIgogI2luY2x1ZGUgIlBsYXRmb3JtS2V5 Ym9hcmRFdmVudC5oIgogI2luY2x1ZGUgIlBsYXRmb3JtV2hlZWxFdmVudC5oIgogI2luY2x1ZGUg IlJlbmRlcldpZGdldC5oIgogI2luY2x1ZGUgIlNjcm9sbGJhci5oIgotI2luY2x1ZGUgIk5vdElt cGxlbWVudGVkLmgiCiAKIFFUX0JFR0lOX05BTUVTUEFDRQogUV9HVUlfRVhQT1JUIGV4dGVybiBi b29sIHF0X3RhYl9hbGxfd2lkZ2V0czsgLy8gZnJvbSBxYXBwbGljYXRpb24uY3BwCkBAIC05Niw3 ICs5Niw3IEBAIGJvb2wgRXZlbnRIYW5kbGVyOjpwYXNzV2lkZ2V0TW91c2VEb3duRXZlbnRUb1dp ZGdldChjb25zdCBNb3VzZUV2ZW50V2l0aEhpdFRlc3RSCiAKIGJvb2wgRXZlbnRIYW5kbGVyOjpl dmVudEFjdGl2YXRlZFZpZXcoY29uc3QgUGxhdGZvcm1Nb3VzZUV2ZW50JikgY29uc3QKIHsKLSAg ICAvL1F0IGhhcyBhbiBhY3RpdmF0aW9uIGV2ZW50IHdoaWNoIGlzIHNlbnQgaW5kZXBlbmRlbnRs eQorICAgIC8vIFF0IGhhcyBhbiBhY3RpdmF0aW9uIGV2ZW50IHdoaWNoIGlzIHNlbnQgaW5kZXBl bmRlbnRseQogICAgIC8vICAgb2YgbW91c2UgZXZlbnQgc28gdGhpcyB0aGluZyB3aWxsIGJlIGEg c25hZnUgdG8gaW1wbGVtZW50CiAgICAgLy8gICBjb3JyZWN0bHkKICAgICByZXR1cm4gZmFsc2U7 Cg== 58157 2010-06-08 10:37:30 -0700 2010-06-08 10:55:01 -0700 Patch bug-40259-20100608103606.patch text/plain 1711 agbakken ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Yzc5M2QxNTliYTdjNjJiYzgzMzAwODkzZDUwZDk0NTFhOGJjZTdkMy4uOWY1ODU2NGYzMWIwYjA5 MGM2MzI4NDU1MDRmMjBmNmRlMTkwOGI2YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNi0wOCAgQW5k ZXJzIEJha2tlbiAgPGFnYmFra2VuQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIEV2ZW50SGFuZGxlclF0LmNwcCBoYXMgY29k aW5nLXN0eWxlIGVycm9ycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDAyNTkKKworCUNvZGluZyBzdHlsZSBjaGFuZ2Ugb25seS4KKworICAgICAgICAq IHBhZ2UvcXQvRXZlbnRIYW5kbGVyUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRIYW5k bGVyOjpldmVudEFjdGl2YXRlZFZpZXcpOgorCiAyMDEwLTA2LTA4ICBZdXJ5IFNlbWlraGF0c2t5 ICA8eXVyeXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZlbGRt YW4uCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BhZ2UvcXQvRXZlbnRIYW5kbGVyUXQuY3BwIGIvV2Vi Q29yZS9wYWdlL3F0L0V2ZW50SGFuZGxlclF0LmNwcAppbmRleCBhY2U4ZTU0NDNiMDg0MDkzNWZh ZWMxYWFkMDMzY2U2MjAwNzI5NGFjLi4xOGQ5YjczYzE4ZWZiNDQ4MWU1ZjQzODg2ZDYxMDliODc5 YjdhM2E4IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BhZ2UvcXQvRXZlbnRIYW5kbGVyUXQuY3BwCisr KyBiL1dlYkNvcmUvcGFnZS9xdC9FdmVudEhhbmRsZXJRdC5jcHAKQEAgLTQzLDEyICs0MywxMiBA QAogI2luY2x1ZGUgIkhpdFRlc3RSZXN1bHQuaCIKICNpbmNsdWRlICJLZXlib2FyZEV2ZW50Lmgi CiAjaW5jbHVkZSAiTW91c2VFdmVudFdpdGhIaXRUZXN0UmVzdWx0cy5oIgorI2luY2x1ZGUgIk5v dEltcGxlbWVudGVkLmgiCiAjaW5jbHVkZSAiUGFnZS5oIgogI2luY2x1ZGUgIlBsYXRmb3JtS2V5 Ym9hcmRFdmVudC5oIgogI2luY2x1ZGUgIlBsYXRmb3JtV2hlZWxFdmVudC5oIgogI2luY2x1ZGUg IlJlbmRlcldpZGdldC5oIgogI2luY2x1ZGUgIlNjcm9sbGJhci5oIgotI2luY2x1ZGUgIk5vdElt cGxlbWVudGVkLmgiCiAKIFFUX0JFR0lOX05BTUVTUEFDRQogUV9HVUlfRVhQT1JUIGV4dGVybiBi b29sIHF0X3RhYl9hbGxfd2lkZ2V0czsgLy8gZnJvbSBxYXBwbGljYXRpb24uY3BwCkBAIC05Niw3 ICs5Niw3IEBAIGJvb2wgRXZlbnRIYW5kbGVyOjpwYXNzV2lkZ2V0TW91c2VEb3duRXZlbnRUb1dp ZGdldChjb25zdCBNb3VzZUV2ZW50V2l0aEhpdFRlc3RSCiAKIGJvb2wgRXZlbnRIYW5kbGVyOjpl dmVudEFjdGl2YXRlZFZpZXcoY29uc3QgUGxhdGZvcm1Nb3VzZUV2ZW50JikgY29uc3QKIHsKLSAg ICAvL1F0IGhhcyBhbiBhY3RpdmF0aW9uIGV2ZW50IHdoaWNoIGlzIHNlbnQgaW5kZXBlbmRlbnRs eQorICAgIC8vIFF0IGhhcyBhbiBhY3RpdmF0aW9uIGV2ZW50IHdoaWNoIGlzIHNlbnQgaW5kZXBl bmRlbnRseQogICAgIC8vICAgb2YgbW91c2UgZXZlbnQgc28gdGhpcyB0aGluZyB3aWxsIGJlIGEg c25hZnUgdG8gaW1wbGVtZW50CiAgICAgLy8gICBjb3JyZWN0bHkKICAgICByZXR1cm4gZmFsc2U7 Cg== 58159 2010-06-08 10:55:05 -0700 2010-06-12 21:47:07 -0700 Patch bug-40259-20100608105341.patch text/plain 1718 agbakken ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Yzc5M2QxNTliYTdjNjJiYzgzMzAwODkzZDUwZDk0NTFhOGJjZTdkMy4uYmU3NTI1MTRiNWJlM2Jm ZTMzNGZmMWY2MWY0NzI5NmEzZDk4ZGM3MiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNi0wOCAgQW5k ZXJzIEJha2tlbiAgPGFnYmFra2VuQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIEV2ZW50SGFuZGxlclF0LmNwcCBoYXMgY29k aW5nLXN0eWxlIGVycm9ycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDAyNTkKKworICAgICAgICBDb2Rpbmcgc3R5bGUgY2hhbmdlIG9ubHkuCisKKyAg ICAgICAgKiBwYWdlL3F0L0V2ZW50SGFuZGxlclF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkV2 ZW50SGFuZGxlcjo6ZXZlbnRBY3RpdmF0ZWRWaWV3KToKKwogMjAxMC0wNi0wOCAgWXVyeSBTZW1p a2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBQYXZl bCBGZWxkbWFuLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wYWdlL3F0L0V2ZW50SGFuZGxlclF0LmNw cCBiL1dlYkNvcmUvcGFnZS9xdC9FdmVudEhhbmRsZXJRdC5jcHAKaW5kZXggYWNlOGU1NDQzYjA4 NDA5MzVmYWVjMWFhZDAzM2NlNjIwMDcyOTRhYy4uMThkOWI3M2MxOGVmYjQ0ODFlNWY0Mzg4NmQ2 MTA5Yjg3OWI3YTNhOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL3F0L0V2ZW50SGFuZGxlclF0 LmNwcAorKysgYi9XZWJDb3JlL3BhZ2UvcXQvRXZlbnRIYW5kbGVyUXQuY3BwCkBAIC00MywxMiAr NDMsMTIgQEAKICNpbmNsdWRlICJIaXRUZXN0UmVzdWx0LmgiCiAjaW5jbHVkZSAiS2V5Ym9hcmRF dmVudC5oIgogI2luY2x1ZGUgIk1vdXNlRXZlbnRXaXRoSGl0VGVzdFJlc3VsdHMuaCIKKyNpbmNs dWRlICJOb3RJbXBsZW1lbnRlZC5oIgogI2luY2x1ZGUgIlBhZ2UuaCIKICNpbmNsdWRlICJQbGF0 Zm9ybUtleWJvYXJkRXZlbnQuaCIKICNpbmNsdWRlICJQbGF0Zm9ybVdoZWVsRXZlbnQuaCIKICNp bmNsdWRlICJSZW5kZXJXaWRnZXQuaCIKICNpbmNsdWRlICJTY3JvbGxiYXIuaCIKLSNpbmNsdWRl ICJOb3RJbXBsZW1lbnRlZC5oIgogCiBRVF9CRUdJTl9OQU1FU1BBQ0UKIFFfR1VJX0VYUE9SVCBl eHRlcm4gYm9vbCBxdF90YWJfYWxsX3dpZGdldHM7IC8vIGZyb20gcWFwcGxpY2F0aW9uLmNwcApA QCAtOTYsNyArOTYsNyBAQCBib29sIEV2ZW50SGFuZGxlcjo6cGFzc1dpZGdldE1vdXNlRG93bkV2 ZW50VG9XaWRnZXQoY29uc3QgTW91c2VFdmVudFdpdGhIaXRUZXN0UgogCiBib29sIEV2ZW50SGFu ZGxlcjo6ZXZlbnRBY3RpdmF0ZWRWaWV3KGNvbnN0IFBsYXRmb3JtTW91c2VFdmVudCYpIGNvbnN0 CiB7Ci0gICAgLy9RdCBoYXMgYW4gYWN0aXZhdGlvbiBldmVudCB3aGljaCBpcyBzZW50IGluZGVw ZW5kZW50bHkKKyAgICAvLyBRdCBoYXMgYW4gYWN0aXZhdGlvbiBldmVudCB3aGljaCBpcyBzZW50 IGluZGVwZW5kZW50bHkKICAgICAvLyAgIG9mIG1vdXNlIGV2ZW50IHNvIHRoaXMgdGhpbmcgd2ls bCBiZSBhIHNuYWZ1IHRvIGltcGxlbWVudAogICAgIC8vICAgY29ycmVjdGx5CiAgICAgcmV0dXJu IGZhbHNlOwo=