40258 2010-06-07 13:01:12 -0700 [Qt] DragControllerQt.cpp has coding-style errors 2011-04-05 20:56:55 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED EasyFix, Qt, QtTriaged P5 Trivial --- 1 agbakken webkit-unassigned benjamin commit-queue jedrzej.nowacki oldest_to_newest 235010 0 agbakken 2010-06-07 13:01:12 -0700 [Qt] DragControllerQt.cpp has coding-style errors 235011 1 58076 agbakken 2010-06-07 13:01:36 -0700 Created attachment 58076 Patch 235822 2 58076 levin 2010-06-09 09:15:18 -0700 Comment on attachment 58076 Patch >+ No new tests. (OOPS!) :( 238351 3 jedrzej.nowacki 2010-06-15 06:30:08 -0700 WebCore/ChangeLog:8 + No new tests. (OOPS!) You should remove this line. WebCore/page/qt/DragControllerQt.cpp:53 + // FIXME: This logic is incomplete '.' at the end. 379651 4 88255 rafael.lobo 2011-04-05 09:38:54 -0700 Created attachment 88255 Fixing previous patch submitted by Anders Bakken to fix the coding-style on DragControllerQt.cpp 380090 5 88255 commit-queue 2011-04-05 20:56:51 -0700 Comment on attachment 88255 Fixing previous patch submitted by Anders Bakken to fix the coding-style on DragControllerQt.cpp Clearing flags on attachment: 88255 Committed r83014: <http://trac.webkit.org/changeset/83014> 380091 6 commit-queue 2011-04-05 20:56:55 -0700 All reviewed patches have been landed. Closing bug. 58076 2010-06-07 13:01:36 -0700 2010-06-09 16:28:44 -0700 Patch bug-40258-20100607130017.patch text/plain 1190 agbakken ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTllMmFiMDg5ZGEwZjk5ZGE5ZWI4MWQ1MzBhY2JkZmI2MzkwYmVjNy4uYjRlOWYzZWEzNDY0MzI5 OWZjMTNlODM0OWZlMDU5ZjQ2ZTg4MjkwMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNi0wNyAgQW5k ZXJzIEJha2tlbiAgPGFnYmFra2VuQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIERyYWdDb250cm9sbGVyUXQuY3BwIGhhcyBj b2Rpbmctc3R5bGUgZXJyb3JzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD00MDI1OAorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gKE9PUFMhKQorCisgICAg ICAgICogcGFnZS9xdC9EcmFnQ29udHJvbGxlclF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRy YWdDb250cm9sbGVyOjpkcmFnT3BlcmF0aW9uKToKKwogMjAxMC0wNi0wNyAgQW5kcmVpIFBvcGVz Y3UgIDxhbmRyZWlwQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSmVyZW15IE9y bG93LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wYWdlL3F0L0RyYWdDb250cm9sbGVyUXQuY3BwIGIv V2ViQ29yZS9wYWdlL3F0L0RyYWdDb250cm9sbGVyUXQuY3BwCmluZGV4IDMzODE1YjVkNTQxOTBj ZWNhODkxOGY5ZDg5ZTU4ZmFkNzM4NzVmNWQuLjA0OWJkNTYwM2YyMjMxZjUwZjgzOTU2MGM2OGM0 NmY1MWNhMWVmOGIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGFnZS9xdC9EcmFnQ29udHJvbGxlclF0 LmNwcAorKysgYi9XZWJDb3JlL3BhZ2UvcXQvRHJhZ0NvbnRyb2xsZXJRdC5jcHAKQEAgLTUwLDcg KzUwLDcgQEAgYm9vbCBEcmFnQ29udHJvbGxlcjo6aXNDb3B5S2V5RG93bigpCiAgICAgCiBEcmFn T3BlcmF0aW9uIERyYWdDb250cm9sbGVyOjpkcmFnT3BlcmF0aW9uKERyYWdEYXRhKiBkcmFnRGF0 YSkKIHsKLSAgICAvL0ZJWE1FOiBUaGlzIGxvZ2ljIGlzIGluY29tcGxldGUKKyAgICAvLyBGSVhN RTogVGhpcyBsb2dpYyBpcyBpbmNvbXBsZXRlCiAgICAgaWYgKGRyYWdEYXRhLT5jb250YWluc1VS TCgpKQogICAgICAgICByZXR1cm4gRHJhZ09wZXJhdGlvbkNvcHk7CiAgICAgICAgIAo= 88255 2011-04-05 09:38:54 -0700 2011-04-05 20:56:51 -0700 Fixing previous patch submitted by Anders Bakken to fix the coding-style on DragControllerQt.cpp patch.diff text/plain 1145 rafael.lobo ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkM2JlMDg5Li42Mzk0M2FjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDQtMDUgIEFuZGVycyBCYWtrZW4gIDxhZ2Jha2tlbkBnbWFpbC5jb20+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBEcmFnQ29u dHJvbGxlclF0LmNwcCBoYXMgY29kaW5nLXN0eWxlIGVycm9ycworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDAyNTgKKworICAgICAgICBUaGlzIHBhdGNo IGRvZXMgbm90IHJlcXVpcmUgbmV3IHRlc3QgY2FzZXMuCisKKyAgICAgICAgKiBwYWdlL3F0L0Ry YWdDb250cm9sbGVyUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RHJhZ0NvbnRyb2xsZXI6OmRy YWdPcGVyYXRpb24pOgorCiAyMDExLTA0LTA1ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBw bGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGFnZS9xdC9EcmFnQ29udHJvbGxlclF0LmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BhZ2UvcXQvRHJhZ0NvbnRyb2xsZXJRdC5jcHAKaW5kZXggY2RlYTU1Yi4uZGNjZDZjYyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9xdC9EcmFnQ29udHJvbGxlclF0LmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3F0L0RyYWdDb250cm9sbGVyUXQuY3BwCkBAIC01MCw3 ICs1MCw3IEBAIGJvb2wgRHJhZ0NvbnRyb2xsZXI6OmlzQ29weUtleURvd24oRHJhZ0RhdGEqKQog ICAgIAogRHJhZ09wZXJhdGlvbiBEcmFnQ29udHJvbGxlcjo6ZHJhZ09wZXJhdGlvbihEcmFnRGF0 YSogZHJhZ0RhdGEpCiB7Ci0gICAgLy9GSVhNRTogVGhpcyBsb2dpYyBpcyBpbmNvbXBsZXRlCisg ICAgLy8gRklYTUU6IFRoaXMgbG9naWMgaXMgaW5jb21wbGV0ZS4KICAgICBpZiAoZHJhZ0RhdGEt PmNvbnRhaW5zVVJMKDApKQogICAgICAgICByZXR1cm4gRHJhZ09wZXJhdGlvbkNvcHk7CiAgICAg ICAgIAo=