40249 2010-06-07 11:51:08 -0700 [Qt] EditorClientQt.h has coding-style errors 2010-06-09 16:26:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED Qt P2 Normal --- 0 agbakken webkit-unassigned commit-queue kenneth laszlo.gombos oldest_to_newest 234971 0 agbakken 2010-06-07 11:51:08 -0700 [Qt] EditorClientQt.h has coding-style errors 234973 1 58063 agbakken 2010-06-07 11:51:29 -0700 Created attachment 58063 Patch 235482 2 laszlo.gombos 2010-06-08 13:28:57 -0700 Is this coding style rule captured somewhere ? I could not find it on http://webkit.org/coding/coding-style.html. 235491 3 58063 kenneth 2010-06-08 13:42:04 -0700 Comment on attachment 58063 Patch It is in the style guide alright :-) it has to use the same case as the filename. The filename has .h and not .H :-) dot should be substituted by a _ 235492 4 kenneth 2010-06-08 13:42:52 -0700 (In reply to comment #2) > Is this coding style rule captured somewhere ? I could not find it on http://webkit.org/coding/coding-style.html. 14. #define, #ifdef "header guards" should be named exactly the same as the file (including case), replacing the '.' with a '_'. 236074 5 58063 commit-queue 2010-06-09 16:26:02 -0700 Comment on attachment 58063 Patch Clearing flags on attachment: 58063 Committed r60923: <http://trac.webkit.org/changeset/60923> 236075 6 commit-queue 2010-06-09 16:26:08 -0700 All reviewed patches have been landed. Closing bug. 58063 2010-06-07 11:51:29 -0700 2010-06-09 16:26:01 -0700 Patch bug-40249-20100607115011.patch text/plain 1168 agbakken ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmlu ZGV4IGZkNThiNjllODYzOTNhMzRiODFhMWEwMDgxNjEyOGYwNjM1ODFhZmYuLjZmZTUyYTE2NTAy NGEwM2Y4N2NkYTk2MTM1Yzg3NWZiNzg4OTZkNTEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFu Z2VMb2cKKysrIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEwLTA2 LTA3ICBBbmRlcnMgQmFra2VuICA8YWdiYWtrZW5AZ21haWwuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gRWRpdG9yQ2xpZW50UXQuaCBo YXMgY29kaW5nLXN0eWxlIGVycm9ycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDAyNDkKKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0VkaXRvckNs aWVudFF0Lmg6CisKIDIwMTAtMDYtMDYgIEFudG9uaW8gR29tZXMgIDx0b25pa2l0b29Ad2Via2l0 Lm9yZz4sIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEtlbm5ldGggQ2hyaXN0aWFuc2VuLCBFcmljIFNlaWRlbC4KZGlmZiAt LWdpdCBhL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGllbnRRdC5oIGIvV2ViS2l0 L3F0L1dlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudFF0LmgKaW5kZXggODExMjk4Yjc1MjkyOWRh NDZiNGE0NzQzMjY3ZDkyOWY1NTk4MzQ2MS4uYTVmNmIyM2I3NzdhYTZmMmM5OGNlMzgxMTkyM2Yw MzEyZWYwYjM4ZCAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0VkaXRvckNs aWVudFF0LmgKKysrIGIvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudFF0LmgK QEAgLTI3LDggKzI3LDggQEAKICAqIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBP RiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCiAgKi8KIAotI2lmbmRlZiBFZGl0b3JD bGllbnRRdF9ICi0jZGVmaW5lIEVkaXRvckNsaWVudFF0X0gKKyNpZm5kZWYgRWRpdG9yQ2xpZW50 UXRfaAorI2RlZmluZSBFZGl0b3JDbGllbnRRdF9oCiAKICNpbmNsdWRlICJFZGl0b3JDbGllbnQu aCIKICNpbmNsdWRlICJSZWZDb3VudGVkLmgiCg==