<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>40243</bug_id>
          
          <creation_ts>2010-06-07 11:39:47 -0700</creation_ts>
          <short_desc>[Qt] ContextMenuClientQt.cpp has coding-style errors</short_desc>
          <delta_ts>2011-01-31 17:27:19 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>EasyFix, Qt, QtTriaged</keywords>
          <priority>P5</priority>
          <bug_severity>Trivial</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Anders Bakken">agbakken</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>benjamin</cc>
    
    <cc>commit-queue</cc>
    
    <cc>jedrzej.nowacki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>234956</commentid>
    <comment_count>0</comment_count>
    <who name="Anders Bakken">agbakken</who>
    <bug_when>2010-06-07 11:39:47 -0700</bug_when>
    <thetext>[Qt] ContextMenuClientQt.cpp has coding-style errors</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>234958</commentid>
    <comment_count>1</comment_count>
      <attachid>58056</attachid>
    <who name="Anders Bakken">agbakken</who>
    <bug_when>2010-06-07 11:40:15 -0700</bug_when>
    <thetext>Created attachment 58056
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>235828</commentid>
    <comment_count>2</comment_count>
      <attachid>58056</attachid>
    <who name="David Levin">levin</who>
    <bug_when>2010-06-09 09:35:27 -0700</bug_when>
    <thetext>Comment on attachment 58056
Patch

WebKit/qt/WebCoreSupport/ContextMenuClientQt.cpp:33
 +  #include &quot;RefCounted.h&quot;
This should be included like this 

#include &lt;wtf/RefCounted.h&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>342413</commentid>
    <comment_count>3</comment_count>
      <attachid>80609</attachid>
    <who name="Srikumar B">srikumar.b</who>
    <bug_when>2011-01-30 18:22:39 -0800</bug_when>
    <thetext>Created attachment 80609
coding style changed to include RefCounted.h header wrt to wtf

coding style changed to include RefCounted.h header wrt to wtf</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>342930</commentid>
    <comment_count>4</comment_count>
      <attachid>80609</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-01-31 17:27:14 -0800</bug_when>
    <thetext>Comment on attachment 80609
coding style changed to include RefCounted.h header wrt to wtf

Clearing flags on attachment: 80609

Committed r77183: &lt;http://trac.webkit.org/changeset/77183&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>342931</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-01-31 17:27:19 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>58056</attachid>
            <date>2010-06-07 11:40:15 -0700</date>
            <delta_ts>2010-06-09 16:32:28 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-40243-20100607113856.patch</filename>
            <type>text/plain</type>
            <size>1250</size>
            <attacher name="Anders Bakken">agbakken</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmlu
ZGV4IGZkNThiNjllODYzOTNhMzRiODFhMWEwMDgxNjEyOGYwNjM1ODFhZmYuLjUxNmQ1OTA1MGYw
MGYxMjdlMTEyNjAyZWY5ZmE0ZWFmZWZjNzNkYWIgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFu
Z2VMb2cKKysrIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEwLTA2
LTA3ICBBbmRlcnMgQmFra2VuICA8YWdiYWtrZW5AZ21haWwuY29tPgorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gQ29udGV4dE1lbnVDbGllbnRR
dC5jcHAgaGFzIGNvZGluZy1zdHlsZSBlcnJvcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTQwMjQzCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9D
b250ZXh0TWVudUNsaWVudFF0LmNwcDoKKwogMjAxMC0wNi0wNiAgQW50b25pbyBHb21lcyAgPHRv
bmlraXRvb0B3ZWJraXQub3JnPiwgTGFzemxvIEdvbWJvcyAgPGxhc3psby4xLmdvbWJvc0Bub2tp
YS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBDaHJpc3RpYW5zZW4sIEVyaWMg
U2VpZGVsLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0NvbnRleHRNZW51
Q2xpZW50UXQuY3BwIGIvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0NvbnRleHRNZW51Q2xpZW50
UXQuY3BwCmluZGV4IGI0NDAwZmY1MTAzYjViMDczODAyZjM2NzY5MjU2YjA1NjRhNjU4ZGYuLmM3
YWM4ZWRjYWJhNWExMzc5ZTdjMzQwZGNjNWQwMzI0NDdkZWUxY2IgMTAwNjQ0Ci0tLSBhL1dlYktp
dC9xdC9XZWJDb3JlU3VwcG9ydC9Db250ZXh0TWVudUNsaWVudFF0LmNwcAorKysgYi9XZWJLaXQv
cXQvV2ViQ29yZVN1cHBvcnQvQ29udGV4dE1lbnVDbGllbnRRdC5jcHAKQEAgLTI5LDEzICsyOSwx
MyBAQAogI2luY2x1ZGUgIkNvbnRleHRNZW51LmgiCiAjaW5jbHVkZSAiSGl0VGVzdFJlc3VsdC5o
IgogI2luY2x1ZGUgIktVUkwuaCIKLSNpbmNsdWRlICJSZWZDb3VudGVkLmgiCiAjaW5jbHVkZSAi
Tm90SW1wbGVtZW50ZWQuaCIKKyNpbmNsdWRlICJSZWZDb3VudGVkLmgiCiAKICNpbmNsdWRlIDxz
dGRpby5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7Ci0gICAgCisKIHZvaWQgQ29udGV4dE1lbnVD
bGllbnRRdDo6Y29udGV4dE1lbnVEZXN0cm95ZWQoKQogewogICAgIGRlbGV0ZSB0aGlzOwo=
</data>
<flag name="review"
          id="42862"
          type_id="1"
          status="-"
          setter="levin"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>80609</attachid>
            <date>2011-01-30 18:22:39 -0800</date>
            <delta_ts>2011-01-31 17:27:14 -0800</delta_ts>
            <desc>coding style changed to include RefCounted.h header wrt to wtf</desc>
            <filename>40243.patch</filename>
            <type>text/plain</type>
            <size>1117</size>
            <attacher name="Srikumar B">srikumar.b</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X
ZWJLaXQvcXQvQ2hhbmdlTG9nCShyZXZpc2lvbiA3NzA5MikKKysrIFNvdXJjZS9XZWJLaXQvcXQv
Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDEtMzAgIFNy
aWt1bWFyIEJvbmRhICA8c3Jpa3VtYXIuYkBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBDb250ZXh0TWVudUNsaWVudFF0LmNw
cCBoYXMgY29kaW5nLXN0eWxlIGVycm9ycworICAgICAgICAiUmVmQ291bnRlZC5oIiBoZWFkZXIg
aW5jbHVzaW9uIHN0eWxlIGNoYW5nZWQgdG8gPHd0Zi9SZWZDb3VudGVkLmg+IAorICAgICAgICBo
dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDAyNDMKKworICAgICAgICAq
IFdlYkNvcmVTdXBwb3J0L0NvbnRleHRNZW51Q2xpZW50UXQuY3BwOgorCiAyMDExLTAxLTI4ICBE
YW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2Ft
IFdlaW5pZy4KSW5kZXg6IFNvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvQ29udGV4dE1l
bnVDbGllbnRRdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3Vw
cG9ydC9Db250ZXh0TWVudUNsaWVudFF0LmNwcAkocmV2aXNpb24gNzcwOTIpCisrKyBTb3VyY2Uv
V2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0NvbnRleHRNZW51Q2xpZW50UXQuY3BwCSh3b3JraW5n
IGNvcHkpCkBAIC0yOSw4ICsyOSw4IEBACiAjaW5jbHVkZSAiQ29udGV4dE1lbnUuaCIKICNpbmNs
dWRlICJIaXRUZXN0UmVzdWx0LmgiCiAjaW5jbHVkZSAiS1VSTC5oIgotI2luY2x1ZGUgIlJlZkNv
dW50ZWQuaCIKICNpbmNsdWRlICJOb3RJbXBsZW1lbnRlZC5oIgorI2luY2x1ZGUgPHd0Zi9SZWZD
b3VudGVkLmg+CiAKICNpbmNsdWRlIDxzdGRpby5oPgogCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>