40240 2010-06-07 11:24:21 -0700 [Qt] ChromeClientQt.cpp has coding-style errors 2010-06-09 13:53:48 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED Qt P2 Normal --- 0 agbakken webkit-unassigned commit-queue oldest_to_newest 234945 0 agbakken 2010-06-07 11:24:21 -0700 [Qt] ChromeClientQt.cpp has coding-style errors 234947 1 58053 agbakken 2010-06-07 11:25:11 -0700 Created attachment 58053 Patch 235987 2 58053 commit-queue 2010-06-09 13:53:42 -0700 Comment on attachment 58053 Patch Clearing flags on attachment: 58053 Committed r60910: <http://trac.webkit.org/changeset/60910> 235988 3 commit-queue 2010-06-09 13:53:48 -0700 All reviewed patches have been landed. Closing bug. 58053 2010-06-07 11:25:11 -0700 2010-06-09 13:53:42 -0700 Patch bug-40240-20100607112353.patch text/plain 5354 agbakken ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmlu ZGV4IGZkNThiNjllODYzOTNhMzRiODFhMWEwMDgxNjEyOGYwNjM1ODFhZmYuLjgzYWVmZThiZjFm YzExNWIzNDA3ZTliOTgxYjRjMzVlYTJkNzhjYWEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFu Z2VMb2cKKysrIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEwLTA2 LTA3ICBBbmRlcnMgQmFra2VuICA8YWdiYWtrZW5AZ21haWwuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gQ2hyb21lQ2xpZW50UXQuY3Bw IGhhcyBjb2Rpbmctc3R5bGUgZXJyb3JzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00MDI0MAorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvQ2hyb21l Q2xpZW50UXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q2hyb21lQ2xpZW50UXQ6OnBhZ2VSZWN0 KToKKyAgICAgICAgKFdlYkNvcmU6OkNocm9tZUNsaWVudFF0OjpjcmVhdGVXaW5kb3cpOgorICAg ICAgICAoV2ViQ29yZTo6Q2hyb21lQ2xpZW50UXQ6OnJ1bkphdmFTY3JpcHRBbGVydCk6CisgICAg ICAgIChXZWJDb3JlOjpDaHJvbWVDbGllbnRRdDo6cnVuSmF2YVNjcmlwdENvbmZpcm0pOgorICAg ICAgICAoV2ViQ29yZTo6Q2hyb21lQ2xpZW50UXQ6OnJ1bkphdmFTY3JpcHRQcm9tcHQpOgorICAg ICAgICAoV2ViQ29yZTo6Q2hyb21lQ2xpZW50UXQ6OnByaW50KToKKyAgICAgICAgKFdlYkNvcmU6 OkNocm9tZUNsaWVudFF0OjphdHRhY2hSb290R3JhcGhpY3NMYXllcik6CisgICAgICAgIChXZWJD b3JlOjpDaHJvbWVDbGllbnRRdDo6dmlzaWJsZVJlY3RGb3JUaWxlZEJhY2tpbmdTdG9yZSk6CisK IDIwMTAtMDYtMDYgIEFudG9uaW8gR29tZXMgIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4sIExhc3ps byBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IEtlbm5ldGggQ2hyaXN0aWFuc2VuLCBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBhL1dlYktp dC9xdC9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRRdC5jcHAgYi9XZWJLaXQvcXQvV2ViQ29y ZVN1cHBvcnQvQ2hyb21lQ2xpZW50UXQuY3BwCmluZGV4IDQzNGRhOWEwMTA2MDMxZDk4MzkzYjI2 YTRiNzFmN2UxZTBkMzk1NGYuLmQ4Mzg5YjU3NjQ5NTFjNGI3MDg1YTViM2I5M2NmZTBhM2FmZWIx OWIgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRRdC5j cHAKKysrIGIvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudFF0LmNwcApAQCAt MjksNiArMjksNyBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIkNocm9tZUNsaWVu dFF0LmgiCiAKKyNpbmNsdWRlICJEYXRhYmFzZVRyYWNrZXIuaCIKICNpbmNsdWRlICJGaWxlQ2hv b3Nlci5oIgogI2luY2x1ZGUgIkZyYW1lLmgiCiAjaW5jbHVkZSAiRnJhbWVMb2FkUmVxdWVzdC5o IgpAQCAtMzcsMTEgKzM4LDEwIEBACiAjaW5jbHVkZSAiRnJhbWVWaWV3LmgiCiAjaW5jbHVkZSAi SGl0VGVzdFJlc3VsdC5oIgogI2luY2x1ZGUgIkljb24uaCIKLSNpbmNsdWRlICJOb3RpZmljYXRp b25QcmVzZW50ZXJDbGllbnRRdC5oIgogI2luY2x1ZGUgIk5vdEltcGxlbWVudGVkLmgiCisjaW5j bHVkZSAiTm90aWZpY2F0aW9uUHJlc2VudGVyQ2xpZW50UXQuaCIKICNpbmNsdWRlICJTY3JvbGxi YXJUaGVtZS5oIgogI2luY2x1ZGUgIldpbmRvd0ZlYXR1cmVzLmgiCi0jaW5jbHVkZSAiRGF0YWJh c2VUcmFja2VyLmgiCiAjaWYgZGVmaW5lZChRX1dTX01BRU1PXzUpCiAjaW5jbHVkZSAiUXRNYWVt b1dlYlBvcHVwLmgiCiAjZWxzZQpAQCAtNTAsMTggKzUwLDE4IEBACiAjaW5jbHVkZSAiUVdlYlBh Z2VDbGllbnQuaCIKICNpbmNsdWRlICJTZWN1cml0eU9yaWdpbi5oIgogCi0jaW5jbHVkZSA8cWRl YnVnLmg+Ci0jaW5jbHVkZSA8cWV2ZW50bG9vcC5oPgotI2luY2x1ZGUgPHF0ZXh0ZG9jdW1lbnQu aD4KLSNpbmNsdWRlIDxxdG9vbHRpcC5oPgotCisjaW5jbHVkZSAicXdlYmZyYW1lX3AuaCIKICNp bmNsdWRlICJxd2VicGFnZS5oIgogI2luY2x1ZGUgInF3ZWJwYWdlX3AuaCIKLSNpbmNsdWRlICJx d2ViZnJhbWVfcC5oIgogI2luY2x1ZGUgInF3ZWJzZWN1cml0eW9yaWdpbi5oIgogI2luY2x1ZGUg InF3ZWJzZWN1cml0eW9yaWdpbl9wLmgiCiAjaW5jbHVkZSAicXdlYnZpZXcuaCIKIAorI2luY2x1 ZGUgPHFkZWJ1Zy5oPgorI2luY2x1ZGUgPHFldmVudGxvb3AuaD4KKyNpbmNsdWRlIDxxdGV4dGRv Y3VtZW50Lmg+CisjaW5jbHVkZSA8cXRvb2x0aXAuaD4KKwogI2lmIFVTRShBQ0NFTEVSQVRFRF9D T01QT1NJVElORykKICNpbmNsdWRlICJHcmFwaGljc0xheWVyUXQuaCIKICNlbmRpZgpAQCAtMTA2 LDcgKzEwNiw3IEBAIEZsb2F0UmVjdCBDaHJvbWVDbGllbnRRdDo6cGFnZVJlY3QoKQogewogICAg IGlmICghbV93ZWJQYWdlKQogICAgICAgICByZXR1cm4gRmxvYXRSZWN0KCk7Ci0gICAgcmV0dXJu IEZsb2F0UmVjdChRUmVjdEYoUVBvaW50RigwLDApLCBtX3dlYlBhZ2UtPnZpZXdwb3J0U2l6ZSgp KSk7CisgICAgcmV0dXJuIEZsb2F0UmVjdChRUmVjdEYoUVBvaW50RigwLCAwKSwgbV93ZWJQYWdl LT52aWV3cG9ydFNpemUoKSkpOwogfQogCiAKQEAgLTE2Myw3ICsxNjMsNyBAQCB2b2lkIENocm9t ZUNsaWVudFF0Ojpmb2N1c2VkTm9kZUNoYW5nZWQoV2ViQ29yZTo6Tm9kZSopCiAKIFBhZ2UqIENo cm9tZUNsaWVudFF0OjpjcmVhdGVXaW5kb3coRnJhbWUqLCBjb25zdCBGcmFtZUxvYWRSZXF1ZXN0 JiByZXF1ZXN0LCBjb25zdCBXaW5kb3dGZWF0dXJlcyYgZmVhdHVyZXMpCiB7Ci0gICAgUVdlYlBh Z2UgKm5ld1BhZ2UgPSBtX3dlYlBhZ2UtPmNyZWF0ZVdpbmRvdyhmZWF0dXJlcy5kaWFsb2cgPyBR V2ViUGFnZTo6V2ViTW9kYWxEaWFsb2cgOiBRV2ViUGFnZTo6V2ViQnJvd3NlcldpbmRvdyk7Cisg ICAgUVdlYlBhZ2UqIG5ld1BhZ2UgPSBtX3dlYlBhZ2UtPmNyZWF0ZVdpbmRvdyhmZWF0dXJlcy5k aWFsb2cgPyBRV2ViUGFnZTo6V2ViTW9kYWxEaWFsb2cgOiBRV2ViUGFnZTo6V2ViQnJvd3Nlcldp bmRvdyk7CiAgICAgaWYgKCFuZXdQYWdlKQogICAgICAgICByZXR1cm4gMDsKIApAQCAtMjkwLDIx ICsyOTAsMjEgQEAgdm9pZCBDaHJvbWVDbGllbnRRdDo6Y2xvc2VXaW5kb3dTb29uKCkKIHZvaWQg Q2hyb21lQ2xpZW50UXQ6OnJ1bkphdmFTY3JpcHRBbGVydChGcmFtZSogZiwgY29uc3QgU3RyaW5n JiBtc2cpCiB7CiAgICAgUVN0cmluZyB4ID0gbXNnOwotICAgIEZyYW1lTG9hZGVyQ2xpZW50UXQg KmZsID0gc3RhdGljX2Nhc3Q8RnJhbWVMb2FkZXJDbGllbnRRdCo+KGYtPmxvYWRlcigpLT5jbGll bnQoKSk7CisgICAgRnJhbWVMb2FkZXJDbGllbnRRdCogZmwgPSBzdGF0aWNfY2FzdDxGcmFtZUxv YWRlckNsaWVudFF0Kj4oZi0+bG9hZGVyKCktPmNsaWVudCgpKTsKICAgICBtX3dlYlBhZ2UtPmph dmFTY3JpcHRBbGVydChmbC0+d2ViRnJhbWUoKSwgeCk7CiB9CiAKIGJvb2wgQ2hyb21lQ2xpZW50 UXQ6OnJ1bkphdmFTY3JpcHRDb25maXJtKEZyYW1lKiBmLCBjb25zdCBTdHJpbmcmIG1zZykKIHsK ICAgICBRU3RyaW5nIHggPSBtc2c7Ci0gICAgRnJhbWVMb2FkZXJDbGllbnRRdCAqZmwgPSBzdGF0 aWNfY2FzdDxGcmFtZUxvYWRlckNsaWVudFF0Kj4oZi0+bG9hZGVyKCktPmNsaWVudCgpKTsKKyAg ICBGcmFtZUxvYWRlckNsaWVudFF0KiBmbCA9IHN0YXRpY19jYXN0PEZyYW1lTG9hZGVyQ2xpZW50 UXQqPihmLT5sb2FkZXIoKS0+Y2xpZW50KCkpOwogICAgIHJldHVybiBtX3dlYlBhZ2UtPmphdmFT Y3JpcHRDb25maXJtKGZsLT53ZWJGcmFtZSgpLCB4KTsKIH0KIAogYm9vbCBDaHJvbWVDbGllbnRR dDo6cnVuSmF2YVNjcmlwdFByb21wdChGcmFtZSogZiwgY29uc3QgU3RyaW5nJiBtZXNzYWdlLCBj b25zdCBTdHJpbmcmIGRlZmF1bHRWYWx1ZSwgU3RyaW5nJiByZXN1bHQpCiB7CiAgICAgUVN0cmlu ZyB4ID0gcmVzdWx0OwotICAgIEZyYW1lTG9hZGVyQ2xpZW50UXQgKmZsID0gc3RhdGljX2Nhc3Q8 RnJhbWVMb2FkZXJDbGllbnRRdCo+KGYtPmxvYWRlcigpLT5jbGllbnQoKSk7CisgICAgRnJhbWVM b2FkZXJDbGllbnRRdCogZmwgPSBzdGF0aWNfY2FzdDxGcmFtZUxvYWRlckNsaWVudFF0Kj4oZi0+ bG9hZGVyKCktPmNsaWVudCgpKTsKICAgICBib29sIHJjID0gbV93ZWJQYWdlLT5qYXZhU2NyaXB0 UHJvbXB0KGZsLT53ZWJGcmFtZSgpLCAoUVN0cmluZyltZXNzYWdlLCAoUVN0cmluZylkZWZhdWx0 VmFsdWUsICZ4KTsKIAogICAgIC8vIEZpeCB1cCBhIHF1aXJrIGluIHRoZSBRSW5wdXREaWFsb2cg Y2xhc3MuIElmIG5vIGlucHV0IGhhcHBlbmVkIHRoZSBzdHJpbmcgc2hvdWxkIGJlIGVtcHR5CkBA IC00NTksNyArNDU5LDcgQEAgdm9pZCBDaHJvbWVDbGllbnRRdDo6c2V0VG9vbFRpcChjb25zdCBT dHJpbmcgJnRpcCwgVGV4dERpcmVjdGlvbikKICNlbmRpZgogfQogCi12b2lkIENocm9tZUNsaWVu dFF0OjpwcmludChGcmFtZSAqZnJhbWUpCit2b2lkIENocm9tZUNsaWVudFF0OjpwcmludChGcmFt ZSogZnJhbWUpCiB7CiAgICAgZW1pdCBtX3dlYlBhZ2UtPnByaW50UmVxdWVzdGVkKFFXZWJGcmFt ZVByaXZhdGU6OmtpdChmcmFtZSkpOwogfQpAQCAtNTQyLDcgKzU0Miw3IEBAIHZvaWQgQ2hyb21l Q2xpZW50UXQ6OnJlcXVlc3RHZW9sb2NhdGlvblBlcm1pc3Npb25Gb3JGcmFtZShGcmFtZSosIEdl b2xvY2F0aW9uKikKIAogI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKIHZvaWQgQ2hy b21lQ2xpZW50UXQ6OmF0dGFjaFJvb3RHcmFwaGljc0xheWVyKEZyYW1lKiBmcmFtZSwgR3JhcGhp Y3NMYXllciogZ3JhcGhpY3NMYXllcikKLXsgICAgCit7CiAgICAgaWYgKHBsYXRmb3JtUGFnZUNs aWVudCgpKQogICAgICAgICBwbGF0Zm9ybVBhZ2VDbGllbnQoKS0+c2V0Um9vdEdyYXBoaWNzTGF5 ZXIoZ3JhcGhpY3NMYXllciA/IGdyYXBoaWNzTGF5ZXItPm5hdGl2ZUxheWVyKCkgOiAwKTsKIH0K QEAgLTU2NywxMCArNTY3LDEwIEBAIGJvb2wgQ2hyb21lQ2xpZW50UXQ6OmFsbG93c0FjY2VsZXJh dGVkQ29tcG9zaXRpbmcoKSBjb25zdAogfQogCiAjZW5kaWYKLSAgICAKKwogI2lmIEVOQUJMRShU SUxFRF9CQUNLSU5HX1NUT1JFKQogSW50UmVjdCBDaHJvbWVDbGllbnRRdDo6dmlzaWJsZVJlY3RG b3JUaWxlZEJhY2tpbmdTdG9yZSgpIGNvbnN0Ci17IAorewogICAgIGlmICghcGxhdGZvcm1QYWdl Q2xpZW50KCkgfHwgIW1fd2ViUGFnZSkKICAgICAgICAgcmV0dXJuIEludFJlY3QoKTsKIAo=