40237 2010-06-07 09:17:58 -0700 [Qt] QtWebKit exports WebCore symbols 2014-02-03 03:06:49 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC All RESOLVED INVALID Qt, QtTriaged P3 Normal --- 1 debfx webkit-unassigned fabo jturcotte oldest_to_newest 234882 0 58036 debfx 2010-06-07 09:17:58 -0700 Created attachment 58036 Patch to reduce visibility similar to the JavaScriptCore commit QtWebKit exports the WebCore symbols when building as a standalone package. Previously the JavaScriptCore symbols were exported too. This has been fixed by this commit: http://trac.webkit.org/changeset/58100/trunk/JavaScriptCore/JavaScriptCore.pro The same should be done in WebCore. 236283 1 jturcotte 2010-06-10 03:32:50 -0700 Looks good to me. The CONFIG(standalone_package) condition should clearly be removed since we will start getting releases separated from Qt. If you want a reviewer to look at your patch you should set the review flag of the attachment to '?' (and the commit queue flag to '?' if you want it to be landed automatically) 237427 2 58036 eric 2010-06-12 19:11:01 -0700 Comment on attachment 58036 Patch to reduce visibility similar to the JavaScriptCore commit Please generate the patch from a WebKit checkout, and include a ChangeLog per our contribution guidelines: http://webkit.org/coding/contributing.html webkit-patch upload is one script which can help you make sure you're following the guildes. 974986 3 jturcotte 2014-02-03 03:06:49 -0800 === Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines. 58036 2010-06-07 09:17:58 -0700 2010-06-12 19:11:01 -0700 Patch to reduce visibility similar to the JavaScriptCore commit webcore_symbol_visibility.diff text/plain 648 debfx LS0tIHF0d2Via2l0LTQuN35iZXRhMStnaXQyMDEwMDUyMi5vcmlnL1dlYkNvcmUvV2ViQ29yZS5w cm8KKysrIHF0d2Via2l0LTQuN35iZXRhMStnaXQyMDEwMDUyMi9XZWJDb3JlL1dlYkNvcmUucHJv CkBAIC04NSwxMCArODUsOCBAQAogdW5peDohbWFjOiotZysrKjpRTUFLRV9MRkxBR1MgKz0gLVds LC0tZ2Mtc2VjdGlvbnMKIGxpbnV4Ki1nKysqOlFNQUtFX0xGTEFHUyArPSAkJFFNQUtFX0xGTEFH U19OT1VOREVGCiAKLUNPTkZJRyhyZWxlYXNlKTohQ09ORklHKHN0YW5kYWxvbmVfcGFja2FnZSkg ewotICAgIGNvbnRhaW5zKFFUX0NPTkZJRywgcmVkdWNlX2V4cG9ydHMpOkNPTkZJRyArPSBoaWRl X3N5bWJvbHMKLSAgICB1bml4OmNvbnRhaW5zKFFUX0NPTkZJRywgcmVkdWNlX3JlbG9jYXRpb25z KTpDT05GSUcgKz0gYnN5bWJvbGljX2Z1bmN0aW9ucwotfQorY29udGFpbnMoUVRfQ09ORklHLCBy ZWR1Y2VfZXhwb3J0cyk6Q09ORklHICs9IGhpZGVfc3ltYm9scwordW5peDpjb250YWlucyhRVF9D T05GSUcsIHJlZHVjZV9yZWxvY2F0aW9ucyk6Q09ORklHICs9IGJzeW1ib2xpY19mdW5jdGlvbnMK IAogbGludXgtKjogREVGSU5FUyArPSBIQVZFX1NURElOVF9ICiBmcmVlYnNkLSo6IERFRklORVMg Kz0gSEFWRV9QVEhSRUFEX05QX0gK