40200 2010-06-04 20:59:16 -0700 "Fix" fast/dom/stripNullFromTextNodes.html in HTML5 parser 2010-06-07 11:51:48 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 39259 1 abarth abarth ap eric oldest_to_newest 234501 0 abarth 2010-06-04 20:59:16 -0700 "Fix" fast/dom/stripNullFromTextNodes.html in HTML5 parser 234502 1 57958 abarth 2010-06-04 21:00:51 -0700 Created attachment 57958 Patch 234521 2 57958 eric 2010-06-04 22:08:19 -0700 Comment on attachment 57958 Patch I guess we don't have any way to check in results for a test like this, eh? We could with the html5lib tests. Please consider adding a test with checked in results. 234620 3 ap 2010-06-05 09:59:49 -0700 So, neither WebKit nor shipping versions of Gecko turn nulls into U+FFFD, but HTML5 requires that. Could it be a bug in the spec? What does IE do? 234621 4 ap 2010-06-05 10:06:39 -0700 For some context: HTML5 offline storage parser also had the requirement to turn nulls into U+FFFD, which was dropped based on our feedback. U+FFFD is generally used to signal decoding errors, which a null definitely doesn't cause. 234622 5 abarth 2010-06-05 10:19:57 -0700 I believe swallows the nulls, but I haven't tested recently. We should file a bug with the HTML5 WG. 234623 6 ap 2010-06-05 10:24:38 -0700 I tested in more detail, and it seems to be trickier: - WebKit passes stripNullFromTextNodes.html, as it strips nulls from text node content; - so does IE 7; - Firefox 3.6.3 actually fails the test, and inserts U+FFFD; - but Firefox passes an original reduction for rdar://4702420, which I incorrectly assumed to be the same: <div>\0</div> So, Firefox seems to drop the null if it's the only character in a text node (?!) 234624 7 57967 ap 2010-06-05 10:26:22 -0700 Created attachment 57967 original reduction 234974 8 57958 abarth 2010-06-07 11:51:41 -0700 Comment on attachment 57958 Patch Clearing flags on attachment: 57958 Committed r60791: <http://trac.webkit.org/changeset/60791> 234975 9 abarth 2010-06-07 11:51:48 -0700 All reviewed patches have been landed. Closing bug. 57958 2010-06-04 21:00:51 -0700 2010-06-07 11:51:41 -0700 Patch bug-40200-20100604210050.patch text/plain 1764 abarth ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTU3OWYyYTY5YjNlYTQzMzQ0MjdmYzZhNzkzODFhNGZhOTYwZTdjNS4uMzkyMTljMzE4ZTE2MTEw YjQ0ZGUyNTEyMDlhNDk4MTcwY2FiNWQ5YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwyMiBAQAogCiAgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgogCisgICAgICAgICJGaXgiIGZhc3QvZG9tL3N0cmlwTnVs bEZyb21UZXh0Tm9kZXMuaHRtbCBpbiBIVE1MNSBwYXJzZXIKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwMjAwCisKKyAgICAgICAgVGhlIHByb3BlciBo YW5kbGluZyBvZiBudWxsIGNoYXJhY3RlcnMgaXMgdG8gcmVwbGFjZSB0aGVtIHdpdGggVStGRkZE LgorICAgICAgICBUaGlzIHBhdGNoICJmaXhlcyIgZmFzdC9kb20vc3RyaXBOdWxsRnJvbVRleHRO b2Rlcy5odG1sIGluIHRoZSBzZW5zZQorICAgICAgICB0aGF0IGl0IG1ha2VzIGl0IGdpdmUgdGhl IHByb3BlciBvdXRwdXQgdy5yLnQuIEhUTUw1LiAgSG93ZXZlciwgdGhhdAorICAgICAgICBkb2Vz bid0IG1hdGNoIHRoZSBiZWhhdmlvciBvZiB0aGUgb2xkIHBhcnNlciwgd2hpY2gganVzdCBzdHJp cHBlZCB0aGUKKyAgICAgICAgbnVsbHMuCisKKyAgICAgICAgKiBodG1sL0hUTUw1TGV4ZXIuaDoK KyAgICAgICAgKFdlYkNvcmU6OkhUTUw1TGV4ZXI6OklucHV0U3RyZWFtUHJlcHJvY2Vzc29yOjpw ZWVrKToKKworMjAxMC0wNi0wNCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCiAgICAgICAgIEhUTUw1IHBhcnNl ciBzaG91bGQgbm9ybWFsaXplIGxpbmUgZW5kaW5ncwogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDAxOTkKIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9odG1s L0hUTUw1TGV4ZXIuaCBiL1dlYkNvcmUvaHRtbC9IVE1MNUxleGVyLmgKaW5kZXggMDU2ZmYwNWM0 YWI0M2ZlMTIzYTJiYzkxN2JiMDgyN2Y0M2IwNDRhMi4uNWVlOGU1NDBkN2QxNzE2Y2IxM2YwNDEz ZWM1MTIwOGM3MDNjYThiMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9odG1sL0hUTUw1TGV4ZXIuaAor KysgYi9XZWJDb3JlL2h0bWwvSFRNTDVMZXhlci5oCkBAIC0xNTAsOCArMTUwLDExIEBAIG5hbWVz cGFjZSBXZWJDb3JlIHsKICAgICAgICAgICAgICAgICBpZiAobV9uZXh0SW5wdXRDaGFyYWN0ZXIg PT0gJ1xyJykgewogICAgICAgICAgICAgICAgICAgICBtX25leHRJbnB1dENoYXJhY3RlciA9ICdc bic7CiAgICAgICAgICAgICAgICAgICAgIG1fc2tpcE5leHROZXdMaW5lID0gdHJ1ZTsKLSAgICAg ICAgICAgICAgICB9IGVsc2UKKyAgICAgICAgICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAg ICAgICAgICBtX3NraXBOZXh0TmV3TGluZSA9IGZhbHNlOworICAgICAgICAgICAgICAgICAgICBp ZiAobV9uZXh0SW5wdXRDaGFyYWN0ZXIgPT0gJ1wwJyB8fCAobV9uZXh0SW5wdXRDaGFyYWN0ZXIg Pj0gMHhEODAwICYmIG1fbmV4dElucHV0Q2hhcmFjdGVyIDw9IDB4REZGRikpCisgICAgICAgICAg ICAgICAgICAgICAgICBtX25leHRJbnB1dENoYXJhY3RlciA9IDB4RkZGRDsKKyAgICAgICAgICAg ICAgICB9CiAgICAgICAgICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgICAgICAgICB9CiAK 57967 2010-06-05 10:26:22 -0700 2010-06-05 10:26:22 -0700 original reduction thReduction.html text/html 42 ap PGRpdiBzdHlsZT0iYm9yZGVyOjFweCBzb2xpZCByZWQ7Ij4APC9kaXY+