40194 2010-06-04 18:05:13 -0700 AX: support helpText() in DumpRenderTree 2013-11-12 11:45:06 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC Windows 7 RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach webkit-unassigned aboxhall apinheiro commit-queue dmazzoni jcraig jdiggs mario msaboff samuel_white thorton webkit-bug-importer oldest_to_newest 234447 0 cfleizach 2010-06-04 18:05:13 -0700 that way you can uncomment out accessibility/aria-help.html from the skipped test lists 934778 1 samuel_white 2013-09-30 13:04:54 -0700 <rdar://problem/15113997> 949344 2 216584 samuel_white 2013-11-11 09:47:58 -0800 Created attachment 216584 Patch. 949420 3 216584 commit-queue 2013-11-11 13:07:11 -0800 Comment on attachment 216584 Patch. Clearing flags on attachment: 216584 Committed r159067: <http://trac.webkit.org/changeset/159067> 949421 4 commit-queue 2013-11-11 13:07:14 -0800 All reviewed patches have been landed. Closing bug. 949745 5 msaboff 2013-11-12 11:13:22 -0800 This test has been failing 100% of the time since the move, on all platforms. 949746 6 thorton 2013-11-12 11:13:59 -0800 (In reply to comment #5) > This test has been failing 100% of the time since the move, on all platforms. Sorry, that was me, machine was still logged in as msaboff. 949747 7 216584 cfleizach 2013-11-12 11:14:06 -0800 Comment on attachment 216584 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=216584&action=review > LayoutTests/accessibility/aria-help.html:4 > +<script src="../../../resources/js-test-pre.js"></script> this lines need to be updated to be ../resources 949749 8 thorton 2013-11-12 11:16:08 -0800 (In reply to comment #7) > (From update of attachment 216584 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=216584&action=review > > > LayoutTests/accessibility/aria-help.html:4 > > +<script src="../../../resources/js-test-pre.js"></script> > > this lines need to be updated to be ../resources Will do! 949750 9 thorton 2013-11-12 11:19:22 -0800 Theoretically fixed in http://trac.webkit.org/changeset/159128 949761 10 samuel_white 2013-11-12 11:35:56 -0800 (In reply to comment #9) > Theoretically fixed in http://trac.webkit.org/changeset/159128 Thanks Tim. 949764 11 samuel_white 2013-11-12 11:37:20 -0800 Chris, any idea why this didn't get caught by the bots? The mac platform results should have failed for aria-help.html. 949766 12 thorton 2013-11-12 11:45:06 -0800 (In reply to comment #11) > Chris, any idea why this didn't get caught by the bots? The mac platform results should have failed for aria-help.html. They certainly caught it when it was landed. Not sure why EWS didn't notice... 216584 2013-11-11 09:47:58 -0800 2013-11-12 11:14:06 -0800 Patch. win-help-text.patch text/plain 4200 samuel_white ZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9BY2Nlc3NpYmlsaXR5VUlFbGVt ZW50V2luLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9BY2Nlc3NpYmlsaXR5VUlFbGVt ZW50V2luLmNwcAppbmRleCA1NTQyMzVmLi42YTY1MWViIDEwMDY0NAotLS0gYS9Ub29scy9EdW1w UmVuZGVyVHJlZS93aW4vQWNjZXNzaWJpbGl0eVVJRWxlbWVudFdpbi5jcHAKKysrIGIvVG9vbHMv RHVtcFJlbmRlclRyZWUvd2luL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRXaW4uY3BwCkBAIC0zMjQs NyArMzI0LDE1IEBAIEpTU3RyaW5nUmVmIEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6Omxhbmd1YWdl KCkKIAogSlNTdHJpbmdSZWYgQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6aGVscFRleHQoKSBjb25z dAogewotICAgIHJldHVybiAwOworICAgIGlmICghbV9lbGVtZW50KQorICAgICAgICByZXR1cm4g SlNTdHJpbmdDcmVhdGVXaXRoQ2hhcmFjdGVycygwLCAwKTsKKworICAgIEJTVFIgaGVscFRleHRC U1RSOworICAgIGlmIChGQUlMRUQobV9lbGVtZW50LT5nZXRfYWNjSGVscChzZWxmKCksICZoZWxw VGV4dEJTVFIpKSB8fCAhaGVscFRleHRCU1RSKQorICAgICAgICByZXR1cm4gSlNTdHJpbmdDcmVh dGVXaXRoQ2hhcmFjdGVycygwLCAwKTsKKyAgICB3c3RyaW5nIGhlbHBUZXh0KGhlbHBUZXh0QlNU UiwgU3lzU3RyaW5nTGVuKGhlbHBUZXh0QlNUUikpOworICAgIDo6U3lzRnJlZVN0cmluZyhoZWxw VGV4dEJTVFIpOworICAgIHJldHVybiBKU1N0cmluZ0NyZWF0ZVdpdGhDaGFyYWN0ZXJzKGhlbHBU ZXh0LmRhdGEoKSwgaGVscFRleHQubGVuZ3RoKCkpOwogfQogCiBkb3VibGUgQWNjZXNzaWJpbGl0 eVVJRWxlbWVudDo6eCgpCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L2Fy aWEtaGVscC5odG1sIGIvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9hcmlhLWhlbHAuaHRtbApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5jM2NmMDNlCi0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9hcmlhLWhlbHAuaHRtbApAQCAtMCwwICsx LDMwIEBACis8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lFVEYvL0RURCBIVE1MLy9FTiI+Cis8 aHRtbD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9Ii4uLy4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXBy ZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBpZD0iYm9keSI+CisKKzxkaXYgaWQ9ImJ1 dHRvbiIgdGFiaW5kZXg9MCByb2xlPSJidXR0b24iIGFyaWEtbGFiZWw9InRpdGxlIiBhcmlhLWhl bHA9ImNsaWNrIGhlcmUiPgorYnV0dG9uCis8L2Rpdj4KKworPHAgaWQ9ImRlc2NyaXB0aW9uIj48 L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKworPHNjcmlwdD4KKworICAgIGRlc2NyaXB0 aW9uKCJUaGlzIHRlc3RzIHRoYXQgYXJpYS1oZWxwIGF0dHJpYnV0ZSB3b3JrcyBhcyBleHBlY3Rl ZC4iKTsKKworICAgIGlmICh3aW5kb3cuYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIpIHsKKworICAg ICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiYnV0dG9uIikuZm9jdXMoKTsKKyAgICAgICAg dmFyIGJ1dHRvbiA9IGFjY2Vzc2liaWxpdHlDb250cm9sbGVyLmZvY3VzZWRFbGVtZW50OworICAg ICAgICBzaG91bGRCZSgiYnV0dG9uLmhlbHBUZXh0IiwgIidBWEhlbHA6IGNsaWNrIGhlcmUnIik7 CisgICAgfQorCis8L3NjcmlwdD4KKworPHNjcmlwdCBzcmM9Ii4uLy4uLy4uL3Jlc291cmNlcy9q cy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvYXJpYS1oZWxwLmh0bWwgYi9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9hcmlhLWhlbHAuaHRtbApkZWxl dGVkIGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggYzNjZjAzZS4uMDAwMDAwMAotLS0gYS9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9hcmlhLWhlbHAuaHRtbAorKysgL2Rldi9u dWxsCkBAIC0xLDMwICswLDAgQEAKLTwhRE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFRE IEhUTUwvL0VOIj4KLTxodG1sPgotPGhlYWQ+Ci08c2NyaXB0IHNyYz0iLi4vLi4vLi4vcmVzb3Vy Y2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KLTwvaGVhZD4KLTxib2R5IGlkPSJib2R5Ij4K LQotPGRpdiBpZD0iYnV0dG9uIiB0YWJpbmRleD0wIHJvbGU9ImJ1dHRvbiIgYXJpYS1sYWJlbD0i dGl0bGUiIGFyaWEtaGVscD0iY2xpY2sgaGVyZSI+Ci1idXR0b24KLTwvZGl2PgotCi08cCBpZD0i ZGVzY3JpcHRpb24iPjwvcD4KLTxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgotCi08c2NyaXB0Pgot Ci0gICAgZGVzY3JpcHRpb24oIlRoaXMgdGVzdHMgdGhhdCBhcmlhLWhlbHAgYXR0cmlidXRlIHdv cmtzIGFzIGV4cGVjdGVkLiIpOwotCi0gICAgaWYgKHdpbmRvdy5hY2Nlc3NpYmlsaXR5Q29udHJv bGxlcikgewotCi0gICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJidXR0b24iKS5mb2N1 cygpOwotICAgICAgICB2YXIgYnV0dG9uID0gYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIuZm9jdXNl ZEVsZW1lbnQ7Ci0gICAgICAgIHNob3VsZEJlKCJidXR0b24uaGVscFRleHQiLCAiJ0FYSGVscDog Y2xpY2sgaGVyZSciKTsKLSAgICB9Ci0KLTwvc2NyaXB0PgotCi08c2NyaXB0IHNyYz0iLi4vLi4v Li4vcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Ci08L2JvZHk+Ci08L2h0bWw+ CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKaW5kZXggYmVkMTM0Zi4uZmQyYmFkOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTEx LTExICBTYW11ZWwgV2hpdGUgIDxzYW11ZWxfd2hpdGVAYXBwbGUuY29tPgorCisgICAgICAgIEFY OiBzdXBwb3J0IGhlbHBUZXh0KCkgaW4gRHVtcFJlbmRlclRyZWUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwMTk0CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTW92aW5nIGxheW91dCB0ZXN0IGJhY2sgdG8g aXRzIG9yaWdpbmFsIGxvY2F0aW9uLiBTaG91bGRuJ3QgYmUgcGxhdGZvcm0gc3BlY2lmaWMuCisK KyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2FyaWEtaGVscC5odG1sOiBSZW5hbWVkIGZyb20gTGF5 b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvYXJpYS1oZWxwLmh0bWwuCisKIDIw MTMtMTEtMDYgIE1pY2hhxYIgUGFrdcWCYSB2ZWwgUnV0a2EgIDxtLnBha3VsYUBzYW1zdW5nLmNv bT4KIAogICAgICAgICBbQVRLXSBhY2Nlc3NpYmlsaXR5L3RpdGxlLXVpLWVsZW1lbnQtY29ycmVj dG5lc3MuaHRtbCBmYWlscwpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hh bmdlTG9nCmluZGV4IGQwZDI2ZTkuLjE0ZTViM2EgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxv ZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMy0xMS0xMSAgU2Ft dWVsIFdoaXRlICA8c2FtdWVsX3doaXRlQGFwcGxlLmNvbT4KKworICAgICAgICBBWDogc3VwcG9y dCBoZWxwVGV4dCgpIGluIER1bXBSZW5kZXJUcmVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDE5NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEltcGxlbWVudGVkIHN0dWJiZWQgaGVscFRleHQgbWV0aG9k cyBzbyB3ZSBjYW4gbW92ZSBhcmlhLWhlbHAuaHRtbCBiYWNrIHRvIExheW91dFRlc3RzL2FjY2Vz c2liaWxpdHkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS93aW4vQWNjZXNzaWJpbGl0eVVJ RWxlbWVudFdpbi5jcHA6CisgICAgICAgIChBY2Nlc3NpYmlsaXR5VUlFbGVtZW50OjpoZWxwVGV4 dCk6CisKIDIwMTMtMTEtMDYgIEtyenlzenRvZiBDemVjaCAgPGsuY3plY2hAc2Ftc3VuZy5jb20+ CiAKICAgICAgICAgW0FUS10gSW1wbGVtZW50IHRhYmxlcy1yZWxhdGVkIGF0dHJpYnV0ZXNPZioo KSBmdW5jdGlvbnMgZm9yIEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQK