40186 2010-06-04 13:43:13 -0700 WebKit2: Need to close WebPageProxy when the WebView is destroyed 2010-06-04 13:56:05 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 adachan adachan oldest_to_newest 234362 0 adachan 2010-06-04 13:43:13 -0700 We need to close WebPageProxy when the WebView is destroyed, or a stale WebPageProxy will remain in the page map of the WebProcessProxy. 234363 1 57910 adachan 2010-06-04 13:47:48 -0700 Created attachment 57910 Patch 234365 2 57910 andersca 2010-06-04 13:50:30 -0700 Comment on attachment 57910 Patch r=me! 234367 3 adachan 2010-06-04 13:56:05 -0700 Fixed in http://trac.webkit.org/changeset/60705 57910 2010-06-04 13:47:48 -0700 2010-06-04 13:50:30 -0700 Patch 40186.patch.txt text/plain 2817 adachan SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MDcwNCkKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMDYtMDQgIEFkYSBDaGFuICA8YWRhY2hhbkBhcHBsZS5jb20+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cDov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDAxODYKKyAgICAgICAgCisgICAgICAg IE5lZWQgdG8gY2xvc2UgV2ViUGFnZVByb3h5IHdoZW4gdGhlIFdlYlZpZXcgaXMgZGVzdHJveWVk LgorICAgICAgICBBbHNvLCBXZWJQYWdlUHJveHkgc2hvdWxkbid0IGhvbGQgYW4gT3duUHRyIHRv IHRoZSBQYWdlQ2xpZW50LCB3aGljaCBpcyB0aGUgV2ViVmlldyBvbiBXaW5kb3dzLgorCisgICAg ICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBh Z2VQcm94eTo6V2ViUGFnZVByb3h5KToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5Ojpz ZXRQYWdlQ2xpZW50KToKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5Lmg6CisgICAg ICAgICogVUlQcm9jZXNzL3dpbi9XZWJWaWV3LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViVmll dzo6Y2xvc2UpOgorCiAyMDEwLTA2LTAzICBBZGEgQ2hhbiAgPGFkYWNoYW5AYXBwbGUuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gUm9iZW4uCkluZGV4OiBXZWJLaXQyL1VJUHJvY2Vz cy9XZWJQYWdlUHJveHkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvVUlQcm9jZXNzL1dlYlBh Z2VQcm94eS5jcHAJKHJldmlzaW9uIDYwNzA0KQorKysgV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFn ZVByb3h5LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjAsNyArNjAsOCBAQCBQYXNzUmVmUHRyPFdl YlBhZ2VQcm94eT4gV2ViUGFnZVByb3h5OjpjCiB9CiAKIFdlYlBhZ2VQcm94eTo6V2ViUGFnZVBy b3h5KFdlYlBhZ2VOYW1lc3BhY2UqIHBhZ2VOYW1lc3BhY2UsIHVpbnQ2NF90IHBhZ2VJRCkKLSAg ICA6IG1fcGFnZU5hbWVzcGFjZShwYWdlTmFtZXNwYWNlKQorICAgIDogbV9wYWdlQ2xpZW50KDAp CisgICAgLCBtX3BhZ2VOYW1lc3BhY2UocGFnZU5hbWVzcGFjZSkKICAgICAsIG1fbWFpbkZyYW1l KDApCiAgICAgLCBtX2NhbkdvQmFjayhmYWxzZSkKICAgICAsIG1fY2FuR29Gb3J3YXJkKGZhbHNl KQpAQCAtOTIsNyArOTMsMTEgQEAgYm9vbCBXZWJQYWdlUHJveHk6OmlzVmFsaWQoKQogCiB2b2lk IFdlYlBhZ2VQcm94eTo6c2V0UGFnZUNsaWVudChQYWdlQ2xpZW50KiBwYWdlQ2xpZW50KQogewor I2lmIFBMQVRGT1JNKFdJTikKKyAgICBtX3BhZ2VDbGllbnQgPSBwYWdlQ2xpZW50OworI2Vsc2UK ICAgICBtX3BhZ2VDbGllbnQuc2V0KHBhZ2VDbGllbnQpOworI2VuZGlmCiB9CiAKIHZvaWQgV2Vi UGFnZVByb3h5Ojppbml0aWFsaXplTG9hZGVyQ2xpZW50KFdLUGFnZUxvYWRlckNsaWVudCogbG9h ZENsaWVudCkKSW5kZXg6IFdlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oCShyZXZpc2lvbiA2MDcwNCkK KysrIFdlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oCSh3b3JraW5nIGNvcHkpCkBAIC0x ODMsNyArMTgzLDEzIEBAIHByaXZhdGU6CiAgICAgdm9pZCBkaWRSdW5KYXZhU2NyaXB0SW5NYWlu RnJhbWUoY29uc3QgV2ViQ29yZTo6U3RyaW5nJiwgdWludDY0X3QpOwogICAgIHZvaWQgZGlkR2V0 UmVuZGVyVHJlZUV4dGVybmFsUmVwcmVzZW50YXRpb24oY29uc3QgV2ViQ29yZTo6U3RyaW5nJiwg dWludDY0X3QpOwogCisjaWYgUExBVEZPUk0oV0lOKQorICAgIFBhZ2VDbGllbnQqIG1fcGFnZUNs aWVudDsKKyNlbHNlCisgICAgLy8gRklYTUU6IFRoaXMgc2hvdWxkIG5vdCBiZSBhbiBPd25QdHIg dG8gdGhlIFBhZ2VDbGllbnQuICBXZSBuZWVkIHRvIGZpbmQgYSBiZXR0ZXIgd2F5IHRvIGNsZWFu IHVwIG1fcGFnZUNsaWVudCBvbiBtYWMuCisgICAgLy8gaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDAxODUKICAgICBPd25QdHI8UGFnZUNsaWVudD4gbV9wYWdlQ2xpZW50 OworI2VuZGlmCiAgICAgV2ViTG9hZGVyQ2xpZW50IG1fbG9hZGVyQ2xpZW50OwogICAgIFdlYlBv bGljeUNsaWVudCBtX3BvbGljeUNsaWVudDsKICAgICBXZWJVSUNsaWVudCBtX3VpQ2xpZW50OwpJ bmRleDogV2ViS2l0Mi9VSVByb2Nlc3Mvd2luL1dlYlZpZXcuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YktpdDIvVUlQcm9jZXNzL3dpbi9XZWJWaWV3LmNwcAkocmV2aXNpb24gNjA3MDQpCisrKyBXZWJL aXQyL1VJUHJvY2Vzcy93aW4vV2ViVmlldy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ5Niw2ICs0 OTYsNyBAQCB2b2lkIFdlYlZpZXc6OnN0b3BUcmFja2luZ01vdXNlTGVhdmUoKQogdm9pZCBXZWJW aWV3OjpjbG9zZSgpCiB7CiAgICAgc2V0SG9zdFdpbmRvdygwKTsKKyAgICBtX3BhZ2UtPmNsb3Nl KCk7CiB9CiAKIC8vIFBhZ2VDbGllbnQK