40185 2010-06-04 13:21:09 -0700 WebPageProxy should keep a weak reference to the PageClient 2010-07-27 14:08:58 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 adachan aroben andersca aroben kenneth sam zoltan oldest_to_newest 234358 0 adachan 2010-06-04 13:21:09 -0700 Right now WebPageProxy stores an OwnPtr to the PageClient. That is not appropriate because WebPageProxy does not create the PageClient and it can be set to something that it should not own. For example, on Windows, it's currently being set to the WebView itself. This will cause a crash because WebView has a reference to WebPageProxy which has an OwnPtr to its PageClient, which is the WebView. 256793 1 aroben 2010-07-27 13:33:30 -0700 Seems like WKView should own the PageClient instead. 256816 2 62743 aroben 2010-07-27 14:01:46 -0700 Created attachment 62743 Patch 256819 3 aroben 2010-07-27 14:08:58 -0700 Committed r64155: <http://trac.webkit.org/changeset/64155> 62743 2010-07-27 14:01:46 -0700 2010-07-27 14:02:11 -0700 Patch bug-40185-20100727170144.patch text/plain 3497 aroben ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg YzkwMWMyNzEyYjg1ZjlmMmNlNjQ3ZTYxNTIzMzNhMjY0YzlkMzgxMi4uM2Q1NGFmYjdkNTBkZGVm OTY2MzBlN2U5NjJmM2E1YjE5NDNhODZiNSAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyNyBAQAogMjAxMC0wNy0yNyAgQWRh bSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKKyAgICAgICAgRml4IFBhZ2VDbGllbnQgb3du ZXJzaGlwIGluIFdlYlBhZ2VQcm94eQorCisgICAgICAgIFdLVmlldyBub3cgb3ducyB0aGUgUGFn ZUNsaWVudCwgc2ltaWxhciB0byBob3cgdGhpbmdzIHdvcmsgb24gV2luZG93cworICAgICAgICAo d2hlcmUgdGhlIFdlYlZpZXcgaXMgdGhlIFBhZ2VDbGllbnQpLgorCisgICAgICAgIEZpeGVzIDxo dHRwOi8vd2Via2l0Lm9yZy9iLzQwMTg1PiBXZWJQYWdlUHJveHkgc2hvdWxkIGtlZXAgYSB3ZWFr CisgICAgICAgIHJlZmVyZW5jZSB0byB0aGUgUGFnZUNsaWVudAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3 Lm1tOgorICAgICAgICAoLVtXS1ZpZXcgaW5pdFdpdGhGcmFtZTpwYWdlTmFtZXNwYWNlUmVmOl0p OiBTdG9yZSB0aGUgUGFnZUNsaWVudEltcGwKKyAgICAgICAgb24gb3VyIFdLVmlld0RhdGEgb2Jq ZWN0IGFuZCBwYXNzIGl0IHRvIHRoZSBXZWJQYWdlUHJveHkuCisKKyAgICAgICAgKiBVSVByb2Nl c3MvV2ViUGFnZVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5OjpzZXRQ YWdlQ2xpZW50KToKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5Lmg6CisgICAgICAg IFJlbW92ZWQgTWFjLXNwZWNpZmljIGNvZGUgdGhhdCBwdXQgdGhlIFBhZ2VDbGllbnQgaW4gYW4g T3duUHRyLiBXZSBub3cKKyAgICAgICAgc3RvcmUgaXQgaW4gYSBiYXJlIHBvaW50ZXIganVzdCBs aWtlIG9uIFdpbmRvd3MuCisKKzIwMTAtMDctMjcgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUu Y29tPgorCiAgICAgICAgIE1ha2UgcHJlZmVyZW5jZXMgQVBJcyByb2J1c3QgYWdhaW5zdCB3ZWIg cHJvY2VzcyBjcmFzaGVzCiAKICAgICAgICAgRml4ZXMgPGh0dHA6Ly93ZWJraXQub3JnL2IvNDMw NDk+IENyYXNoIGluCmRpZmYgLS1naXQgYS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmll dy5tbSBiL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCmluZGV4IDY0MmQ2N2Ux Y2VhMTdiYmZlOWVhMDZlNmNkNDljNWQ1NjJmY2NiMWYuLjY2NGYzMmRhZWFlNGE0YTI1Y2UzMjkz NzFhNGYwYjkwNDk2NzMyZWEgMTAwNjQ0Ci0tLSBhL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMv V0tWaWV3Lm1tCisrKyBiL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCkBAIC00 OSw2ICs0OSw3IEBAIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCiBAaW50ZXJmYWNlIFdLVmll d0RhdGEgOiBOU09iamVjdCB7CiBAcHVibGljCisgICAgT3duUHRyPFBhZ2VDbGllbnRJbXBsPiBf cGFnZUNsaWVudDsKICAgICBSZWZQdHI8V2ViUGFnZVByb3h5PiBfcGFnZTsKIAogICAgIC8vIEZv ciBUb29sVGlwcy4KQEAgLTg0LDggKzg1LDkgQEAgLSAoaWQpaW5pdFdpdGhGcmFtZTooTlNSZWN0 KWZyYW1lIHBhZ2VOYW1lc3BhY2VSZWY6KFdLUGFnZU5hbWVzcGFjZVJlZilwYWdlTmFtZXMKIAog ICAgIF9kYXRhID0gW1tXS1ZpZXdEYXRhIGFsbG9jXSBpbml0XTsKIAorICAgIF9kYXRhLT5fcGFn ZUNsaWVudC5zZXQobmV3IFBhZ2VDbGllbnRJbXBsKHNlbGYpKTsKICAgICBfZGF0YS0+X3BhZ2Ug PSB0b1dLKHBhZ2VOYW1lc3BhY2VSZWYpLT5jcmVhdGVXZWJQYWdlKCk7Ci0gICAgX2RhdGEtPl9w YWdlLT5zZXRQYWdlQ2xpZW50KG5ldyBQYWdlQ2xpZW50SW1wbChzZWxmKSk7CisgICAgX2RhdGEt Pl9wYWdlLT5zZXRQYWdlQ2xpZW50KF9kYXRhLT5fcGFnZUNsaWVudC5nZXQoKSk7CiAgICAgX2Rh dGEtPl9wYWdlLT5pbml0aWFsaXplV2ViUGFnZShJbnRTaXplKGZyYW1lLnNpemUpLCBuZXcgQ2h1 bmtlZFVwZGF0ZURyYXdpbmdBcmVhUHJveHkoc2VsZikpOwogICAgIF9kYXRhLT5fcGFnZS0+c2V0 SXNJbldpbmRvdyhbc2VsZiB3aW5kb3ddKTsKIApkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9VSVByb2Nl c3MvV2ViUGFnZVByb3h5LmNwcCBiL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAK aW5kZXggNWNkODFhOGYxYjFjNzM3NDE0OTQ0NWQwMzVkN2Q0NjVkZGVkYzU0ZC4uNjE5MmQ4NjNm MTZiNzAxMTliNzQ1ZDg4ZjU3ZjMyZDQ2ZTA5ZDhhNCAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9VSVBy b2Nlc3MvV2ViUGFnZVByb3h5LmNwcAorKysgYi9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJv eHkuY3BwCkBAIC05NywxMSArOTcsNyBAQCBib29sIFdlYlBhZ2VQcm94eTo6aXNWYWxpZCgpCiAK IHZvaWQgV2ViUGFnZVByb3h5OjpzZXRQYWdlQ2xpZW50KFBhZ2VDbGllbnQqIHBhZ2VDbGllbnQp CiB7Ci0jaWYgUExBVEZPUk0oV0lOKQogICAgIG1fcGFnZUNsaWVudCA9IHBhZ2VDbGllbnQ7Ci0j ZWxzZQotICAgIG1fcGFnZUNsaWVudC5zZXQocGFnZUNsaWVudCk7Ci0jZW5kaWYKIH0KIAogdm9p ZCBXZWJQYWdlUHJveHk6OnNldERyYXdpbmdBcmVhKFBhc3NPd25QdHI8RHJhd2luZ0FyZWFQcm94 eT4gZHJhd2luZ0FyZWEpCmRpZmYgLS1naXQgYS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJv eHkuaCBiL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oCmluZGV4IDU1ZjRkN2M4YjZh NDE2NDFkZDBlZjRhYWYzZTNlY2FiZmNlMTRjODEuLjY5ZDUyMjdkNDhiODEwYmZiMmEyNTY3MTZj NjNmNTcxODEwNjZlNGYgMTAwNjQ0Ci0tLSBhL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94 eS5oCisrKyBiL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oCkBAIC0yMTAsMTMgKzIx MCw3IEBAIHByaXZhdGU6CiAgICAgdm9pZCBkaWRDaGFuZ2VBY2NlbGVyYXRlZENvbXBvc2l0aW5n KGJvb2wgY29tcG9zaXRpbmcpOwogI2VuZGlmICAgIAogCi0jaWYgUExBVEZPUk0oV0lOKQogICAg IFBhZ2VDbGllbnQqIG1fcGFnZUNsaWVudDsKLSNlbHNlCi0gICAgLy8gRklYTUU6IFRoaXMgc2hv dWxkIG5vdCBiZSBhbiBPd25QdHIgdG8gdGhlIFBhZ2VDbGllbnQuICBXZSBuZWVkIHRvIGZpbmQg YSBiZXR0ZXIgd2F5IHRvIGNsZWFuIHVwIG1fcGFnZUNsaWVudCBvbiBtYWMuCi0gICAgLy8gaHR0 cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDAxODUKLSAgICBPd25QdHI8UGFn ZUNsaWVudD4gbV9wYWdlQ2xpZW50OwotI2VuZGlmCiAgICAgV2ViTG9hZGVyQ2xpZW50IG1fbG9h ZGVyQ2xpZW50OwogICAgIFdlYlBvbGljeUNsaWVudCBtX3BvbGljeUNsaWVudDsKICAgICBXZWJV SUNsaWVudCBtX3VpQ2xpZW50Owo=