40182 2010-06-04 12:20:32 -0700 [GTK] EventSender should call gtk_main_do_event instead of invoking signal handlers directly 2010-11-02 17:15:25 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 mrobinson webkit-unassigned xan.lopez oldest_to_newest 234330 0 mrobinson 2010-06-04 12:20:32 -0700 Calling gtk_main_do_event is "more correct." In particular, it will allow us to call gtk_get_current_event() in WebCore/WebKit without breaking LayoutTests. 234333 1 57905 mrobinson 2010-06-04 12:26:46 -0700 Created attachment 57905 Use gtk_main_do_event instead of invoking signal handlers directly 234336 2 57905 xan.lopez 2010-06-04 12:35:44 -0700 Comment on attachment 57905 Use gtk_main_do_event instead of invoking signal handlers directly Looks good. 234339 3 mrobinson 2010-06-04 12:41:48 -0700 Committed r60700: <http://trac.webkit.org/changeset/60700> 258335 4 mrobinson 2010-07-30 12:38:37 -0700 *** Bug 29203 has been marked as a duplicate of this bug. *** 57905 2010-06-04 12:26:46 -0700 2010-11-02 17:15:25 -0700 Use gtk_main_do_event instead of invoking signal handlers directly bug-40182-20100604122645.patch text/plain 2537 mrobinson ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBmYWZlYTE1M2ZiMjE4Zjk1MjRlYzM5OThlOGRjNDk5Mzg0MzI0NDdiLi4xY2EwNzVh MTVmZjE3YjhjYWM3ZTM2ZmYyMjUyM2Q5ZTAxMTQ2OGM3IDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAK KzIwMTAtMDYtMDQgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIEV2ZW50 U2VuZGVyIHNob3VsZCBjYWxsIGd0a19tYWluX2RvX2V2ZW50IGluc3RlYWQgb2YgaW52b2tpbmcg c2lnbmFsIGhhbmRsZXJzIGRpcmVjdGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00MDE4MgorCisgICAgICAgIEluc3RlYWQgb2YgaW52b2tpbmcgc2ln bmFsIGhhbmRsZXJzIGRpcmVjdGx5IHZpYSBnX3NpZ25hbF9lbWl0X2J5X25hbWUsIGNhbGwKKyAg ICAgICAgZ3RrX21haW5fZG9fZXZlbnQuIFRoaXMgd2lsbCBhbGxvdyB1cyB0byBjYWxsIGd0a19n ZXRfY3VycmVudF9ldmVudCgpIGluIFdlYktpdAorICAgICAgICB3aXRob3V0IGJyZWFraW5nIERS VC4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2d0ay9FdmVudFNlbmRlci5jcHA6CisgICAg ICAgIChkaXNwYXRjaEV2ZW50KTogVXNlIGd0a19tYWluX2RvX2V2ZW50IGluc3RlYWQgb2YgaW52 b2tpbmcgc2lnbmFsIGhhbmRsZXJzIGRpcmVjdGx5LgorICAgICAgICAoa2V5RG93bkNhbGxiYWNr KTogVXNlIGRpc3BhdGNoRXZlbnQgaGVyZSB3aGljaCBub3cgdXNlcyBndGtfbWFpbl9kb19ldmVu dC4KKwogMjAxMC0wNi0wNCAgWWFlbCBBaGFyb24gIDx5YWVsLmFoYXJvbkBub2tpYS5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4uCmRpZmYgLS1naXQgYS9XZWJLaXRU b29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRXZlbnRTZW5kZXIuY3BwIGIvV2ViS2l0VG9vbHMvRHVt cFJlbmRlclRyZWUvZ3RrL0V2ZW50U2VuZGVyLmNwcAppbmRleCA5ZWI0NzkxNDM5MTg2NjljYTc4 YmMzYWFhNDc2NDU0MmFiN2MwYmViLi4yZDc3YThhZGNlMmY4MzgzMTQ5OTk5OWNhMTcwYWQ4YTM0 Y2I5YTM0IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRXZlbnRT ZW5kZXIuY3BwCisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9FdmVudFNlbmRl ci5jcHAKQEAgLTM2NiwxNSArMzY2LDcgQEAgc3RhdGljIHZvaWQgZGlzcGF0Y2hFdmVudChHZGtF dmVudCBldmVudCkKICAgICBpZiAoIXZpZXcpCiAgICAgICAgIHJldHVybjsKIAotICAgIGdib29s ZWFuIHJldHVyblZhbHVlOwotICAgIGlmIChldmVudC50eXBlID09IEdES19CVVRUT05fUFJFU1Mg fHwgZXZlbnQudHlwZSA9PSBHREtfMkJVVFRPTl9QUkVTUyB8fCBldmVudC50eXBlID09IEdES18z QlVUVE9OX1BSRVNTKQotICAgICAgICBnX3NpZ25hbF9lbWl0X2J5X25hbWUodmlldywgImJ1dHRv bl9wcmVzc19ldmVudCIsICZldmVudCwgJnJldHVyblZhbHVlKTsKLSAgICBlbHNlIGlmIChldmVu dC50eXBlID09IEdES19CVVRUT05fUkVMRUFTRSkKLSAgICAgICAgZ19zaWduYWxfZW1pdF9ieV9u YW1lKHZpZXcsICJidXR0b25fcmVsZWFzZV9ldmVudCIsICZldmVudCwgJnJldHVyblZhbHVlKTsK LSAgICBlbHNlIGlmIChldmVudC50eXBlID09IEdES19NT1RJT05fTk9USUZZKQotICAgICAgICBn X3NpZ25hbF9lbWl0X2J5X25hbWUodmlldywgIm1vdGlvbl9ub3RpZnlfZXZlbnQiLCAmZXZlbnQs ICZyZXR1cm5WYWx1ZSk7Ci0gICAgZWxzZSBpZiAoZXZlbnQudHlwZSA9PSBHREtfU0NST0xMKQot ICAgICAgICBndGtfbWFpbl9kb19ldmVudCgmZXZlbnQpOworICAgIGd0a19tYWluX2RvX2V2ZW50 KCZldmVudCk7CiB9CiAKIHZvaWQgcmVwbGF5U2F2ZWRFdmVudHMoKQpAQCAtNTM0LDEzICs1MjYs MTEgQEAgc3RhdGljIEpTVmFsdWVSZWYga2V5RG93bkNhbGxiYWNrKEpTQ29udGV4dFJlZiBjb250 ZXh0LCBKU09iamVjdFJlZiBmdW5jdGlvbiwgSlMKICAgICAgICAgZ19mcmVlKGtleXMpOwogICAg IH0KIAotICAgIGdib29sZWFuIHJldHVybl92YWw7CiAgICAgZXZlbnQua2V5LnR5cGUgPSBHREtf S0VZX1BSRVNTOwotCi0gICAgZ19zaWduYWxfZW1pdF9ieV9uYW1lKHZpZXcsICJrZXktcHJlc3Mt ZXZlbnQiLCAmZXZlbnQua2V5LCAmcmV0dXJuX3ZhbCk7CisgICAgZGlzcGF0Y2hFdmVudChldmVu dCk7CiAKICAgICBldmVudC5rZXkudHlwZSA9IEdES19LRVlfUkVMRUFTRTsKLSAgICBnX3NpZ25h bF9lbWl0X2J5X25hbWUodmlldywgImtleS1yZWxlYXNlLWV2ZW50IiwgJmV2ZW50LmtleSwgJnJl dHVybl92YWwpOworICAgIGRpc3BhdGNoRXZlbnQoZXZlbnQpOwogCiAgICAgcmV0dXJuIEpTVmFs dWVNYWtlVW5kZWZpbmVkKGNvbnRleHQpOwogfQo=