40157 2010-06-03 23:07:37 -0700 Web Inspector: CSS style closing brace is not selectable. 2010-06-11 05:48:59 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 loislo webkit-unassigned bweinstein commit-queue joepeck keishi pfeldman pmuellr rik timothy yurys oldest_to_newest 234066 0 loislo 2010-06-03 23:07:37 -0700 %SUBJ% 236306 1 58363 me 2010-06-10 04:40:32 -0700 Created attachment 58363 <div>}</div> inherits -webkit-user-select: none; from the body element. I overrode it. 236309 2 58363 pfeldman 2010-06-10 05:00:32 -0700 Comment on attachment 58363 <div>}</div> inherits -webkit-user-select: none; from the body element. I overrode it. WebCore/inspector/front-end/inspector.css:3981 + .styles-selector, .close-brace { I think we should add -webkit-user-select: text to .styles-section instead. 236320 3 58368 me 2010-06-10 05:48:15 -0700 Created attachment 58368 Selectable brace Yes, it works the same. 236322 4 58368 pfeldman 2010-06-10 05:52:16 -0700 Comment on attachment 58368 Selectable brace (You should have removed it from the header now that it is set on the parent element). 236329 5 58371 me 2010-06-10 06:18:24 -0700 Created attachment 58371 Selectable brace 236330 6 58371 pfeldman 2010-06-10 06:20:00 -0700 Comment on attachment 58371 Selectable brace Thanks! 236542 7 58371 commit-queue 2010-06-10 14:40:27 -0700 Comment on attachment 58371 Selectable brace Rejecting patch 58371 from commit-queue. Unexpected failure when processing patch! Please file a bug against webkit-patch. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--build', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 58371, '--test', '--parent-command=commit-queue', '--no-update']" exit_code: 1 Logging in as eseidel@chromium.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=58371&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=40157&ctype=xml Processing 1 patch from 1 bug. Cleaning working directory Processing patch 58371 from bug 40157. ERROR: /Users/eseidel/Projects/CommitQueue/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). 236715 8 joepeck 2010-06-11 00:16:53 -0700 Nice! Looks like the cq didn't land because its missing the line to fill in for the reviewer. Using `prepare-ChangeLog` will put in the right template and prevent this error. This is missing the "Reviewed by (OOPS)" line or whatever. I can manually add that line in and land this patch tomorrow. Or someone can beat me to it! 236798 9 pfeldman 2010-06-11 05:48:59 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/inspector.css Committed r61009 58363 2010-06-10 04:40:32 -0700 2010-06-10 05:48:15 -0700 <div>}</div> inherits -webkit-user-select: none; from the body element. I overrode it. selectable_close_brace.patch text/plain 1554 me ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NWUyMjMwYy4uODJlZGYyMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNi0xMCAgTmlraXRhIFZhc2ls eWV2ICA8bWVAZWx2MXMucnU+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogTWFrZSBhIGNsb3Nl IGJyYWNlIGluIFN0eWxlcyBwYW5lIHNlbGVjdGFibGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDE1NworCisgICAgICAgICogaW5zcGVjdG9yL2Zy b250LWVuZC9TdHlsZXNTaWRlYmFyUGFuZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TdHls ZVByb3BlcnRpZXNTZWN0aW9uKToKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL2luc3Bl Y3Rvci5jc3M6CisgICAgICAgICguc3R5bGVzLXNlbGVjdG9yLCAuY2xvc2UtYnJhY2UpOgorCiAy MDEwLTA2LTA5ICBNT1JJVEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IEtlbnQgVGFtdXJhLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL1N0eWxlc1NpZGViYXJQYW5lLmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL1N0eWxlc1NpZGViYXJQYW5lLmpzCmluZGV4IDAxMTYyM2YuLjBjMWI0OTEgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TdHlsZXNTaWRlYmFyUGFuZS5qcworKysg Yi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU3R5bGVzU2lkZWJhclBhbmUuanMKQEAgLTYx OSw2ICs2MTksNyBAQCBXZWJJbnNwZWN0b3IuU3R5bGVQcm9wZXJ0aWVzU2VjdGlvbiA9IGZ1bmN0 aW9uKHN0eWxlUnVsZSwgc3VidGl0bGUsIGNvbXB1dGVkU3R5bAogCiAgICAgICAgIHZhciBjbG9z ZUJyYWNlID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7CiAgICAgICAgIGNsb3NlQnJh Y2UudGV4dENvbnRlbnQgPSAifSI7CisgICAgICAgIGNsb3NlQnJhY2UuY2xhc3NOYW1lID0gImNs b3NlLWJyYWNlIjsKICAgICAgICAgdGhpcy5lbGVtZW50LmFwcGVuZENoaWxkKGNsb3NlQnJhY2Up OwogICAgIH0KIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3Bl Y3Rvci5jc3MgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmNzcwppbmRl eCA2MzVmNmI3Li5jMTk1MzZlIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvaW5zcGVjdG9yLmNzcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVj dG9yLmNzcwpAQCAtMzk3OCw3ICszOTc4LDcgQEAgb2wuYnJlYWtwb2ludC1saXN0IHsKICAgICBm b250LXNpemU6IDExcHg7CiB9CiAKLS5zdHlsZXMtc2VsZWN0b3IgeworLnN0eWxlcy1zZWxlY3Rv ciwgLmNsb3NlLWJyYWNlIHsKICAgICBjdXJzb3I6IHRleHQ7CiAgICAgLXdlYmtpdC11c2VyLXNl bGVjdDogdGV4dDsKIH0K 58368 2010-06-10 05:48:15 -0700 2010-06-10 06:20:16 -0700 Selectable brace selectable_close_brace.patch text/plain 932 me ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Yzk0ZmVlOS4uNDFjZTk0YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMSBAQAorMjAxMC0wNi0xMCAgTmlraXRhIFZhc2ls eWV2ICA8bWVAZWx2MXMucnU+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogTWFrZSBhIGNsb3Nl IGJyYWNlIGluIFN0eWxlcyBwYW5lIHNlbGVjdGFibGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDE1NworCisgICAgICAgICogaW5zcGVjdG9yL2Zy b250LWVuZC9pbnNwZWN0b3IuY3NzOgorICAgICAgICAoLnN0eWxlcy1zZWN0aW9uKToKKwogMjAx MC0wNi0wOSAgQW5kcmVpIFBvcGVzY3UgIDxhbmRyZWlwQGdvb2dsZS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9pbnNwZWN0b3IuY3NzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3Bl Y3Rvci5jc3MKaW5kZXggNjM1ZjZiNy4uYTliYTQ0NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5jc3MKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL2luc3BlY3Rvci5jc3MKQEAgLTQwMDgsNiArNDAwOCw3IEBAIGEud29ya2VyLWl0ZW0g ewogICAgIHdoaXRlLXNwYWNlOiBub3dyYXA7CiAgICAgLXdlYmtpdC1iYWNrZ3JvdW5kLW9yaWdp bjogcGFkZGluZzsKICAgICAtd2Via2l0LWJhY2tncm91bmQtY2xpcDogcGFkZGluZzsKKyAgICAt d2Via2l0LXVzZXItc2VsZWN0OiB0ZXh0OwogfQogCiAuc3R5bGVzLXNlY3Rpb246bm90KC5maXJz dC1zdHlsZXMtc2VjdGlvbikgewo= 58371 2010-06-10 06:18:24 -0700 2010-06-11 05:30:30 -0700 Selectable brace selectable_close_brace.patch text/plain 1315 me ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Yzk0ZmVlOS4uNmU3NTU3MiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNi0xMCAgTmlraXRhIFZhc2ls eWV2ICA8bWVAZWx2MXMucnU+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogTWFrZSBhIGNsb3Nl IGJyYWNlIGluIFN0eWxlcyBwYW5lIHNlbGVjdGFibGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDE1NworCisgICAgICAgICogaW5zcGVjdG9yL2Zy b250LWVuZC9pbnNwZWN0b3IuY3NzOgorICAgICAgICAoLnN0eWxlcy1zZWxlY3Rvcik6CisgICAg ICAgICguc3R5bGVzLXNlY3Rpb24gLnByb3BlcnRpZXMgbGkpOgorICAgICAgICAoLnN0eWxlcy1z ZWN0aW9uKToKKwogMjAxMC0wNi0wOSAgQW5kcmVpIFBvcGVzY3UgIDxhbmRyZWlwQGdvb2dsZS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuY3NzIGIvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL2luc3BlY3Rvci5jc3MKaW5kZXggNjM1ZjZiNy4uNTJiODViYyAxMDA2NDQKLS0t IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5jc3MKKysrIGIvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5jc3MKQEAgLTM5ODAsNyArMzk4MCw2IEBA IG9sLmJyZWFrcG9pbnQtbGlzdCB7CiAKIC5zdHlsZXMtc2VsZWN0b3IgewogICAgIGN1cnNvcjog dGV4dDsKLSAgICAtd2Via2l0LXVzZXItc2VsZWN0OiB0ZXh0OwogfQogCiAud29ya2Vycy1saXN0 IHsKQEAgLTQwMDgsNiArNDAwNyw3IEBAIGEud29ya2VyLWl0ZW0gewogICAgIHdoaXRlLXNwYWNl OiBub3dyYXA7CiAgICAgLXdlYmtpdC1iYWNrZ3JvdW5kLW9yaWdpbjogcGFkZGluZzsKICAgICAt d2Via2l0LWJhY2tncm91bmQtY2xpcDogcGFkZGluZzsKKyAgICAtd2Via2l0LXVzZXItc2VsZWN0 OiB0ZXh0OwogfQogCiAuc3R5bGVzLXNlY3Rpb246bm90KC5maXJzdC1zdHlsZXMtc2VjdGlvbikg ewpAQCAtNDA2Miw3ICs0MDYyLDYgQEAgYS53b3JrZXItaXRlbSB7CiAgICAgd2hpdGUtc3BhY2U6 IG5vd3JhcDsKICAgICB0ZXh0LW92ZXJmbG93OiBlbGxpcHNpczsKICAgICBvdmVyZmxvdzogaGlk ZGVuOwotICAgIC13ZWJraXQtdXNlci1zZWxlY3Q6IHRleHQ7CiAgICAgY3Vyc29yOiBhdXRvOwog fQogCg==