40146 2010-06-03 15:39:39 -0700 Geolocation needs more LayoutTests to test making callbacks to remote frames 2010-06-04 03:46:40 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 steveblock webkit-unassigned abarth ap eric jorlow steveblock webkit.review.bot oldest_to_newest 233957 0 steveblock 2010-06-03 15:39:39 -0700 Bug 40129 added a layout test to test making a callback from a Geolocation object to a remote frame. In this case, the JavaScript call chain was initiated from the frame owning the Geolocation object. We should add a similar test where the call chain is initiated from the remote frame. See https://bugs.webkit.org/show_bug.cgi?id=40129#c8 234132 1 57858 steveblock 2010-06-04 02:43:54 -0700 Created attachment 57858 Patch 234133 2 57858 jorlow 2010-06-04 02:52:26 -0700 Comment on attachment 57858 Patch r=me If you'd like, feel free to make a patch with more than one test. 234134 3 steveblock 2010-06-04 02:57:52 -0700 Committed r60669: <http://trac.webkit.org/changeset/60669> 234141 4 webkit.review.bot 2010-06-04 03:22:38 -0700 http://trac.webkit.org/changeset/60669 might have broken GTK Linux 32-bit Release The following changes are on the blame list: http://trac.webkit.org/changeset/60669 http://trac.webkit.org/changeset/60670 234151 5 57858 steveblock 2010-06-04 03:46:40 -0700 Comment on attachment 57858 Patch Added callback-to-remote-context2.html to the GTK skipped list in r60672, http://trac.webkit.org/changeset/60672 and updated Bug 40153 57858 2010-06-04 02:43:54 -0700 2010-06-04 03:46:39 -0700 Patch bug-40146-20100604104352.patch text/plain 3723 steveblock SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDYwNjY3KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMDYtMDQgIFN0ZXZlIEJsb2NrICA8c3Rl dmVibG9ja0Bnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEdlb2xvY2F0aW9uIG5lZWRzIG1vcmUgTGF5b3V0VGVzdHMgdG8gdGVzdCBt YWtpbmcgY2FsbGJhY2tzIHRvIHJlbW90ZSBmcmFtZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwMTQ2CisKKyAgICAgICAgVGhpcyB0ZXN0IGlzIHNp bWlsYXIgdG8gY2FsbGJhY2stdG8tcmVtb3RlLWNvbnRleHQuaHRtbCBpbiB0aGF0IGl0IHRlc3Qg bWFraW5nIGEgY2FsbGJhY2sKKyAgICAgICAgZnJvbSBhIEdlb2xvY2F0aW9uIG9iamVjdCB0byBh IHJlbW90ZSBmcmFtZS4gSW4gY2FsbGJhY2stdG8tcmVtb3RlLWNvbnRleHQuaHRtbCwgdGhlIGNh bGwKKyAgICAgICAgY2hhaW4gdG8gdGhlIEdlb2xvY2F0aW9uIG1ldGhvZCBpcyBzdGFydGVkIGZy b20gdGhlIG93bmluZyBmcmFtZS4gSW4gdGhpcyB0ZXN0LCBob3dldmVyLAorICAgICAgICB0aGUg Y2FsbCBjaGFpbiBpcyBzdGFydGVkIGZyb20gdGhlIHJlbW90ZSBmcmFtZS4KKworICAgICAgICAq IGZhc3QvZG9tL0dlb2xvY2F0aW9uL2NhbGxiYWNrLXRvLXJlbW90ZS1jb250ZXh0Mi1leHBlY3Rl ZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZG9tL0dlb2xvY2F0aW9uL2NhbGxiYWNrLXRv LXJlbW90ZS1jb250ZXh0Mi5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2RvbS9HZW9sb2Nh dGlvbi9zY3JpcHQtdGVzdHMvY2FsbGJhY2stdG8tcmVtb3RlLWNvbnRleHQyLmpzOiBBZGRlZC4K KwogMjAxMC0wNi0wNCAgU3RldmUgQmxvY2sgIDxzdGV2ZWJsb2NrQGdvb2dsZS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgSmVyZW15IE9ybG93LgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9k b20vR2VvbG9jYXRpb24vY2FsbGJhY2stdG8tcmVtb3RlLWNvbnRleHQyLWV4cGVjdGVkLnR4dAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9HZW9sb2NhdGlvbi9jYWxsYmFjay10 by1yZW1vdGUtY29udGV4dDItZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVz dHMvZmFzdC9kb20vR2VvbG9jYXRpb24vY2FsbGJhY2stdG8tcmVtb3RlLWNvbnRleHQyLWV4cGVj dGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMCBAQAorVGVzdHMgdGhhdCB3aGVuIGEg R2VvbG9jYXRpb24gcmVxdWVzdCBpcyBtYWRlIGZyb20gYSByZW1vdGUgZnJhbWUsIGFuZCB0aGUg SmF2YVNjcmlwdCBjYWxsIGNoYWluIHN0YXJ0cyBmcm9tIHRoYXQgcmVtb3RlIGZyYW1lLCBjYWxs YmFja3MgYXJlIG1hZGUgYXMgdXN1YWwuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNl cmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKwor CitQQVNTIFN1Y2Nlc3MgY2FsbGJhY2sgaW52b2tlZAorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQg aXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL0dl b2xvY2F0aW9uL2NhbGxiYWNrLXRvLXJlbW90ZS1jb250ZXh0Mi5odG1sCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL2Zhc3QvZG9tL0dlb2xvY2F0aW9uL2NhbGxiYWNrLXRvLXJlbW90ZS1jb250 ZXh0Mi5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vR2VvbG9jYXRp b24vY2FsbGJhY2stdG8tcmVtb3RlLWNvbnRleHQyLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAg KzEsMTMgQEAKKzwhRE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwvL0VOIj4K KzxodG1sPgorPGhlYWQ+Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4uLy4uL2pzL3Jl c291cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+Cis8c2NyaXB0IHNyYz0iLi4vLi4vanMvcmVzb3Vy Y2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHAgaWQ9ImRl c2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQgc3JjPSJz Y3JpcHQtdGVzdHMvY2FsbGJhY2stdG8tcmVtb3RlLWNvbnRleHQyLmpzIj48L3NjcmlwdD4KKzxz Y3JpcHQgc3JjPSIuLi8uLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4K KzwvYm9keT4KKzwvaHRtbD4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL0dlb2xvY2F0aW9u L3NjcmlwdC10ZXN0cy9jYWxsYmFjay10by1yZW1vdGUtY29udGV4dDIuanMKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vR2VvbG9jYXRpb24vc2NyaXB0LXRlc3RzL2NhbGxiYWNr LXRvLXJlbW90ZS1jb250ZXh0Mi5qcwkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3Qv ZG9tL0dlb2xvY2F0aW9uL3NjcmlwdC10ZXN0cy9jYWxsYmFjay10by1yZW1vdGUtY29udGV4dDIu anMJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMjEgQEAKK2Rlc2NyaXB0aW9uKCJUZXN0cyB0aGF0 IHdoZW4gYSBHZW9sb2NhdGlvbiByZXF1ZXN0IGlzIG1hZGUgZnJvbSBhIHJlbW90ZSBmcmFtZSwg YW5kIHRoZSBKYXZhU2NyaXB0IGNhbGwgY2hhaW4gc3RhcnRzIGZyb20gdGhhdCByZW1vdGUgZnJh bWUsIGNhbGxiYWNrcyBhcmUgbWFkZSBhcyB1c3VhbC4iKTsKKworZnVuY3Rpb24gb25JZnJhbWVS ZWFkeSgpIHsKKyAgICAvLyBNYWtlIHJlcXVlc3QgZnJvbSByZW1vdGUgZnJhbWUsIHdpdGggY2Fs bCBjaGFpbiBzdGFydGluZyBoZXJlCisgICAgd2luZG93LnNldFRpbWVvdXQoZnVuY3Rpb24oKSB7 CisgICAgICAgIGlmcmFtZS5jb250ZW50V2luZG93Lm5hdmlnYXRvci5nZW9sb2NhdGlvbi5nZXRD dXJyZW50UG9zaXRpb24oZnVuY3Rpb24oKSB7CisgICAgICAgICAgICB0ZXN0UGFzc2VkKCdTdWNj ZXNzIGNhbGxiYWNrIGludm9rZWQnKTsKKyAgICAgICAgICAgIGZpbmlzaEpTVGVzdCgpOworICAg ICAgICB9LCBmdW5jdGlvbigpIHsKKyAgICAgICAgICAgIHRlc3RGYWlsZWQoJ0Vycm9yIGNhbGxi YWNrIGludm9rZWQgdW5leHBlY3RlZGx5Jyk7CisgICAgICAgICAgICBmaW5pc2hKU1Rlc3QoKTsK KyAgICAgICAgfSk7CisgICAgfSwgMCk7Cit9CisKK3ZhciBpZnJhbWUgPSBkb2N1bWVudC5jcmVh dGVFbGVtZW50KCdpZnJhbWUnKTsKK2lmcmFtZS5zcmMgPSAncmVzb3VyY2VzL2NhbGxiYWNrLXRv LXJlbW90ZS1jb250ZXh0LWlubmVyLmh0bWwnOworZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZChp ZnJhbWUpOworCit3aW5kb3cuanNUZXN0SXNBc3luYyA9IHRydWU7Cit3aW5kb3cuc3VjY2Vzc2Z1 bGx5UGFyc2VkID0gdHJ1ZTsK