40136 2010-06-03 13:46:56 -0700 webkit-patch upload doesn't show diff on cygwin 2012-02-10 20:00:12 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 78408 1 tonyg tonyg abarth commit-queue eric levin oldest_to_newest 233905 0 tonyg 2010-06-03 13:46:56 -0700 webkit-patch upload doesn't show diff on cygwin 233910 1 57808 tonyg 2010-06-03 13:53:21 -0700 Created attachment 57808 Patch 233914 2 levin 2010-06-03 13:56:11 -0700 Hmmm... no test. :( (Don't know how possible it is or not.) 233916 3 tonyg 2010-06-03 14:02:37 -0700 (In reply to comment #2) > Hmmm... no test. :( (Don't know how possible it is or not.) Manually, I tested this on osx to verify that the pretty diff is still displayed and cygwin to verify that the plain old diff is displayed. However, test-webkitpy hangs for me on cygwin so I haven't verified the full suite passes. If you think a test is important, I can update the mock to control the return value of can_open_url() and add a test that exercises the new branch in confirmdiff. But I can't really test can_open_url() itself. By the way, I'm starting to suspect that no one else is developing webkit on windows+cygwin. Should I just leave it be and switch to mac? 233927 4 tonyg 2010-06-03 14:21:44 -0700 By the way, the pretty diff file is successfully created in C:\cygwin\tmp. An alternative approach to adding can_open_url() would be to modify open_url() to test webbrowser.get() internally and on exception just output the file:///{{CYGWIN_PATH}}/tmp/{{TEMP_FILE}} URL to the console so the user can manually open it. 234021 5 57808 abarth 2010-06-03 18:23:03 -0700 Comment on attachment 57808 Patch Looks reasonable. Generally, we don't have a good strategy for testing things in user.py. In fact, that file exists to abstract away things that we don't know how to test. 234111 6 57808 commit-queue 2010-06-04 01:56:02 -0700 Comment on attachment 57808 Patch Clearing flags on attachment: 57808 Committed r60666: <http://trac.webkit.org/changeset/60666> 234112 7 commit-queue 2010-06-04 01:56:13 -0700 All reviewed patches have been landed. Closing bug. 57808 2010-06-03 13:53:21 -0700 2010-06-04 01:56:02 -0700 Patch bug-40136-20100603135320.patch text/plain 2977 tonyg ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBkMjJiYzg5ZTQxOTcyMGRjMWM4ZGZlMmY3MmM5ZTA1NDZkZDU1M2I1Li45ZDVmYzYx YjA1N2JjMTNjYjI3ZjNmMjUyZDZiMjBkYzE0YWZjMTQxIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAK KzIwMTAtMDYtMDMgIFRvbnkgR2VudGlsY29yZSAgPHRvbnlnQGNocm9taXVtLm9yZz4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEZXRlY3Qgd2hldGhl ciB0aGUgdXNlcidzIGVudmlyb25tZW50IGNhbiBvcGVuIGEgYnJvd3Nlci4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwMTM2CisKKyAgICAgICAgU29t ZSBlbnZpcm9ubWVudHMgbGlrZSBjeWd3aW4gc2lsZW50bHkgZmFpbCB3ZWJicm93c2VyLm9wZW4o KSBjYXVzaW5nCisgICAgICAgIHdlYmtpdC1wYXRjaCB1cGxvYWQgbm90IHRvIGRpc3BsYXkgYW55 IGRpZmYuIFRoaXMgZGV0ZWN0cyBlbnZpcm9ubWVudHMKKyAgICAgICAgd2hlcmUgd2ViYnJvd3Nl ci5vcGVuKCkgd291bGQgZmFpbCBieSB0ZXN0aW5nIGlmIHdlYmJyb3dzZXIuZ2V0KCkKKyAgICAg ICAgcmFpc2VzIGFuIGV4Y2VwdGlvbi4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29t bW9uL3N5c3RlbS91c2VyLnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9tb2Nr dG9vbC5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvY29uZmlybWRp ZmYucHk6CisKIDIwMTAtMDYtMDMgIE1pa2UgRmVudG9uICA8bWlmZW50b25AcmltLmNvbT4KIAog ICAgICAgICBVbnJldmlld2VkLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJr aXRweS9jb21tb24vc3lzdGVtL3VzZXIucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5 L2NvbW1vbi9zeXN0ZW0vdXNlci5weQppbmRleCA4MmZhMGQzYjAzZGMzOGFkNGZhNjQ5NmMzYTRh Zjk4ZjRkMzVlM2Q0Li5iNGRmM2NiNDcwOTAyNjMxY2RkYjhhZTYwYzRjZTg3ZWEzNzQ4Yzk3IDEw MDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vdXNl ci5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vdXNl ci5weQpAQCAtMTA0LDUgKzEwNCwxNCBAQCBjbGFzcyBVc2VyKG9iamVjdCk6CiAgICAgICAgIHJl c3BvbnNlID0gcmF3X2lucHV0KCIlcyBbWS9uXTogIiAlIG1lc3NhZ2UpCiAgICAgICAgIHJldHVy biBub3QgcmVzcG9uc2Ugb3IgcmVzcG9uc2UubG93ZXIoKSA9PSAieSIKIAorICAgIGRlZiBjYW5f b3Blbl91cmwoc2VsZik6CisgICAgICAgIHRyeToKKyAgICAgICAgICAgIHdlYmJyb3dzZXIuZ2V0 KCkKKyAgICAgICAgICAgIHJldHVybiBUcnVlCisgICAgICAgIGV4Y2VwdCB3ZWJicm93c2VyLkVy cm9yLCBlOgorICAgICAgICAgICAgcmV0dXJuIEZhbHNlCisKICAgICBkZWYgb3Blbl91cmwoc2Vs ZiwgdXJsKToKKyAgICAgICAgaWYgbm90IHNlbGYuY2FuX29wZW5fdXJsKCk6CisgICAgICAgICAg ICBfbG9nLndhcm4oIkZhaWxlZCB0byBvcGVuICVzIiAlIHVybCkKICAgICAgICAgd2ViYnJvd3Nl ci5vcGVuKHVybCkKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9v bC9tb2NrdG9vbC5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9tb2NrdG9v bC5weQppbmRleCAzOTM0ZWEzMWIzN2JhYjg5ZTg4OWQ0NGYzM2Q3NDlhOGU4OTkwYTg4Li5hZTU0 MTU5YmZmNGI5OTFjNjg4Zjc4YjI0YmZiYzY1Yzc3ZmQ0NzQzIDEwMDY0NAotLS0gYS9XZWJLaXRU b29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvbW9ja3Rvb2wucHkKKysrIGIvV2ViS2l0VG9vbHMv U2NyaXB0cy93ZWJraXRweS90b29sL21vY2t0b29sLnB5CkBAIC00NTMsNiArNDUzLDkgQEAgY2xh c3MgTW9ja1VzZXIob2JqZWN0KToKICAgICBkZWYgY29uZmlybShzZWxmLCBtZXNzYWdlPU5vbmUp OgogICAgICAgICByZXR1cm4gVHJ1ZQogCisgICAgZGVmIGNhbl9vcGVuX3VybChzZWxmKToKKyAg ICAgICAgcmV0dXJuIFRydWUKKwogICAgIGRlZiBvcGVuX3VybChzZWxmLCB1cmwpOgogICAgICAg ICBpZiB1cmwuc3RhcnRzd2l0aCgiZmlsZTovLyIpOgogICAgICAgICAgICAgbG9nKCJNT0NLOiB1 c2VyLm9wZW5fdXJsOiBmaWxlOi8vLi4uIikKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvdG9vbC9zdGVwcy9jb25maXJtZGlmZi5weSBiL1dlYktpdFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvdG9vbC9zdGVwcy9jb25maXJtZGlmZi5weQppbmRleCA2MjZmY2YzYTg3MmNi OWE2MzljODY4MjUxNDczMzY3OWNjYjgzMDgzLi43ZThlMzQ4OTgxNGIzZmU5YTQxYjYzZmQ2NTg2 ZmRhZDAzNjBkODVkIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rv b2wvc3RlcHMvY29uZmlybWRpZmYucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRw eS90b29sL3N0ZXBzL2NvbmZpcm1kaWZmLnB5CkBAIC00Niw2ICs0Niw5IEBAIGNsYXNzIENvbmZp cm1EaWZmKEFic3RyYWN0U3RlcCk6CiAgICAgICAgIF0KIAogICAgIGRlZiBfc2hvd19wcmV0dHlf ZGlmZihzZWxmLCBkaWZmKToKKyAgICAgICAgaWYgbm90IHNlbGYuX3Rvb2wudXNlci5jYW5fb3Bl bl91cmwoKToKKyAgICAgICAgICAgIHJldHVybiBOb25lCisKICAgICAgICAgdHJ5OgogICAgICAg ICAgICAgcHJldHR5X3BhdGNoID0gUHJldHR5UGF0Y2goc2VsZi5fdG9vbC5leGVjdXRpdmUsCiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzZWxmLl90b29sLnNjbSgpLmNo ZWNrb3V0X3Jvb3QpCg==