4013 2005-07-15 12:52:15 -0700 text find doesn't wrap in PDF files 2005-07-15 16:13:44 -0700 1 1 1 Unclassified WebKit New Bugs 412 Mac OS X 10.4 RESOLVED FIXED http://www.copyright.gov/legislation/dmca.pdf P2 Normal --- 1 trey sullivan oldest_to_newest 14695 0 trey 2005-07-15 12:52:15 -0700 Load any PDF filein Safari. Search for a string that appears more than once. Keep searching until you hit the end of the doc. The search will not wrap around. If you do the same thing in an HTML doc, it does wrap. 14704 1 2976 trey 2005-07-15 14:18:55 -0700 Created attachment 2976 proposed patch Note most of these new methods are not called in practice, but for testing I at least invoked them in gdb. 14705 2 2976 sullivan 2005-07-15 14:31:04 -0700 Comment on attachment 2976 proposed patch Rather than retain, I'd suggest using -copy on savedSelection, because the lifetime of a PDFSelection seems somewhat murky (calling [PDFSubview currentSelection] twice in a row returns the same object each time, surprisingly). Otherwise, this seems good. Please explain how you tested it. 14706 3 2976 sullivan 2005-07-15 14:43:26 -0700 Comment on attachment 2976 proposed patch One more comment. If setCurrentSelection:nil works as expected (synonym for clearing the selection), then I'd rewrite: if (savedSelection) { [PDFSubview setCurrentSelection:savedSelection]; [savedSelection release]; } else { [PDFSubview clearSelection]; } as just + [PDFSubview setCurrentSelection:savedSelection]; + [savedSelection release]; 14708 4 2978 trey 2005-07-15 16:00:35 -0700 Created attachment 2978 proposed patch with consensus changes 14709 5 2978 sullivan 2005-07-15 16:09:08 -0700 Comment on attachment 2978 proposed patch with consensus changes Great, nice fix. 14710 6 sullivan 2005-07-15 16:13:44 -0700 Checked in. 2976 2005-07-15 14:18:55 -0700 2005-07-15 16:00:35 -0700 proposed patch 4013.patch text/plain 3415 trey SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViS2l0L0No YW5nZUxvZyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4zMjI5CmRpZmYgLXAgLXUgLXIxLjMyMjkg Q2hhbmdlTG9nCi0tLSBDaGFuZ2VMb2cJMjAwNS8wNy8xNSAyMDozNToyNAkxLjMyMjkKKysrIENo YW5nZUxvZwkyMDA1LzA3LzE1IDIxOjE2OjU1CkBAIC0xLDMgKzEsMjMgQEAKKzIwMDUtMDctMTUg IFRyZXkgTWF0dGVzb24gIDx0cmV5QHVzYS5uZXQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgSm9o biBTdWxsaXZhbi4KKworICAgICAgICBGaXggZm9yIGh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2lu Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDAxMworICAgICAgICAgICAgICAgIHRleHQgZmluZCBkb2Vz bid0IHdyYXAgaW4gUERGIGZpbGVzCisKKyAgICAgICAgVGhpcyBqdXN0IHdvcmtzIG9uY2UgV2Vi UERGVmlldyBpbXBsZW1lbnRzIHRoZSBXZWJEb2N1bWVudFRleHQgcHJvdG9jb2wsIHdoaWNoIGlz CisgICAgICAgIGp1c3QgYSBtYXR0ZXIgb2YgZm9yd2FyZGluZyB0aGUgbWV0aG9kcyB0byBQREZL aXQuCisKKyAgICAgICAgKiBXZWJWaWV3LnN1YnByb2ovV2ViUERGVmlldy5oOgorICAgICAgICAq IFdlYlZpZXcuc3VicHJvai9XZWJQREZWaWV3Lm06CisgICAgICAgICgtW1dlYlBERlZpZXcgc3Vw cG9ydHNUZXh0RW5jb2RpbmddKToKKyAgICAgICAgKC1bV2ViUERGVmlldyBzdHJpbmddKToKKyAg ICAgICAgKC1bV2ViUERGVmlldyBhdHRyaWJ1dGVkU3RyaW5nXSk6CisgICAgICAgICgtW1dlYlBE RlZpZXcgc2VsZWN0ZWRTdHJpbmddKToKKyAgICAgICAgKC1bV2ViUERGVmlldyBzZWxlY3RlZEF0 dHJpYnV0ZWRTdHJpbmddKToKKyAgICAgICAgKC1bV2ViUERGVmlldyBzZWxlY3RBbGxdKToKKyAg ICAgICAgKC1bV2ViUERGVmlldyBkZXNlbGVjdEFsbF0pOgorCiAyMDA1LTA3LTE1ICBKb2huIFN1 bGxpdmFuICA8c3VsbGl2YW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hY2ll aiBTdGFjaG93aWFrLgpJbmRleDogLi9XZWJWaWV3LnN1YnByb2ovV2ViUERGVmlldy5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJLaXQvV2ViVmlldy5zdWJwcm9qL1dlYlBERlZp ZXcuaCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS43CmRpZmYgLXAgLXUgLXIxLjcgLi9XZWJWaWV3 LnN1YnByb2ovV2ViUERGVmlldy5oCi0tLSAuL1dlYlZpZXcuc3VicHJvai9XZWJQREZWaWV3LmgJ MjAwNS8wNi8xNCAxODowNjowMAkxLjcKKysrIC4vV2ViVmlldy5zdWJwcm9qL1dlYlBERlZpZXcu aAkyMDA1LzA3LzE1IDIxOjE3OjA4CkBAIC0zMyw3ICszMyw3IEBACiAKIEBwcm90b2NvbCBfd2Vi X1dlYkRvY3VtZW50VGV4dFNpemluZzsKIAotQGludGVyZmFjZSBXZWJQREZWaWV3IDogTlNWaWV3 IDxXZWJEb2N1bWVudFZpZXcsIFdlYkRvY3VtZW50U2VhcmNoaW5nLCBfd2ViX1dlYkRvY3VtZW50 VGV4dFNpemluZz4KK0BpbnRlcmZhY2UgV2ViUERGVmlldyA6IE5TVmlldyA8V2ViRG9jdW1lbnRW aWV3LCBXZWJEb2N1bWVudFNlYXJjaGluZywgV2ViRG9jdW1lbnRUZXh0LCBfd2ViX1dlYkRvY3Vt ZW50VGV4dFNpemluZz4KIHsKICAgICBQREZWaWV3ICpQREZTdWJ2aWV3OwogICAgIFdlYkRhdGFT b3VyY2UgKmRhdGFTb3VyY2U7CkluZGV4OiAuL1dlYlZpZXcuc3VicHJvai9XZWJQREZWaWV3Lm0K PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L1dlYktpdC9XZWJWaWV3LnN1YnByb2ovV2Vi UERGVmlldy5tLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjE4CmRpZmYgLXAgLXUgLXIxLjE4IC4v V2ViVmlldy5zdWJwcm9qL1dlYlBERlZpZXcubQotLS0gLi9XZWJWaWV3LnN1YnByb2ovV2ViUERG Vmlldy5tCTIwMDUvMDcvMTQgMjM6NTE6NDQJMS4xOAorKysgLi9XZWJWaWV3LnN1YnByb2ovV2Vi UERGVmlldy5tCTIwMDUvMDcvMTUgMjE6MTc6MDkKQEAgLTQ1Miw2ICs0NTIsNTUgQEAgc3RhdGlj IHZvaWQgYXBwbGljYXRpb25JbmZvRm9yTUlNRVR5cGUoTgogICAgIH0KIH0KIAorLyoqKiBXZWJE b2N1bWVudFRleHQgcHJvdG9jb2wgaW1wbGVtZW50YXRpb24gKioqLworCistIChCT09MKXN1cHBv cnRzVGV4dEVuY29kaW5nCit7CisgICAgcmV0dXJuIE5POworfQorCistIChOU1N0cmluZyAqKXN0 cmluZworeworICAgIHJldHVybiBbW1BERlN1YnZpZXcgZG9jdW1lbnRdIHN0cmluZ107Cit9CisK Ky0gKE5TQXR0cmlidXRlZFN0cmluZyAqKWF0dHJpYnV0ZWRTdHJpbmcKK3sKKyAgICAvLyBjaGFu Z2luZyB0aGUgc2VsZWN0aW9uIGlzIGEgaGFjaywgYnV0IHRoZSBvbmx5IHdheSB0byBnZXQgYW4g YXR0ciBzdHJpbmcgaXMgdmlhIFBERlNlbGVjdGlvbgorICAgIAorICAgIC8vIG11c3QgcmV0YWlu IHRoaXMgc2VsZWN0aW9uIG9iamVjdCBiZWNhdXNlIHdlIGNoYW5nZSB0aGUgc2VsZWN0aW9uIHdo aWNoIHNlZW1zIHRvIHJlbGVhc2UgaXQKKyAgICBQREZTZWxlY3Rpb24gKnNhdmVkU2VsZWN0aW9u ID0gW1tQREZTdWJ2aWV3IGN1cnJlbnRTZWxlY3Rpb25dIHJldGFpbl07CisgICAgW1BERlN1YnZp ZXcgc2VsZWN0QWxsOm5pbF07CisgICAgTlNBdHRyaWJ1dGVkU3RyaW5nICpyZXN1bHQgPSBbW1BE RlN1YnZpZXcgY3VycmVudFNlbGVjdGlvbl0gYXR0cmlidXRlZFN0cmluZ107CisgICAgaWYgKHNh dmVkU2VsZWN0aW9uKSB7CisgICAgICAgIFtQREZTdWJ2aWV3IHNldEN1cnJlbnRTZWxlY3Rpb246 c2F2ZWRTZWxlY3Rpb25dOworICAgICAgICBbc2F2ZWRTZWxlY3Rpb24gcmVsZWFzZV07CisgICAg fSBlbHNlIHsKKyAgICAgICAgW1BERlN1YnZpZXcgY2xlYXJTZWxlY3Rpb25dOworICAgIH0KKyAg ICByZXR1cm4gcmVzdWx0OworfQorCistIChOU1N0cmluZyAqKXNlbGVjdGVkU3RyaW5nCit7Cisg ICAgcmV0dXJuIFtbUERGU3VidmlldyBjdXJyZW50U2VsZWN0aW9uXSBzdHJpbmddOworfQorCist IChOU0F0dHJpYnV0ZWRTdHJpbmcgKilzZWxlY3RlZEF0dHJpYnV0ZWRTdHJpbmcKK3sKKyAgICBy ZXR1cm4gW1tQREZTdWJ2aWV3IGN1cnJlbnRTZWxlY3Rpb25dIGF0dHJpYnV0ZWRTdHJpbmddOwor fQorCistICh2b2lkKXNlbGVjdEFsbAoreworICAgIFtQREZTdWJ2aWV3IHNlbGVjdEFsbDpuaWxd OworfQorCistICh2b2lkKWRlc2VsZWN0QWxsCit7CisgICAgW1BERlN1YnZpZXcgY2xlYXJTZWxl Y3Rpb25dOworfQorCiBAZW5kCiAKICNlbmRpZiAvLyBPTUlUX1RJR0VSX0ZFQVRVUkVTCg== 2978 2005-07-15 16:00:35 -0700 2005-07-15 16:09:08 -0700 proposed patch with consensus changes 4013-2.patch text/plain 3585 trey SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViS2l0L0No YW5nZUxvZyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4zMjI5CmRpZmYgLXAgLXUgLXIxLjMyMjkg Q2hhbmdlTG9nCi0tLSBDaGFuZ2VMb2cJMjAwNS8wNy8xNSAyMDozNToyNAkxLjMyMjkKKysrIENo YW5nZUxvZwkyMDA1LzA3LzE1IDIyOjU1OjQ5CkBAIC0xLDMgKzEsMjMgQEAKKzIwMDUtMDctMTUg IFRyZXkgTWF0dGVzb24gIDx0cmV5QHVzYS5uZXQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgSm9o biBTdWxsaXZhbi4KKworICAgICAgICBGaXggZm9yIGh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2lu Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDAxMworICAgICAgICAgICAgICAgIHRleHQgZmluZCBkb2Vz bid0IHdyYXAgaW4gUERGIGZpbGVzCisKKyAgICAgICAgVGhpcyBqdXN0IHdvcmtzIG9uY2UgV2Vi UERGVmlldyBpbXBsZW1lbnRzIHRoZSBXZWJEb2N1bWVudFRleHQgcHJvdG9jb2wsIHdoaWNoIGlz CisgICAgICAgIGp1c3QgYSBtYXR0ZXIgb2YgZm9yd2FyZGluZyB0aGUgbWV0aG9kcyB0byBQREZL aXQuCisKKyAgICAgICAgKiBXZWJWaWV3LnN1YnByb2ovV2ViUERGVmlldy5oOgorICAgICAgICAq IFdlYlZpZXcuc3VicHJvai9XZWJQREZWaWV3Lm06CisgICAgICAgICgtW1dlYlBERlZpZXcgc3Vw cG9ydHNUZXh0RW5jb2RpbmddKToKKyAgICAgICAgKC1bV2ViUERGVmlldyBzdHJpbmddKToKKyAg ICAgICAgKC1bV2ViUERGVmlldyBhdHRyaWJ1dGVkU3RyaW5nXSk6CisgICAgICAgICgtW1dlYlBE RlZpZXcgc2VsZWN0ZWRTdHJpbmddKToKKyAgICAgICAgKC1bV2ViUERGVmlldyBzZWxlY3RlZEF0 dHJpYnV0ZWRTdHJpbmddKToKKyAgICAgICAgKC1bV2ViUERGVmlldyBzZWxlY3RBbGxdKToKKyAg ICAgICAgKC1bV2ViUERGVmlldyBkZXNlbGVjdEFsbF0pOgorCiAyMDA1LTA3LTE1ICBKb2huIFN1 bGxpdmFuICA8c3VsbGl2YW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hY2ll aiBTdGFjaG93aWFrLgpJbmRleDogLi9XZWJWaWV3LnN1YnByb2ovV2ViUERGVmlldy5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJLaXQvV2ViVmlldy5zdWJwcm9qL1dlYlBERlZp ZXcuaCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS43CmRpZmYgLXAgLXUgLXIxLjcgLi9XZWJWaWV3 LnN1YnByb2ovV2ViUERGVmlldy5oCi0tLSAuL1dlYlZpZXcuc3VicHJvai9XZWJQREZWaWV3LmgJ MjAwNS8wNi8xNCAxODowNjowMAkxLjcKKysrIC4vV2ViVmlldy5zdWJwcm9qL1dlYlBERlZpZXcu aAkyMDA1LzA3LzE1IDIyOjU2OjA0CkBAIC0zMyw3ICszMyw3IEBACiAKIEBwcm90b2NvbCBfd2Vi X1dlYkRvY3VtZW50VGV4dFNpemluZzsKIAotQGludGVyZmFjZSBXZWJQREZWaWV3IDogTlNWaWV3 IDxXZWJEb2N1bWVudFZpZXcsIFdlYkRvY3VtZW50U2VhcmNoaW5nLCBfd2ViX1dlYkRvY3VtZW50 VGV4dFNpemluZz4KK0BpbnRlcmZhY2UgV2ViUERGVmlldyA6IE5TVmlldyA8V2ViRG9jdW1lbnRW aWV3LCBXZWJEb2N1bWVudFNlYXJjaGluZywgV2ViRG9jdW1lbnRUZXh0LCBfd2ViX1dlYkRvY3Vt ZW50VGV4dFNpemluZz4KIHsKICAgICBQREZWaWV3ICpQREZTdWJ2aWV3OwogICAgIFdlYkRhdGFT b3VyY2UgKmRhdGFTb3VyY2U7CkluZGV4OiAuL1dlYlZpZXcuc3VicHJvai9XZWJQREZWaWV3Lm0K PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L1dlYktpdC9XZWJWaWV3LnN1YnByb2ovV2Vi UERGVmlldy5tLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjE4CmRpZmYgLXAgLXUgLXIxLjE4IC4v V2ViVmlldy5zdWJwcm9qL1dlYlBERlZpZXcubQotLS0gLi9XZWJWaWV3LnN1YnByb2ovV2ViUERG Vmlldy5tCTIwMDUvMDcvMTQgMjM6NTE6NDQJMS4xOAorKysgLi9XZWJWaWV3LnN1YnByb2ovV2Vi UERGVmlldy5tCTIwMDUvMDcvMTUgMjI6NTY6MDQKQEAgLTQ1Miw2ICs0NTIsNTcgQEAgc3RhdGlj IHZvaWQgYXBwbGljYXRpb25JbmZvRm9yTUlNRVR5cGUoTgogICAgIH0KIH0KIAorLyoqKiBXZWJE b2N1bWVudFRleHQgcHJvdG9jb2wgaW1wbGVtZW50YXRpb24gKioqLworCistIChCT09MKXN1cHBv cnRzVGV4dEVuY29kaW5nCit7CisgICAgcmV0dXJuIE5POworfQorCistIChOU1N0cmluZyAqKXN0 cmluZworeworICAgIHJldHVybiBbW1BERlN1YnZpZXcgZG9jdW1lbnRdIHN0cmluZ107Cit9CisK Ky0gKE5TQXR0cmlidXRlZFN0cmluZyAqKWF0dHJpYnV0ZWRTdHJpbmcKK3sKKyAgICAvLyBjaGFu Z2luZyB0aGUgc2VsZWN0aW9uIGlzIGEgaGFjaywgYnV0IHRoZSBvbmx5IHdheSB0byBnZXQgYW4g YXR0ciBzdHJpbmcgaXMgdmlhIFBERlNlbGVjdGlvbgorICAgIAorICAgIC8vIG11c3QgY29weSB0 aGlzIHNlbGVjdGlvbiBvYmplY3QgYmVjYXVzZSB3ZSBjaGFuZ2UgdGhlIHNlbGVjdGlvbiB3aGlj aCBzZWVtcyB0byByZWxlYXNlIGl0CisgICAgUERGU2VsZWN0aW9uICpzYXZlZFNlbGVjdGlvbiA9 IFtbUERGU3VidmlldyBjdXJyZW50U2VsZWN0aW9uXSBjb3B5XTsKKyAgICBbUERGU3VidmlldyBz ZWxlY3RBbGw6bmlsXTsKKyAgICBOU0F0dHJpYnV0ZWRTdHJpbmcgKnJlc3VsdCA9IFtbUERGU3Vi dmlldyBjdXJyZW50U2VsZWN0aW9uXSBhdHRyaWJ1dGVkU3RyaW5nXTsKKyAgICBpZiAoc2F2ZWRT ZWxlY3Rpb24pIHsKKyAgICAgICAgW1BERlN1YnZpZXcgc2V0Q3VycmVudFNlbGVjdGlvbjpzYXZl ZFNlbGVjdGlvbl07CisgICAgICAgIFtzYXZlZFNlbGVjdGlvbiByZWxlYXNlXTsKKyAgICB9IGVs c2UgeworICAgICAgICAvLyBGSVhNRTogYmVoYXZpb3Igb2Ygc2V0Q3VycmVudFNlbGVjdGlvbjpu aWwgaXMgbm90IGRvY3VtZW50ZWQgLSBjaGVjayA0MTgyOTM0IGZvciBwcm9ncmVzcworICAgICAg ICAvLyBPdGhlcndpc2UsIHdlIGNvdWxkIGNvbGxhcHNlIHRoaXMgY29kZSB3aXRoIHRoZSBjYXNl IGFib3ZlLgorICAgICAgICBbUERGU3VidmlldyBjbGVhclNlbGVjdGlvbl07CisgICAgfQorICAg IHJldHVybiByZXN1bHQ7Cit9CisKKy0gKE5TU3RyaW5nICopc2VsZWN0ZWRTdHJpbmcKK3sKKyAg ICByZXR1cm4gW1tQREZTdWJ2aWV3IGN1cnJlbnRTZWxlY3Rpb25dIHN0cmluZ107Cit9CisKKy0g KE5TQXR0cmlidXRlZFN0cmluZyAqKXNlbGVjdGVkQXR0cmlidXRlZFN0cmluZworeworICAgIHJl dHVybiBbW1BERlN1YnZpZXcgY3VycmVudFNlbGVjdGlvbl0gYXR0cmlidXRlZFN0cmluZ107Cit9 CisKKy0gKHZvaWQpc2VsZWN0QWxsCit7CisgICAgW1BERlN1YnZpZXcgc2VsZWN0QWxsOm5pbF07 Cit9CisKKy0gKHZvaWQpZGVzZWxlY3RBbGwKK3sKKyAgICBbUERGU3VidmlldyBjbGVhclNlbGVj dGlvbl07Cit9CisKIEBlbmQKIAogI2VuZGlmIC8vIE9NSVRfVElHRVJfRkVBVFVSRVMK