40128 2010-06-03 10:13:31 -0700 Regressions in debug functionality 2010-06-24 11:29:50 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Trivial --- 1 nlawrence nlawrence barraclough nlawrence oliver sfalken webkit.review.bot oldest_to_newest 233808 0 57785 nlawrence 2010-06-03 10:13:31 -0700 Created attachment 57785 suggested patch There are a few things that don't work anymore but are useful for debugging: * JS_ZOMBIES doesn't compile anymore. * The dumpCallFrame function in the interpreter causes a runtime error because JSValue::description does not match the current state of JSValue * The dumpRegisters function in the interpreter is not up to date with the most recent call frame patches. * Additionally it would be nice if JSValue::isCell checked that the value was aligned. 233809 1 webkit.review.bot 2010-06-03 10:16:04 -0700 Attachment 57785 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 JavaScriptCore/runtime/JSImmediate.h:47: CELL_MASK is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/runtime/JSImmediate.h:602: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 233825 2 57788 nlawrence 2010-06-03 10:44:04 -0700 Created attachment 57788 fixed style issue I did not fix the issue with having underscores in the name because it is a constant defined in Collector.h 233826 3 webkit.review.bot 2010-06-03 10:46:15 -0700 Attachment 57788 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 JavaScriptCore/runtime/JSImmediate.h:47: CELL_MASK is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 233903 4 57788 levin 2010-06-03 13:46:24 -0700 Comment on attachment 57788 fixed style issue I won't be able to review this, but I can let you know that you'll need a ChangeLog to make it through the review. 233948 5 57820 nlawrence 2010-06-03 15:22:16 -0700 Created attachment 57820 Changelogged 233949 6 webkit.review.bot 2010-06-03 15:23:30 -0700 Attachment 57820 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 JavaScriptCore/runtime/JSImmediate.h:47: CELL_MASK is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 237418 7 57820 darin 2010-06-12 19:07:05 -0700 Comment on attachment 57820 Changelogged > +#if !defined(NDEBUG) #ifndef NDEBUG is more idiomatic for this sort of thing. The rest of this looks fine. 240836 8 59280 nlawrence 2010-06-21 13:12:28 -0700 Created attachment 59280 changed #if !defined to #ifndef 240838 9 webkit.review.bot 2010-06-21 13:14:22 -0700 Attachment 59280 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 JavaScriptCore/runtime/JSImmediate.h:47: CELL_MASK is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 240841 10 59280 ggaren 2010-06-21 13:16:32 -0700 Comment on attachment 59280 changed #if !defined to #ifndef r=me When might JSValue::description() want to print INVALID()? (That's the kind of information that can be useful in a ChangeLog -- an explanation of "why", in addition to "what".) 241415 11 57820 eric 2010-06-22 13:23:10 -0700 Comment on attachment 57820 Changelogged Cleared Darin Adler's review+ from obsolete attachment 57820 so that this bug does not appear in http://webkit.org/pending-commit. 242604 12 sfalken 2010-06-24 11:29:50 -0700 http://trac.webkit.org/changeset/61778 57785 2010-06-03 10:13:31 -0700 2010-06-03 10:44:04 -0700 suggested patch random-fixups.patch text/plain 2881 nlawrence SW5kZXg6IEphdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0ludGVycHJldGVyLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9JbnRlcnByZXRlci5jcHAJKHJldmlz aW9uIDYwMzI5KQorKysgSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvSW50ZXJwcmV0ZXIuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC00NTYsNyArNDU2LDYgQEAgdm9pZCBJbnRlcnByZXRlcjo6ZHVt cFJlZ2lzdGVycyhDYWxsRnJhbQogICAgIHByaW50ZigiW1Njb3BlQ2hhaW5dICAgICAgICAgICAg ICAgfCAlMTBwIHwgJXAgXG4iLCBpdCwgKCppdCkuc2NvcGVDaGFpbigpKTsgKytpdDsKICAgICBw cmludGYoIltDYWxsZXJSZWdpc3RlcnNdICAgICAgICAgIHwgJTEwcCB8ICVkIFxuIiwgaXQsICgq aXQpLmkoKSk7ICsraXQ7CiAgICAgcHJpbnRmKCJbUmV0dXJuUENdICAgICAgICAgICAgICAgICB8 ICUxMHAgfCAlcCBcbiIsIGl0LCAoKml0KS52UEMoKSk7ICsraXQ7Ci0gICAgKytpdDsKICAgICBw cmludGYoIltBcmd1bWVudENvdW50XSAgICAgICAgICAgIHwgJTEwcCB8ICVkIFxuIiwgaXQsICgq aXQpLmkoKSk7ICsraXQ7CiAgICAgcHJpbnRmKCJbQ2FsbGVlXSAgICAgICAgICAgICAgICAgICB8 ICUxMHAgfCAlcCBcbiIsIGl0LCAoKml0KS5mdW5jdGlvbigpKTsgKytpdDsKICAgICBwcmludGYo Ii0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tXG4iKTsKSW5kZXg6IEphdmFTY3JpcHRDb3JlL3J1bnRpbWUv SlNJbW1lZGlhdGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTSW1t ZWRpYXRlLmgJKHJldmlzaW9uIDYwMzI5KQorKysgSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0lt bWVkaWF0ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC00NCw2ICs0NCw4IEBAIG5hbWVzcGFjZSBKU0Mg ewogICAgIGNsYXNzIEpTT2JqZWN0OwogICAgIGNsYXNzIFVTdHJpbmc7CiAKKyAgICBleHRlcm4g Y29uc3Qgc2l6ZV90IENFTExfTUFTSzsKKwogI2lmIFVTRShKU1ZBTFVFNjQpCiAgICAgaW5saW5l IGludHB0cl90IHJlaW50ZXJwcmV0RG91YmxlVG9JbnRwdHIoZG91YmxlIHZhbHVlKQogICAgIHsK QEAgLTU5NSw3ICs1OTcsMTMgQEAgbmFtZXNwYWNlIEpTQyB7CiAKICAgICBpbmxpbmUgYm9vbCBK U1ZhbHVlOjppc0NlbGwoKSBjb25zdAogICAgIHsKKyNpZiAhZGVmaW5lZChOREVCVUcpCisgICAg ICAgIGJvb2wgciA9ICFKU0ltbWVkaWF0ZTo6aXNJbW1lZGlhdGUoYXNWYWx1ZSgpKTsKKyAgICAg ICAgQVNTRVJUKCFyIHx8IChKU0ltbWVkaWF0ZTo6cmF3VmFsdWUoYXNWYWx1ZSgpKSAmIENFTExf TUFTSykgPT0gMCk7CisgICAgICAgIHJldHVybiByOworI2Vsc2UKICAgICAgICAgcmV0dXJuICFK U0ltbWVkaWF0ZTo6aXNJbW1lZGlhdGUoYXNWYWx1ZSgpKTsKKyNlbmRpZgogICAgIH0KIAogICAg IGlubGluZSBib29sIEpTVmFsdWU6OmlzSW50MzIoKSBjb25zdApJbmRleDogSmF2YVNjcmlwdENv cmUvcnVudGltZS9KU1ZhbHVlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9ydW50 aW1lL0pTVmFsdWUuY3BwCShyZXZpc2lvbiA2MDMyOSkKKysrIEphdmFTY3JpcHRDb3JlL3J1bnRp bWUvSlNWYWx1ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEyNSwxMCArMTI1LDEwIEBAIGNoYXIq IEpTVmFsdWU6OmRlc2NyaXB0aW9uKCkKICAgICAgICAgc25wcmludGYoZGVzY3JpcHRpb24sIHNp emUsICJGYWxzZSIpOwogICAgIGVsc2UgaWYgKGlzTnVsbCgpKQogICAgICAgICBzbnByaW50Zihk ZXNjcmlwdGlvbiwgc2l6ZSwgIk51bGwiKTsKLSAgICBlbHNlIHsKLSAgICAgICAgQVNTRVJUKGlz VW5kZWZpbmVkKCkpOworICAgIGVsc2UgaWYgKGlzVW5kZWZpbmVkKCkpCiAgICAgICAgIHNucHJp bnRmKGRlc2NyaXB0aW9uLCBzaXplLCAiVW5kZWZpbmVkIik7Ci0gICAgfQorICAgIGVsc2UKKyAg ICAgICAgc25wcmludGYoZGVzY3JpcHRpb24sIHNpemUsICJJTlZBTElEIik7CiAKICAgICByZXR1 cm4gZGVzY3JpcHRpb247CiB9CkluZGV4OiBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTWm9tYmll LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTWm9tYmllLmNwcAko cmV2aXNpb24gNjAzMjkpCisrKyBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTWm9tYmllLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMzcsNyArMzcsNyBAQCBTdHJ1Y3R1cmUqIEpTWm9tYmllOjpsZWFr ZWRab21iaWVTdHJ1Y3R1CiAgICAgc3RhdGljIFN0cnVjdHVyZSogc3RydWN0dXJlID0gMDsKICAg ICBpZiAoIXN0cnVjdHVyZSkgewogICAgICAgICBTdHJ1Y3R1cmU6OnN0YXJ0SWdub3JpbmdMZWFr cygpOwotICAgICAgICBzdHJ1Y3R1cmUgPSBTdHJ1Y3R1cmU6OmNyZWF0ZShqc051bGwoKSwgVHlw ZUluZm8oVW5zcGVjaWZpZWRUeXBlKSkucmVsZWFzZVJlZigpOworICAgICAgICBzdHJ1Y3R1cmUg PSBTdHJ1Y3R1cmU6OmNyZWF0ZShqc051bGwoKSwgVHlwZUluZm8oVW5zcGVjaWZpZWRUeXBlKSwg MCkucmVsZWFzZVJlZigpOwogICAgICAgICBTdHJ1Y3R1cmU6OnN0b3BJZ25vcmluZ0xlYWtzKCk7 CiAgICAgfQogICAgIHJldHVybiBzdHJ1Y3R1cmU7Cg== 57788 2010-06-03 10:44:04 -0700 2010-06-03 15:22:16 -0700 fixed style issue random-fixups.patch text/plain 2877 nlawrence SW5kZXg6IEphdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0ludGVycHJldGVyLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9JbnRlcnByZXRlci5jcHAJKHJldmlz aW9uIDYwMzI5KQorKysgSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvSW50ZXJwcmV0ZXIuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC00NTYsNyArNDU2LDYgQEAgdm9pZCBJbnRlcnByZXRlcjo6ZHVt cFJlZ2lzdGVycyhDYWxsRnJhbQogICAgIHByaW50ZigiW1Njb3BlQ2hhaW5dICAgICAgICAgICAg ICAgfCAlMTBwIHwgJXAgXG4iLCBpdCwgKCppdCkuc2NvcGVDaGFpbigpKTsgKytpdDsKICAgICBw cmludGYoIltDYWxsZXJSZWdpc3RlcnNdICAgICAgICAgIHwgJTEwcCB8ICVkIFxuIiwgaXQsICgq aXQpLmkoKSk7ICsraXQ7CiAgICAgcHJpbnRmKCJbUmV0dXJuUENdICAgICAgICAgICAgICAgICB8 ICUxMHAgfCAlcCBcbiIsIGl0LCAoKml0KS52UEMoKSk7ICsraXQ7Ci0gICAgKytpdDsKICAgICBw cmludGYoIltBcmd1bWVudENvdW50XSAgICAgICAgICAgIHwgJTEwcCB8ICVkIFxuIiwgaXQsICgq aXQpLmkoKSk7ICsraXQ7CiAgICAgcHJpbnRmKCJbQ2FsbGVlXSAgICAgICAgICAgICAgICAgICB8 ICUxMHAgfCAlcCBcbiIsIGl0LCAoKml0KS5mdW5jdGlvbigpKTsgKytpdDsKICAgICBwcmludGYo Ii0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tXG4iKTsKSW5kZXg6IEphdmFTY3JpcHRDb3JlL3J1bnRpbWUv SlNJbW1lZGlhdGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTSW1t ZWRpYXRlLmgJKHJldmlzaW9uIDYwMzI5KQorKysgSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0lt bWVkaWF0ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC00NCw2ICs0NCw4IEBAIG5hbWVzcGFjZSBKU0Mg ewogICAgIGNsYXNzIEpTT2JqZWN0OwogICAgIGNsYXNzIFVTdHJpbmc7CiAKKyAgICBleHRlcm4g Y29uc3Qgc2l6ZV90IENFTExfTUFTSzsKKwogI2lmIFVTRShKU1ZBTFVFNjQpCiAgICAgaW5saW5l IGludHB0cl90IHJlaW50ZXJwcmV0RG91YmxlVG9JbnRwdHIoZG91YmxlIHZhbHVlKQogICAgIHsK QEAgLTU5NSw3ICs1OTcsMTMgQEAgbmFtZXNwYWNlIEpTQyB7CiAKICAgICBpbmxpbmUgYm9vbCBK U1ZhbHVlOjppc0NlbGwoKSBjb25zdAogICAgIHsKKyNpZiAhZGVmaW5lZChOREVCVUcpCisgICAg ICAgIGJvb2wgciA9ICFKU0ltbWVkaWF0ZTo6aXNJbW1lZGlhdGUoYXNWYWx1ZSgpKTsKKyAgICAg ICAgQVNTRVJUKCFyIHx8ICEoSlNJbW1lZGlhdGU6OnJhd1ZhbHVlKGFzVmFsdWUoKSkgJiBDRUxM X01BU0spKTsKKyAgICAgICAgcmV0dXJuIHI7CisjZWxzZQogICAgICAgICByZXR1cm4gIUpTSW1t ZWRpYXRlOjppc0ltbWVkaWF0ZShhc1ZhbHVlKCkpOworI2VuZGlmCiAgICAgfQogCiAgICAgaW5s aW5lIGJvb2wgSlNWYWx1ZTo6aXNJbnQzMigpIGNvbnN0CkluZGV4OiBKYXZhU2NyaXB0Q29yZS9y dW50aW1lL0pTVmFsdWUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3J1bnRpbWUv SlNWYWx1ZS5jcHAJKHJldmlzaW9uIDYwMzI5KQorKysgSmF2YVNjcmlwdENvcmUvcnVudGltZS9K U1ZhbHVlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTI1LDEwICsxMjUsMTAgQEAgY2hhciogSlNW YWx1ZTo6ZGVzY3JpcHRpb24oKQogICAgICAgICBzbnByaW50ZihkZXNjcmlwdGlvbiwgc2l6ZSwg IkZhbHNlIik7CiAgICAgZWxzZSBpZiAoaXNOdWxsKCkpCiAgICAgICAgIHNucHJpbnRmKGRlc2Ny aXB0aW9uLCBzaXplLCAiTnVsbCIpOwotICAgIGVsc2UgewotICAgICAgICBBU1NFUlQoaXNVbmRl ZmluZWQoKSk7CisgICAgZWxzZSBpZiAoaXNVbmRlZmluZWQoKSkKICAgICAgICAgc25wcmludGYo ZGVzY3JpcHRpb24sIHNpemUsICJVbmRlZmluZWQiKTsKLSAgICB9CisgICAgZWxzZQorICAgICAg ICBzbnByaW50ZihkZXNjcmlwdGlvbiwgc2l6ZSwgIklOVkFMSUQiKTsKIAogICAgIHJldHVybiBk ZXNjcmlwdGlvbjsKIH0KSW5kZXg6IEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNab21iaWUuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNab21iaWUuY3BwCShyZXZp c2lvbiA2MDMyOSkKKysrIEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNab21iaWUuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0zNyw3ICszNyw3IEBAIFN0cnVjdHVyZSogSlNab21iaWU6OmxlYWtlZFpv bWJpZVN0cnVjdHUKICAgICBzdGF0aWMgU3RydWN0dXJlKiBzdHJ1Y3R1cmUgPSAwOwogICAgIGlm ICghc3RydWN0dXJlKSB7CiAgICAgICAgIFN0cnVjdHVyZTo6c3RhcnRJZ25vcmluZ0xlYWtzKCk7 Ci0gICAgICAgIHN0cnVjdHVyZSA9IFN0cnVjdHVyZTo6Y3JlYXRlKGpzTnVsbCgpLCBUeXBlSW5m byhVbnNwZWNpZmllZFR5cGUpKS5yZWxlYXNlUmVmKCk7CisgICAgICAgIHN0cnVjdHVyZSA9IFN0 cnVjdHVyZTo6Y3JlYXRlKGpzTnVsbCgpLCBUeXBlSW5mbyhVbnNwZWNpZmllZFR5cGUpLCAwKS5y ZWxlYXNlUmVmKCk7CiAgICAgICAgIFN0cnVjdHVyZTo6c3RvcElnbm9yaW5nTGVha3MoKTsKICAg ICB9CiAgICAgcmV0dXJuIHN0cnVjdHVyZTsK 57820 2010-06-03 15:22:16 -0700 2010-06-22 13:23:10 -0700 Changelogged random-fixups.patch text/plain 3889 nlawrence SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDYwNjM2KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTAtMDYtMDMgIE5hdGhhbiBM YXdyZW5jZSAgPG5sYXdyZW5jZUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTQwMTI4CisgICAgICAgIEZpeGVkIGJyb2tlbiBkZWJ1ZyBmdW5jdGlvbmFsaXR5Lgor CisgICAgICAgICogaW50ZXJwcmV0ZXIvSW50ZXJwcmV0ZXIuY3BwOgorICAgICAgICAoSlNDOjpJ bnRlcnByZXRlcjo6ZHVtcFJlZ2lzdGVycyk6CisgICAgICAgICAgICBGaXhlZCB0byB3b3JrIHdp dGggdXBkYXRlZCBjYWxsIGZyYW1lLgorICAgICAgICAqIHJ1bnRpbWUvSlNJbW1lZGlhdGUuaDoK KyAgICAgICAgKEpTQzo6SlNWYWx1ZTo6aXNDZWxsKToKKyAgICAgICAgICAgIEFkZGVkIGFzc2Vy dCBmb3IgYWxpZ25lZCBjZWxsLgorICAgICAgICAqIHJ1bnRpbWUvSlNWYWx1ZS5jcHA6CisgICAg ICAgIChKU0M6OkpTVmFsdWU6OmRlc2NyaXB0aW9uKToKKyAgICAgICAgICAgIEZpeGVkIHRvIHdv cmsgd2l0aCBjdXJyZW50IEpTVmFsdWUgaW1wbGVtZW50YXRpb24uCisgICAgICAgICogcnVudGlt ZS9KU1pvbWJpZS5jcHA6CisgICAgICAgIChKU0M6OkpTWm9tYmllOjpsZWFrZWRab21iaWVTdHJ1 Y3R1cmUpOgorICAgICAgICAgICAgSlNvbWJpZXMgY29tcGlsZSBhZ2Fpbi4KKwogMjAxMC0wNi0w MyAgR2F2aW4gQmFycmFjbG91Z2ggIDxiYXJyYWNsb3VnaEBhcHBsZS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZICh3aW5kb3dzIGJ1aWxkIGZpeCBJSSkuCkluZGV4OiBKYXZhU2Ny aXB0Q29yZS9pbnRlcnByZXRlci9JbnRlcnByZXRlci5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNj cmlwdENvcmUvaW50ZXJwcmV0ZXIvSW50ZXJwcmV0ZXIuY3BwCShyZXZpc2lvbiA2MDMyOSkKKysr IEphdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0ludGVycHJldGVyLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNDU2LDcgKzQ1Niw2IEBAIHZvaWQgSW50ZXJwcmV0ZXI6OmR1bXBSZWdpc3RlcnMoQ2Fs bEZyYW0KICAgICBwcmludGYoIltTY29wZUNoYWluXSAgICAgICAgICAgICAgIHwgJTEwcCB8ICVw IFxuIiwgaXQsICgqaXQpLnNjb3BlQ2hhaW4oKSk7ICsraXQ7CiAgICAgcHJpbnRmKCJbQ2FsbGVy UmVnaXN0ZXJzXSAgICAgICAgICB8ICUxMHAgfCAlZCBcbiIsIGl0LCAoKml0KS5pKCkpOyArK2l0 OwogICAgIHByaW50ZigiW1JldHVyblBDXSAgICAgICAgICAgICAgICAgfCAlMTBwIHwgJXAgXG4i LCBpdCwgKCppdCkudlBDKCkpOyArK2l0OwotICAgICsraXQ7CiAgICAgcHJpbnRmKCJbQXJndW1l bnRDb3VudF0gICAgICAgICAgICB8ICUxMHAgfCAlZCBcbiIsIGl0LCAoKml0KS5pKCkpOyArK2l0 OwogICAgIHByaW50ZigiW0NhbGxlZV0gICAgICAgICAgICAgICAgICAgfCAlMTBwIHwgJXAgXG4i LCBpdCwgKCppdCkuZnVuY3Rpb24oKSk7ICsraXQ7CiAgICAgcHJpbnRmKCItLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLVxuIik7CkluZGV4OiBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTSW1tZWRpYXRlLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0ltbWVkaWF0ZS5oCShyZXZp c2lvbiA2MDMyOSkKKysrIEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNJbW1lZGlhdGUuaAkod29y a2luZyBjb3B5KQpAQCAtNDQsNiArNDQsOCBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICBjbGFzcyBK U09iamVjdDsKICAgICBjbGFzcyBVU3RyaW5nOwogCisgICAgZXh0ZXJuIGNvbnN0IHNpemVfdCBD RUxMX01BU0s7CisKICNpZiBVU0UoSlNWQUxVRTY0KQogICAgIGlubGluZSBpbnRwdHJfdCByZWlu dGVycHJldERvdWJsZVRvSW50cHRyKGRvdWJsZSB2YWx1ZSkKICAgICB7CkBAIC01OTUsNyArNTk3 LDEzIEBAIG5hbWVzcGFjZSBKU0MgewogCiAgICAgaW5saW5lIGJvb2wgSlNWYWx1ZTo6aXNDZWxs KCkgY29uc3QKICAgICB7CisjaWYgIWRlZmluZWQoTkRFQlVHKQorICAgICAgICBib29sIHIgPSAh SlNJbW1lZGlhdGU6OmlzSW1tZWRpYXRlKGFzVmFsdWUoKSk7CisgICAgICAgIEFTU0VSVCghciB8 fCAhKEpTSW1tZWRpYXRlOjpyYXdWYWx1ZShhc1ZhbHVlKCkpICYgQ0VMTF9NQVNLKSk7CisgICAg ICAgIHJldHVybiByOworI2Vsc2UKICAgICAgICAgcmV0dXJuICFKU0ltbWVkaWF0ZTo6aXNJbW1l ZGlhdGUoYXNWYWx1ZSgpKTsKKyNlbmRpZgogICAgIH0KIAogICAgIGlubGluZSBib29sIEpTVmFs dWU6OmlzSW50MzIoKSBjb25zdApJbmRleDogSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1ZhbHVl LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTVmFsdWUuY3BwCShy ZXZpc2lvbiA2MDMyOSkKKysrIEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNWYWx1ZS5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTEyNSwxMCArMTI1LDEwIEBAIGNoYXIqIEpTVmFsdWU6OmRlc2NyaXB0 aW9uKCkKICAgICAgICAgc25wcmludGYoZGVzY3JpcHRpb24sIHNpemUsICJGYWxzZSIpOwogICAg IGVsc2UgaWYgKGlzTnVsbCgpKQogICAgICAgICBzbnByaW50ZihkZXNjcmlwdGlvbiwgc2l6ZSwg Ik51bGwiKTsKLSAgICBlbHNlIHsKLSAgICAgICAgQVNTRVJUKGlzVW5kZWZpbmVkKCkpOworICAg IGVsc2UgaWYgKGlzVW5kZWZpbmVkKCkpCiAgICAgICAgIHNucHJpbnRmKGRlc2NyaXB0aW9uLCBz aXplLCAiVW5kZWZpbmVkIik7Ci0gICAgfQorICAgIGVsc2UKKyAgICAgICAgc25wcmludGYoZGVz Y3JpcHRpb24sIHNpemUsICJJTlZBTElEIik7CiAKICAgICByZXR1cm4gZGVzY3JpcHRpb247CiB9 CkluZGV4OiBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTWm9tYmllLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTWm9tYmllLmNwcAkocmV2aXNpb24gNjAzMjkpCisr KyBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTWm9tYmllLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MzcsNyArMzcsNyBAQCBTdHJ1Y3R1cmUqIEpTWm9tYmllOjpsZWFrZWRab21iaWVTdHJ1Y3R1CiAg ICAgc3RhdGljIFN0cnVjdHVyZSogc3RydWN0dXJlID0gMDsKICAgICBpZiAoIXN0cnVjdHVyZSkg ewogICAgICAgICBTdHJ1Y3R1cmU6OnN0YXJ0SWdub3JpbmdMZWFrcygpOwotICAgICAgICBzdHJ1 Y3R1cmUgPSBTdHJ1Y3R1cmU6OmNyZWF0ZShqc051bGwoKSwgVHlwZUluZm8oVW5zcGVjaWZpZWRU eXBlKSkucmVsZWFzZVJlZigpOworICAgICAgICBzdHJ1Y3R1cmUgPSBTdHJ1Y3R1cmU6OmNyZWF0 ZShqc051bGwoKSwgVHlwZUluZm8oVW5zcGVjaWZpZWRUeXBlKSwgMCkucmVsZWFzZVJlZigpOwog ICAgICAgICBTdHJ1Y3R1cmU6OnN0b3BJZ25vcmluZ0xlYWtzKCk7CiAgICAgfQogICAgIHJldHVy biBzdHJ1Y3R1cmU7Cg== 59280 2010-06-21 13:12:28 -0700 2010-06-21 13:16:43 -0700 changed #if !defined to #ifndef random-fixups.patch text/plain 3873 nlawrence SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDYxNTY3KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjMgQEAKKyAyMDEwLTA2LTIxICBOYXRoYW4g TGF3cmVuY2UgIDxubGF3cmVuY2VAYXBwbGUuY29tPgorCisgICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTQwMTI4CisgICAgICAgICBGaXhlZCBicm9rZW4gZGVidWcgZnVuY3Rpb25hbGl0 eS4KKworICAgICAgICAgKiBpbnRlcnByZXRlci9JbnRlcnByZXRlci5jcHA6CisgICAgICAgICAo SlNDOjpJbnRlcnByZXRlcjo6ZHVtcFJlZ2lzdGVycyk6CisgICAgICAgICAgICAgRml4ZWQgdG8g d29yayB3aXRoIHVwZGF0ZWQgY2FsbCBmcmFtZS4KKyAgICAgICAgICogcnVudGltZS9KU0ltbWVk aWF0ZS5oOgorICAgICAgICAgKEpTQzo6SlNWYWx1ZTo6aXNDZWxsKToKKyAgICAgICAgICAgICBB ZGRlZCBhc3NlcnQgZm9yIGFsaWduZWQgY2VsbC4KKyAgICAgICAgICogcnVudGltZS9KU1ZhbHVl LmNwcDoKKyAgICAgICAgIChKU0M6OkpTVmFsdWU6OmRlc2NyaXB0aW9uKToKKyAgICAgICAgICAg ICBGaXhlZCB0byB3b3JrIHdpdGggY3VycmVudCBKU1ZhbHVlIGltcGxlbWVudGF0aW9uLgorICAg ICAgICAgKiBydW50aW1lL0pTWm9tYmllLmNwcDoKKyAgICAgICAgIChKU0M6OkpTWm9tYmllOjps ZWFrZWRab21iaWVTdHJ1Y3R1cmUpOgorICAgICAgICAgICAgIEpTb21iaWVzIGNvbXBpbGUgYWdh aW4uCisKIDIwMTAtMDYtMTkgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBHZW9mZnJleSBHYXJlbi4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL2lu dGVycHJldGVyL0ludGVycHJldGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9p bnRlcnByZXRlci9JbnRlcnByZXRlci5jcHAJKHJldmlzaW9uIDYxNTY3KQorKysgSmF2YVNjcmlw dENvcmUvaW50ZXJwcmV0ZXIvSW50ZXJwcmV0ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NTYs NyArNDU2LDYgQEAgdm9pZCBJbnRlcnByZXRlcjo6ZHVtcFJlZ2lzdGVycyhDYWxsRnJhbQogICAg IHByaW50ZigiW1Njb3BlQ2hhaW5dICAgICAgICAgICAgICAgfCAlMTBwIHwgJXAgXG4iLCBpdCwg KCppdCkuc2NvcGVDaGFpbigpKTsgKytpdDsKICAgICBwcmludGYoIltDYWxsZXJSZWdpc3RlcnNd ICAgICAgICAgIHwgJTEwcCB8ICVkIFxuIiwgaXQsICgqaXQpLmkoKSk7ICsraXQ7CiAgICAgcHJp bnRmKCJbUmV0dXJuUENdICAgICAgICAgICAgICAgICB8ICUxMHAgfCAlcCBcbiIsIGl0LCAoKml0 KS52UEMoKSk7ICsraXQ7Ci0gICAgKytpdDsKICAgICBwcmludGYoIltBcmd1bWVudENvdW50XSAg ICAgICAgICAgIHwgJTEwcCB8ICVkIFxuIiwgaXQsICgqaXQpLmkoKSk7ICsraXQ7CiAgICAgcHJp bnRmKCJbQ2FsbGVlXSAgICAgICAgICAgICAgICAgICB8ICUxMHAgfCAlcCBcbiIsIGl0LCAoKml0 KS5mdW5jdGlvbigpKTsgKytpdDsKICAgICBwcmludGYoIi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tXG4i KTsKSW5kZXg6IEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNJbW1lZGlhdGUuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTSW1tZWRpYXRlLmgJKHJldmlzaW9uIDYxNTY3 KQorKysgSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0ltbWVkaWF0ZS5oCSh3b3JraW5nIGNvcHkp CkBAIC00NCw2ICs0NCw4IEBAIG5hbWVzcGFjZSBKU0MgewogICAgIGNsYXNzIEpTT2JqZWN0Owog ICAgIGNsYXNzIFVTdHJpbmc7CiAKKyAgICBleHRlcm4gY29uc3Qgc2l6ZV90IENFTExfTUFTSzsK KwogI2lmIFVTRShKU1ZBTFVFNjQpCiAgICAgaW5saW5lIGludHB0cl90IHJlaW50ZXJwcmV0RG91 YmxlVG9JbnRwdHIoZG91YmxlIHZhbHVlKQogICAgIHsKQEAgLTU5NSw3ICs1OTcsMTMgQEAgbmFt ZXNwYWNlIEpTQyB7CiAKICAgICBpbmxpbmUgYm9vbCBKU1ZhbHVlOjppc0NlbGwoKSBjb25zdAog ICAgIHsKKyNpZm5kZWYgTkRFQlVHCisgICAgICAgIGJvb2wgciA9ICFKU0ltbWVkaWF0ZTo6aXNJ bW1lZGlhdGUoYXNWYWx1ZSgpKTsKKyAgICAgICAgQVNTRVJUKCFyIHx8ICEoSlNJbW1lZGlhdGU6 OnJhd1ZhbHVlKGFzVmFsdWUoKSkgJiBDRUxMX01BU0spKTsKKyAgICAgICAgcmV0dXJuIHI7Cisj ZWxzZQogICAgICAgICByZXR1cm4gIUpTSW1tZWRpYXRlOjppc0ltbWVkaWF0ZShhc1ZhbHVlKCkp OworI2VuZGlmCiAgICAgfQogCiAgICAgaW5saW5lIGJvb2wgSlNWYWx1ZTo6aXNJbnQzMigpIGNv bnN0CkluZGV4OiBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTVmFsdWUuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNWYWx1ZS5jcHAJKHJldmlzaW9uIDYxNTY3KQor KysgSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1ZhbHVlLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MTI2LDEwICsxMjYsMTAgQEAgY2hhciogSlNWYWx1ZTo6ZGVzY3JpcHRpb24oKQogICAgICAgICBz bnByaW50ZihkZXNjcmlwdGlvbiwgc2l6ZSwgIkZhbHNlIik7CiAgICAgZWxzZSBpZiAoaXNOdWxs KCkpCiAgICAgICAgIHNucHJpbnRmKGRlc2NyaXB0aW9uLCBzaXplLCAiTnVsbCIpOwotICAgIGVs c2UgewotICAgICAgICBBU1NFUlQoaXNVbmRlZmluZWQoKSk7CisgICAgZWxzZSBpZiAoaXNVbmRl ZmluZWQoKSkKICAgICAgICAgc25wcmludGYoZGVzY3JpcHRpb24sIHNpemUsICJVbmRlZmluZWQi KTsKLSAgICB9CisgICAgZWxzZQorICAgICAgICBzbnByaW50ZihkZXNjcmlwdGlvbiwgc2l6ZSwg IklOVkFMSUQiKTsKIAogICAgIHJldHVybiBkZXNjcmlwdGlvbjsKIH0KSW5kZXg6IEphdmFTY3Jp cHRDb3JlL3J1bnRpbWUvSlNab21iaWUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3Jl L3J1bnRpbWUvSlNab21iaWUuY3BwCShyZXZpc2lvbiA2MTU2NykKKysrIEphdmFTY3JpcHRDb3Jl L3J1bnRpbWUvSlNab21iaWUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNyw3ICszNyw3IEBAIFN0 cnVjdHVyZSogSlNab21iaWU6OmxlYWtlZFpvbWJpZVN0cnVjdHUKICAgICBzdGF0aWMgU3RydWN0 dXJlKiBzdHJ1Y3R1cmUgPSAwOwogICAgIGlmICghc3RydWN0dXJlKSB7CiAgICAgICAgIFN0cnVj dHVyZTo6c3RhcnRJZ25vcmluZ0xlYWtzKCk7Ci0gICAgICAgIHN0cnVjdHVyZSA9IFN0cnVjdHVy ZTo6Y3JlYXRlKGpzTnVsbCgpLCBUeXBlSW5mbyhVbnNwZWNpZmllZFR5cGUpKS5yZWxlYXNlUmVm KCk7CisgICAgICAgIHN0cnVjdHVyZSA9IFN0cnVjdHVyZTo6Y3JlYXRlKGpzTnVsbCgpLCBUeXBl SW5mbyhVbnNwZWNpZmllZFR5cGUpLCAwKS5yZWxlYXNlUmVmKCk7CiAgICAgICAgIFN0cnVjdHVy ZTo6c3RvcElnbm9yaW5nTGVha3MoKTsKICAgICB9CiAgICAgcmV0dXJuIHN0cnVjdHVyZTsK