40105 2010-06-03 00:03:49 -0700 bad codecs.open in webkitpy/layout_tests/ports/websocket_server.py 2010-06-03 22:15:17 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ukai webkit-unassigned oldest_to_newest 233636 0 ukai 2010-06-03 00:03:49 -0700 In websocket_server.PyWebSocket.start() method, it open file by codecs.open(output_log, "utf-8"), but second parameter should be "r" here. Also, it would be nice to kill the websocket server process when the process is running, but url is not alive. 233642 1 57739 ukai 2010-06-03 00:17:34 -0700 Created attachment 57739 Patch 234056 2 ukai 2010-06-03 22:15:17 -0700 Committed r60654: <http://trac.webkit.org/changeset/60654> 57739 2010-06-03 00:17:34 -0700 2010-06-03 13:39:33 -0700 Patch bug-40105-20100603001732.patch text/plain 1995 ukai ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAzNjgyZjMzZDhjYzc4NDk2OTI3Y2EyMmIxOWI4MWMzODEzMTk1YzgxLi41ZjFkNDBl MGI4NmU0YjQwMGRlNDc4ODczYThiMzZmMzhlMjUzODlmIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTAtMDYtMDMgIEZ1bWl0b3NoaSBVa2FpICA8dWthaUBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgYmFkIGNvZGVjcy5vcGVu IGluIHdlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0cy93ZWJzb2NrZXRfc2VydmVyLnB5CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDEwNQorCisgICAg ICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJzb2NrZXRfc2VydmVy LnB5OgorICAgICAgICAtIGtpbGwgcHl3ZWJzb2NrZXQgcHJvY2VzcyB3aGVuIHVybCBpcyBub3Qg YWxpdmUgYW5kIHRoZSBwcm9jZXNzIGlzIG5vdAorICAgICAgICAgIHRlcm1pbmF0ZWQsIG5vdCB0 byBsZWF2ZSBweXdlYnNvY2tldCBzZXJ2ZXIgcnVubmluZy4KKyAgICAgICAgLSBmaXggY29kZWNz Lm9wZW4gcGFyYW1ldGVycy4KKwogMjAxMC0wNi0wMiAgRGllZ28gR29uemFsZXogIDxkaWVnb2hj Z0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0 aWFuc2VuLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcG9ydC93ZWJzb2NrZXRfc2VydmVyLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJzb2NrZXRfc2VydmVyLnB5CmluZGV4IDIyYWU3ODAx ZDMyYjI5ZWE2YTU0NmQ4ZWUwMjk0Njc1OTlhMDNmZTMuLjgxYmYzOWVjMjc1MjEwODgxOTBiMmI5 ZDdhMDhkZGU2YjQ0ZmQxYjcgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Vic29ja2V0X3NlcnZlci5weQorKysgYi9XZWJLaXRUb29s cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYnNvY2tldF9zZXJ2ZXIucHkK QEAgLTIwNywxMiArMjA3LDEzIEBAIGNsYXNzIFB5V2ViU29ja2V0KGh0dHBfc2VydmVyLkxpZ2h0 dHBkKToKICAgICAgICAgICAgIHVybCA9ICdodHRwJwogICAgICAgICB1cmwgPSB1cmwgKyAnOi8v MTI3LjAuMC4xOiVkLycgJSBzZWxmLl9wb3J0CiAgICAgICAgIGlmIG5vdCB1cmxfaXNfYWxpdmUo dXJsKToKLSAgICAgICAgICAgIGZwID0gY29kZWNzLm9wZW4ob3V0cHV0X2xvZywgInV0Zi04IikK LSAgICAgICAgICAgIHRyeToKKyAgICAgICAgICAgIGlmIHNlbGYuX3Byb2Nlc3MucmV0dXJuY29k ZSA9PSBOb25lOgorICAgICAgICAgICAgICAgICMgRklYTUU6IFdlIHNob3VsZCB1c2UgYSBub24t c3RhdGljIEV4ZWN1dGl2ZSBmb3IgZWFzaWVyCisgICAgICAgICAgICAgICAgIyB0ZXN0aW5nLgor ICAgICAgICAgICAgICAgIEV4ZWN1dGl2ZSgpLmtpbGxfcHJvY2VzcyhzZWxmLl9wcm9jZXNzLnBp ZCkKKyAgICAgICAgICAgIHdpdGggY29kZWNzLm9wZW4ob3V0cHV0X2xvZywgInIiLCAidXRmLTgi KSBhcyBmcDoKICAgICAgICAgICAgICAgICBmb3IgbGluZSBpbiBmcDoKICAgICAgICAgICAgICAg ICAgICAgX2xvZy5lcnJvcihsaW5lKQotICAgICAgICAgICAgZmluYWxseToKLSAgICAgICAgICAg ICAgICBmcC5jbG9zZSgpCiAgICAgICAgICAgICByYWlzZSBQeVdlYlNvY2tldE5vdFN0YXJ0ZWQo CiAgICAgICAgICAgICAgICAgJ0ZhaWxlZCB0byBzdGFydCAlcyBzZXJ2ZXIgb24gcG9ydCAlcy4n ICUKICAgICAgICAgICAgICAgICAgICAgKHNlbGYuX3NlcnZlcl9uYW1lLCBzZWxmLl9wb3J0KSkK