40102 2010-06-02 21:25:59 -0700 WebCore EventHandler needs to take account of onLoad events fired before layout() complete 2011-04-19 05:15:29 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Other Linux CLOSED FIXED Qt, QtTriaged P2 Normal --- 39918 1 tkent webkit-unassigned ap hausmann hyatt kenneth laszlo.gombos ossy robert thakis oldest_to_newest 233597 0 tkent 2010-06-02 21:25:59 -0700 editing/input/page-up-down-scrolls.html, which was introduced by r60591, fails on Qt Linux. 233613 1 thakis 2010-06-02 22:27:46 -0700 Does webkit/qt/linux have sendEvent in its DRT? Are there instructions on how to build webkit/qt/linux somewhere? How is it normally handled when a new test fails only on a subset of ports? 233654 2 ossy 2010-06-03 01:08:10 -0700 pretty diff can be found here: http://build.webkit.org/results/Qt%20Linux%20Release/r60591%20%2812729%29/editing/input/page-up-down-scrolls-pretty-diff.html Yes, Qt-DRT has sendEvent, pageUp and pageDown should be handled. This test fails only on Qt port, so it was a correct solution. We usually file a bug and put the test into the skipped list as you did. And then somebody will try to fix the bug. (If you would like to build QtWebKit on Linux, try to follow http://trac.webkit.org/wiki/BuildingQtOnLinux . But I'm not sure if it is an absolutely perfect and up-to-date documentation.) 234579 3 ossy 2010-06-05 02:04:49 -0700 Simon, what do you think, is it a release blocker? Or should we simple cherry-pick http://trac.webkit.org/changeset/60600 which add editing/input/page-up-down-scrolls.html to the Skipped list? 235368 4 laszlo.gombos 2010-06-08 11:04:13 -0700 I do not think this is a release blocker - keeping it with P2 priority. 235763 5 ossy 2010-06-09 06:51:17 -0700 (In reply to comment #4) > I do not think this is a release blocker - keeping it with P2 priority. OK, but if it isn't a release blocker, we should cherry-pick http://trac.webkit.org/changeset/60600 to make buildbot happier. Simon, could you do it? 237543 6 robert 2010-06-13 04:52:45 -0700 This is failing because WebCore 'cheats' by firing the onLoad event before the FrameView has performed its final layout(). This is deliberate on the part of WebCore, from implicitClose() in Document.cpp (1862): // Make sure both the initial layout and reflow happen after the onload // fires. This will improve onload scores, and other browsers do it. // If they wanna cheat, we can too. -dwh So at first glance you'd think Qt needs to ensure that it forces the layout before acting on onLoad events that need to know the correct layout, which is presumably what other ports do. In the case of this test, QWebPagePrivate::handleScrolling() could always check that the layout is final before doing anything - but that's just one possible situation. Qt doesn't know it's acting on an onLoad event so there doesn't appear to be a way of doing this in a generic that way will cover all cases. This also seems to me like something WebCore should be looking after anyway - since it's the one that's 'cheating'. That said, I've no idea why this only fails for Qt - maybe it's something to do the way it queues events. 237544 7 58591 robert 2010-06-13 05:04:08 -0700 Created attachment 58591 Patch 237545 8 robert 2010-06-13 05:07:45 -0700 (In reply to comment #7) > Created an attachment (id=58591) [details] > Patch This patch makes WebCore take account of it's own 'cheating' on the firing of eventLoad handlers. I think this is the correct thing to do, it seems unfair to make ports worry about whether the layout is ready when processing onLoad events. 237546 9 kenneth 2010-06-13 05:50:03 -0700 It is a bit confusing that the patch says [Qt] and only touches WebCore code. 237547 10 kenneth 2010-06-13 05:51:38 -0700 (In reply to comment #9) > It is a bit confusing that the patch says [Qt] and only touches WebCore code. I was commenting on the WebCore changelog: 5 [Qt] editing/input/page-up-down-scrolls.html failure 6 7 https://bugs.webkit.org/show_bug.cgi?id=40102 Shouldn't this be WebCore EventHandler needs to take account of onLoad events fired before layout() complete https://bugs.webkit.org/show_bug.cgi?id=40102 instead? 237550 11 robert 2010-06-13 06:18:18 -0700 (In reply to comment #10) > (In reply to comment #9) > > It is a bit confusing that the patch says [Qt] and only touches WebCore code. > > I was commenting on the WebCore changelog: > > 5 [Qt] editing/input/page-up-down-scrolls.html failure > 6 > 7 https://bugs.webkit.org/show_bug.cgi?id=40102 > > Shouldn't this be > > WebCore EventHandler needs to take account of onLoad events fired before layout() complete > https://bugs.webkit.org/show_bug.cgi?id=40102 > > instead? I changed the bug title after uploading the patch! 238057 12 58704 robert 2010-06-14 14:48:22 -0700 Created attachment 58704 Patch 238174 13 58704 kenneth 2010-06-14 17:56:02 -0700 Comment on attachment 58704 Patch Seems OK with me. 238365 14 hausmann 2010-06-15 06:59:25 -0700 This should be included in the release branch, as r60591 is also included and the test indeed fails on the release branch at the moment. 239599 15 robert 2010-06-17 15:20:18 -0700 Committed r61353: <http://trac.webkit.org/changeset/61353> 239652 16 ap 2010-06-17 17:02:34 -0700 > WebCore 'cheats' by firing onLoad events before the frame's layout Why are you saying so? Do we violate any specification? 239658 17 kenneth 2010-06-17 17:08:43 -0700 (In reply to comment #16) > > WebCore 'cheats' by firing onLoad events before the frame's layout > > Why are you saying so? Do we violate any specification? Please read comment #6, it explains it 239662 18 ap 2010-06-17 17:14:33 -0700 Thanks, that explains why ChangeLog said so. But it's not clear to me if this ancient comment is accurate. 239888 19 hausmann 2010-06-18 06:01:47 -0700 Revision r61353 cherry-picked into qtwebkit-2.0 with commit e32cb21d4f1787147bcb681883b96a95f867749a 58591 2010-06-13 05:04:08 -0700 2010-06-14 14:48:12 -0700 Patch bug-40102-20100613130407.patch text/plain 3408 robert ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA3OTlkY2JmMjVlZDY2OGFhMmQzOTQyNmNlODZjY2M3MDlhY2NhNDExLi5jZmNlMWQz MjczYjEyOWU5YWVmOGRmNzVmOTEwZDlmOWIyYTZkYjk3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAK KzIwMTAtMDYtMTMgIFJvYmVydCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gZWRpdGluZy9pbnB1 dC9wYWdlLXVwLWRvd24tc2Nyb2xscy5odG1sIGZhaWx1cmUKKworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDAxMDIKKworICAgICAgICBXZWJDb3JlICdj aGVhdHMnIGJ5IGZpcmluZyBvbkxvYWQgZXZlbnRzIGJlZm9yZSB0aGUgZnJhbWUncyBsYXlvdXQK KyAgICAgICAgaGFzIGJlZW4gcGVyZm9ybWVkLiBUaGlzIGNhbiByZXN1bHQgaW4gZXZlbnQgbGlz dGVuZXJzIHBlcmZvcm1pbmcKKyAgICAgICAgb3BlcmF0aW9ucyB0aGF0IGRlcGVuZCBvbiB0aGUg ZG9jdW1lbnQncyBmaW5hbCBsYXlvdXQsIHN1Y2ggYXMKKyAgICAgICAgc2Nyb2xsaW5nIG9wZXJh dGlvbnMuCisKKyAgICAgICAgV2hlbiBzY3JvbGxpbmcgYSBmcmFtZXZpZXcgaW4gZXZlbnRoYW5k bGVyIGVuc3VyZSB0aGUgbGF5b3V0IGlzIGNvbXBsZXRlLgorCisgICAgICAgICogcGxhdGZvcm0v cXQvU2tpcHBlZDogVW5za2lwIGVkaXRpbmcvaW5wdXQvcGFnZS11cC1kb3duLXNjcm9sbHMuaHRt bAorCiAyMDEwLTA2LTEyICBEbWl0cnkgVGl0b3YgIDxkaW1pY2hAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIE5vdCByZXZpZXdlZCwgdXBkYXRlIENocm9taXVtIGV4cGVjdGVkIHJlc3VsdCBmb2xs b3dpbmcgcjYxMDcxLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBl ZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKaW5kZXggODNlZDdlNGIzMmQyNTdh MjljYTY2MzlkYTdiMDM2MmU3N2Q4M2UxMi4uYzRiM2U3OGZkZDE4Nzg1NmE0NGM3YzIxNDdkM2Jk M2MwODVhNGYwOSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAor KysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCkBAIC04NjQsOSArODY0LDYgQEAg ZmFzdC9ydWJ5L3J1YnlET00tcmVtb3ZlLXRleHQyLmh0bWwKICMgLS0tLS0tLSBmYWlsaW5nIGVk aXRpbmcvaW5wdXQgdGVzdHMKICMgPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0gIwogCi0jIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDEwMgotZWRpdGluZy9pbnB1dC9wYWdl LXVwLWRvd24tc2Nyb2xscy5odG1sCi0KIGVkaXRpbmcvaW5wdXQvZW1hY3MtY3RybC1vLmh0bWwK IAogIyA9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PSAjCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxv ZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDY4YzVlNGViNjE4Mjg1MmE2YTY3MjI0MTU1MzU5 OTA4NTdiN2UwOGIuLjMyMjAzYTZlMmJiNGQyZjQ2YmViZDQzM2RmYmI5YTYxNzJjMjM2ZjggMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMjEgQEAKKzIwMTAtMDYtMTMgIFJvYmVydCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0g ZWRpdGluZy9pbnB1dC9wYWdlLXVwLWRvd24tc2Nyb2xscy5odG1sIGZhaWx1cmUKKworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDAxMDIKKworICAgICAg ICBXZWJDb3JlICdjaGVhdHMnIGJ5IGZpcmluZyBvbkxvYWQgZXZlbnRzIGJlZm9yZSB0aGUgZnJh bWUncyBsYXlvdXQKKyAgICAgICAgaGFzIGJlZW4gcGVyZm9ybWVkLiBUaGlzIGNhbiByZXN1bHQg aW4gZXZlbnQgbGlzdGVuZXJzIHBlcmZvcm1pbmcKKyAgICAgICAgb3BlcmF0aW9ucyB0aGF0IGRl cGVuZCBvbiB0aGUgZG9jdW1lbnQncyBmaW5hbCBsYXlvdXQsIHN1Y2ggYXMKKyAgICAgICAgc2Ny b2xsaW5nIG9wZXJhdGlvbnMuCisKKyAgICAgICAgV2hlbiBzY3JvbGxpbmcgYSBmcmFtZXZpZXcg aW4gZXZlbnRoYW5kbGVyIGVuc3VyZSB0aGUgbGF5b3V0IGlzIGNvbXBsZXRlLgorCisgICAgICAg ICogcGFnZS9FdmVudEhhbmRsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRIYW5kbGVy OjpzY3JvbGxSZWN1cnNpdmVseSk6CisKIDIwMTAtMDYtMTMgIE5vYW0gUm9zZW50aGFsICA8bm9h bS5yb3NlbnRoYWxAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVy LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAgYi9XZWJDb3JlL3Bh Z2UvRXZlbnRIYW5kbGVyLmNwcAppbmRleCBjMDJjMGRiMDgxNDUzNzBlYTA3MzFmMzZhYTgyMDNl OGI1Y2M0YjlhLi43N2FjYTcxODEzYzY1YWYzNjM3YzA0YzljMTlmZDE3YmQ5N2RjMDljIDEwMDY0 NAotLS0gYS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAorKysgYi9XZWJDb3JlL3BhZ2Uv RXZlbnRIYW5kbGVyLmNwcApAQCAtOTk1LDYgKzk5NSw5IEBAIGJvb2wgRXZlbnRIYW5kbGVyOjpz Y3JvbGxPdmVyZmxvdyhTY3JvbGxEaXJlY3Rpb24gZGlyZWN0aW9uLCBTY3JvbGxHcmFudWxhcml0 eSBnCiAKIGJvb2wgRXZlbnRIYW5kbGVyOjpzY3JvbGxSZWN1cnNpdmVseShTY3JvbGxEaXJlY3Rp b24gZGlyZWN0aW9uLCBTY3JvbGxHcmFudWxhcml0eSBncmFudWxhcml0eSwgTm9kZSogc3RhcnRp bmdOb2RlKQogeworICAgIC8vIFRoZSBsYXlvdXQgbmVlZHMgdG8gYmUgdXAgdG8gZGF0ZSB0byBk ZXRlcm1pbmUgaWYgd2UgY2FuIHNjcm9sbC4gV2UgbWF5IGJlCisgICAgLy8gaGVyZSBiZWNhdXNl IG9mIGFuIG9uTG9hZCBldmVudCwgaW4gd2hpY2ggY2FzZSB0aGUgZmluYWwgbGF5b3V0IGhhc24n dCBiZWVuIHBlcmZvcm1lZCB5ZXQuCisgICAgbV9mcmFtZS0+ZG9jdW1lbnQoKS0+dXBkYXRlTGF5 b3V0SWdub3JlUGVuZGluZ1N0eWxlc2hlZXRzKCk7CiAgICAgYm9vbCBoYW5kbGVkID0gc2Nyb2xs T3ZlcmZsb3coZGlyZWN0aW9uLCBncmFudWxhcml0eSwgc3RhcnRpbmdOb2RlKTsKICAgICBpZiAo IWhhbmRsZWQpIHsKICAgICAgICAgRnJhbWUqIGZyYW1lID0gbV9mcmFtZTsK 58704 2010-06-14 14:48:22 -0700 2010-06-14 17:56:02 -0700 Patch bug-40102-20100614224820.patch text/plain 3530 robert ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5ZGQ3MTMwNjJhMjgwNDhkZTMzODBiMGEyNjlhM2NhZTgwZjJhMWJhLi5hODBlYjBk ZGEyMzFlYTA1OTljNDM5YjBjZDI0NDBiNTUwMzE2ZjczIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAK KzIwMTAtMDYtMTMgIFJvYmVydCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYkNvcmUgRXZlbnRIYW5k bGVyIG5lZWRzIHRvIHRha2UgYWNjb3VudCBvZiBvbkxvYWQgZXZlbnRzIGZpcmVkIAorICAgICAg ICBiZWZvcmUgbGF5b3V0KCkgY29tcGxldGUKKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDAxMDIKKworICAgICAgICBXZWJDb3JlICdjaGVhdHMnIGJ5 IGZpcmluZyBvbkxvYWQgZXZlbnRzIGJlZm9yZSB0aGUgZnJhbWUncyBsYXlvdXQKKyAgICAgICAg aGFzIGJlZW4gcGVyZm9ybWVkLiBUaGlzIGNhbiByZXN1bHQgaW4gZXZlbnQgbGlzdGVuZXJzIHBl cmZvcm1pbmcKKyAgICAgICAgb3BlcmF0aW9ucyB0aGF0IGRlcGVuZCBvbiB0aGUgZG9jdW1lbnQn cyBmaW5hbCBsYXlvdXQsIHN1Y2ggYXMKKyAgICAgICAgc2Nyb2xsaW5nIG9wZXJhdGlvbnMuCisK KyAgICAgICAgV2hlbiBzY3JvbGxpbmcgYSBmcmFtZXZpZXcgaW4gZXZlbnRoYW5kbGVyIGVuc3Vy ZSB0aGUgbGF5b3V0IGlzIGNvbXBsZXRlLgorCisgICAgICAgICogcGxhdGZvcm0vcXQvU2tpcHBl ZDogVW5za2lwIGVkaXRpbmcvaW5wdXQvcGFnZS11cC1kb3duLXNjcm9sbHMuaHRtbAorCiAyMDEw LTA2LTE0ICBEbWl0cnkgVGl0b3YgIDxkaW1pY2hAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVu cmV2aWV3ZWQsIHRlbXBvcmFyeSB1cGRhdGUgQ2hyb21pdW0gZXhwZWN0YXRpb25zIGFmdGVyIGh0 dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzYxMTI4CmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBl ZAppbmRleCAyOWEwY2Y2MjBkZjMyYmMwNGQ0Mjc0NjE0NTU0NTBlM2FlYzAzNDA2Li5jY2UwYTgy YWY3YjRjMDEwOTllYzI5ZmY1Mjc1ODgyNWRhYzVlMzE2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBw ZWQKQEAgLTg2MSw5ICs4NjEsNiBAQCBmYXN0L3J1YnkvcnVieURPTS1yZW1vdmUtdGV4dDIuaHRt bAogIyAtLS0tLS0tIGZhaWxpbmcgZWRpdGluZy9pbnB1dCB0ZXN0cwogIyA9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PSAjCiAKLSMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQw MTAyCi1lZGl0aW5nL2lucHV0L3BhZ2UtdXAtZG93bi1zY3JvbGxzLmh0bWwKLQogZWRpdGluZy9p bnB1dC9lbWFjcy1jdHJsLW8uaHRtbAogCiAjID09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ICMKZGlmZiAt LWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzdhZmU5 NDE3YzkzODE2YmMwMmU0YzBjNDIxZGFjZGYyZmFkYzRjMS4uNmU5MTgwMDA4ZDMzYjI3NmQxNWJl MTk4ZmYxYTNkNDlhNzM2NjViNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIv V2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMC0wNi0xMyAgUm9iZXJ0IEhv Z2FuICA8cm9iZXJ0QHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgV2ViQ29yZSBFdmVudEhhbmRsZXIgbmVlZHMgdG8gdGFrZSBhY2Nv dW50IG9mIG9uTG9hZCBldmVudHMgCisgICAgICAgIGZpcmVkIGJlZm9yZSBsYXlvdXQoKSBjb21w bGV0ZQorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00 MDEwMgorCisgICAgICAgIFdlYkNvcmUgJ2NoZWF0cycgYnkgZmlyaW5nIG9uTG9hZCBldmVudHMg YmVmb3JlIHRoZSBmcmFtZSdzIGxheW91dAorICAgICAgICBoYXMgYmVlbiBwZXJmb3JtZWQuIFRo aXMgY2FuIHJlc3VsdCBpbiBldmVudCBsaXN0ZW5lcnMgcGVyZm9ybWluZworICAgICAgICBvcGVy YXRpb25zIHRoYXQgZGVwZW5kIG9uIHRoZSBkb2N1bWVudCdzIGZpbmFsIGxheW91dCwgc3VjaCBh cworICAgICAgICBzY3JvbGxpbmcgb3BlcmF0aW9ucy4KKworICAgICAgICBXaGVuIHNjcm9sbGlu ZyBhIGZyYW1ldmlldyBpbiBldmVudGhhbmRsZXIgZW5zdXJlIHRoZSBsYXlvdXQgaXMgY29tcGxl dGUuCisKKyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpFdmVudEhhbmRsZXI6OnNjcm9sbFJlY3Vyc2l2ZWx5KToKKwogMjAxMC0wNi0xNCAgQW5kZXJz IENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNh bSBXZWluaWcuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcCBiL1dl YkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCmluZGV4IGMwMmMwZGIwODE0NTM3MGVhMDczMWYz NmFhODIwM2U4YjVjYzRiOWEuLjc3YWNhNzE4MTNjNjVhZjM2MzdjMDRjOWMxOWZkMTdiZDk3ZGMw OWMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCisrKyBiL1dlYkNv cmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCkBAIC05OTUsNiArOTk1LDkgQEAgYm9vbCBFdmVudEhh bmRsZXI6OnNjcm9sbE92ZXJmbG93KFNjcm9sbERpcmVjdGlvbiBkaXJlY3Rpb24sIFNjcm9sbEdy YW51bGFyaXR5IGcKIAogYm9vbCBFdmVudEhhbmRsZXI6OnNjcm9sbFJlY3Vyc2l2ZWx5KFNjcm9s bERpcmVjdGlvbiBkaXJlY3Rpb24sIFNjcm9sbEdyYW51bGFyaXR5IGdyYW51bGFyaXR5LCBOb2Rl KiBzdGFydGluZ05vZGUpCiB7CisgICAgLy8gVGhlIGxheW91dCBuZWVkcyB0byBiZSB1cCB0byBk YXRlIHRvIGRldGVybWluZSBpZiB3ZSBjYW4gc2Nyb2xsLiBXZSBtYXkgYmUKKyAgICAvLyBoZXJl IGJlY2F1c2Ugb2YgYW4gb25Mb2FkIGV2ZW50LCBpbiB3aGljaCBjYXNlIHRoZSBmaW5hbCBsYXlv dXQgaGFzbid0IGJlZW4gcGVyZm9ybWVkIHlldC4KKyAgICBtX2ZyYW1lLT5kb2N1bWVudCgpLT51 cGRhdGVMYXlvdXRJZ25vcmVQZW5kaW5nU3R5bGVzaGVldHMoKTsKICAgICBib29sIGhhbmRsZWQg PSBzY3JvbGxPdmVyZmxvdyhkaXJlY3Rpb24sIGdyYW51bGFyaXR5LCBzdGFydGluZ05vZGUpOwog ICAgIGlmICghaGFuZGxlZCkgewogICAgICAgICBGcmFtZSogZnJhbWUgPSBtX2ZyYW1lOwo=