40095 2010-06-02 18:30:05 -0700 webkit-patch apply-from-bug / apply-attachment should not ask for credentials if none are required 2015-07-06 12:07:15 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED WONTFIX P2 Normal --- 1 jamesr youennf bunhere cdumez commit-queue dbates glenn gyuyoung.kim jchaffraix ossy sergio youennf oldest_to_newest 233549 0 jamesr 2010-06-02 18:30:05 -0700 Currently when running webkit-patch apply-from-bug or apply-attachment I am always prompted for access to bugzilla credentials. These are not needed to simply download a patch unless the bug is restricted and so the default should be to not prompt unless webkit-patch gets a 403 when trying to fetch the patch or attachment. 1019607 1 234158 youennf 2014-07-01 05:12:55 -0700 Created attachment 234158 Patch 1019623 2 234158 ossy 2014-07-01 07:52:25 -0700 Comment on attachment 234158 Patch It was so annoying for me to, r=me. 1019628 3 234158 commit-queue 2014-07-01 08:23:08 -0700 Comment on attachment 234158 Patch Clearing flags on attachment: 234158 Committed r170639: <http://trac.webkit.org/changeset/170639> 1019629 4 commit-queue 2014-07-01 08:23:11 -0700 All reviewed patches have been landed. Closing bug. 1107121 5 dbates 2015-07-06 09:59:12 -0700 (In reply to comment #3) > Comment on attachment 234158 [details] > Patch > > Clearing flags on attachment: 234158 > > Committed r170639: <http://trac.webkit.org/changeset/170639> This patch broke using webkit-patch apply-attachment to apply an attachment from a security bug: dbates2-ruby:OpenSource dbates$ Tools/Scripts/webkit-patch apply-attachment --no-update 255825 Fetching: https://bugs.webkit.org/attachment.cgi?id=255825&action=edit Traceback (most recent call last): File "Tools/Scripts/webkit-patch", line 84, in <module> main() File "Tools/Scripts/webkit-patch", line 79, in main WebKitPatch(os.path.abspath(__file__)).main() File "/Volumes/Data/WebKitDevGit/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main result = command.check_arguments_and_execute(options, args, self) File "/Volumes/Data/WebKitDevGit/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Volumes/Data/WebKitDevGit/OpenSource/Tools/Scripts/webkitpy/tool/commands/download.py", line 173, in execute bugs_to_patches = self._collect_patches_by_bug(patches) File "/Volumes/Data/WebKitDevGit/OpenSource/Tools/Scripts/webkitpy/tool/commands/download.py", line 165, in _collect_patches_by_bug bugs_to_patches[patch.bug_id()] = bugs_to_patches.get(patch.bug_id(), []) + [patch] AttributeError: 'NoneType' object has no attribute 'bug_id' 1107122 6 dbates 2015-07-06 10:05:58 -0700 The patch (attachment #234158) assumes that Bugzilla will return a web page with a non-HTTP 200 status code when authentication is required. Bugzilla always returns a page with an HTTP 200 status code regardless of whether authentication is required. 1107125 7 dbates 2015-07-06 10:06:14 -0700 Will rollout patch. 1107126 8 dbates 2015-07-06 10:11:18 -0700 Reverted r170639 for reason: Broke using webkit-patch apply-attachment to apply an attachment from a security bug. The patch incorrectly assumed that Bugzilla returns a non-HTTP 200 status code in its HTTP response when authentication is required. Committed r186356: <http://trac.webkit.org/changeset/186356> 1107138 9 youennf 2015-07-06 10:46:43 -0700 (In reply to comment #8) > Reverted r170639 for reason: > > Broke using webkit-patch apply-attachment to apply an attachment from a > security bug. The patch incorrectly assumed that Bugzilla returns a non-HTTP > 200 status code in its HTTP response when authentication is required. > > Committed r186356: <http://trac.webkit.org/changeset/186356> With the last bugzilla bump revision, credentials are actually needed for these requests. I guess this bug could be marked as WONTFIX. 1107176 10 ossy 2015-07-06 12:07:15 -0700 Unfortunately credentials are always needed with the new bugzilla, so let's close it as wontfix. 234158 2014-07-01 05:12:55 -0700 2014-07-01 08:23:07 -0700 Patch bug-40095-20140626200246.patch text/plain 2627 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwNDE2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTIyOWYwMWU0YzU5YjM0ODlkNmNhMWYyYzllMzM3MmMw YTRiZDJkYi4uZjZkNTZiNTM0MTYxYjg2ZWI1YTczYTJjMGE2OGQ5NTQwYTBjNzk0NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE0LTA2LTI2ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24u ZnI+CisKKyAgICAgICAgd2Via2l0LXBhdGNoIGFwcGx5LWZyb20tYnVnIC8gYXBwbHktYXR0YWNo bWVudCBzaG91bGQgbm90IGFzayBmb3IgY3JlZGVudGlhbHMgaWYgbm9uZSBhcmUgcmVxdWlyZWQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwMDk1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVnemlsbGEvYnVnemlsbGEucHk6CisgICAgICAgIChCdWd6 aWxsYS5mZXRjaF9hdHRhY2htZW50X2NvbnRlbnRzKTogbWFrZSBhIGZpcnN0IGZldGNoIG9uIGJ1 Z3ppbGxhIHdpdGhvdXQgYXV0aGVudGljYXRpb24uIElmIGZhaWxpbmcsIHVzZSBhdXRoZW50aWNh dGlvbiAoc2ltaWxhciB0byBmZXRjaF9idWdfZGljdGlvbmFyeSkuCisgICAgICAgIChCdWd6aWxs YSk6CisgICAgICAgIChCdWd6aWxsYS5idWdfaWRfZm9yX2F0dGFjaG1lbnRfaWQpOiBkaXR0by4K KwogMjAxNC0wNi0yNCAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgog CiAgICAgICAgIFVucmV2aWV3ZWQsIHVwZGF0ZSBteSBzcGVjaWFsaXR5LgpkaWZmIC0tZ2l0IGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1Z3ppbGxhL2J1Z3ppbGxhLnB5IGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1Z3ppbGxhL2J1Z3ppbGxhLnB5Cmlu ZGV4IGM3MmM4MDNhYmVmMTVhMzUzM2ZkMzVmYTljM2IyMzdlYjAwNDE3ODEuLjcxNDJiY2YwY2Qy ZWU3MjIzYmFlYWU3YTZjMDFmZTU3MDdkZWJmNDcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvY29tbW9uL25ldC9idWd6aWxsYS9idWd6aWxsYS5weQorKysgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVnemlsbGEvYnVnemlsbGEucHkKQEAgLTQ4Myw5ICs0 ODMsMTIgQEAgY2xhc3MgQnVnemlsbGEob2JqZWN0KToKIAogICAgIGRlZiBmZXRjaF9hdHRhY2ht ZW50X2NvbnRlbnRzKHNlbGYsIGF0dGFjaG1lbnRfaWQpOgogICAgICAgICBhdHRhY2htZW50X3Vy bCA9IHNlbGYuYXR0YWNobWVudF91cmxfZm9yX2lkKGF0dGFjaG1lbnRfaWQpCi0gICAgICAgICMg V2UgbmVlZCB0byBhdXRoZW50aWNhdGUgdG8gZG93bmxvYWQgcGF0Y2hlcyBmcm9tIHNlY3VyaXR5 IGJ1Z3MuCi0gICAgICAgIHNlbGYuYXV0aGVudGljYXRlKCkKLSAgICAgICAgcmV0dXJuIHNlbGYu YnJvd3Nlci5vcGVuKGF0dGFjaG1lbnRfdXJsKS5yZWFkKCkKKyAgICAgICAgIyBXZSBtYXkgbmVl ZCB0byBhdXRoZW50aWNhdGUgdG8gZG93bmxvYWQgcGF0Y2hlcyBmcm9tIHNlY3VyaXR5IGJ1Z3Mu CisgICAgICAgIHRyeToKKyAgICAgICAgICAgIHJldHVybiBzZWxmLmJyb3dzZXIub3BlbihhdHRh Y2htZW50X3VybCkucmVhZCgpCisgICAgICAgIGV4Y2VwdDoKKyAgICAgICAgICAgIHNlbGYuYXV0 aGVudGljYXRlKCkKKyAgICAgICAgICAgIHJldHVybiBzZWxmLmJyb3dzZXIub3BlbihhdHRhY2ht ZW50X3VybCkucmVhZCgpCiAKICAgICBkZWYgX3BhcnNlX2J1Z19pZF9mcm9tX2F0dGFjaG1lbnRf cGFnZShzZWxmLCBwYWdlKToKICAgICAgICAgIyBUaGUgIlVwIiByZWxhdGlvbiBoYXBwZW5zIHRv IHBvaW50IHRvIHRoZSBidWcuCkBAIC00OTgsMTEgKzUwMSwxMyBAQCBjbGFzcyBCdWd6aWxsYShv YmplY3QpOgogICAgICAgICByZXR1cm4gaW50KG1hdGNoLmdyb3VwKCdidWdfaWQnKSkKIAogICAg IGRlZiBidWdfaWRfZm9yX2F0dGFjaG1lbnRfaWQoc2VsZiwgYXR0YWNobWVudF9pZCk6Ci0gICAg ICAgIHNlbGYuYXV0aGVudGljYXRlKCkKLQogICAgICAgICBhdHRhY2htZW50X3VybCA9IHNlbGYu YXR0YWNobWVudF91cmxfZm9yX2lkKGF0dGFjaG1lbnRfaWQsICdlZGl0JykKICAgICAgICAgX2xv Zy5pbmZvKCJGZXRjaGluZzogJXMiICUgYXR0YWNobWVudF91cmwpCi0gICAgICAgIHBhZ2UgPSBz ZWxmLmJyb3dzZXIub3BlbihhdHRhY2htZW50X3VybCkKKyAgICAgICAgdHJ5OgorICAgICAgICAg ICAgcGFnZSA9IHNlbGYuYnJvd3Nlci5vcGVuKGF0dGFjaG1lbnRfdXJsKQorICAgICAgICBleGNl cHQ6CisgICAgICAgICAgICBzZWxmLmF1dGhlbnRpY2F0ZSgpCisgICAgICAgICAgICBwYWdlID0g c2VsZi5icm93c2VyLm9wZW4oYXR0YWNobWVudF91cmwpCiAgICAgICAgIHJldHVybiBzZWxmLl9w YXJzZV9idWdfaWRfZnJvbV9hdHRhY2htZW50X3BhZ2UocGFnZSkKIAogICAgICMgRklYTUU6IFRo aXMgc2hvdWxkIGp1c3QgcmV0dXJuIEF0dGFjaG1lbnQoaWQpLCB3aGljaCBzaG91bGQgYmUgYWJs ZSB0bwo=