40090 2010-06-02 17:02:57 -0700 Set attributes.stencil to false by default at context creation 2010-06-04 00:42:24 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 zmo zmo cmarrin commit-queue kbr oliver oldest_to_newest 233507 0 zmo 2010-06-02 17:02:57 -0700 Seemed like on certain Mac with ATI cards, turning on stencil causes fps to drop tremendously. See https://bugs.webkit.org/show_bug.cgi?id=38560. 233509 1 kbr 2010-06-02 17:04:36 -0700 This requires a WebGL specification change, but one which has basically already been agreed upon by the WebGL working group. 233524 2 57718 zmo 2010-06-02 17:34:39 -0700 Created attachment 57718 patch 233537 3 kbr 2010-06-02 17:55:16 -0700 (In reply to comment #2) > Created an attachment (id=57718) [details] > patch This looks okay, but it must not be committed until the associated changes have been made to the WebGL spec. I'll try to get this approved by the working group tomorrow morning. Are all of the other WebGL layout tests working with this change? In other words, there weren't any others dependent on the previous default of stencil=true? 233554 4 zmo 2010-06-02 18:44:52 -0700 Yes, all the tests pass with this change. 233581 5 57718 levin 2010-06-02 19:56:05 -0700 Comment on attachment 57718 patch Please set the r?/cq? when "the associated changes have been made to the WebGL spec" since "it must not be committed until" then. Until then it is just cluttering a really full review queue and nothing can be done for it. 233869 6 kbr 2010-06-03 12:21:55 -0700 The WebGL spec has been updated to indicate that the default value of the stencil flag is false. The patch looks good to me. 233904 7 57718 dglazkov 2010-06-03 13:46:52 -0700 Comment on attachment 57718 patch ok. 234084 8 57718 commit-queue 2010-06-04 00:42:15 -0700 Comment on attachment 57718 patch Clearing flags on attachment: 57718 Committed r60660: <http://trac.webkit.org/changeset/60660> 234085 9 commit-queue 2010-06-04 00:42:24 -0700 All reviewed patches have been landed. Closing bug. 57718 2010-06-02 17:34:39 -0700 2010-06-04 00:42:15 -0700 patch stencil_off.patch text/plain 3356 zmo SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MDU4MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDYtMDIgIFpoZW55YW8gTW8gIDx6bW9AZ29vZ2xlLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTZXQgYXR0 cmlidXRlcy5zdGVuY2lsIHRvIGZhbHNlIGJ5IGRlZmF1bHQgYXQgY29udGV4dCBjcmVhdGlvbgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDAwOTAKKwor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNELmg6IFNldCBkZWZh dWx0IGF0dHJpYnV0ZXMuc3RlbmNpbCB0byBmYWxzZS4KKyAgICAgICAgKFdlYkNvcmU6OkdyYXBo aWNzQ29udGV4dDNEOjpBdHRyaWJ1dGVzOjpBdHRyaWJ1dGVzKToKKwogMjAxMC0wNi0wMiAgS2Vu bmV0aCBSdXNzZWxsICA8a2JyQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFy aW4gRmlzaGVyLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRl eHQzRC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3ND b250ZXh0M0QuaAkocmV2aXNpb24gNjA1NjgpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L0dyYXBoaWNzQ29udGV4dDNELmgJKHdvcmtpbmcgY29weSkKQEAgLTM5OCw3ICszOTgsNyBAQCBu YW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgICAgICBBdHRyaWJ1dGVzKCkKICAgICAgICAgICAg ICAgICA6IGFscGhhKHRydWUpCiAgICAgICAgICAgICAgICAgLCBkZXB0aCh0cnVlKQotICAgICAg ICAgICAgICAgICwgc3RlbmNpbCh0cnVlKQorICAgICAgICAgICAgICAgICwgc3RlbmNpbChmYWxz ZSkKICAgICAgICAgICAgICAgICAsIGFudGlhbGlhcyh0cnVlKQogICAgICAgICAgICAgICAgICwg cHJlbXVsdGlwbGllZEFscGhhKHRydWUpCiAgICAgICAgICAgICB7CkluZGV4OiBMYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lv biA2MDU4MykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDEwLTA2LTAyICBaaGVueWFvIE1vICA8em1vQGdvb2dsZS5jb20+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2V0IGF0dHJpYnV0 ZXMuc3RlbmNpbCB0byBmYWxzZSBieSBkZWZhdWx0IGF0IGNvbnRleHQgY3JlYXRpb24KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwMDkwCisKKyAgICAg ICAgKiBmYXN0L2NhbnZhcy93ZWJnbC9jb250ZXh0LWF0dHJpYnV0ZXMtZXhwZWN0ZWQudHh0OiBD aGVjayBpZiB0aGUgZGVmYXVsdCBhdHRyaWJ1dGVzLnN0ZW5jaWwgPT0gZmFsc2UuCisgICAgICAg ICogZmFzdC9jYW52YXMvd2ViZ2wvY29udGV4dC1hdHRyaWJ1dGVzLmh0bWw6IERpdHRvLgorCiAy MDEwLTA2LTAyICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAog ICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByNjA1ODAuCkluZGV4OiBMYXlvdXRUZXN0 cy9mYXN0L2NhbnZhcy93ZWJnbC9jb250ZXh0LWF0dHJpYnV0ZXMtZXhwZWN0ZWQudHh0Cj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2NvbnRleHQtYXR0cmlidXRl cy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDYwNTY4KQorKysgTGF5b3V0VGVzdHMvZmFzdC9jYW52 YXMvd2ViZ2wvY29udGV4dC1hdHRyaWJ1dGVzLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpA QCAtNyw3ICs3LDcgQEAgUEFTUyBjb250ZXh0ID0gY3JlYXRlM0RDb250ZXh0KCkgaXMgbm9uLQog UEFTUyBhdHRyaWJzID0gY29udGV4dC5nZXRDb250ZXh0QXR0cmlidXRlcygpIGlzIG5vbi1udWxs LgogUEFTUyBhdHRyaWJzLmRlcHRoIGlzIHRydWUKIFBBU1MgYXR0cmlicy5hbHBoYSBpcyB0cnVl Ci1QQVNTIGF0dHJpYnMuc3RlbmNpbCA9PSB0cnVlIHx8IGF0dHJpYnMuc3RlbmNpbCA9PSBmYWxz ZSBpcyB0cnVlCitQQVNTIGF0dHJpYnMuc3RlbmNpbCBpcyBmYWxzZQogUEFTUyBhdHRyaWJzLmFu dGlhbGlhcyA9PSB0cnVlIHx8IGF0dHJpYnMuYW50aWFsaWFzID09IGZhbHNlIGlzIHRydWUKIFBB U1MgYXR0cmlicy5wcmVtdWx0aXBsaWVkQWxwaGEgaXMgdHJ1ZQogVGVzdCBjdXN0b21pemVkIHZh bHVlcwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvY29udGV4dC1hdHRyaWJ1 dGVzLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvY29u dGV4dC1hdHRyaWJ1dGVzLmh0bWwJKHJldmlzaW9uIDYwNTY4KQorKysgTGF5b3V0VGVzdHMvZmFz dC9jYW52YXMvd2ViZ2wvY29udGV4dC1hdHRyaWJ1dGVzLmh0bWwJKHdvcmtpbmcgY29weSkKQEAg LTE4LDcgKzE4LDcgQEAgc2hvdWxkQmVOb25OdWxsKCJjb250ZXh0ID0gY3JlYXRlM0RDb250ZQog c2hvdWxkQmVOb25OdWxsKCJhdHRyaWJzID0gY29udGV4dC5nZXRDb250ZXh0QXR0cmlidXRlcygp Iik7CiBzaG91bGRCZSgiYXR0cmlicy5kZXB0aCIsICJ0cnVlIik7CiBzaG91bGRCZSgiYXR0cmli cy5hbHBoYSIsICJ0cnVlIik7Ci1zaG91bGRCZSgiYXR0cmlicy5zdGVuY2lsID09IHRydWUgfHwg YXR0cmlicy5zdGVuY2lsID09IGZhbHNlIiwgInRydWUiKTsKK3Nob3VsZEJlKCJhdHRyaWJzLnN0 ZW5jaWwiLCAiZmFsc2UiKTsKIC8vIEFudGlhbGlhcyBpcyByZXF1ZXN0ZWQgYnkgZGVmYXVsdCwg YnV0IG1pZ2h0IG9yIG1pZ2h0IG5vdCBiZSBzdXBwb3J0ZWQuCiBzaG91bGRCZSgiYXR0cmlicy5h bnRpYWxpYXMgPT0gdHJ1ZSB8fCBhdHRyaWJzLmFudGlhbGlhcyA9PSBmYWxzZSIsICJ0cnVlIik7 CiBzaG91bGRCZSgiYXR0cmlicy5wcmVtdWx0aXBsaWVkQWxwaGEiLCAidHJ1ZSIpOwo=