40088 2010-06-02 16:26:34 -0700 webkit-patch should use a different editor env variable to avoid conflicting with prepare-ChangeLog 2011-06-17 22:58:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED WONTFIX P2 Normal --- 1 abarth abarth darin eric oldest_to_newest 233493 0 abarth 2010-06-02 16:26:34 -0700 webkit-patch should use a different editor env variable to avoid conflicting with prepare-ChangeLog 233495 1 57714 abarth 2010-06-02 16:29:35 -0700 Created attachment 57714 Patch 233498 2 57714 eric 2010-06-02 16:35:26 -0700 Comment on attachment 57714 Patch Why is it _APPLICATION? Seems should just be _EDITOR since it's actually a terminal program. xed --launch --wait just is a terminal program which watches XCode. Otherwise LGTM. 273542 3 eric 2010-09-02 13:50:07 -0700 Status? 273643 4 abarth 2010-09-02 16:02:14 -0700 I need to address your comments and upload a new version. 337938 5 eric 2011-01-21 01:37:50 -0800 3-month ping. :) 423044 6 abarth 2011-06-17 22:58:08 -0700 Looks like we don't care enough about this patch to land it. If I'm wrong, please feel free to re-open. 57714 2010-06-02 16:29:35 -0700 2010-06-11 14:38:40 -0700 Patch bug-40088-20100602162934.patch text/plain 2268 abarth SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDYwNTgwKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDYtMDIgIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICB3ZWJraXQtcGF0Y2ggc2hvdWxkIHVzZSBhIGRpZmZlcmVudCBlZGl0b3IgZW52IHZh cmlhYmxlIHRvIGF2b2lkIGNvbmZsaWN0aW5nIHdpdGggcHJlcGFyZS1DaGFuZ2VMb2cKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwMDg4CisKKyAgICAg ICAgVXNpbmcgdGhlIHNhbWUgZW52aXJvbm1lbnQgdmFyaWFibGUgd2FzIGNhdXNpbmcgcHJvYmxl bXMgZm9yIERhcmluIHdobworICAgICAgICBoYXMgdGhhdCB2YXJpYWJsZSBzZXQgZm9yIHByZXBh cmUtQ2hhbmdlTG9ncy4gIEFmdGVyIHRoaXMgcGF0Y2gsIHdlIHVzZQorICAgICAgICBhIGRpZmZl cmVudCB2YXJpYWJsZSB0byBhdm9pZCB0aGUgY29uZmxpY3QuICBBbHNvLCBjaGFuZ2VkIHRoZSBo ZWxwCisgICAgICAgIGluc3RydWN0aW9ucyB0byBtZW50aW9uIHRoZSAtLWxhdW5jaCBzd2l0Y2gs IHdoaWNoIGlzIGFwcGFyZW50bHkKKyAgICAgICAgbmVjZXNzYXJ5LgorCisgICAgICAgICogU2Ny aXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL3VzZXIucHk6CisKIDIwMTAtMDYtMDIgIENzYWJh IE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBF cmljIFNlaWRlbC4KSW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5 c3RlbS91c2VyLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv Y29tbW9uL3N5c3RlbS91c2VyLnB5CShyZXZpc2lvbiA2MDU4MCkKKysrIFdlYktpdFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS91c2VyLnB5CSh3b3JraW5nIGNvcHkpCkBAIC03 NywxNCArNzcsMTQgQEAgY2xhc3MgVXNlcihvYmplY3QpOgogICAgICAgICBzdWJwcm9jZXNzLmNh bGwoYXJncyArIGZpbGVzKQogCiAgICAgZGVmIGVkaXRfY2hhbmdlbG9nKHNlbGYsIGZpbGVzKToK LSAgICAgICAgZWRpdF9hcHBsaWNhdGlvbiA9IG9zLmVudmlyb24uZ2V0KCJDSEFOR0VfTE9HX0VE SVRfQVBQTElDQVRJT04iKQorICAgICAgICBlZGl0X2FwcGxpY2F0aW9uID0gb3MuZW52aXJvbi5n ZXQoIldFQktJVF9QQVRDSF9FRElUT1JfQVBQTElDQVRJT04iKQogICAgICAgICBpZiBlZGl0X2Fw cGxpY2F0aW9uIGFuZCBzeXMucGxhdGZvcm0gPT0gImRhcndpbiI6CiAgICAgICAgICAgICAjIE9u IE1hYyB3ZSBzdXBwb3J0IGVkaXRpbmcgQ2hhbmdlTG9ncyB1c2luZyBhbiBhcHBsaWNhdGlvbi4K ICAgICAgICAgICAgIGFyZ3MgPSBzaGxleC5zcGxpdChlZGl0X2FwcGxpY2F0aW9uKQotICAgICAg ICAgICAgcHJpbnQgIlVzaW5nIGVkaXRvciBpbiB0aGUgQ0hBTkdFX0xPR19FRElUX0FQUExJQ0FU SU9OIGVudmlyb25tZW50IHZhcmlhYmxlLiIKKyAgICAgICAgICAgIHByaW50ICJVc2luZyBlZGl0 b3IgaW4gdGhlIFdFQktJVF9QQVRDSF9FRElUT1JfQVBQTElDQVRJT04gZW52aXJvbm1lbnQgdmFy aWFibGUuIgogICAgICAgICAgICAgcHJpbnQgIlBsZWFzZSBxdWl0IHRoZSBlZGl0b3IgYXBwbGlj YXRpb24gd2hlbiBkb25lIGVkaXRpbmcuIgogICAgICAgICAgICAgaWYgZWRpdF9hcHBsaWNhdGlv bi5maW5kKCJYY29kZS5hcHAiKToKLSAgICAgICAgICAgICAgICBwcmludCAiSW5zdGVhZCBvZiB1 c2luZyBYY29kZS5hcHAsIGNvbnNpZGVyIHVzaW5nIEVESVRPUj1cInhlZCAtLXdhaXRcIi4iCisg ICAgICAgICAgICAgICAgcHJpbnQgIkluc3RlYWQgb2YgdXNpbmcgWGNvZGUuYXBwLCBjb25zaWRl ciB1c2luZyBFRElUT1I9XCJ4ZWQgLS1sYXVuY2ggLS13YWl0XCIuIgogICAgICAgICAgICAgc3Vi cHJvY2Vzcy5jYWxsKFsib3BlbiIsICItVyIsICItbiIsICItYSJdICsgYXJncyArIGZpbGVzKQog ICAgICAgICAgICAgcmV0dXJuCiAgICAgICAgIHNlbGYuZWRpdChmaWxlcykK