40087 2010-06-02 16:22:52 -0700 REGRESSION(r60580): This broke dragging links if the selection was in a contentEditable element. (Requested by arv on #webkit). 2010-06-02 16:41:33 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 38548 1 webkit.review.bot webkit.review.bot arv commit-queue oldest_to_newest 233490 0 webkit.review.bot 2010-06-02 16:22:52 -0700 http://trac.webkit.org/changeset/60580 broke the build: This broke dragging links if the selection was in a contentEditable element. (Requested by arv on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 233491 1 57712 webkit.review.bot 2010-06-02 16:23:09 -0700 Created attachment 57712 ROLLOUT of r60580 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID --ignore-builders where ATTACHMENT_ID is the ID of this attachment. 233500 2 57712 commit-queue 2010-06-02 16:41:29 -0700 Comment on attachment 57712 ROLLOUT of r60580 Clearing flags on attachment: 57712 Committed r60581: <http://trac.webkit.org/changeset/60581> 233501 3 commit-queue 2010-06-02 16:41:33 -0700 All reviewed patches have been landed. Closing bug. 57712 2010-06-02 16:23:09 -0700 2010-06-02 16:41:29 -0700 ROLLOUT of r60580 bug-40087-20100602232307.patch text/plain 7279 webkit.review.bot ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA4MDg0NDljYTA2NGM1NTlmNjhmNGYxYTE1OWMyNzA4Njg0Zjc1YmUzLi5kNjMyM2Ri YThiM2YwMTVlNDEwZDY5MjdkNGU5OWYwYzQyNGY3MjhhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTAtMDYtMDIgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgor CisgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI2MDU4MC4KKyAgICAgICAgaHR0cDov L3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvNjA1ODAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwMDg3CisKKyAgICAgICAgVGhpcyBicm9rZSBkcmFn Z2luZyBsaW5rcyBpZiB0aGUgc2VsZWN0aW9uIHdhcyBpbiBhCisgICAgICAgIGNvbnRlbnRFZGl0 YWJsZSBlbGVtZW50LiAoUmVxdWVzdGVkIGJ5IGFydiBvbiAjd2Via2l0KS4KKworICAgICAgICAq IGVkaXRpbmcvc2VsZWN0aW9uL2NsaWNrLWluLWZvY3VzYWJsZS1saW5rLXNob3VsZC1ub3QtY2xl YXItc2VsZWN0aW9uLWV4cGVjdGVkLnR4dDogUmVtb3ZlZC4KKyAgICAgICAgKiBlZGl0aW5nL3Nl bGVjdGlvbi9jbGljay1pbi1mb2N1c2FibGUtbGluay1zaG91bGQtbm90LWNsZWFyLXNlbGVjdGlv bi5odG1sOiBSZW1vdmVkLgorICAgICAgICAqIGVkaXRpbmcvc2VsZWN0aW9uL3NjcmlwdC10ZXN0 cy9jbGljay1pbi1mb2N1c2FibGUtbGluay1zaG91bGQtbm90LWNsZWFyLXNlbGVjdGlvbi5qczog UmVtb3ZlZC4KKwogMjAxMC0wNi0wMiAgRXJpayBBcnZpZHNzb24gIDxhcnZAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IG9qYW5AY2hyb21pdW0ub3JnLgpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vY2xpY2staW4tZm9jdXNhYmxlLWxpbmstc2hv dWxkLW5vdC1jbGVhci1zZWxlY3Rpb24tZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZWRpdGlu Zy9zZWxlY3Rpb24vY2xpY2staW4tZm9jdXNhYmxlLWxpbmstc2hvdWxkLW5vdC1jbGVhci1zZWxl Y3Rpb24tZXhwZWN0ZWQudHh0CmRlbGV0ZWQgZmlsZSBtb2RlIDEwMDY0NAppbmRleCA0NWMwNDgz NWFlNmZkNDhkYmJlMzk1OWZmOTgyNGE3ZWUwZDVjYWUyLi4wMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwCi0tLSBhL0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL2Ns aWNrLWluLWZvY3VzYWJsZS1saW5rLXNob3VsZC1ub3QtY2xlYXItc2VsZWN0aW9uLWV4cGVjdGVk LnR4dAorKysgL2Rldi9udWxsCkBAIC0xLDExICswLDAgQEAKLUVuc3VyZXMgdGhhdCB0aGUgc2Vs ZWN0aW9uIGlzIG5vdCBjbGVhcmVkIHdoZW4gdGhlIHVzZXIgZG9lcyBhIG1vdXNlZG93biBvbiBh IG1vdXNlIGZvY3VzYWJsZSBsaW5rLgotCi1PbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJp ZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCi0KLQot UEFTUyBTdHJpbmcod2luZG93LmdldFNlbGVjdGlvbigpKSBpcyAiU2VsZWN0IgotUEFTUyBTdHJp bmcod2luZG93LmdldFNlbGVjdGlvbigpKSBpcyAiU2VsZWN0IgotUEFTUyBzdWNjZXNzZnVsbHlQ YXJzZWQgaXMgdHJ1ZQotCi1URVNUIENPTVBMRVRFCi0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2VkaXRpbmcvc2VsZWN0aW9uL2NsaWNrLWluLWZvY3VzYWJsZS1saW5rLXNob3VsZC1ub3QtY2xl YXItc2VsZWN0aW9uLmh0bWwgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9jbGljay1p bi1mb2N1c2FibGUtbGluay1zaG91bGQtbm90LWNsZWFyLXNlbGVjdGlvbi5odG1sCmRlbGV0ZWQg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCA3ZTYxMjQ3ZjViZGRjMGM5MmNjZDYyOWVhNjUzMjIzMzY0 ODBkM2Q2Li4wMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwCi0tLSBhL0xh eW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL2NsaWNrLWluLWZvY3VzYWJsZS1saW5rLXNob3Vs ZC1ub3QtY2xlYXItc2VsZWN0aW9uLmh0bWwKKysrIC9kZXYvbnVsbApAQCAtMSwxNCArMCwwIEBA Ci08IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lFVEYvL0RURCBIVE1MLy9FTiI+Ci08aHRtbD4K LTxoZWFkPgotPGxpbmsgcmVsPSJzdHlsZXNoZWV0IiBocmVmPSIuLi8uLi9mYXN0L2pzL3Jlc291 cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+Ci08c2NyaXB0IHNyYz0iLi4vLi4vZmFzdC9qcy9yZXNv dXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgotPHNjcmlwdCBzcmM9InJlc291cmNlcy9q cy10ZXN0LXNlbGVjdGlvbi1zaGFyZWQuanMiPjwvc2NyaXB0PgotPC9oZWFkPgotPGJvZHk+Ci08 cCBpZD0iZGVzY3JpcHRpb24iPjwvcD4KLTxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgotPHNjcmlw dCBzcmM9InNjcmlwdC10ZXN0cy9jbGljay1pbi1mb2N1c2FibGUtbGluay1zaG91bGQtbm90LWNs ZWFyLXNlbGVjdGlvbi5qcyI+PC9zY3JpcHQ+Ci08c2NyaXB0IHNyYz0iLi4vLi4vZmFzdC9qcy9y ZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KLTwvYm9keT4KLTwvaHRtbD4KZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL3NjcmlwdC10ZXN0cy9jbGlj ay1pbi1mb2N1c2FibGUtbGluay1zaG91bGQtbm90LWNsZWFyLXNlbGVjdGlvbi5qcyBiL0xheW91 dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL3NjcmlwdC10ZXN0cy9jbGljay1pbi1mb2N1c2FibGUt bGluay1zaG91bGQtbm90LWNsZWFyLXNlbGVjdGlvbi5qcwpkZWxldGVkIGZpbGUgbW9kZSAxMDA2 NDQKaW5kZXggMWQ1MDA5Mzg0NWU3MGRlZGZiYmI0ZWQ1ZGQ1YzdhMDI4MDliZjU3MC4uMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMAotLS0gYS9MYXlvdXRUZXN0cy9lZGl0 aW5nL3NlbGVjdGlvbi9zY3JpcHQtdGVzdHMvY2xpY2staW4tZm9jdXNhYmxlLWxpbmstc2hvdWxk LW5vdC1jbGVhci1zZWxlY3Rpb24uanMKKysrIC9kZXYvbnVsbApAQCAtMSw2MiArMCwwIEBACi1k ZXNjcmlwdGlvbignRW5zdXJlcyB0aGF0IHRoZSBzZWxlY3Rpb24gaXMgbm90IGNsZWFyZWQgd2hl biB0aGUgdXNlciBkb2VzIGEgbW91c2Vkb3duIG9uIGEgbW91c2UgZm9jdXNhYmxlIGxpbmsuJykK LQotZnVuY3Rpb24gZ2V0RWxlbWVudENlbnRlcihlbCkKLXsKLSAgICB2YXIgcmVjdCA9IGVsLmdl dEJvdW5kaW5nQ2xpZW50UmVjdCgpOwotICAgIHZhciB4ID0gcmVjdC5sZWZ0ICsgcmVjdC53aWR0 aCAvIDI7Ci0gICAgdmFyIHkgPSByZWN0LnRvcCArIHJlY3QuaGVpZ2h0IC8gMjsKLSAgICByZXR1 cm4ge3g6IHgsIHk6IHl9OwotfQotCi1mdW5jdGlvbiBkb3VibGVDbGlja09uRWxlbWVudChlbCkK LXsKLSAgICBpZiAod2luZG93LmV2ZW50U2VuZGVyKSB7Ci0gICAgICAgIHZhciBwb2ludCA9IGdl dEVsZW1lbnRDZW50ZXIoZWwpOwotICAgICAgICBldmVudFNlbmRlci5tb3VzZU1vdmVUbyhwb2lu dC54LCBwb2ludC55KTsKLSAgICAgICAgZXZlbnRTZW5kZXIubW91c2VEb3duKCk7Ci0gICAgICAg IGV2ZW50U2VuZGVyLm1vdXNlVXAoKTsKLSAgICAgICAgZXZlbnRTZW5kZXIubW91c2VEb3duKCk7 Ci0gICAgICAgIGV2ZW50U2VuZGVyLm1vdXNlVXAoKTsKLSAgICB9Ci19Ci0KLWZ1bmN0aW9uIG1v dXNlRG93bk9uRWxlbWVudChlbCkKLXsKLSAgICBpZiAod2luZG93LmV2ZW50U2VuZGVyKSB7Ci0g ICAgICAgIHZhciBwb2ludCA9IGdldEVsZW1lbnRDZW50ZXIoZWwpOwotICAgICAgICBldmVudFNl bmRlci5tb3VzZU1vdmVUbyhwb2ludC54LCBwb2ludC55KTsKLSAgICAgICAgZXZlbnRTZW5kZXIu bW91c2VEb3duKCk7Ci0gICAgfQotfQotCi1mdW5jdGlvbiBzZWxlY3Rpb25TaG91bGRCZShzKQot ewotICAgIHNob3VsZEJlRXF1YWxUb1N0cmluZygnU3RyaW5nKHdpbmRvdy5nZXRTZWxlY3Rpb24o KSknLCBzKTsKLX0KLQotdmFyIHNwYW4gPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdzcGFuJyk7 Ci1zcGFuLnRleHRDb250ZW50ID0gJ1NlbGVjdCc7Ci1kb2N1bWVudC5ib2R5LmFwcGVuZENoaWxk KHNwYW4pOwotCi12YXIgYnIgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdicicpOwotZG9jdW1l bnQuYm9keS5hcHBlbmRDaGlsZChicik7Ci0KLXZhciBhID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVu dCgnYScpOwotYS50ZXh0Q29udGVudCA9ICdsaW5rJzsKLWEuaHJlZiA9ICcjJzsKLWEudGFiSW5k ZXggPSAtMTsKLWRvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQoYSk7Ci0KLWlmICh3aW5kb3cuZXZl bnRTZW5kZXIpIHsKLSAgICBkb3VibGVDbGlja09uRWxlbWVudChzcGFuKTsKLSAgICBzZWxlY3Rp b25TaG91bGRCZSgnU2VsZWN0Jyk7Ci0KLSAgICBtb3VzZURvd25PbkVsZW1lbnQoYSk7Ci0gICAg c2VsZWN0aW9uU2hvdWxkQmUoJ1NlbGVjdCcpOwotCi0gICAgZG9jdW1lbnQuYm9keS5yZW1vdmVD aGlsZChhKTsKLSAgICBkb2N1bWVudC5ib2R5LnJlbW92ZUNoaWxkKGJyKTsKLSAgICBkb2N1bWVu dC5ib2R5LnJlbW92ZUNoaWxkKHNwYW4pOwotfQotCi12YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0g dHJ1ZTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cK aW5kZXggMzE1MWM1YzI4MmUzYjQwY2UyMjQ0ZWJmNGZmNTQxYmYzMzhkYTM2OC4uYmJhNjhlZmM3 OWQ3YTRmMzQ3NzE4NWIwOWI3ZGRmZjIyNGUyOTU1ZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFu Z2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNi0w MiAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CisKKyAgICAgICAg VW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjYwNTgwLgorICAgICAgICBodHRwOi8vdHJhYy53ZWJr aXQub3JnL2NoYW5nZXNldC82MDU4MAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDAwODcKKworICAgICAgICBUaGlzIGJyb2tlIGRyYWdnaW5nIGxpbmtz IGlmIHRoZSBzZWxlY3Rpb24gd2FzIGluIGEKKyAgICAgICAgY29udGVudEVkaXRhYmxlIGVsZW1l bnQuIChSZXF1ZXN0ZWQgYnkgYXJ2IG9uICN3ZWJraXQpLgorCisgICAgICAgICogcGFnZS9Gb2N1 c0NvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y2xlYXJTZWxlY3Rpb25JZk5lZWRl ZCk6CisKIDIwMTAtMDYtMDIgIEVyaWsgQXJ2aWRzc29uICA8YXJ2QGNocm9taXVtLm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBvamFuQGNocm9taXVtLm9yZy4KZGlmZiAtLWdpdCBhL1dlYkNv cmUvcGFnZS9Gb2N1c0NvbnRyb2xsZXIuY3BwIGIvV2ViQ29yZS9wYWdlL0ZvY3VzQ29udHJvbGxl ci5jcHAKaW5kZXggODA0MzQxZDlkMzE1NmNjOTQ0OTRjZjAwNDRhOGFhNWFhNjhiZGJmYy4uMzcy Y2IzMmU4ZDBlOTgyNDVhMmNiNDZhNWRlN2NmYjZhMWY3YmZkYiAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9wYWdlL0ZvY3VzQ29udHJvbGxlci5jcHAKKysrIGIvV2ViQ29yZS9wYWdlL0ZvY3VzQ29udHJv bGxlci5jcHAKQEAgLTUxMSwxOSArNTExLDE0IEBAIHN0YXRpYyB2b2lkIGNsZWFyU2VsZWN0aW9u SWZOZWVkZWQoRnJhbWUqIG9sZEZvY3VzZWRGcmFtZSwgRnJhbWUqIG5ld0ZvY3VzZWRGcmFtCiAg ICAgaWYgKHNlbGVjdGlvblN0YXJ0Tm9kZSA9PSBuZXdGb2N1c2VkTm9kZSB8fCBzZWxlY3Rpb25T dGFydE5vZGUtPmlzRGVzY2VuZGFudE9mKG5ld0ZvY3VzZWROb2RlKSB8fCBzZWxlY3Rpb25TdGFy dE5vZGUtPnNoYWRvd0FuY2VzdG9yTm9kZSgpID09IG5ld0ZvY3VzZWROb2RlKQogICAgICAgICBy ZXR1cm47CiAgICAgICAgIAotICAgIGlmIChOb2RlKiBtb3VzZVByZXNzTm9kZSA9IG5ld0ZvY3Vz ZWRGcmFtZS0+ZXZlbnRIYW5kbGVyKCktPm1vdXNlUHJlc3NOb2RlKCkpIHsKLSAgICAgICAgaWYg KG1vdXNlUHJlc3NOb2RlLT5yZW5kZXJlcigpICYmICFtb3VzZVByZXNzTm9kZS0+Y2FuU3RhcnRT ZWxlY3Rpb24oKSkgewotICAgICAgICAgICAgLy8gRG9uJ3QgY2xlYXIgdGhlIHNlbGVjdGlvbiBm b3IgY29udGVudEVkaXRhYmxlIGVsZW1lbnRzLCBidXQgZG8gY2xlYXIgaXQgZm9yIGlucHV0IGFu ZCB0ZXh0YXJlYS4gU2VlIGJ1ZyAzODY5Ni4KLSAgICAgICAgICAgIE5vZGUgKiByb290ID0gcy0+ cm9vdEVkaXRhYmxlRWxlbWVudCgpOwotICAgICAgICAgICAgaWYgKCFyb290KQotICAgICAgICAg ICAgICAgIHJldHVybjsKLQotICAgICAgICAgICAgaWYgKE5vZGUqIHNoYWRvd0FuY2VzdG9yTm9k ZSA9IHJvb3QtPnNoYWRvd0FuY2VzdG9yTm9kZSgpKSB7Ci0gICAgICAgICAgICAgICAgaWYgKCFz aGFkb3dBbmNlc3Rvck5vZGUtPmhhc1RhZ05hbWUoaW5wdXRUYWcpICYmICFzaGFkb3dBbmNlc3Rv ck5vZGUtPmhhc1RhZ05hbWUodGV4dGFyZWFUYWcpKQotICAgICAgICAgICAgICAgICAgICByZXR1 cm47Ci0gICAgICAgICAgICB9Ci0gICAgICAgIH0KLSAgICB9CisgICAgaWYgKE5vZGUqIG1vdXNl UHJlc3NOb2RlID0gbmV3Rm9jdXNlZEZyYW1lLT5ldmVudEhhbmRsZXIoKS0+bW91c2VQcmVzc05v ZGUoKSkKKyAgICAgICAgaWYgKG1vdXNlUHJlc3NOb2RlLT5yZW5kZXJlcigpICYmICFtb3VzZVBy ZXNzTm9kZS0+Y2FuU3RhcnRTZWxlY3Rpb24oKSkKKyAgICAgICAgICAgIGlmIChOb2RlKiByb290 ID0gcy0+cm9vdEVkaXRhYmxlRWxlbWVudCgpKQorICAgICAgICAgICAgICAgIGlmIChOb2RlKiBz aGFkb3dBbmNlc3Rvck5vZGUgPSByb290LT5zaGFkb3dBbmNlc3Rvck5vZGUoKSkKKyAgICAgICAg ICAgICAgICAgICAgLy8gRG9uJ3QgZG8gdGhpcyBmb3IgdGV4dGFyZWFzIGFuZCB0ZXh0IGZpZWxk cywgd2hlbiB0aGV5IGxvc2UgZm9jdXMgdGhlaXIgc2VsZWN0aW9ucyBzaG91bGQgYmUgY2xlYXJl ZAorICAgICAgICAgICAgICAgICAgICAvLyBhbmQgdGhlbiByZXN0b3JlZCB3aGVuIHRoZXkgcmVn YWluIGZvY3VzLCB0byBtYXRjaCBvdGhlciBicm93c2Vycy4KKyAgICAgICAgICAgICAgICAgICAg aWYgKCFzaGFkb3dBbmNlc3Rvck5vZGUtPmhhc1RhZ05hbWUoaW5wdXRUYWcpICYmICFzaGFkb3dB bmNlc3Rvck5vZGUtPmhhc1RhZ05hbWUodGV4dGFyZWFUYWcpKQorICAgICAgICAgICAgICAgICAg ICAgICAgcmV0dXJuOwogICAgIAogICAgIHMtPmNsZWFyKCk7CiB9Cg==