40085 2010-06-02 15:50:52 -0700 Enable WebGL on more platforms even if accelerated compositing is disabled 2010-06-02 17:16:41 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 39917 40091 1 kbr kbr cmarrin dglazkov fishd oliver vangelis oldest_to_newest 233475 0 kbr 2010-06-02 15:50:52 -0700 Some ports of WebKit may want to enable WebGL even if accelerated compositing is not enabled. The code in HTMLCanvasElement which gates the creation of the WebGL context based on the enabling of accelerated compositing should be made conditional. The recent change to support the accelerated compositing flag in Chromium broke that port. The safest change is to ignore the accelerated compositing flag only on Chromium; other ports may opt in to this logic if they choose. 233478 1 57710 kbr 2010-06-02 16:04:46 -0700 Created attachment 57710 Patch From the ChangeLog: Conditionalize the code which prevents a WebGL rendering context from being created if accelerated compositing is disabled. Currently Chromium is the only port which will create a context if accelerated compositing is disabled; other ports may opt in to this code path if desired. 233481 2 57710 fishd 2010-06-02 16:08:39 -0700 Comment on attachment 57710 Patch WebCore/html/HTMLCanvasElement.cpp:160 + #if !PLATFORM(CHROMIUM) perhaps a more specific ENABLE(3D_CANVAS_REQUIRES_ACCELERATED_COMPOSITING) ? 233488 3 kbr 2010-06-02 16:21:35 -0700 (In reply to comment #2) > (From update of attachment 57710 [details]) > WebCore/html/HTMLCanvasElement.cpp:160 > + #if !PLATFORM(CHROMIUM) > perhaps a more specific ENABLE(3D_CANVAS_REQUIRES_ACCELERATED_COMPOSITING) ? I would rather fix this with a small change now than plumb a new enable flag through the build system. WebGL is currently broken in Chromium and I want to fix that ASAP. 233499 4 57710 fishd 2010-06-02 16:38:50 -0700 Comment on attachment 57710 Patch OK, r=me since this fixes the bots, but we should avoid littering cross platform code with PLATFORM(CHROMIUM). What is the plan for eliminating this? 233502 5 kbr 2010-06-02 16:46:37 -0700 (In reply to comment #4) > (From update of attachment 57710 [details]) > OK, r=me since this fixes the bots, but we should avoid littering cross > platform code with PLATFORM(CHROMIUM). What is the plan for eliminating > this? We can add a new enable flag. I know the test of the flag was originally added specifically for the Mac (Safari) port, but it seems that other ports like Qt are happy with the test of the accelerated compositing flag. When adding the new enable flag we'll need to be careful not to accidentally enable WebGL for ports which didn't expect it in certain situations. 233504 6 kbr 2010-06-02 16:57:28 -0700 Committed r60582: <http://trac.webkit.org/changeset/60582> 57710 2010-06-02 16:04:46 -0700 2010-06-02 16:38:50 -0700 Patch create.patch text/plain 1842 kbr SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MDU4MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTAtMDYtMDIgIEtlbm5ldGggUnVzc2VsbCAgPGtickBnb29nbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVu YWJsZSBXZWJHTCBvbiBtb3JlIHBsYXRmb3JtcyBldmVuIGlmIGFjY2VsZXJhdGVkIGNvbXBvc2l0 aW5nIGlzIGRpc2FibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00MDA4NQorCisgICAgICAgIENvbmRpdGlvbmFsaXplIHRoZSBjb2RlIHdoaWNoIHBy ZXZlbnRzIGEgV2ViR0wgcmVuZGVyaW5nIGNvbnRleHQKKyAgICAgICAgZnJvbSBiZWluZyBjcmVh dGVkIGlmIGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIGlzIGRpc2FibGVkLgorICAgICAgICBDdXJy ZW50bHkgQ2hyb21pdW0gaXMgdGhlIG9ubHkgcG9ydCB3aGljaCB3aWxsIGNyZWF0ZSBhIGNvbnRl eHQgaWYKKyAgICAgICAgYWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcgaXMgZGlzYWJsZWQ7IG90aGVy IHBvcnRzIG1heSBvcHQgaW4gdG8KKyAgICAgICAgdGhpcyBjb2RlIHBhdGggaWYgZGVzaXJlZC4K KworICAgICAgICBUZXN0ZWQgd2l0aCBleGlzdGluZyBXZWJHTCBsYXlvdXQgdGVzdHMgaW4gU2Fm YXJpIGFuZCBDaHJvbWl1bSBvbgorICAgICAgICBNYWMgT1MgWC4KKworICAgICAgICAqIGh0bWwv SFRNTENhbnZhc0VsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTENhbnZhc0VsZW1l bnQ6OmdldENvbnRleHQpOgorCiAyMDEwLTA2LTAyICBFcmlrIEFydmlkc3NvbiAgPGFydkBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgb2phbkBjaHJvbWl1bS5vcmcuCkluZGV4 OiBXZWJDb3JlL2h0bWwvSFRNTENhbnZhc0VsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5jcHAJKHJldmlzaW9uIDYwNTgwKQorKysgV2ViQ29y ZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTU2LDcgKzE1 NiwxMSBAQCBDYW52YXNSZW5kZXJpbmdDb250ZXh0KiBIVE1MQ2FudmFzRWxlbWVuCiAgICAgfQog I2lmIEVOQUJMRSgzRF9DQU5WQVMpICAgIAogICAgIFNldHRpbmdzKiBzZXR0aW5ncyA9IGRvY3Vt ZW50KCktPnNldHRpbmdzKCk7Ci0gICAgaWYgKHNldHRpbmdzICYmIHNldHRpbmdzLT53ZWJHTEVu YWJsZWQoKSAmJiBzZXR0aW5ncy0+YWNjZWxlcmF0ZWRDb21wb3NpdGluZ0VuYWJsZWQoKSkgewor ICAgIGlmIChzZXR0aW5ncyAmJiBzZXR0aW5ncy0+d2ViR0xFbmFibGVkKCkKKyNpZiAhUExBVEZP Uk0oQ0hST01JVU0pCisgICAgICAgICYmIHNldHRpbmdzLT5hY2NlbGVyYXRlZENvbXBvc2l0aW5n RW5hYmxlZCgpCisjZW5kaWYKKyAgICAgICAgKSB7CiAgICAgICAgIC8vIEFjY2VwdCB0aGUgbGVn YWN5ICJ3ZWJraXQtM2QiIG5hbWUgYXMgd2VsbCBhcyB0aGUgcHJvdmlzaW9uYWwgImV4cGVyaW1l bnRhbC13ZWJnbCIgbmFtZS4KICAgICAgICAgLy8gT25jZSByYXRpZmllZCwgd2Ugd2lsbCBhbHNv IGFjY2VwdCAid2ViZ2wiIGFzIHRoZSBjb250ZXh0IG5hbWUuCiAgICAgICAgIGlmICgodHlwZSA9 PSAid2Via2l0LTNkIikgfHwK