40073 2010-06-02 11:07:07 -0700 [Qt] rendering error in mediawiki 2011-04-19 05:15:29 -0700 1 1 1 Unclassified WebKit Layout and Rendering 420+ Other Linux CLOSED FIXED http://www.debianclusters.org/index.php/Main_Page Qt, QtTriaged P3 Normal --- 1 avbidder webkit-unassigned abecsi adawit ap commit-queue hausmann kenneth luiz ossy tonikitoo oldest_to_newest 233339 0 avbidder 2010-06-02 11:07:07 -0700 See KDE: https://bugs.kde.org/show_bug.cgi?id=240465 and the attached screenshot. happens with many mediawiki sites, not only debianclusters. khtml and other browsers work fine; webkit doesn't have this problem with wikipedia or some other mediawiki sites, so it seems to be a particular version of their template that causes the bug. Browser: kpart-webkit 0.9svn1129464-1 (Debian version, it's the current unstable package update to a newer svn snapshot) and libqt4-webkit 4:4.6.2-5. cheers -- vbi 233497 1 adawit 2010-06-02 16:35:08 -0700 FYI. This reproducible using QtTestBrowser in QtWebKit 2.0 as well... 233651 2 ap 2010-06-03 00:51:01 -0700 I cannot reproduce this with ToT WebKit, so I suspect that Qt has an old version of WebKit. Issues like this have been addressed in bug 28350, bug 29792, and bug 35507. 233872 3 ossy 2010-06-03 12:41:26 -0700 I can reproduce it with QtTestBrowser (WebKit trunk r60630) 233874 4 ossy 2010-06-03 12:46:51 -0700 (In reply to comment #3) > I can reproduce it with QtTestBrowser (WebKit trunk r60630) It is the ToT of WebKit and I tried with Qt-4.6.0 and Qt-4.7 trunk. 233877 5 kenneth 2010-06-03 12:53:31 -0700 Luiz, can you check this with pure Mac and Qt Mac build? Would be nice to know if this is a Qt only issue or not 233878 6 ossy 2010-06-03 12:56:09 -0700 (In reply to comment #5) > Luiz, can you check this with pure Mac and Qt Mac build? Would be nice to know if this is a Qt only issue or not I tried with an old Safari on Windows and works as we expect. 233880 7 kenneth 2010-06-03 12:57:51 -0700 as far as I remember, the mediawiki pages import illegal css when the user agent contain "KHTML" and we (WebKit community) had to make a quirk. Could it be that this quirk is not enabled for Qt? 233883 8 kenneth 2010-06-03 12:59:27 -0700 Is this setting set for Qt? document()->settings()->needsSiteSpecificQuirks() 233887 9 ossy 2010-06-03 13:05:40 -0700 I cc-ed Andras, he is our CSS parser guru. Have you got any idea? 233892 10 adawit 2010-06-03 13:16:30 -0700 (In reply to comment #2) > I cannot reproduce this with ToT WebKit, so I suspect that Qt has an old version of WebKit. Issues like this have been addressed in bug 28350, bug 29792, and bug 35507. I checked and the fixes from all of those reports are there in QtWebKit 2.0 ; so something else is causing or preventing those fixes from having any effect in QtWebKit... Perhaps the suggestion in comment #8 ?? Dunno. 233893 11 ap 2010-06-03 13:18:34 -0700 Yes, comment 8 sounds like the best explanation. 235390 12 58162 adawit 2010-06-08 11:24:44 -0700 Created attachment 58162 Patch Here is a patch that fixes the problem. 235392 13 adawit 2010-06-08 11:26:13 -0700 (In reply to comment #8) > Is this setting set for Qt? > > document()->settings()->needsSiteSpecificQuirks() Nope, it is not... See patch. 235394 14 58162 kenneth 2010-06-08 11:29:03 -0700 Comment on attachment 58162 Patch WebKit/qt/Api/qwebsettings.cpp:434 + sites that use certain frameworks, such as the older versions of MediaWiki, may not render properly. I'm not sure if we really want references to MediaWiki here. Also, I do not like "not render or display properly in it", as the case is actually that is is a workaround for broken sites, not just sites that do not look good. WebKit/qt/Api/qwebsettings.h:77 + SiteSpecificQuirksModeEnabled We might want a more understanding setting, Let's see what Simon says. Apart from that, the idea is fine. R- due to semi-optimal documentation. 235408 15 58165 adawit 2010-06-08 11:54:21 -0700 Created attachment 58165 Patch - rev. #2 Fixed the attribute documentation based on review in comment #14... 235422 16 58165 kenneth 2010-06-08 12:13:15 -0700 Comment on attachment 58165 Patch - rev. #2 r=me, as we can still change the name etc before cherry-picking this change. 235426 17 tonikitoo 2010-06-08 12:18:09 -0700 no commit message? should be the same as in ChangeLog. > diff --git a/WebKit/qt/Api/qwebsettings.cpp b/WebKit/qt/Api/qwebsettings.cpp > index a5fc794..9631f05 100644 > --- a/WebKit/qt/Api/qwebsettings.cpp > +++ b/WebKit/qt/Api/qwebsettings.cpp > + \value SiteSpecificQuirksModeEnabled This setting enables WebKit's workaround for broken sites. It is > + enabled by default. I do not think it is about WebKit workarounds. CSS Quirk Mode is a way that browsers (not only WebKit) support the old and broken CSS use that works for IE6 and family. http://www.quirksmode.org/css/quirksmode.html You are not mentioning about CSS in the setting name. Should you? or at least in the documentation. It is a CSS Mode and has Quirk and Strict modes. I would not commit it as is :-( due to the documentation and the setting name. 235443 18 kenneth 2010-06-08 12:47:10 -0700 Safari has it enabled by default and there is a menu for disabling it Safari->Develop->Disable Site-Specific Hacks Antonio, this has nothing to do with CSS Quirks and Strict mode, but are work around for broken sites. 235445 19 kenneth 2010-06-08 12:49:43 -0700 (In reply to comment #18) > Safari has it enabled by default and there is a menu for disabling it > > Safari->Develop->Disable Site-Specific Hacks > > Antonio, this has nothing to do with CSS Quirks and Strict mode, but are work around for broken sites. I guess the QuicksMode in the name is confusing and maybe we should go for SiteSpecificHacksEnabled instead ? Let me cq- 235446 20 ap 2010-06-08 12:50:19 -0700 The reason to have a way to disable these workarounds is to give developers of those specific sites a way to test how their sites would work without the workarounds. Users never need to disable these workarounds. 237206 21 58165 kenneth 2010-06-11 18:44:18 -0700 Comment on attachment 58165 Patch - rev. #2 Can you supply a new patch where this is renamed QWebSettings:SiteSpecificQuirksEnabled due remove the Mode; then I will re-review. 237232 22 58541 adawit 2010-06-11 22:33:25 -0700 Created attachment 58541 Patch - rev. #3 Renamed attribute to 'SiteSpecificQuirksEnabled' as requested... 237235 23 adawit 2010-06-11 22:49:14 -0700 (In reply to comment #21) > (From update of attachment 58165 [details]) > Can you supply a new patch where this is renamed QWebSettings:SiteSpecificQuirksEnabled due remove the Mode; then I will re-review. Done... Note that this version will not cleanly apply to the trunk version of qtwebkit since a new WebGLEnabled option is present there. 237274 24 kenneth 2010-06-12 04:30:24 -0700 Can you supply a version that will? 237301 25 58553 adawit 2010-06-12 09:13:23 -0700 Created attachment 58553 Same patch vs trunk... Patch against the current trunk version of webkit... 237316 26 58553 commit-queue 2010-06-12 11:05:21 -0700 Comment on attachment 58553 Same patch vs trunk... Clearing flags on attachment: 58553 Committed r61064: <http://trac.webkit.org/changeset/61064> 237610 27 hausmann 2010-06-13 14:15:51 -0700 Dawit, are you saying that in the KDE webkit integration you need to disable these site specific quirks, because of the user agent that you're sending? 237616 28 adawit 2010-06-13 15:02:48 -0700 (In reply to comment #27) > Dawit, are you saying that in the KDE webkit integration you need to disable these site specific quirks, because of the user agent that you're sending? Nope. This is not a KDE webkit specific issue. It is a QtWebKit bug that affects all QtWebKit based browser. See comments #1-3 above... 238291 29 hausmann 2010-06-15 01:22:23 -0700 (In reply to comment #28) > (In reply to comment #27) > > Dawit, are you saying that in the KDE webkit integration you need to disable these site specific quirks, because of the user agent that you're sending? > > Nope. This is not a KDE webkit specific issue. It is a QtWebKit bug that affects all QtWebKit based browser. See comments #1-3 above... Right, but what I'd like to find out _who_ is going to use this web setting and disable the site specific quirks? 238346 30 tonikitoo 2010-06-15 06:11:24 -0700 (In reply to comment #29) > (In reply to comment #28) > > (In reply to comment #27) > > > Dawit, are you saying that in the KDE webkit integration you need to disable these site specific quirks, because of the user agent that you're sending? > > > > Nope. This is not a KDE webkit specific issue. It is a QtWebKit bug that affects all QtWebKit based browser. See comments #1-3 above... > > Right, but what I'd like to find out _who_ is going to use this web setting and disable the site specific quirks? that is a good question. why to disable it at all or why its value in Settings.cpp|h is not true by default already? fwiw, mac, win, gtk and chromium ports also have this setting as a public api. 238352 31 adawit 2010-06-15 06:30:49 -0700 (In reply to comment #29) > (In reply to comment #28) > > (In reply to comment #27) > > > Dawit, are you saying that in the KDE webkit integration you need to disable these site specific quirks, because of the user agent that you're sending? > > > > Nope. This is not a KDE webkit specific issue. It is a QtWebKit bug that affects all QtWebKit based browser. See comments #1-3 above... > > Right, but what I'd like to find out _who_ is going to use this web setting and disable the site specific quirks? Developers. The patch is implemented that way because other browsers provide a means of enabling/disabling this feature. See comment #18 and comment #20. It is only applicable to developers... 238354 32 kenneth 2010-06-15 06:36:29 -0700 Site authors of sites currently affected by quirks who want to make their site standard compliant. 238794 33 hausmann 2010-06-16 04:36:42 -0700 Makes sense, thanks :) I'll swap the last two enums in qwebsettings.h to ensure binary compatibility when including it in the release branch. 238801 34 hausmann 2010-06-16 04:54:00 -0700 Revision r61064 cherry-picked into qtwebkit-2.0 with commit 815815940c24badaefd9b4deeb1851534bd677e0 238802 35 hausmann 2010-06-16 04:54:21 -0700 http://trac.webkit.org/changeset/61251 corrects the enum order 58162 2010-06-08 11:24:44 -0700 2010-06-08 11:54:21 -0700 Patch qtwebkit_site_specific_quirks_mode.patch text/plain 2982 adawit ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYnNldHRpbmdzLmNwcCBiL1dlYktpdC9xdC9B cGkvcXdlYnNldHRpbmdzLmNwcAppbmRleCBhNWZjNzk0Li41N2Y1MTcwIDEwMDY0NAotLS0gYS9X ZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2Vic2V0 dGluZ3MuY3BwCkBAIC0yNDQsNiArMjQ0LDkgQEAgdm9pZCBRV2ViU2V0dGluZ3NQcml2YXRlOjph cHBseSgpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdsb2JhbC0+YXR0 cmlidXRlcy52YWx1ZShRV2ViU2V0dGluZ3M6OlRpbGVkQmFja2luZ1N0b3JlRW5hYmxlZCkpOwog ICAgICAgICBzZXR0aW5ncy0+c2V0VGlsZWRCYWNraW5nU3RvcmVFbmFibGVkKHZhbHVlKTsKICNl bmRpZgorICAgICAgICB2YWx1ZSA9IGF0dHJpYnV0ZXMudmFsdWUoUVdlYlNldHRpbmdzOjpTaXRl U3BlY2lmaWNRdWlya3NNb2RlRW5hYmxlZCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgZ2xvYmFsLT5hdHRyaWJ1dGVzLnZhbHVlKFFXZWJTZXR0aW5nczo6U2l0ZVNwZWNp ZmljUXVpcmtzTW9kZUVuYWJsZWQpKTsKKyAgICAgICAgc2V0dGluZ3MtPnNldE5lZWRzU2l0ZVNw ZWNpZmljUXVpcmtzKHZhbHVlKTsKIAogICAgICAgICBzZXR0aW5ncy0+c2V0VXNlc1BhZ2VDYWNo ZShXZWJDb3JlOjpwYWdlQ2FjaGUoKS0+Y2FwYWNpdHkoKSk7CiAgICAgfSBlbHNlIHsKQEAgLTQy Niw2ICs0MjksOSBAQCBRV2ViU2V0dGluZ3MqIFFXZWJTZXR0aW5nczo6Z2xvYmFsU2V0dGluZ3Mo KQogICAgICAgICBhbmQgYXQgb3RoZXIgdGltZXMgc2Nyb2xsaW5nIHRoZSBwYWdlIGl0c2VsZi4g Rm9yIHRoaXMgcmVhc29uIGlmcmFtZXMgYW5kIGZyYW1lc2V0cyBhcmUKICAgICAgICAgYmFyZWx5 IHVzYWJsZSBvbiB0b3VjaCBkZXZpY2VzLiBUaGlzIHdpbGwgZmxhdHRlbiBhbGwgdGhlIGZyYW1l cyB0byBiZWNvbWUgb25lIHNjcm9sbGFibGUgcGFnZS4KICAgICAgICAgVGhpcyBpcyBkaXNhYmxl ZCBieSBkZWZhdWx0LgorICAgIFx2YWx1ZSBTaXRlU3BlY2lmaWNRdWlya3NNb2RlRW5hYmxlZCBU aGlzIHNldHRpbmcgYWN0aXZhdGVzIFdlYktpdCdzIHdvcmthcm91bmQgZm9yIHNpdGVzIHRoYXQg ZG8KKyAgICAgICAgbm90IHJlbmRlciBvciBkaXNwbGF5IHByb3Blcmx5IGluIGl0LiBUaGlzIGlz IGVuYWJsZWQgYnkgZGVmYXVsdC4gSWYgeW91IGRpc2FibGUgdGhpcyBhdHRyaWJ1dGUsCisgICAg ICAgIHNpdGVzIHRoYXQgdXNlIGNlcnRhaW4gZnJhbWV3b3Jrcywgc3VjaCBhcyB0aGUgb2xkZXIg dmVyc2lvbnMgb2YgTWVkaWFXaWtpLCBtYXkgbm90IHJlbmRlciBwcm9wZXJseS4KICovCiAKIC8q IQpAQCAtNDYxLDYgKzQ2Nyw3IEBAIFFXZWJTZXR0aW5nczo6UVdlYlNldHRpbmdzKCkKICAgICBk LT5hdHRyaWJ1dGVzLmluc2VydChRV2ViU2V0dGluZ3M6OkFjY2VsZXJhdGVkQ29tcG9zaXRpbmdF bmFibGVkLCB0cnVlKTsKICAgICBkLT5hdHRyaWJ1dGVzLmluc2VydChRV2ViU2V0dGluZ3M6OlRp bGVkQmFja2luZ1N0b3JlRW5hYmxlZCwgZmFsc2UpOwogICAgIGQtPmF0dHJpYnV0ZXMuaW5zZXJ0 KFFXZWJTZXR0aW5nczo6RnJhbWVGbGF0dGVuaW5nRW5hYmxlZCwgZmFsc2UpOworICAgIGQtPmF0 dHJpYnV0ZXMuaW5zZXJ0KFFXZWJTZXR0aW5nczo6U2l0ZVNwZWNpZmljUXVpcmtzTW9kZUVuYWJs ZWQsIHRydWUpOwogICAgIGQtPm9mZmxpbmVTdG9yYWdlRGVmYXVsdFF1b3RhID0gNSAqIDEwMjQg KiAxMDI0OwogICAgIGQtPmRlZmF1bHRUZXh0RW5jb2RpbmcgPSBRTGF0aW4xU3RyaW5nKCJpc28t ODg1OS0xIik7CiB9CmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5oIGIv V2ViS2l0L3F0L0FwaS9xd2Vic2V0dGluZ3MuaAppbmRleCBiOTc4ZjVlLi45ZWJlZTc3IDEwMDY0 NAotLS0gYS9XZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5oCisrKyBiL1dlYktpdC9xdC9BcGkv cXdlYnNldHRpbmdzLmgKQEAgLTczLDcgKzczLDggQEAgcHVibGljOgogICAgICAgICBTcGF0aWFs TmF2aWdhdGlvbkVuYWJsZWQsCiAgICAgICAgIExvY2FsQ29udGVudENhbkFjY2Vzc0ZpbGVVcmxz LAogICAgICAgICBUaWxlZEJhY2tpbmdTdG9yZUVuYWJsZWQsCi0gICAgICAgIEZyYW1lRmxhdHRl bmluZ0VuYWJsZWQKKyAgICAgICAgRnJhbWVGbGF0dGVuaW5nRW5hYmxlZCwKKyAgICAgICAgU2l0 ZVNwZWNpZmljUXVpcmtzTW9kZUVuYWJsZWQKICAgICB9OwogICAgIGVudW0gV2ViR3JhcGhpYyB7 CiAgICAgICAgIE1pc3NpbmdJbWFnZUdyYXBoaWMsCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQ2hh bmdlTG9nIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwppbmRleCAzZGViOWFjLi5kZmY1MmQyIDEwMDY0 NAotLS0gYS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNyBAQAorMjAxMC0wNi0wOCAgRGF3aXQgQWxlbWF5ZWh1ICA8YWRhd2l0QGtkZS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRk ZWQgYW4gYXR0cmlidXRlIHRvIGVuYWJsZS9kaXNhYmxlIHNpdGUgc3BlY2lmaWMgcXVpcmtzIG1v ZGUgaW4gV2ViS2l0LiAKKyAgICAgICAgVGhlIGF0dHJpYnV0ZSBpcyBlbmFibGVkIGJ5IGRlZmF1 bHQuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQw MDczCisKKyAgICAgICAgKiBBcGkvcXdlYnNldHRpbmdzLmNwcDoKKyAgICAgICAgKFFXZWJTZXR0 aW5nc1ByaXZhdGU6OmFwcGx5KToKKyAgICAgICAgKFFXZWJTZXR0aW5nczo6UVdlYlNldHRpbmdz KToKKyAgICAgICAgKiBBcGkvcXdlYnNldHRpbmdzLmg6CisKIDIwMTAtMDYtMDIgIFRhc3VrdSBT dXp1a2kgIDx0YXN1a3Uuc3V6dWtpQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBT aGluaWNoaXJvIEhhbWFqaS4K 58165 2010-06-08 11:54:21 -0700 2010-06-11 22:33:25 -0700 Patch - rev. #2 qtwebkit_site_specific_quirks_mode_2.patch text/plain 2800 adawit ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYnNldHRpbmdzLmNwcCBiL1dlYktpdC9xdC9B cGkvcXdlYnNldHRpbmdzLmNwcAppbmRleCBhNWZjNzk0Li45NjMxZjA1IDEwMDY0NAotLS0gYS9X ZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2Vic2V0 dGluZ3MuY3BwCkBAIC0yNDQsNiArMjQ0LDkgQEAgdm9pZCBRV2ViU2V0dGluZ3NQcml2YXRlOjph cHBseSgpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdsb2JhbC0+YXR0 cmlidXRlcy52YWx1ZShRV2ViU2V0dGluZ3M6OlRpbGVkQmFja2luZ1N0b3JlRW5hYmxlZCkpOwog ICAgICAgICBzZXR0aW5ncy0+c2V0VGlsZWRCYWNraW5nU3RvcmVFbmFibGVkKHZhbHVlKTsKICNl bmRpZgorICAgICAgICB2YWx1ZSA9IGF0dHJpYnV0ZXMudmFsdWUoUVdlYlNldHRpbmdzOjpTaXRl U3BlY2lmaWNRdWlya3NNb2RlRW5hYmxlZCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgZ2xvYmFsLT5hdHRyaWJ1dGVzLnZhbHVlKFFXZWJTZXR0aW5nczo6U2l0ZVNwZWNp ZmljUXVpcmtzTW9kZUVuYWJsZWQpKTsKKyAgICAgICAgc2V0dGluZ3MtPnNldE5lZWRzU2l0ZVNw ZWNpZmljUXVpcmtzKHZhbHVlKTsKIAogICAgICAgICBzZXR0aW5ncy0+c2V0VXNlc1BhZ2VDYWNo ZShXZWJDb3JlOjpwYWdlQ2FjaGUoKS0+Y2FwYWNpdHkoKSk7CiAgICAgfSBlbHNlIHsKQEAgLTQy Niw2ICs0MjksOCBAQCBRV2ViU2V0dGluZ3MqIFFXZWJTZXR0aW5nczo6Z2xvYmFsU2V0dGluZ3Mo KQogICAgICAgICBhbmQgYXQgb3RoZXIgdGltZXMgc2Nyb2xsaW5nIHRoZSBwYWdlIGl0c2VsZi4g Rm9yIHRoaXMgcmVhc29uIGlmcmFtZXMgYW5kIGZyYW1lc2V0cyBhcmUKICAgICAgICAgYmFyZWx5 IHVzYWJsZSBvbiB0b3VjaCBkZXZpY2VzLiBUaGlzIHdpbGwgZmxhdHRlbiBhbGwgdGhlIGZyYW1l cyB0byBiZWNvbWUgb25lIHNjcm9sbGFibGUgcGFnZS4KICAgICAgICAgVGhpcyBpcyBkaXNhYmxl ZCBieSBkZWZhdWx0LgorICAgIFx2YWx1ZSBTaXRlU3BlY2lmaWNRdWlya3NNb2RlRW5hYmxlZCBU aGlzIHNldHRpbmcgZW5hYmxlcyBXZWJLaXQncyB3b3JrYXJvdW5kIGZvciBicm9rZW4gc2l0ZXMu IEl0IGlzIAorICAgICAgICBlbmFibGVkIGJ5IGRlZmF1bHQuCiAqLwogCiAvKiEKQEAgLTQ2MSw2 ICs0NjYsNyBAQCBRV2ViU2V0dGluZ3M6OlFXZWJTZXR0aW5ncygpCiAgICAgZC0+YXR0cmlidXRl cy5pbnNlcnQoUVdlYlNldHRpbmdzOjpBY2NlbGVyYXRlZENvbXBvc2l0aW5nRW5hYmxlZCwgdHJ1 ZSk7CiAgICAgZC0+YXR0cmlidXRlcy5pbnNlcnQoUVdlYlNldHRpbmdzOjpUaWxlZEJhY2tpbmdT dG9yZUVuYWJsZWQsIGZhbHNlKTsKICAgICBkLT5hdHRyaWJ1dGVzLmluc2VydChRV2ViU2V0dGlu Z3M6OkZyYW1lRmxhdHRlbmluZ0VuYWJsZWQsIGZhbHNlKTsKKyAgICBkLT5hdHRyaWJ1dGVzLmlu c2VydChRV2ViU2V0dGluZ3M6OlNpdGVTcGVjaWZpY1F1aXJrc01vZGVFbmFibGVkLCB0cnVlKTsK ICAgICBkLT5vZmZsaW5lU3RvcmFnZURlZmF1bHRRdW90YSA9IDUgKiAxMDI0ICogMTAyNDsKICAg ICBkLT5kZWZhdWx0VGV4dEVuY29kaW5nID0gUUxhdGluMVN0cmluZygiaXNvLTg4NTktMSIpOwog fQpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L0FwaS9xd2Vic2V0dGluZ3MuaCBiL1dlYktpdC9xdC9B cGkvcXdlYnNldHRpbmdzLmgKaW5kZXggYjk3OGY1ZS4uOWViZWU3NyAxMDA2NDQKLS0tIGEvV2Vi S2l0L3F0L0FwaS9xd2Vic2V0dGluZ3MuaAorKysgYi9XZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5n cy5oCkBAIC03Myw3ICs3Myw4IEBAIHB1YmxpYzoKICAgICAgICAgU3BhdGlhbE5hdmlnYXRpb25F bmFibGVkLAogICAgICAgICBMb2NhbENvbnRlbnRDYW5BY2Nlc3NGaWxlVXJscywKICAgICAgICAg VGlsZWRCYWNraW5nU3RvcmVFbmFibGVkLAotICAgICAgICBGcmFtZUZsYXR0ZW5pbmdFbmFibGVk CisgICAgICAgIEZyYW1lRmxhdHRlbmluZ0VuYWJsZWQsCisgICAgICAgIFNpdGVTcGVjaWZpY1F1 aXJrc01vZGVFbmFibGVkCiAgICAgfTsKICAgICBlbnVtIFdlYkdyYXBoaWMgewogICAgICAgICBN aXNzaW5nSW1hZ2VHcmFwaGljLApkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L0NoYW5nZUxvZyBiL1dl YktpdC9xdC9DaGFuZ2VMb2cKaW5kZXggM2RlYjlhYy4uZGZmNTJkMiAxMDA2NDQKLS0tIGEvV2Vi S2l0L3F0L0NoYW5nZUxvZworKysgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTAtMDYtMDggIERhd2l0IEFsZW1heWVodSAgPGFkYXdpdEBrZGUub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIGFuIGF0dHJp YnV0ZSB0byBlbmFibGUvZGlzYWJsZSBzaXRlIHNwZWNpZmljIHF1aXJrcyBtb2RlIGluIFdlYktp dC4gCisgICAgICAgIFRoZSBhdHRyaWJ1dGUgaXMgZW5hYmxlZCBieSBkZWZhdWx0LgorCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDA3MworCisgICAg ICAgICogQXBpL3F3ZWJzZXR0aW5ncy5jcHA6CisgICAgICAgIChRV2ViU2V0dGluZ3NQcml2YXRl OjphcHBseSk6CisgICAgICAgIChRV2ViU2V0dGluZ3M6OlFXZWJTZXR0aW5ncyk6CisgICAgICAg ICogQXBpL3F3ZWJzZXR0aW5ncy5oOgorCiAyMDEwLTA2LTAyICBUYXN1a3UgU3V6dWtpICA8dGFz dWt1LnN1enVraUBub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2hpbmljaGlybyBI YW1hamkuCg== 58541 2010-06-11 22:33:25 -0700 2010-06-13 07:36:37 -0700 Patch - rev. #3 site_specific_quirks_mode_3_latest_branch.patch text/plain 2767 adawit ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYnNldHRpbmdzLmNwcCBiL1dlYktpdC9xdC9B cGkvcXdlYnNldHRpbmdzLmNwcAppbmRleCBhNWZjNzk0Li5iZDk3ZjE4IDEwMDY0NAotLS0gYS9X ZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2Vic2V0 dGluZ3MuY3BwCkBAIC0yNDQsNiArMjQ0LDkgQEAgdm9pZCBRV2ViU2V0dGluZ3NQcml2YXRlOjph cHBseSgpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdsb2JhbC0+YXR0 cmlidXRlcy52YWx1ZShRV2ViU2V0dGluZ3M6OlRpbGVkQmFja2luZ1N0b3JlRW5hYmxlZCkpOwog ICAgICAgICBzZXR0aW5ncy0+c2V0VGlsZWRCYWNraW5nU3RvcmVFbmFibGVkKHZhbHVlKTsKICNl bmRpZgorICAgICAgICB2YWx1ZSA9IGF0dHJpYnV0ZXMudmFsdWUoUVdlYlNldHRpbmdzOjpTaXRl U3BlY2lmaWNRdWlya3NFbmFibGVkLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBnbG9iYWwtPmF0dHJpYnV0ZXMudmFsdWUoUVdlYlNldHRpbmdzOjpTaXRlU3BlY2lmaWNR dWlya3NFbmFibGVkKSk7CisgICAgICAgIHNldHRpbmdzLT5zZXROZWVkc1NpdGVTcGVjaWZpY1F1 aXJrcyh2YWx1ZSk7CiAKICAgICAgICAgc2V0dGluZ3MtPnNldFVzZXNQYWdlQ2FjaGUoV2ViQ29y ZTo6cGFnZUNhY2hlKCktPmNhcGFjaXR5KCkpOwogICAgIH0gZWxzZSB7CkBAIC00MjYsNiArNDI5 LDggQEAgUVdlYlNldHRpbmdzKiBRV2ViU2V0dGluZ3M6Omdsb2JhbFNldHRpbmdzKCkKICAgICAg ICAgYW5kIGF0IG90aGVyIHRpbWVzIHNjcm9sbGluZyB0aGUgcGFnZSBpdHNlbGYuIEZvciB0aGlz IHJlYXNvbiBpZnJhbWVzIGFuZCBmcmFtZXNldHMgYXJlCiAgICAgICAgIGJhcmVseSB1c2FibGUg b24gdG91Y2ggZGV2aWNlcy4gVGhpcyB3aWxsIGZsYXR0ZW4gYWxsIHRoZSBmcmFtZXMgdG8gYmVj b21lIG9uZSBzY3JvbGxhYmxlIHBhZ2UuCiAgICAgICAgIFRoaXMgaXMgZGlzYWJsZWQgYnkgZGVm YXVsdC4KKyAgICBcdmFsdWUgU2l0ZVNwZWNpZmljUXVpcmtzRW5hYmxlZCBUaGlzIHNldHRpbmcg ZW5hYmxlcyBXZWJLaXQncyB3b3JrYXJvdW5kIGZvciBicm9rZW4gc2l0ZXMuIEl0IGlzCisgICAg ICAgIGVuYWJsZWQgYnkgZGVmYXVsdC4KICovCiAKIC8qIQpAQCAtNDYxLDYgKzQ2Niw3IEBAIFFX ZWJTZXR0aW5nczo6UVdlYlNldHRpbmdzKCkKICAgICBkLT5hdHRyaWJ1dGVzLmluc2VydChRV2Vi U2V0dGluZ3M6OkFjY2VsZXJhdGVkQ29tcG9zaXRpbmdFbmFibGVkLCB0cnVlKTsKICAgICBkLT5h dHRyaWJ1dGVzLmluc2VydChRV2ViU2V0dGluZ3M6OlRpbGVkQmFja2luZ1N0b3JlRW5hYmxlZCwg ZmFsc2UpOwogICAgIGQtPmF0dHJpYnV0ZXMuaW5zZXJ0KFFXZWJTZXR0aW5nczo6RnJhbWVGbGF0 dGVuaW5nRW5hYmxlZCwgZmFsc2UpOworICAgIGQtPmF0dHJpYnV0ZXMuaW5zZXJ0KFFXZWJTZXR0 aW5nczo6U2l0ZVNwZWNpZmljUXVpcmtzRW5hYmxlZCwgdHJ1ZSk7CiAgICAgZC0+b2ZmbGluZVN0 b3JhZ2VEZWZhdWx0UXVvdGEgPSA1ICogMTAyNCAqIDEwMjQ7CiAgICAgZC0+ZGVmYXVsdFRleHRF bmNvZGluZyA9IFFMYXRpbjFTdHJpbmcoImlzby04ODU5LTEiKTsKIH0KZGlmZiAtLWdpdCBhL1dl YktpdC9xdC9BcGkvcXdlYnNldHRpbmdzLmggYi9XZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5o CmluZGV4IGI5NzhmNWUuLjIwN2E5YjYgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9BcGkvcXdlYnNl dHRpbmdzLmgKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2Vic2V0dGluZ3MuaApAQCAtNzMsNyArNzMs OCBAQCBwdWJsaWM6CiAgICAgICAgIFNwYXRpYWxOYXZpZ2F0aW9uRW5hYmxlZCwKICAgICAgICAg TG9jYWxDb250ZW50Q2FuQWNjZXNzRmlsZVVybHMsCiAgICAgICAgIFRpbGVkQmFja2luZ1N0b3Jl RW5hYmxlZCwKLSAgICAgICAgRnJhbWVGbGF0dGVuaW5nRW5hYmxlZAorICAgICAgICBGcmFtZUZs YXR0ZW5pbmdFbmFibGVkLAorICAgICAgICBTaXRlU3BlY2lmaWNRdWlya3NFbmFibGVkCiAgICAg fTsKICAgICBlbnVtIFdlYkdyYXBoaWMgewogICAgICAgICBNaXNzaW5nSW1hZ2VHcmFwaGljLApk aWZmIC0tZ2l0IGEvV2ViS2l0L3F0L0NoYW5nZUxvZyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cKaW5k ZXggMGI0NDgyZC4uYmFkOWMwMyAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0L0NoYW5nZUxvZworKysg Yi9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDYtMTEgIERhd2l0 IEFsZW1heWVodSAgPGFkYXdpdEBrZGUub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIGFuIGF0dHJpYnV0ZSB0byBlbmFibGUvZGlzYWJs ZSBzaXRlIHNwZWNpZmljIHF1aXJrcyBtb2RlIGluIFdlYktpdC4KKyAgICAgICAgVGhlIGF0dHJp YnV0ZSBpcyBlbmFibGVkIGJ5IGRlZmF1bHQuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTQwMDczCisKKyAgICAgICAgKiBBcGkvcXdlYnNldHRpbmdz LmNwcDoKKyAgICAgICAgKFFXZWJTZXR0aW5nc1ByaXZhdGU6OmFwcGx5KToKKyAgICAgICAgKFFX ZWJTZXR0aW5nczo6UVdlYlNldHRpbmdzKToKKyAgICAgICAgKiBBcGkvcXdlYnNldHRpbmdzLmg6 CisKIDIwMTAtMDYtMTAgIEFuZHkgU2hhdyAgPGFuZHkuc2hhd0Bub2tpYS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4uCg== 58553 2010-06-12 09:13:23 -0700 2010-06-12 11:05:20 -0700 Same patch vs trunk... site_specific_quirks_mode_1_trunk.patch text/plain 2699 adawit ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYnNldHRpbmdzLmNwcCBiL1dlYktpdC9xdC9B cGkvcXdlYnNldHRpbmdzLmNwcAppbmRleCAwZWQ0NTE5Li40ODgxYmFjIDEwMDY0NAotLS0gYS9X ZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2Vic2V0 dGluZ3MuY3BwCkBAIC0yNDYsNiArMjQ2LDEwIEBAIHZvaWQgUVdlYlNldHRpbmdzUHJpdmF0ZTo6 YXBwbHkoKQogICAgICAgICBzZXR0aW5ncy0+c2V0VGlsZWRCYWNraW5nU3RvcmVFbmFibGVkKHZh bHVlKTsKICNlbmRpZgogCisgICAgICAgIHZhbHVlID0gYXR0cmlidXRlcy52YWx1ZShRV2ViU2V0 dGluZ3M6OlNpdGVTcGVjaWZpY1F1aXJrc0VuYWJsZWQsCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGdsb2JhbC0+YXR0cmlidXRlcy52YWx1ZShRV2ViU2V0dGluZ3M6OlNp dGVTcGVjaWZpY1F1aXJrc0VuYWJsZWQpKTsKKyAgICAgICAgc2V0dGluZ3MtPnNldE5lZWRzU2l0 ZVNwZWNpZmljUXVpcmtzKHZhbHVlKTsKKwogICAgICAgICBzZXR0aW5ncy0+c2V0VXNlc1BhZ2VD YWNoZShXZWJDb3JlOjpwYWdlQ2FjaGUoKS0+Y2FwYWNpdHkoKSk7CiAgICAgfSBlbHNlIHsKICAg ICAgICAgUUxpc3Q8UVdlYlNldHRpbmdzUHJpdmF0ZSo+IHNldHRpbmdzID0gKjo6YWxsU2V0dGlu Z3MoKTsKQEAgLTQyOCw2ICs0MzIsOCBAQCBRV2ViU2V0dGluZ3MqIFFXZWJTZXR0aW5nczo6Z2xv YmFsU2V0dGluZ3MoKQogICAgICAgICBhbmQgYXQgb3RoZXIgdGltZXMgc2Nyb2xsaW5nIHRoZSBw YWdlIGl0c2VsZi4gRm9yIHRoaXMgcmVhc29uIGlmcmFtZXMgYW5kIGZyYW1lc2V0cyBhcmUKICAg ICAgICAgYmFyZWx5IHVzYWJsZSBvbiB0b3VjaCBkZXZpY2VzLiBUaGlzIHdpbGwgZmxhdHRlbiBh bGwgdGhlIGZyYW1lcyB0byBiZWNvbWUgb25lIHNjcm9sbGFibGUgcGFnZS4KICAgICAgICAgVGhp cyBpcyBkaXNhYmxlZCBieSBkZWZhdWx0LgorICAgIFx2YWx1ZSBTaXRlU3BlY2lmaWNRdWlya3NF bmFibGVkIFRoaXMgc2V0dGluZyBlbmFibGVzIFdlYktpdCdzIHdvcmthcm91bmQgZm9yIGJyb2tl biBzaXRlcy4gSXQgaXMKKyAgICAgICAgZW5hYmxlZCBieSBkZWZhdWx0LgogKi8KIAogLyohCkBA IC00NjQsNiArNDcwLDcgQEAgUVdlYlNldHRpbmdzOjpRV2ViU2V0dGluZ3MoKQogICAgIGQtPmF0 dHJpYnV0ZXMuaW5zZXJ0KFFXZWJTZXR0aW5nczo6V2ViR0xFbmFibGVkLCBmYWxzZSk7CiAgICAg ZC0+YXR0cmlidXRlcy5pbnNlcnQoUVdlYlNldHRpbmdzOjpUaWxlZEJhY2tpbmdTdG9yZUVuYWJs ZWQsIGZhbHNlKTsKICAgICBkLT5hdHRyaWJ1dGVzLmluc2VydChRV2ViU2V0dGluZ3M6OkZyYW1l RmxhdHRlbmluZ0VuYWJsZWQsIGZhbHNlKTsKKyAgICBkLT5hdHRyaWJ1dGVzLmluc2VydChRV2Vi U2V0dGluZ3M6OlNpdGVTcGVjaWZpY1F1aXJrc0VuYWJsZWQsIHRydWUpOwogICAgIGQtPm9mZmxp bmVTdG9yYWdlRGVmYXVsdFF1b3RhID0gNSAqIDEwMjQgKiAxMDI0OwogICAgIGQtPmRlZmF1bHRU ZXh0RW5jb2RpbmcgPSBRTGF0aW4xU3RyaW5nKCJpc28tODg1OS0xIik7CiB9CmRpZmYgLS1naXQg YS9XZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5oIGIvV2ViS2l0L3F0L0FwaS9xd2Vic2V0dGlu Z3MuaAppbmRleCA2ZTA3ODI5Li5jMDYzYmNkIDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvQXBpL3F3 ZWJzZXR0aW5ncy5oCisrKyBiL1dlYktpdC9xdC9BcGkvcXdlYnNldHRpbmdzLmgKQEAgLTc0LDcg Kzc0LDggQEAgcHVibGljOgogICAgICAgICBMb2NhbENvbnRlbnRDYW5BY2Nlc3NGaWxlVXJscywK ICAgICAgICAgVGlsZWRCYWNraW5nU3RvcmVFbmFibGVkLAogICAgICAgICBGcmFtZUZsYXR0ZW5p bmdFbmFibGVkLAotICAgICAgICBXZWJHTEVuYWJsZWQKKyAgICAgICAgV2ViR0xFbmFibGVkLAor ICAgICAgICBTaXRlU3BlY2lmaWNRdWlya3NFbmFibGVkCiAgICAgfTsKICAgICBlbnVtIFdlYkdy YXBoaWMgewogICAgICAgICBNaXNzaW5nSW1hZ2VHcmFwaGljLApkaWZmIC0tZ2l0IGEvV2ViS2l0 L3F0L0NoYW5nZUxvZyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cKaW5kZXggYTQ1YmNhYy4uMWY2NDli MiAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0L0NoYW5nZUxvZworKysgYi9XZWJLaXQvcXQvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDYtMTIgIERhd2l0IEFsZW1heWVodSAgPGFkYXdp dEBrZGUub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEFkZGVkIGFuIGF0dHJpYnV0ZSB0byBlbmFibGUvZGlzYWJsZSBzaXRlIHNwZWNpZmljIHF1 aXJrcyBtb2RlIGluIFdlYktpdC4gCisgICAgICAgIFRoZSBhdHRyaWJ1dGUgaXMgZW5hYmxlZCBi eSBkZWZhdWx0LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD00MDA3MworCisgICAgICAgICogQXBpL3F3ZWJzZXR0aW5ncy5jcHA6CisgICAgICAgIChR V2ViU2V0dGluZ3NQcml2YXRlOjphcHBseSk6CisgICAgICAgIChRV2ViU2V0dGluZ3M6OlFXZWJT ZXR0aW5ncyk6CisgICAgICAgICogQXBpL3F3ZWJzZXR0aW5ncy5oOgorCiAyMDEwLTA2LTEzICBS b2JlcnQgSG9nYW4gIDxyb2JlcnRAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBB bGV4ZXkgUHJvc2t1cnlha292Lgo=