40062 2010-06-02 08:10:39 -0700 [Qt] On Maemo6 platform auto upper case and predictive text input method hints are not disabled for password field 2011-04-19 05:15:29 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Other Other RESOLVED FIXED Qt, QtTriaged P2 Normal --- 0 raine.makelainen webkit-unassigned commit-queue hausmann kenneth menard thiago.macieira oldest_to_newest 233270 0 raine.makelainen 2010-06-02 08:10:39 -0700 In EditorClientQt::setInputMethodState(bool active) on Maemo6 platform auto upper case and predictive text input input method hints are not disabled for password field. This affect to Virtual Keyboard behaviour. 233279 1 57657 raine.makelainen 2010-06-02 08:32:46 -0700 Created attachment 57657 Fix proposal for disabling auto upper case and predictive text for password field 233313 2 57657 kenneth 2010-06-02 10:16:27 -0700 Comment on attachment 57657 Fix proposal for disabling auto upper case and predictive text for password field WebKit/qt/ChangeLog:11 + No new tests. If there are no new tests you should explain why, or at least leave out this line. R=me, but please fix this and reupload. 233318 3 57666 raine.makelainen 2010-06-02 10:27:07 -0700 Created attachment 57666 Fix proposal 2 for disabling auto upper case and predictive text for password field 233557 4 57666 commit-queue 2010-06-02 18:54:40 -0700 Comment on attachment 57666 Fix proposal 2 for disabling auto upper case and predictive text for password field Clearing flags on attachment: 57666 Committed r60589: <http://trac.webkit.org/changeset/60589> 233558 5 commit-queue 2010-06-02 18:54:45 -0700 All reviewed patches have been landed. Closing bug. 234186 6 hausmann 2010-06-04 06:24:44 -0700 Hnmmn, where is Q_WS_MAEMO_6 defined? I don't see that in the Qt 4.7 builds that are in the queue for Maemo 5. 234324 7 kenneth 2010-06-04 12:15:27 -0700 Thiago, do you know about this? 234736 8 thiago.macieira 2010-06-07 01:12:37 -0700 It's not defined in the official Qt sources. I believe productisation adds it, so it's internal API, not available for webkit. 234772 9 raine.makelainen 2010-06-07 04:07:57 -0700 (In reply to comment #6) > Hnmmn, where is Q_WS_MAEMO_6 defined? I don't see that in the Qt 4.7 builds that are in the queue for Maemo 5. Rodrigo, added this for now to: http://gitorious.org/+qtwebkit-packagers/webkit/qtwebkit-maemo6/blobs/master/debian/rules. 234795 10 hausmann 2010-06-07 04:54:17 -0700 (In reply to comment #9) > (In reply to comment #6) > > Hnmmn, where is Q_WS_MAEMO_6 defined? I don't see that in the Qt 4.7 builds that are in the queue for Maemo 5. > > Rodrigo, added this for now to: > http://gitorious.org/+qtwebkit-packagers/webkit/qtwebkit-maemo6/blobs/master/debian/rules. That's nice, but it's not practical for development. The ability to detect Maemo 6 must come from Qt. Thiago, do you know of any plans to add this to Qt? 234817 11 thiago.macieira 2010-06-07 06:13:42 -0700 Last I checked, there were plans to NEVER add it to Qt. Maemo 6 is X11, there are no differences. If you need to find out more information, you need to add an API for it. I doubt that you're looking for Maemo 6 anyway, but instead to some specific aspect of it that could exist in other X11-based devices. That's why I have strongly opposed ever adding QT_WS_MAEMO_6. 234832 12 hausmann 2010-06-07 07:01:07 -0700 (In reply to comment #11) > Last I checked, there were plans to NEVER add it to Qt. > > Maemo 6 is X11, there are no differences. > > If you need to find out more information, you need to add an API for it. I doubt that you're looking for Maemo 6 anyway, but instead to some specific aspect of it that could exist in other X11-based devices. > > That's why I have strongly opposed ever adding QT_WS_MAEMO_6. Alternatively what would suffice for us would be a way to detect that we're building for a mobile platform, _or_ !desktop for something slightly wider. It would be nice if that came from Qt. Otherwise we have to ask people to build webkit with qmake CONFIG+=mobile if they want to build for a mobile platform, and we introduce our own defines. But then we'd have the same problem within Qt: When WebKit is compiled within Qt for Symbian, Maemo5 or Maemo6 we would want to set that configuration... 234889 13 thiago.macieira 2010-06-07 09:38:54 -0700 I still disagree. What is a netbook? It's halfway between a desktop and a handheld. If you are looking for the form-factor, you should be able to get that from a Qt API. I doubt that you are, though. You are looking for some information on the input mechanisms that exist for the current device. 234998 14 kenneth 2010-06-07 12:28:16 -0700 (In reply to comment #13) > I still disagree. What is a netbook? It's halfway between a desktop and a handheld. > > If you are looking for the form-factor, you should be able to get that from a Qt API. I doubt that you are, though. > > You are looking for some information on the input mechanisms that exist for the current device. If Qt could define these input method flags and put them all in Qt 4.7, we would have no problem, as they could be ignored by platforms not knowing about them. I guess the problems is that these are not defined for vanilla Qt, but only for the one distributed with Maemo5 and Symbian. 245206 15 hausmann 2010-07-01 01:44:12 -0700 (In reply to comment #14) > (In reply to comment #13) > > I still disagree. What is a netbook? It's halfway between a desktop and a handheld. > > > > If you are looking for the form-factor, you should be able to get that from a Qt API. I doubt that you are, though. > > > > You are looking for some information on the input mechanisms that exist for the current device. > > If Qt could define these input method flags and put them all in Qt 4.7, we would have no problem, as they could be ignored by platforms not knowing about them. > > I guess the problems is that these are not defined for vanilla Qt, but only for the one distributed with Maemo5 and Symbian. Actually these flags are available on all platforms. We could remove the #ifdefs and it would compile. But the question really is: Why is predictive text input and auto-uppercasing disabled for mobile devices? Right now it's done for _any_ inputs, and if it should be done only for password fields, then it should be the input method that decides to do that, because it has all the hints set. I'd like to remove this block of code altogether. 245239 16 57657 eric 2010-07-01 03:16:17 -0700 Comment on attachment 57657 Fix proposal for disabling auto upper case and predictive text for password field Cleared Kenneth Rohde Christiansen's review+ from obsolete attachment 57657 so that this bug does not appear in http://webkit.org/pending-commit. 356047 17 menard 2011-02-23 06:02:51 -0800 The patch has landed http://trac.webkit.org/changeset/60589 57657 2010-06-02 08:32:46 -0700 2010-07-01 03:16:17 -0700 Fix proposal for disabling auto upper case and predictive text for password field 0001-Fix-proposal-for-disabling-auto-upper-case-and-predi.patch text/plain 2309 raine.makelainen RnJvbSAzY2Y2ZGRkOGVkZWY2MTkyYzgyNGJlY2Y4OWZkMGEzZGJlZmUwMTk1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSYWluZSBNYWtlbGFpbmVuIDxyYWluZS5tYWtlbGFpbmVuQG5v a2lhLmNvbT4KRGF0ZTogV2VkLCAyIEp1biAyMDEwIDE4OjI2OjM5ICswMzAwClN1YmplY3Q6IFtQ QVRDSF0gRml4IHByb3Bvc2FsIGZvciBkaXNhYmxpbmcgYXV0byB1cHBlciBjYXNlIGFuZCBwcmVk aWN0aXZlIHRleHQuCgpTaWduZWQtb2ZmLWJ5OiBSYWluZSBNYWtlbGFpbmVuIDxyYWluZS5tYWtl bGFpbmVuQG5va2lhLmNvbT4KLS0tCiBXZWJLaXQvcXQvQ2hhbmdlTG9nICAgICAgICAgICAgICAg ICAgICAgICAgIHwgICAxNSArKysrKysrKysrKysrKysKIFdlYktpdC9xdC9XZWJDb3JlU3VwcG9y dC9FZGl0b3JDbGllbnRRdC5jcHAgfCAgICA0ICsrLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTcgaW5z ZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQ2hhbmdl TG9nIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwppbmRleCAxMWFhNzE2Li4yZTU0YTI4IDEwMDY0NAot LS0gYS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxMC0wNi0wMiAgUmFpbmUgTWFrZWxhaW5lbiAgPHJhaW5lLm1ha2VsYWlu ZW5Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtRdF0gT24gTWFlbW82IHBsYXRmb3JtIGF1dG8gdXBwZXIgY2FzZSBhbmQgcHJlZGlj dGl2ZSB0ZXh0IGlucHV0IG1ldGhvZCBoaW50cyBhcmUgbm90IGRpc2FibGVkIGZvciBwYXNzd29y ZCBmaWVsZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQwMDYyCisgICAgICAgCisgICAgICAgIEludHJvZHVjaW5nIFFfV1NfTUFFTU9fNiBmb3IgTWFl bW82IHNwZWNpZmljIGNvZGUuIEVuYWJsaW5nIGNvZGUgdGhhdCBzZXRzIGlucHV0IAorICAgICAg ICBtZXRob2QgaGludHMgUXQ6OkltaE5vQXV0b1VwcGVyY2FzZSBhbmQgUXQ6OkltaE5vUHJlZGlj dGl2ZVRleHQgdHJ1ZSBmb3IgTWFlbW82LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4KKworICAg ICAgICAqIFdlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudFF0LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkVkaXRvckNsaWVudFF0OjpzZXRJbnB1dE1ldGhvZFN0YXRlKToKKwogMjAxMC0wNi0wMSAg WWFlbCBBaGFyb24gIDx5YWVsLmFoYXJvbkBub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvV2Vi Q29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50UXQuY3BwIGIvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0 L0VkaXRvckNsaWVudFF0LmNwcAppbmRleCAwZjU0ZTIxLi4xZmQ0NjJjIDEwMDY0NAotLS0gYS9X ZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50UXQuY3BwCisrKyBiL1dlYktpdC9x dC9XZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGllbnRRdC5jcHAKQEAgLTYwNiwxMSArNjA2LDExIEBA IHZvaWQgRWRpdG9yQ2xpZW50UXQ6OnNldElucHV0TWV0aG9kU3RhdGUoYm9vbCBhY3RpdmUpCiAg ICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICAgICAgd2ViUGFnZUNsaWVudC0+c2V0SW5wdXRN ZXRob2RIaW50KFF0OjpJbWhIaWRkZW5UZXh0LCBpc1Bhc3N3b3JkRmllbGQpOwotI2lmIGRlZmlu ZWQoUV9XU19NQUVNT181KSB8fCBkZWZpbmVkKFFfT1NfU1lNQklBTikKKyNpZiBkZWZpbmVkKFFf V1NfTUFFTU9fNSkgfHwgZGVmaW5lZChRX1dTX01BRU1PXzYpIHx8IGRlZmluZWQoUV9PU19TWU1C SUFOKQogICAgICAgICAvLyBkaXNhYmxlcyBhdXRvLXVwcGVyY2FzZSBhbmQgcHJlZGljdGl2ZSB0 ZXh0IGZvciBtb2JpbGUgZGV2aWNlcwogICAgICAgICB3ZWJQYWdlQ2xpZW50LT5zZXRJbnB1dE1l dGhvZEhpbnQoUXQ6OkltaE5vQXV0b1VwcGVyY2FzZSwgdHJ1ZSk7CiAgICAgICAgIHdlYlBhZ2VD bGllbnQtPnNldElucHV0TWV0aG9kSGludChRdDo6SW1oTm9QcmVkaWN0aXZlVGV4dCwgdHJ1ZSk7 Ci0jZW5kaWYgLy8gUV9XU19NQUVNT181IHx8IFFfT1NfU1lNQklBTgorI2VuZGlmIC8vIFFfV1Nf TUFFTU9fNSB8fCBRX1dTX01BRU1PXzYgfHwgUV9PU19TWU1CSUFOCiAjZW5kaWYgLy8gUVRfVkVS U0lPTiBjaGVjawogICAgICAgICB3ZWJQYWdlQ2xpZW50LT5zZXRJbnB1dE1ldGhvZEVuYWJsZWQo YWN0aXZlKTsKICAgICB9Ci0tIAoxLjYuMy4zCgo= 57666 2010-06-02 10:27:07 -0700 2010-07-01 01:45:05 -0700 Fix proposal 2 for disabling auto upper case and predictive text for password field 0001-Fix-proposal-for-disabling-auto-upper-case-and-predi.patch text/plain 2282 raine.makelainen RnJvbSAwNWI2MzExMTFlZGRhMTJhM2RiMjgyZTNmYjQzYmNmMmViNWMzMzdjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSYWluZSBNYWtlbGFpbmVuIDxyYWluZS5tYWtlbGFpbmVuQG5v a2lhLmNvbT4KRGF0ZTogV2VkLCAyIEp1biAyMDEwIDIwOjIyOjEyICswMzAwClN1YmplY3Q6IFtQ QVRDSF0gRml4IHByb3Bvc2FsIGZvciBkaXNhYmxpbmcgYXV0byB1cHBlciBjYXNlIGFuZCBwcmVk aWN0aXZlIHRleHQuCgpTaWduZWQtb2ZmLWJ5OiBSYWluZSBNYWtlbGFpbmVuIDxyYWluZS5tYWtl bGFpbmVuQG5va2lhLmNvbT4KLS0tCiBXZWJLaXQvcXQvQ2hhbmdlTG9nICAgICAgICAgICAgICAg ICAgICAgICAgIHwgICAxMyArKysrKysrKysrKysrCiBXZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQv RWRpdG9yQ2xpZW50UXQuY3BwIHwgICAgNCArKy0tCiAyIGZpbGVzIGNoYW5nZWQsIDE1IGluc2Vy dGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L0NoYW5nZUxv ZyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cKaW5kZXggMTFhYTcxNi4uZWQyMjU3NyAxMDA2NDQKLS0t IGEvV2ViS2l0L3F0L0NoYW5nZUxvZworKysgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTYgQEAKKzIwMTAtMDYtMDIgIFJhaW5lIE1ha2VsYWluZW4gIDxyYWluZS5tYWtlbGFpbmVu QG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbUXRdIE9uIE1hZW1vNiBwbGF0Zm9ybSBhdXRvIHVwcGVyIGNhc2UgYW5kIHByZWRpY3Rp dmUgdGV4dCBpbnB1dCBtZXRob2QgaGludHMgYXJlIG5vdCBkaXNhYmxlZCBmb3IgcGFzc3dvcmQg ZmllbGQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00 MDA2MgorICAgICAgIAorICAgICAgICBJbnRyb2R1Y2luZyBRX1dTX01BRU1PXzYgZm9yIE1hZW1v NiBzcGVjaWZpYyBjb2RlLiBFbmFibGluZyBjb2RlIHRoYXQgc2V0cyBpbnB1dCAKKyAgICAgICAg bWV0aG9kIGhpbnRzIFF0OjpJbWhOb0F1dG9VcHBlcmNhc2UgYW5kIFF0OjpJbWhOb1ByZWRpY3Rp dmVUZXh0IHRydWUgZm9yIE1hZW1vNi4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0VkaXRv ckNsaWVudFF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVkaXRvckNsaWVudFF0OjpzZXRJbnB1 dE1ldGhvZFN0YXRlKToKKwogMjAxMC0wNi0wMSAgWWFlbCBBaGFyb24gIDx5YWVsLmFoYXJvbkBu b2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5z ZW4uCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50UXQu Y3BwIGIvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudFF0LmNwcAppbmRleCAw ZjU0ZTIxLi4xZmQ0NjJjIDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRWRp dG9yQ2xpZW50UXQuY3BwCisrKyBiL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGll bnRRdC5jcHAKQEAgLTYwNiwxMSArNjA2LDExIEBAIHZvaWQgRWRpdG9yQ2xpZW50UXQ6OnNldElu cHV0TWV0aG9kU3RhdGUoYm9vbCBhY3RpdmUpCiAgICAgICAgICAgICB9CiAgICAgICAgIH0KICAg ICAgICAgd2ViUGFnZUNsaWVudC0+c2V0SW5wdXRNZXRob2RIaW50KFF0OjpJbWhIaWRkZW5UZXh0 LCBpc1Bhc3N3b3JkRmllbGQpOwotI2lmIGRlZmluZWQoUV9XU19NQUVNT181KSB8fCBkZWZpbmVk KFFfT1NfU1lNQklBTikKKyNpZiBkZWZpbmVkKFFfV1NfTUFFTU9fNSkgfHwgZGVmaW5lZChRX1dT X01BRU1PXzYpIHx8IGRlZmluZWQoUV9PU19TWU1CSUFOKQogICAgICAgICAvLyBkaXNhYmxlcyBh dXRvLXVwcGVyY2FzZSBhbmQgcHJlZGljdGl2ZSB0ZXh0IGZvciBtb2JpbGUgZGV2aWNlcwogICAg ICAgICB3ZWJQYWdlQ2xpZW50LT5zZXRJbnB1dE1ldGhvZEhpbnQoUXQ6OkltaE5vQXV0b1VwcGVy Y2FzZSwgdHJ1ZSk7CiAgICAgICAgIHdlYlBhZ2VDbGllbnQtPnNldElucHV0TWV0aG9kSGludChR dDo6SW1oTm9QcmVkaWN0aXZlVGV4dCwgdHJ1ZSk7Ci0jZW5kaWYgLy8gUV9XU19NQUVNT181IHx8 IFFfT1NfU1lNQklBTgorI2VuZGlmIC8vIFFfV1NfTUFFTU9fNSB8fCBRX1dTX01BRU1PXzYgfHwg UV9PU19TWU1CSUFOCiAjZW5kaWYgLy8gUVRfVkVSU0lPTiBjaGVjawogICAgICAgICB3ZWJQYWdl Q2xpZW50LT5zZXRJbnB1dE1ldGhvZEVuYWJsZWQoYWN0aXZlKTsKICAgICB9Ci0tIAoxLjYuMy4z Cgo=