40046 2010-06-01 23:58:15 -0700 [gtk] Compilation error when you disable DRAG SUPPORT. 2014-02-03 07:57:45 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 deepak.m webkit-unassigned deepak.deepakmittal gustavo levin zan oldest_to_newest 233106 0 deepak.m 2010-06-01 23:58:15 -0700 Hi, There was a compilation error when you disable DRAG SUPPORT. ENABLE(DRAG_SUPPORT) wrappers were missing in WebCore/page/gtk/EventHandlerGtk.cpp Since i was using release version i checked out EventHandlerGtk.cpp from nightly build and manually created patch using diff and added changelog. 233108 1 57629 deepak.m 2010-06-02 00:02:23 -0700 Created attachment 57629 Fix compilation when DRAG_SUPPORT disabled This will add missing ENABLE(DRAG_SUPPORT) in WebCore/page/gtk/EventHandlerGtk.cpp 233122 2 57629 levin 2010-06-02 00:59:11 -0700 Comment on attachment 57629 Fix compilation when DRAG_SUPPORT disabled > 2010-06-02 Deepak Mundra <deepak.m@allaboutif.com> > > Reviewed by NOBODY (OOPS!). > > Fix compilation, when you disable DRAG SUPPORT. > ENABLE(DRAG_SUPPORT) wrappers were missing in WebCore/page/gtk/EventHandlerGtk.cpp. The general idea looks great, but this patch isn't well formed, so it doesn't apply on the bots and it wouldn't go through using the commit queue. It looks like you may have a ChangeLog but the file that it applies to is not in the patch. If you need help preparing your patch, please see http://webkit.org/coding/contributing.html. Note that this ChangeLog is missing a *bug link* which is also typical for ChangeLog entries. when you put the patch up for review again, consider marking it commit-queue? so that the reviewer will also mark it as commit-queue+ and it will get committed for you. 975860 3 deepak.deepakmittal 2014-02-03 07:38:22 -0800 Changes already came in the latest code and it is building properly so closing this issue as Fixed. 975863 4 zan 2014-02-03 07:57:45 -0800 OK, thanks for reporting back. 57629 2010-06-02 00:02:23 -0700 2010-06-11 14:31:48 -0700 Fix compilation when DRAG_SUPPORT disabled Wcpge.patch text/plain 1015 deepak.m MjAxMC0wNi0wMiAgRGVlcGFrIE11bmRyYSAgPGRlZXBhay5tQGFsbGFib3V0aWYuY29tPgoKICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgRml4IGNvbXBpbGF0aW9u LCB3aGVuIHlvdSBkaXNhYmxlIERSQUcgU1VQUE9SVC4KICAgICAgICBFTkFCTEUoRFJBR19TVVBQ T1JUKSB3cmFwcGVycyB3ZXJlIG1pc3NpbmcgaW4gV2ViQ29yZS9wYWdlL2d0ay9FdmVudEhhbmRs ZXJHdGsuY3BwLgotLS0KCi0tLSBXZWJDb3JlL3BhZ2UvZ3RrL0V2ZW50SGFuZGxlckd0ay5jcHAJ MjAxMC0wNi0wMiAxMTo1MDozNy4wMDAwMDAwMDAgKzA1MzAKKysrIFdlYkNvcmUvcGFnZS9ndGsv RXZlbnRIYW5kbGVyR3RrLmNwcAkyMDEwLTA2LTAyIDEyOjAzOjM2LjAwMDAwMDAwMCArMDUzMApA QCAtNDIsNyArNDIsOSBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKKyNpZiBFTkFCTEUoRFJB R19TVVBQT1JUKQogY29uc3QgZG91YmxlIEV2ZW50SGFuZGxlcjo6VGV4dERyYWdEZWxheSA9IDAu MDsKKyNlbmRpZgogCiBib29sIEV2ZW50SGFuZGxlcjo6dGFic1RvQWxsQ29udHJvbHMoS2V5Ym9h cmRFdmVudCogZXZlbnQpIGNvbnN0CiB7CkBAIC05NCwxMCArOTYsMTIgQEAKICAgICByZXR1cm4g c3RhdGljX2Nhc3Q8RnJhbWVWaWV3Kj4od2lkZ2V0KS0+ZnJhbWUoKS0+ZXZlbnRIYW5kbGVyKCkt PmhhbmRsZVdoZWVsRXZlbnQoZXZlbnQpOwogfQogCisjaWYgRU5BQkxFKERSQUdfU1VQUE9SVCkK IFBhc3NSZWZQdHI8Q2xpcGJvYXJkPiBFdmVudEhhbmRsZXI6OmNyZWF0ZURyYWdnaW5nQ2xpcGJv YXJkKCkgY29uc3QKIHsKICAgICByZXR1cm4gQ2xpcGJvYXJkR3RrOjpjcmVhdGUoQ2xpcGJvYXJk V3JpdGFibGUsIERhdGFPYmplY3RHdGs6OmNyZWF0ZSgpLCB0cnVlKTsKIH0KKyNlbmRpZgogCiBi b29sIEV2ZW50SGFuZGxlcjo6cGFzc01vdXNlUHJlc3NFdmVudFRvU3ViZnJhbWUoTW91c2VFdmVu dFdpdGhIaXRUZXN0UmVzdWx0cyYgbWV2LCBGcmFtZSogc3ViZnJhbWUpCiB7Cg==