40040 2010-06-01 21:12:35 -0700 Web Inspector: Timeline should nicely format the Timer timeout 2010-06-02 02:54:46 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 joepeck joepeck bweinstein commit-queue joepeck keishi pfeldman pmuellr rik timothy yurys oldest_to_newest 233060 0 joepeck 2010-06-01 21:12:35 -0700 Given the following: setTimeout(function(){}, 15000); I expected to see "15s" in the info bubble for the Timer on the Timeline panel. Instead I saw the unitless 15000. Is this worth testing? Its just a matter of applying the number formatter. 233061 1 57618 joepeck 2010-06-01 21:15:18 -0700 Created attachment 57618 [PATCH] Use Number.secondsToString I like this formatter, because it will turn 15000 into 15s. However, it does round. So 12345 becomes 12.35s. 233178 2 57618 commit-queue 2010-06-02 02:54:40 -0700 Comment on attachment 57618 [PATCH] Use Number.secondsToString Clearing flags on attachment: 57618 Committed r60552: <http://trac.webkit.org/changeset/60552> 233179 3 commit-queue 2010-06-02 02:54:46 -0700 All reviewed patches have been landed. Closing bug. 57618 2010-06-01 21:15:18 -0700 2010-06-02 02:54:40 -0700 [PATCH] Use Number.secondsToString timer-format.patch text/plain 1576 joepeck ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZmZjNDMwNy4uMGM5YTVlNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNi0wMSAgSm9zZXBoIFBlY29y YXJvICA8am9lcGVja0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFRpbWVsaW5lIHNob3VsZCBuaWNlbHkg Zm9ybWF0IHRoZSBUaW1lciB0aW1lb3V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00MDA0MAorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9U aW1lbGluZVBhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lUGFuZWwuRm9y bWF0dGVkUmVjb3JkLnByb3RvdHlwZS5fZ2VuZXJhdGVQb3B1cENvbnRlbnQpOiBGb3JtYXQgdGhl IFRpbWVyJ3MgdGltZW91dCB0aW1lLgorCiAyMDEwLTA2LTAxICBNYXJrIFJvd2UgIDxtcm93ZUBh cHBsZS5jb20+CiAKICAgICAgICAgUnViYmVyLXN0YW1wZWQgYnkgQWRhbSBSb2Jlbi4KZGlmZiAt LWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZVBhbmVsLmpzIGIvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RpbWVsaW5lUGFuZWwuanMKaW5kZXggYjlmMDgxNC4u MjllZmQ3OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RpbWVsaW5l UGFuZWwuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RpbWVsaW5lUGFuZWwu anMKQEAgLTk0MCw3ICs5NDAsNyBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVQYW5lbC5Gb3JtYXR0 ZWRSZWNvcmQucHJvdG90eXBlID0gewogICAgICAgICAgICAgY2FzZSByZWNvcmRUeXBlcy5UaW1l clJlbW92ZToKICAgICAgICAgICAgICAgICBjb250ZW50SGVscGVyLl9hcHBlbmRUZXh0Um93KFdl Ykluc3BlY3Rvci5VSVN0cmluZygiVGltZXIgSUQiKSwgdGhpcy5kYXRhLnRpbWVySWQpOwogICAg ICAgICAgICAgICAgIGlmICh0eXBlb2YgdGhpcy50aW1lb3V0ID09PSAibnVtYmVyIikgewotICAg ICAgICAgICAgICAgICAgICBjb250ZW50SGVscGVyLl9hcHBlbmRUZXh0Um93KFdlYkluc3BlY3Rv ci5VSVN0cmluZygiVGltZW91dCIpLCB0aGlzLnRpbWVvdXQpOworICAgICAgICAgICAgICAgICAg ICBjb250ZW50SGVscGVyLl9hcHBlbmRUZXh0Um93KFdlYkluc3BlY3Rvci5VSVN0cmluZygiVGlt ZW91dCIpLCBOdW1iZXIuc2Vjb25kc1RvU3RyaW5nKHRoaXMudGltZW91dCAvIDEwMDAsIFdlYklu c3BlY3Rvci5VSVN0cmluZykpOwogICAgICAgICAgICAgICAgICAgICBjb250ZW50SGVscGVyLl9h cHBlbmRUZXh0Um93KFdlYkluc3BlY3Rvci5VSVN0cmluZygiUmVwZWF0cyIpLCAhdGhpcy5zaW5n bGVTaG90KTsKICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgaWYgKHR5cGVvZiB0 aGlzLmNhbGxTaXRlU2NyaXB0TGluZSA9PT0gIm51bWJlciIpCg==