40034 2010-06-01 17:58:52 -0700 WebFrame::paintDocumentRectToContextAtPoint doesn't paint scrollbars 2010-06-04 17:11:19 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 alice.barraclough alice.barraclough oldest_to_newest 233011 0 alice.barraclough 2010-06-01 17:58:52 -0700 WebFrame::paintDocumentRectToContextAtPoint doesn't paint scrollbars, and I think it should. Otherwise calling this function with a region the same size as the webview will result in a blank unpainted space where the scrollbars would have been. <rdar://problem/7799848> 234398 1 57920 alice.barraclough 2010-06-04 14:53:02 -0700 Created attachment 57920 patch 234406 2 57923 alice.barraclough 2010-06-04 15:50:21 -0700 Created attachment 57923 patch that also renames 234425 3 57923 jhoneycutt 2010-06-04 16:55:44 -0700 Comment on attachment 57923 patch that also renames r=me 234427 4 alice.barraclough 2010-06-04 17:11:19 -0700 http://trac.webkit.org/changeset/60722 57920 2010-06-04 14:53:02 -0700 2010-06-04 15:50:21 -0700 patch patch-paint-scrollbars.txt text/plain 1337 alice.barraclough SW5kZXg6IFdlYktpdC93aW4vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93aW4vQ2hh bmdlTG9nCShyZXZpc2lvbiA2MDcwOCkKKysrIFdlYktpdC93aW4vQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDYtMDQgIEFsaWNlIExpdSAgPGFsaWNlLmxp dUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgV2ViRnJhbWU6OnBhaW50RG9jdW1lbnRSZWN0VG9Db250ZXh0QXRQb2ludCBkb2Vzbid0 IHBhaW50IHNjcm9sbGJhcnMKKyAgICAgICAgaHBwdHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTQwMDM0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83Nzk5ODQ4PgorCisgICAg ICAgICogV2ViRnJhbWUuY3BwOgorICAgICAgICAoV2ViRnJhbWU6OnBhaW50RG9jdW1lbnRSZWN0 VG9Db250ZXh0QXRQb2ludCk6IENhbGwgcGFpbnQoKSBpbnN0ZWFkIG9mIHBhaW50Q29udGVudHMo KS4KKyAgICAgICAgQWxzbyBtb3ZlIHRoZSBkaXJ0eVJlY3QgdG8gY291bnRlcmFjdCB0aGUgbW92 aW5nIHRoYXQgaGFwcGVucyBpbiBwYWludCgpLgorCiAyMDEwLTA1LTMwICBEYW5pZWwgQmF0ZXMg IDxkYmF0ZXNAcmltLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBhdHRlbXB0IHRvIGZpeCB0 aGUgYnVpbGQgYWZ0ZXIgaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvNjA0MTguCklu ZGV4OiBXZWJLaXQvd2luL1dlYkZyYW1lLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvd2luL1dl YkZyYW1lLmNwcAkocmV2aXNpb24gNjA2NDApCisrKyBXZWJLaXQvd2luL1dlYkZyYW1lLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMzgwLDkgKzM4MCw4IEBAIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZ UEUgV2ViRnJhbWU6OnBhaW4KICAgICBnYy5zZXRTaG91bGRJbmNsdWRlQ2hpbGRXaW5kb3dzKHRy dWUpOwogICAgIGdjLnNhdmUoKTsKICAgICBJbnRSZWN0IGRpcnR5UmVjdChyZWN0KTsKLSAgICBn Yy50cmFuc2xhdGUoLXB0LngsIC1wdC55KTsKLSAgICBnYy5jbGlwKGRpcnR5UmVjdCk7Ci0gICAg dmlldy0+cGFpbnRDb250ZW50cygmZ2MsIHJlY3QpOworICAgIGRpcnR5UmVjdC5tb3ZlKC1wdC54 LCAtcHQueSk7CisgICAgdmlldy0+cGFpbnQoJmdjLCBkaXJ0eVJlY3QpOwogICAgIGdjLnJlc3Rv cmUoKTsKIAogICAgIHJldHVybiBTX09LOwo= 57923 2010-06-04 15:50:21 -0700 2010-06-04 16:55:43 -0700 patch that also renames patch-paint-scrollbars-rename.txt text/plain 5539 alice.barraclough SW5kZXg6IFdlYktpdC93aW4vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93aW4vQ2hh bmdlTG9nCShyZXZpc2lvbiA2MDcxMykKKysrIFdlYktpdC93aW4vQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTAtMDYtMDQgIEFsaWNlIExpdSAgPGFsaWNlLmxp dUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgV2ViRnJhbWU6OnBhaW50RG9jdW1lbnRSZWN0VG9Db250ZXh0QXRQb2ludCBkb2Vzbid0 IHBhaW50IHNjcm9sbGJhcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTQwMDM0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83Nzk5ODQ4PgorCisgICAg ICAgICogV2ViRnJhbWUuY3BwOgorICAgICAgICAoV2ViRnJhbWU6OnBhaW50U2Nyb2xsVmlld1Jl Y3RUb0NvbnRleHRBdFBvaW50KTogUmVuYW1lZCBmcm9tIHBhaW50RG9jdW1lbnRSZWN0VG9Db250 ZXh0QXRQb2ludC4gCisgICAgICAgIENhbGwgcGFpbnQoKSBpbnN0ZWFkIG9mIHBhaW50Q29udGVu dHMoKS4gQWxzbyBtb3ZlIHRoZSBkaXJ0eVJlY3QgdG8gY291bnRlcmFjdCB0aGUgbW92aW5nIHRo YXQgaGFwcGVucyBpbiBwYWludCgpLgorCisgICAgICAgIEp1c3QgcmVuYW1pbmcgY2hhbmdlczoK KyAgICAgICAgKiBJbnRlcmZhY2VzL0lXZWJGcmFtZVByaXZhdGUuaWRsOgorICAgICAgICAqIElu dGVyZmFjZXMvSVdlYlZpZXdQcml2YXRlLmlkbDoKKyAgICAgICAgKiBXZWJGcmFtZS5oOgorICAg ICAgICAqIFdlYlZpZXcuY3BwOgorICAgICAgICAoV2ViVmlldzo6cGFpbnRTY3JvbGxWaWV3UmVj dFRvQ29udGV4dEF0UG9pbnQpOgorICAgICAgICAqIFdlYlZpZXcuaDoKKworICAgICAgICAqIElu dGVyZmFjZXMvV2ViS2l0LmlkbDogVG91Y2hlZCBmb3IgcmVidWlsZC4KKwogMjAxMC0wNS0zMCAg RGFuaWVsIEJhdGVzICA8ZGJhdGVzQHJpbS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgYXR0 ZW1wdCB0byBmaXggdGhlIGJ1aWxkIGFmdGVyIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdl c2V0LzYwNDE4LgpJbmRleDogV2ViS2l0L3dpbi9XZWJGcmFtZS5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViS2l0L3dpbi9XZWJGcmFtZS5jcHAJKHJldmlzaW9uIDYwNjQwKQorKysgV2ViS2l0L3dpbi9X ZWJGcmFtZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM1OSw3ICszNTksNyBAQCBIUkVTVUxUIFNU RE1FVEhPRENBTExUWVBFIFdlYkZyYW1lOjpwYWluCiAgICAgcmV0dXJuIFNfT0s7CiB9CiAKLUhS RVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgV2ViRnJhbWU6OnBhaW50RG9jdW1lbnRSZWN0VG9Db250 ZXh0QXRQb2ludCgKK0hSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgV2ViRnJhbWU6OnBhaW50U2Ny b2xsVmlld1JlY3RUb0NvbnRleHRBdFBvaW50KAogICAgIC8qIFtpbl0gKi8gUkVDVCByZWN0LAog ICAgIC8qIFtpbl0gKi8gUE9JTlQgcHQsCiAgICAgLyogW2luXSAqLyBPTEVfSEFORExFIGRldmlj ZUNvbnRleHQpCkBAIC0zODAsOSArMzgwLDggQEAgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBX ZWJGcmFtZTo6cGFpbgogICAgIGdjLnNldFNob3VsZEluY2x1ZGVDaGlsZFdpbmRvd3ModHJ1ZSk7 CiAgICAgZ2Muc2F2ZSgpOwogICAgIEludFJlY3QgZGlydHlSZWN0KHJlY3QpOwotICAgIGdjLnRy YW5zbGF0ZSgtcHQueCwgLXB0LnkpOwotICAgIGdjLmNsaXAoZGlydHlSZWN0KTsKLSAgICB2aWV3 LT5wYWludENvbnRlbnRzKCZnYywgcmVjdCk7CisgICAgZGlydHlSZWN0Lm1vdmUoLXB0LngsIC1w dC55KTsKKyAgICB2aWV3LT5wYWludCgmZ2MsIGRpcnR5UmVjdCk7CiAgICAgZ2MucmVzdG9yZSgp OwogCiAgICAgcmV0dXJuIFNfT0s7CkluZGV4OiBXZWJLaXQvd2luL1dlYkZyYW1lLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViS2l0L3dpbi9XZWJGcmFtZS5oCShyZXZpc2lvbiA2MDY0MCkKKysrIFdlYktp dC93aW4vV2ViRnJhbWUuaAkod29ya2luZyBjb3B5KQpAQCAtMjQ1LDcgKzI0NSw3IEBAIHB1Ymxp YzoKICAgICAgICAgLyogW2luXSAqLyBSRUNUIHJlY3QsCiAgICAgICAgIC8qIFtpbl0gKi8gT0xF X0hBTkRMRSBkZXZpY2VDb250ZXh0KTsKIAotICAgIHZpcnR1YWwgSFJFU1VMVCBTVERNRVRIT0RD QUxMVFlQRSBwYWludERvY3VtZW50UmVjdFRvQ29udGV4dEF0UG9pbnQoCisgICAgdmlydHVhbCBI UkVTVUxUIFNURE1FVEhPRENBTExUWVBFIHBhaW50U2Nyb2xsVmlld1JlY3RUb0NvbnRleHRBdFBv aW50KAogICAgICAgICAvKiBbaW5dICovIFJFQ1QgcmVjdCwKICAgICAgICAgLyogW2luXSAqLyBQ T0lOVCBwdCwKICAgICAgICAgLyogW2luXSAqLyBPTEVfSEFORExFIGRldmljZUNvbnRleHQpOwpJ bmRleDogV2ViS2l0L3dpbi9XZWJWaWV3LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvd2luL1dl YlZpZXcuY3BwCShyZXZpc2lvbiA2MDY0MCkKKysrIFdlYktpdC93aW4vV2ViVmlldy5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTU2NzYsNyArNTY3Niw3IEBAIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZ UEUgV2ViVmlldzo6cGFpbnQKICAgICByZXR1cm4gbV9tYWluRnJhbWUtPnBhaW50RG9jdW1lbnRS ZWN0VG9Db250ZXh0KHJlY3QsIGRldmljZUNvbnRleHQpOwogfQogCi1IUkVTVUxUIFNURE1FVEhP RENBTExUWVBFIFdlYlZpZXc6OnBhaW50RG9jdW1lbnRSZWN0VG9Db250ZXh0QXRQb2ludCgKK0hS RVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgV2ViVmlldzo6cGFpbnRTY3JvbGxWaWV3UmVjdFRvQ29u dGV4dEF0UG9pbnQoCiAgICAgLyogW2luXSAqLyBSRUNUIHJlY3QsCiAgICAgLyogW2luXSAqLyBQ T0lOVCBwdCwKICAgICAvKiBbaW5dICovIE9MRV9IQU5ETEUgZGV2aWNlQ29udGV4dCkKQEAgLTU2 ODcsNyArNTY4Nyw3IEBAIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgV2ViVmlldzo6cGFpbnQK ICAgICBpZiAoIW1fbWFpbkZyYW1lKQogICAgICAgICByZXR1cm4gRV9GQUlMOwogCi0gICAgcmV0 dXJuIG1fbWFpbkZyYW1lLT5wYWludERvY3VtZW50UmVjdFRvQ29udGV4dEF0UG9pbnQocmVjdCwg cHQsIGRldmljZUNvbnRleHQpOworICAgIHJldHVybiBtX21haW5GcmFtZS0+cGFpbnRTY3JvbGxW aWV3UmVjdFRvQ29udGV4dEF0UG9pbnQocmVjdCwgcHQsIGRldmljZUNvbnRleHQpOwogfQogCiBI UkVTVUxUIFNURE1FVEhPRENBTExUWVBFIFdlYlZpZXc6OnJlcG9ydEV4Y2VwdGlvbigKSW5kZXg6 IFdlYktpdC93aW4vV2ViVmlldy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93aW4vV2ViVmlldy5o CShyZXZpc2lvbiA2MDY0MCkKKysrIFdlYktpdC93aW4vV2ViVmlldy5oCSh3b3JraW5nIGNvcHkp CkBAIC02OTcsNyArNjk3LDcgQEAgcHVibGljOgogICAgICAgICAvKiBbaW5dICovIFJFQ1QgcmVj dCwKICAgICAgICAgLyogW2luXSAqLyBPTEVfSEFORExFIGRjKTsKIAotICAgIHZpcnR1YWwgSFJF U1VMVCBTVERNRVRIT0RDQUxMVFlQRSBwYWludERvY3VtZW50UmVjdFRvQ29udGV4dEF0UG9pbnQo CisgICAgdmlydHVhbCBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIHBhaW50U2Nyb2xsVmlld1Jl Y3RUb0NvbnRleHRBdFBvaW50KAogICAgICAgICAvKiBbaW5dICovIFJFQ1QgcmVjdCwKICAgICAg ICAgLyogW2luXSAqLyBQT0lOVCBwdCwKICAgICAgICAgLyogW2luXSAqLyBPTEVfSEFORExFIGRj KTsKSW5kZXg6IFdlYktpdC93aW4vSW50ZXJmYWNlcy9JV2ViRnJhbWVQcml2YXRlLmlkbAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJLaXQvd2luL0ludGVyZmFjZXMvSVdlYkZyYW1lUHJpdmF0ZS5pZGwJKHJl dmlzaW9uIDYwNjQwKQorKysgV2ViS2l0L3dpbi9JbnRlcmZhY2VzL0lXZWJGcmFtZVByaXZhdGUu aWRsCSh3b3JraW5nIGNvcHkpCkBAIC0xMTEsNSArMTExLDUgQEAgaW50ZXJmYWNlIElXZWJGcmFt ZVByaXZhdGUgOiBJVW5rbm93bgogCiAgICAgSFJFU1VMVCBsYXllclRyZWVBc1RleHQoW291dCwg cmV0dmFsXSBCU1RSKiByZXN1bHQpOwogCi0gICAgSFJFU1VMVCBwYWludERvY3VtZW50UmVjdFRv Q29udGV4dEF0UG9pbnQoW2luXSBSRUNUIHJlY3QsIFtpbl0gUE9JTlQgcHQsIFtpbl0gT0xFX0hB TkRMRSBkZXZpY2VDb250ZXh0KTsKKyAgICBIUkVTVUxUIHBhaW50U2Nyb2xsVmlld1JlY3RUb0Nv bnRleHRBdFBvaW50KFtpbl0gUkVDVCByZWN0LCBbaW5dIFBPSU5UIHB0LCBbaW5dIE9MRV9IQU5E TEUgZGV2aWNlQ29udGV4dCk7CiB9CkluZGV4OiBXZWJLaXQvd2luL0ludGVyZmFjZXMvSVdlYlZp ZXdQcml2YXRlLmlkbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvd2luL0ludGVyZmFjZXMvSVdlYlZp ZXdQcml2YXRlLmlkbAkocmV2aXNpb24gNjA2NDApCisrKyBXZWJLaXQvd2luL0ludGVyZmFjZXMv SVdlYlZpZXdQcml2YXRlLmlkbAkod29ya2luZyBjb3B5KQpAQCAtMjM0LDcgKzIzNCw3IEBAIGlu dGVyZmFjZSBJV2ViVmlld1ByaXZhdGUgOiBJVW5rbm93bgogCiAgICAgSFJFU1VMVCBuZXh0RGlz cGxheUlzU3luY2hyb25vdXMoKTsKIAotICAgIEhSRVNVTFQgcGFpbnREb2N1bWVudFJlY3RUb0Nv bnRleHRBdFBvaW50KFtpbl0gUkVDVCByZWN0LCBbaW5dIFBPSU5UIHB0LCBbaW5dIE9MRV9IQU5E TEUgZGMpOworICAgIEhSRVNVTFQgcGFpbnRTY3JvbGxWaWV3UmVjdFRvQ29udGV4dEF0UG9pbnQo W2luXSBSRUNUIHJlY3QsIFtpbl0gUE9JTlQgcHQsIFtpbl0gT0xFX0hBTkRMRSBkYyk7CiAKICAg ICBbbG9jYWxdIEhSRVNVTFQgcmVwb3J0RXhjZXB0aW9uKFtpbl0gSlNDb250ZXh0UmVmIGNvbnRl eHQsIFtpbl0gSlNWYWx1ZVJlZiBleGNlcHRpb24pOwogfQpJbmRleDogV2ViS2l0L3dpbi9JbnRl cmZhY2VzL1dlYktpdC5pZGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3dpbi9JbnRlcmZhY2VzL1dl YktpdC5pZGwJKHJldmlzaW9uIDYwNjQwKQorKysgV2ViS2l0L3dpbi9JbnRlcmZhY2VzL1dlYktp dC5pZGwJKHdvcmtpbmcgY29weSkKQEAgLTMwMCw0ICszMDAsMyBAQCBsaWJyYXJ5IFdlYktpdAog ICAgICAgICBbZGVmYXVsdF0gaW50ZXJmYWNlIElXZWJVc2VyQ29udGVudFVSTFBhdHRlcm47CiAg ICAgfQogfQotCg==