40030 2010-06-01 17:37:46 -0700 [chromium] Layer compositor fails on ASSERT when updating layer contents 2010-06-02 02:02:05 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 vangelis webkit-unassigned commit-queue fishd oldest_to_newest 233003 0 vangelis 2010-06-01 17:37:46 -0700 This happens infrequently but when the dirtyRect of a composited layer contains portions that fall outside the layer's bounds, the code that updates the contents of the layer's texture (LayerChromium::updateTextureContents()) hits an assert. The solution is to clip the dirty region to the bounds of the layer since that's the only visible portion anyway. 233015 1 57610 vangelis 2010-06-01 18:12:43 -0700 Created attachment 57610 Proposed patch 233028 2 57610 dglazkov 2010-06-01 19:05:14 -0700 Comment on attachment 57610 Proposed patch sounds good. 233142 3 57610 commit-queue 2010-06-02 02:01:59 -0700 Comment on attachment 57610 Proposed patch Clearing flags on attachment: 57610 Committed r60548: <http://trac.webkit.org/changeset/60548> 233143 4 commit-queue 2010-06-02 02:02:05 -0700 All reviewed patches have been landed. Closing bug. 57610 2010-06-01 18:12:43 -0700 2010-06-02 02:01:59 -0700 Proposed patch limitDirtyRect_40030.txt text/plain 2223 vangelis SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MDUyMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDYtMDEgIFZhbmdlbGlzIEtva2tldmlzICA8dmFuZ2VsaXNA Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtDaHJvbWl1bV0gQ2xhbXAgZGlydHlSZWN0IHVwZGF0ZXMgb2YgY29tcG9zaXRlZCBs YXllciBjb250ZW50cyB0byB0aGUgc2l6ZQorICAgICAgICBvZiB0aGUgbGF5ZXIgdG8gYXZvaWQg d3JpdGluZyBvdXRzaWRlIHRleHR1cmUgYm91bmRzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDAwMzAKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2Nocm9taXVtL0xheWVyQ2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5ZXJD aHJvbWl1bTo6dXBkYXRlVGV4dHVyZUNvbnRlbnRzKToKKwogMjAxMC0wNi0wMSAgTWFyayBSb3dl ICA8bXJvd2VAYXBwbGUuY29tPgogCiAgICAgICAgIFJ1YmJlci1zdGFtcGVkIGJ5IEFkYW0gUm9i ZW4uCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyQ2hyb21p dW0uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0v TGF5ZXJDaHJvbWl1bS5jcHAJKHJldmlzaW9uIDYwNTEyKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jaHJvbWl1bS9MYXllckNocm9taXVtLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTE4 LDYgKzExOCwxMCBAQCB2b2lkIExheWVyQ2hyb21pdW06OnVwZGF0ZVRleHR1cmVDb250ZW50CiAg ICAgICAgIE93blB0cjxQbGF0Zm9ybUNvbnRleHRTa2lhPiBza2lhQ29udGV4dDsKICAgICAgICAg T3duUHRyPEdyYXBoaWNzQ29udGV4dD4gZ3JhcGhpY3NDb250ZXh0OwogICAgICAgICBpZiAoZHJh d3NDb250ZW50KCkpIHsgLy8gTGF5ZXIgY29udGVudHMgbXVzdCBiZSBkcmF3biBpbnRvIGEgY2Fu dmFzLgorICAgICAgICAgICAgLy8gQ2xpcCB0aGUgZGlydHlSZWN0IHRvIHRoZSBzaXplIG9mIHRo ZSBsYXllciB0byBhdm9pZCBkcmF3aW5nIG91dHNpZGUKKyAgICAgICAgICAgIC8vIHRoZSBib3Vu ZHMgb2YgdGhlIGJhY2tpbmcgdGV4dHVyZS4KKyAgICAgICAgICAgIGRpcnR5UmVjdC5pbnRlcnNl Y3QoSW50UmVjdChJbnRQb2ludCgwLCAwKSwgbV9ib3VuZHMpKTsKKwogICAgICAgICAgICAgY2Fu dmFzLnNldChuZXcgc2tpYTo6UGxhdGZvcm1DYW52YXMoZGlydHlSZWN0LndpZHRoKCksIGRpcnR5 UmVjdC5oZWlnaHQoKSwgZmFsc2UpKTsKICAgICAgICAgICAgIHNraWFDb250ZXh0LnNldChuZXcg UGxhdGZvcm1Db250ZXh0U2tpYShjYW52YXMuZ2V0KCkpKTsKIApAQCAtMTM1LDggKzEzOSw3IEBA IHZvaWQgTGF5ZXJDaHJvbWl1bTo6dXBkYXRlVGV4dHVyZUNvbnRlbnQKICAgICAgICAgICAgIG1f b3duZXItPnBhaW50R3JhcGhpY3NMYXllckNvbnRlbnRzKCpncmFwaGljc0NvbnRleHQsIGRpcnR5 UmVjdCk7CiAgICAgICAgICAgICBjb25zdCBTa0JpdG1hcCYgYml0bWFwID0gY2FudmFzLT5nZXRE ZXZpY2UoKS0+YWNjZXNzQml0bWFwKGZhbHNlKTsKICAgICAgICAgICAgIHNraWFCaXRtYXAgPSAm Yml0bWFwOwotICAgICAgICAgICAgcmVxdWlyZWRUZXh0dXJlU2l6ZSA9IEludFNpemUobWF4KG1f Ym91bmRzLndpZHRoKCksIGRpcnR5UmVjdC53aWR0aCgpKSwKLSAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIG1heChtX2JvdW5kcy5oZWlnaHQoKSwgZGlydHlSZWN0Lmhl aWdodCgpKSk7CisgICAgICAgICAgICByZXF1aXJlZFRleHR1cmVTaXplID0gbV9ib3VuZHM7CiAg ICAgICAgIH0gZWxzZSB7IC8vIExheWVyIGlzIGEgY29udGFpbmVyLgogICAgICAgICAgICAgLy8g VGhlIGxheWVyIGNvbnRhaW5zIGFuIEltYWdlLgogICAgICAgICAgICAgTmF0aXZlSW1hZ2VTa2lh KiBza2lhSW1hZ2UgPSBzdGF0aWNfY2FzdDxOYXRpdmVJbWFnZVNraWEqPihjb250ZW50cygpKTsK