40022 2010-06-01 13:07:35 -0700 [chromium] Convert shaders used by the GL compositor to use GLSL ES 2010-06-02 02:50:38 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 vangelis webkit-unassigned abarth commit-queue eric fishd ossy webkit.review.bot oldest_to_newest 232922 0 vangelis 2010-06-01 13:07:35 -0700 Currently fragment shaders used by LayerRendererChromium are not valid GLSL ES shaders as they don't supply a precision qualifier. The GPU process has recently been modified to only accept GLSL ES shaders. 232938 1 57591 vangelis 2010-06-01 13:41:23 -0700 Created attachment 57591 Proposed patch 233130 2 57591 commit-queue 2010-06-02 01:18:40 -0700 Comment on attachment 57591 Proposed patch Clearing flags on attachment: 57591 Committed r60545: <http://trac.webkit.org/changeset/60545> 233131 3 commit-queue 2010-06-02 01:18:45 -0700 All reviewed patches have been landed. Closing bug. 233147 4 webkit.review.bot 2010-06-02 02:18:39 -0700 http://trac.webkit.org/changeset/60545 might have broken Qt Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/60544 http://trac.webkit.org/changeset/60545 http://trac.webkit.org/changeset/60546 http://trac.webkit.org/changeset/60547 http://trac.webkit.org/changeset/60543 233176 5 ossy 2010-06-02 02:50:38 -0700 (In reply to comment #4) > http://trac.webkit.org/changeset/60545 might have broken Qt Linux Release > The following changes are on the blame list: > http://trac.webkit.org/changeset/60544 > http://trac.webkit.org/changeset/60545 > http://trac.webkit.org/changeset/60546 > http://trac.webkit.org/changeset/60547 > http://trac.webkit.org/changeset/60543 This patch is innocent, another one is the culprit, sorry for the SPAM. 57591 2010-06-01 13:41:23 -0700 2010-06-02 01:18:39 -0700 Proposed patch precisionQualifiers_40022.txt text/plain 2833 vangelis SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MDUwMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDYtMDEgIFZhbmdlbGlzIEtva2tldmlzICA8dmFuZ2VsaXNA Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEFkZGluZyB0aGUgcHJlY2lzaW9uIHF1YWxpZmllciB0byBmcmFnbWVudCBzaGFkZXJz IHVzZWQgYnkgdGhlIEdMCisgICAgICAgIGNvbXBvc2l0b3IgaW4gY2hyb21pdW0gdG8gdHVybiB0 aGVtIGludG8gdmFsaWQgR0xTTCBFUy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTQwMDIyCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJv bWl1bS9MYXllclJlbmRlcmVyQ2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5ZXJS ZW5kZXJlckNocm9taXVtOjppbml0aWFsaXplU2hhcmVkR0xPYmplY3RzKToKKwogMjAxMC0wNi0w MSAgUm9iIEJ1aXMgIDxyd2xidWlzQGdtYWlsLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBO aWtvbGFzIFppbW1lcm1hbm4uCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9t aXVtL0xheWVyUmVuZGVyZXJDaHJvbWl1bS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJlbmRlcmVyQ2hyb21pdW0uY3BwCShyZXZpc2lv biA2MDQ5OCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJSZW5k ZXJlckNocm9taXVtLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTkwLDggKzU5MCw3IEBAIGJvb2wg TGF5ZXJSZW5kZXJlckNocm9taXVtOjppbml0aWFsaXplU2gKICAgICAgICAgIiAgdl90ZXhDb29y ZCA9IGFfdGV4Q29vcmQ7ICAgXG4iCiAgICAgICAgICJ9ICAgICAgICAgICAgICAgICAgICAgICAg ICAgIFxuIjsKICAgICBjaGFyIGZyYWdtZW50U2hhZGVyU3RyaW5nW10gPQotICAgICAgICAvLyBG SVhNRTogUmUtaW50cm9kdWNlIHByZWNpc2lvbiBxdWFsaWZpZXIgd2hlbiB3ZSBuZWVkIEdMIEVT IHNoYWRlcnMuCi0gICAgICAgICIvL3ByZWNpc2lvbiBtZWRpdW1wIGZsb2F0OyAgICAgICAgICAg ICAgICAgICAgICAgICAgICBcbiIKKyAgICAgICAgInByZWNpc2lvbiBtZWRpdW1wIGZsb2F0OyAg ICAgICAgICAgICAgICAgICAgICAgICAgICBcbiIKICAgICAgICAgInZhcnlpbmcgdmVjMiB2X3Rl eENvb3JkOyAgICAgICAgICAgICAgICAgICAgICAgICAgICBcbiIKICAgICAgICAgInVuaWZvcm0g c2FtcGxlcjJEIHNfdGV4dHVyZTsgICAgICAgICAgICAgICAgICAgICAgICBcbiIKICAgICAgICAg InVuaWZvcm0gZmxvYXQgYWxwaGE7ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcbiIK QEAgLTYwNSw4ICs2MDQsNyBAQCBib29sIExheWVyUmVuZGVyZXJDaHJvbWl1bTo6aW5pdGlhbGl6 ZVNoCiAgICAgLy8gZnJvbSBmcmFnbWVudFNoYWRlclN0cmluZyBpbiB0aGF0IGl0IGRvZXNuJ3Qg c3dpenpsZSB0aGUgY29sb3JzIGFuZCBkb2Vzbid0CiAgICAgLy8gdGFrZSBhbiBhbHBoYSB2YWx1 ZS4KICAgICBjaGFyIHNjcm9sbEZyYWdtZW50U2hhZGVyU3RyaW5nW10gPQotICAgICAgICAvLyBG SVhNRTogUmUtaW50cm9kdWNlIHByZWNpc2lvbiBxdWFsaWZpZXIgd2hlbiB3ZSBuZWVkIEdMIEVT IHNoYWRlcnMuCi0gICAgICAgICIvL3ByZWNpc2lvbiBtZWRpdW1wIGZsb2F0OyAgICAgICAgICAg ICAgICAgICAgICAgICAgICBcbiIKKyAgICAgICAgInByZWNpc2lvbiBtZWRpdW1wIGZsb2F0OyAg ICAgICAgICAgICAgICAgICAgICAgICAgICBcbiIKICAgICAgICAgInZhcnlpbmcgdmVjMiB2X3Rl eENvb3JkOyAgICAgICAgICAgICAgICAgICAgICAgICAgICBcbiIKICAgICAgICAgInVuaWZvcm0g c2FtcGxlcjJEIHNfdGV4dHVyZTsgICAgICAgICAgICAgICAgICAgICAgICBcbiIKICAgICAgICAg InZvaWQgbWFpbigpICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcbiIK QEAgLTYyNCw4ICs2MjIsNyBAQCBib29sIExheWVyUmVuZGVyZXJDaHJvbWl1bTo6aW5pdGlhbGl6 ZVNoCiAgICAgICAgICIgICBnbF9Qb3NpdGlvbiA9IG1hdHJpeCAqIGFfcG9zaXRpb247IFxuIgog ICAgICAgICAifSAgICAgICAgICAgICAgICAgICAgICAgICAgICBcbiI7CiAgICAgY2hhciBib3Jk ZXJGcmFnbWVudFNoYWRlclN0cmluZ1tdID0KLSAgICAgICAgLy8gRklYTUU6IFJlLWludHJvZHVj ZSBwcmVjaXNpb24gcXVhbGlmaWVyIHdoZW4gd2UgbmVlZCBHTCBFUyBzaGFkZXJzLgotICAgICAg ICAiLy9wcmVjaXNpb24gbWVkaXVtcCBmbG9hdDsgICAgICAgICAgICAgICAgICAgICAgICAgICAg XG4iCisgICAgICAgICJwcmVjaXNpb24gbWVkaXVtcCBmbG9hdDsgICAgICAgICAgICAgICAgICAg ICAgICAgICAgXG4iCiAgICAgICAgICJ1bmlmb3JtIHZlYzQgY29sb3I7ICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgXG4iCiAgICAgICAgICJ2b2lkIG1haW4oKSAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgXG4iCiAgICAgICAgICJ7ICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXG4iCg==