40016 2010-06-01 11:56:50 -0700 [Qt] Make possible run DRT with QGraphicsWebView 2010-06-02 18:33:17 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED Qt P2 Normal --- 40014 1 diegohcg diegohcg commit-queue hausmann kenneth ossy oldest_to_newest 232886 0 diegohcg 2010-06-01 11:56:50 -0700 Make possible to use a environment variable for switching backend. Usage: QT_DRT_WEBVIEW_MODE=graphics WebKitTools/Scripts/run-webkit-tests --qt 232898 1 57578 diegohcg 2010-06-01 12:16:37 -0700 Created attachment 57578 Patch 232906 2 57578 kenneth 2010-06-01 12:36:09 -0700 Comment on attachment 57578 Patch Cool patch Diego :-) nice work. So what is the status about the tests? Now many are not passing? r=me, but please send an email to the list announcing this and let's wait a day before committing, just to make sure that no one have objections. Have you talked to Ossy about this already? 233304 3 ossy 2010-06-02 09:51:30 -0700 (In reply to comment #2) > (From update of attachment 57578 [details]) > Cool patch Diego :-) nice work. So what is the status about the tests? Now many are not passing? > > r=me, but please send an email to the list announcing this and let's wait a day before committing, just to make sure that no one have objections. > > Have you talked to Ossy about this already? Without QT_DRT_WEBVIEW_MODE=graphics environment variable there aren't any regression on ToT. With this option I got similar results as Diego mentioned on webkit-qt mailing list. 233315 4 diegohcg 2010-06-02 10:23:19 -0700 (In reply to comment #3) > Without QT_DRT_WEBVIEW_MODE=graphics environment variable > there aren't any regression on ToT. With this option I got > similar results as Diego mentioned on webkit-qt mailing list. Thanks Ossy :) 233551 5 57578 commit-queue 2010-06-02 18:33:11 -0700 Comment on attachment 57578 Patch Clearing flags on attachment: 57578 Committed r60586: <http://trac.webkit.org/changeset/60586> 233552 6 commit-queue 2010-06-02 18:33:17 -0700 All reviewed patches have been landed. Closing bug. 57578 2010-06-01 12:16:37 -0700 2010-06-02 18:33:10 -0700 Patch 0001-2010-06-01-Diego-Gonzalez-diegohcg-webkit.org.diff text/plain 6544 diegohcg RnJvbSAwYjFiNGNkMjE3NjNkYzE3YWRiMTgwMzEwMjkxNTVmNzVmNTg0NjA0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEaWVnbyBHb256YWxleiA8ZGllZ29oY2dAd2Via2l0Lm9yZz4K RGF0ZTogVHVlLCAxIEp1biAyMDEwIDE1OjA0OjA4IC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gMjAx MC0wNi0wMSAgRGllZ28gR29uemFsZXogIDxkaWVnb2hjZ0B3ZWJraXQub3JnPgoKICAgIFtRdF0g TWFrZSBwb3NzaWJsZSBydW4gRFJUIHdpdGggUUdyYXBoaWNzV2ViVmlldwogICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwMDE2CgogICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCgogICAgTWFrZSBwb3NzaWJsZSB0byB1c2UgYSBlbnZpcm9ubWVudCB2YXJp YWJsZSBmb3Igc3dpdGNoaW5nIGJhY2tlbmQuCiAgICBVc2FnZTogUVRfRFJUX1dFQlZJRVdfTU9E RT1ncmFwaGljcyBXZWJLaXRUb29scy9TY3JpcHRzL3J1bi13ZWJraXQtdGVzdHMgLS1xdAoKICAg ICogRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWVRdC5jcHA6CiAgICAoV2ViQ29yZTo6 V2ViVmlld0dyYXBoaWNzQmFzZWQ6OldlYlZpZXdHcmFwaGljc0Jhc2VkKToKICAgIChXZWJDb3Jl OjpEdW1wUmVuZGVyVHJlZTo6RHVtcFJlbmRlclRyZWUpOgogICAgKiBEdW1wUmVuZGVyVHJlZS9x dC9EdW1wUmVuZGVyVHJlZVF0Lmg6CiAgICAoV2ViQ29yZTo6RHVtcFJlbmRlclRyZWU6OnNldEdy YXBoaWNzQmFzZWQpOgogICAgKFdlYkNvcmU6OkR1bXBSZW5kZXJUcmVlOjppc0dyYXBoaWNzQmFz ZWQpOgogICAgKFdlYkNvcmU6OldlYlZpZXdHcmFwaGljc0Jhc2VkOjpncmFwaGljc1ZpZXcpOgog ICAgKFdlYkNvcmU6OldlYlZpZXdHcmFwaGljc0Jhc2VkOjpzZXRQYWdlKToKICAgICogU2NyaXB0 cy9vbGQtcnVuLXdlYmtpdC10ZXN0czoKLS0tCiBXZWJLaXRUb29scy9DaGFuZ2VMb2cgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICB8ICAgMjAgKysrKysrKysrKysrKwogV2ViS2l0VG9vbHMv RHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWVRdC5jcHAgfCAgIDMwICsrKysrKysrKysr KysrKysrLS0KIFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlUXQu aCAgIHwgICAyMCArKysrKysrKysrKystCiBXZWJLaXRUb29scy9TY3JpcHRzL29sZC1ydW4td2Vi a2l0LXRlc3RzICAgICAgICAgICB8ICAgIDEgKwogNCBmaWxlcyBjaGFuZ2VkLCA2NiBpbnNlcnRp b25zKCspLCA1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxv ZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxvZwppbmRleCBjOGMwZWNkLi5mNzQyM2Q2IDEwMDY0NAot LS0gYS9XZWJLaXRUb29scy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjMgQEAKKzIwMTAtMDYtMDEgIERpZWdvIEdvbnphbGV6ICA8ZGllZ29oY2dAd2Vi a2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbUXRdIE1ha2UgcG9zc2libGUgcnVuIERSVCB3aXRoIFFHcmFwaGljc1dlYlZpZXcKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwMDE2CisKKyAgICAg ICAgTWFrZSBwb3NzaWJsZSB0byB1c2UgYSBlbnZpcm9ubWVudCB2YXJpYWJsZSBmb3Igc3dpdGNo aW5nIGJhY2tlbmQuCisgICAgICAgIFVzYWdlOiBRVF9EUlRfV0VCVklFV19NT0RFPWdyYXBoaWNz IFdlYktpdFRvb2xzL1NjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cyAtLXF0CisKKyAgICAgICAgKiBE dW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZVF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OldlYlZpZXdHcmFwaGljc0Jhc2VkOjpXZWJWaWV3R3JhcGhpY3NCYXNlZCk6CisgICAgICAgIChX ZWJDb3JlOjpEdW1wUmVuZGVyVHJlZTo6RHVtcFJlbmRlclRyZWUpOgorICAgICAgICAqIER1bXBS ZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlUXQuaDoKKyAgICAgICAgKFdlYkNvcmU6OkR1bXBS ZW5kZXJUcmVlOjpzZXRHcmFwaGljc0Jhc2VkKToKKyAgICAgICAgKFdlYkNvcmU6OkR1bXBSZW5k ZXJUcmVlOjppc0dyYXBoaWNzQmFzZWQpOgorICAgICAgICAoV2ViQ29yZTo6V2ViVmlld0dyYXBo aWNzQmFzZWQ6OmdyYXBoaWNzVmlldyk6CisgICAgICAgIChXZWJDb3JlOjpXZWJWaWV3R3JhcGhp Y3NCYXNlZDo6c2V0UGFnZSk6CisgICAgICAgICogU2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0 czoKKwogMjAxMC0wNi0wMSAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgWGFuIExvcGV6LgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9v bHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWVRdC5jcHAgYi9XZWJLaXRUb29scy9E dW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZVF0LmNwcAppbmRleCBiYTk3ODBiLi4yOGI2 YTczIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVy VHJlZVF0LmNwcAorKysgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVy VHJlZVF0LmNwcApAQCAtMzQ5LDI0ICszNDksNDYgQEAgUU9iamVjdCogV2ViUGFnZTo6Y3JlYXRl UGx1Z2luKGNvbnN0IFFTdHJpbmcmIGNsYXNzSWQsIGNvbnN0IFFVcmwmIHVybCwgY29uc3QgUVMK ICNlbmRpZgogfQogCitXZWJWaWV3R3JhcGhpY3NCYXNlZDo6V2ViVmlld0dyYXBoaWNzQmFzZWQo UVdpZGdldCogcGFyZW50KQorICAgIDogbV9pdGVtKG5ldyBRR3JhcGhpY3NXZWJWaWV3KQorewor ICAgIHNldFNjZW5lKG5ldyBRR3JhcGhpY3NTY2VuZSh0aGlzKSk7CisgICAgc2NlbmUoKS0+YWRk SXRlbShtX2l0ZW0pOworfQorCiBEdW1wUmVuZGVyVHJlZTo6RHVtcFJlbmRlclRyZWUoKQogICAg IDogbV9kdW1wUGl4ZWxzKGZhbHNlKQogICAgICwgbV9zdGRpbigwKQogICAgICwgbV9lbmFibGVU ZXh0T3V0cHV0KGZhbHNlKQogICAgICwgbV9zaW5nbGVGaWxlTW9kZShmYWxzZSkKKyAgICAsIG1f Z3JhcGhpY3NCYXNlZChmYWxzZSkKICAgICAsIG1fcGVyc2lzdGVudFN0b3JhZ2VQYXRoKFFTdHJp bmcoZ2V0ZW52KCJEVU1QUkVOREVSVFJFRV9URU1QIikpKQogeworCisgICAgUUJ5dGVBcnJheSB2 aWV3TW9kZSA9IGdldGVudigiUVRfRFJUX1dFQlZJRVdfTU9ERSIpOworICAgIGlmICh2aWV3TW9k ZSA9PSAiZ3JhcGhpY3MiKQorICAgICAgICBzZXRHcmFwaGljc0Jhc2VkKHRydWUpOworCiAgICAg RHVtcFJlbmRlclRyZWVTdXBwb3J0UXQ6Om92ZXJ3cml0ZVBsdWdpbkRpcmVjdG9yaWVzKCk7CiAK ICAgICBRV2ViU2V0dGluZ3M6OmVuYWJsZVBlcnNpc3RlbnRTdG9yYWdlKG1fcGVyc2lzdGVudFN0 b3JhZ2VQYXRoKTsKIAogICAgIG1fbmV0d29ya0FjY2Vzc01hbmFnZXIgPSBuZXcgTmV0d29ya0Fj Y2Vzc01hbmFnZXIodGhpcyk7CiAgICAgLy8gY3JlYXRlIG91ciBwcmltYXJ5IHRlc3RpbmcgcGFn ZS92aWV3LgotICAgIG1fbWFpblZpZXcgPSBuZXcgUVdlYlZpZXcoMCk7Ci0gICAgbV9tYWluVmll dy0+cmVzaXplKFFTaXplKExheW91dFRlc3RDb250cm9sbGVyOjptYXhWaWV3V2lkdGgsIExheW91 dFRlc3RDb250cm9sbGVyOjptYXhWaWV3SGVpZ2h0KSk7Ci0gICAgbV9wYWdlID0gbmV3IFdlYlBh Z2UobV9tYWluVmlldywgdGhpcyk7Ci0gICAgbV9tYWluVmlldy0+c2V0UGFnZShtX3BhZ2UpOwor ICAgIGlmIChpc0dyYXBoaWNzQmFzZWQoKSkgeworICAgICAgICBXZWJWaWV3R3JhcGhpY3NCYXNl ZCogdmlldyA9IG5ldyBXZWJWaWV3R3JhcGhpY3NCYXNlZCgwKTsKKyAgICAgICAgbV9wYWdlID0g bmV3IFdlYlBhZ2UodmlldywgdGhpcyk7CisgICAgICAgIHZpZXctPnNldFBhZ2UobV9wYWdlKTsK KyAgICAgICAgbV9tYWluVmlldyA9IHZpZXc7CisgICAgfSBlbHNlIHsKKyAgICAgICAgUVdlYlZp ZXcqIHZpZXcgPSBuZXcgUVdlYlZpZXcoMCk7CisgICAgICAgIG1fcGFnZSA9IG5ldyBXZWJQYWdl KHZpZXcsIHRoaXMpOworICAgICAgICB2aWV3LT5zZXRQYWdlKG1fcGFnZSk7CisgICAgICAgIG1f bWFpblZpZXcgPSB2aWV3OworICAgIH0KKwogICAgIG1fbWFpblZpZXctPnNldENvbnRleHRNZW51 UG9saWN5KFF0OjpOb0NvbnRleHRNZW51KTsKKyAgICBtX21haW5WaWV3LT5yZXNpemUoUVNpemUo TGF5b3V0VGVzdENvbnRyb2xsZXI6Om1heFZpZXdXaWR0aCwgTGF5b3V0VGVzdENvbnRyb2xsZXI6 Om1heFZpZXdIZWlnaHQpKTsKIAogICAgIC8vIGNsZWFuIHVwIGNhY2hlIGJ5IHJlc2V0dGluZyBx dW90YS4KICAgICBxaW50NjQgcXVvdGEgPSB3ZWJQYWdlKCktPnNldHRpbmdzKCktPm9mZmxpbmVX ZWJBcHBsaWNhdGlvbkNhY2hlUXVvdGEoKTsKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0R1bXBS ZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlUXQuaCBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJU cmVlL3F0L0R1bXBSZW5kZXJUcmVlUXQuaAppbmRleCAzZmE0NDg1Li4wOGQwZDJhIDEwMDY0NAot LS0gYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZVF0LmgKKysr IGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWVRdC5oCkBAIC00 MSw2ICs0MSw4IEBACiAjZW5kaWYKIAogI2luY2x1ZGUgIi4uLy4uLy4uL1dlYktpdC9xdC9XZWJD b3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRRdC5oIgorI2luY2x1ZGUgPHFncmFwaGlj c3ZpZXcuaD4KKyNpbmNsdWRlIDxxZ3JhcGhpY3N3ZWJ2aWV3Lmg+CiAjaW5jbHVkZSA8cXdlYmZy YW1lLmg+CiAjaW5jbHVkZSA8cXdlYmluc3BlY3Rvci5oPgogI2luY2x1ZGUgPHF3ZWJwYWdlLmg+ CkBAIC04MCw2ICs4Miw5IEBAIHB1YmxpYzoKICAgICB2b2lkIHNldFNpbmdsZUZpbGVNb2RlKGJv b2wgZmxhZykgeyBtX3NpbmdsZUZpbGVNb2RlID0gZmxhZzsgfQogICAgIGJvb2wgaXNTaW5nbGVG aWxlTW9kZSgpIHsgcmV0dXJuIG1fc2luZ2xlRmlsZU1vZGU7IH0KIAorICAgIHZvaWQgc2V0R3Jh cGhpY3NCYXNlZChib29sIGZsYWcpIHsgbV9ncmFwaGljc0Jhc2VkID0gZmxhZzsgfQorICAgIGJv b2wgaXNHcmFwaGljc0Jhc2VkKCkgeyByZXR1cm4gbV9ncmFwaGljc0Jhc2VkOyB9CisKICAgICB2 b2lkIHNldER1bXBQaXhlbHMoYm9vbCk7CiAKICAgICB2b2lkIGNsb3NlUmVtYWluaW5nV2luZG93 cygpOwpAQCAtMTM1LDcgKzE0MCw3IEBAIHByaXZhdGU6CiAgICAgUVN0cmluZyBtX2V4cGVjdGVk SGFzaDsKIAogICAgIFdlYlBhZ2UgKm1fcGFnZTsKLSAgICBRV2ViVmlldyogbV9tYWluVmlldzsK KyAgICBRV2lkZ2V0KiBtX21haW5WaWV3OwogCiAgICAgRXZlbnRTZW5kZXIgKm1fZXZlbnRTZW5k ZXI7CiAgICAgVGV4dElucHV0Q29udHJvbGxlciAqbV90ZXh0SW5wdXRDb250cm9sbGVyOwpAQCAt MTQ3LDYgKzE1Miw3IEBAIHByaXZhdGU6CiAgICAgUUxpc3Q8UU9iamVjdCo+IHdpbmRvd3M7CiAg ICAgYm9vbCBtX2VuYWJsZVRleHRPdXRwdXQ7CiAgICAgYm9vbCBtX3NpbmdsZUZpbGVNb2RlOwor ICAgIGJvb2wgbV9ncmFwaGljc0Jhc2VkOwogICAgIFFTdHJpbmcgbV9wZXJzaXN0ZW50U3RvcmFn ZVBhdGg7CiB9OwogCkBAIC0yMDIsNiArMjA4LDE4IEBAIHByaXZhdGU6CiAgICAgRHVtcFJlbmRl clRyZWUgKm1fZHJ0OwogfTsKIAorY2xhc3MgV2ViVmlld0dyYXBoaWNzQmFzZWQgOiBwdWJsaWMg UUdyYXBoaWNzVmlldyB7CisgICAgUV9PQkpFQ1QKKworcHVibGljOgorICAgIFdlYlZpZXdHcmFw aGljc0Jhc2VkKFFXaWRnZXQqIHBhcmVudCk7CisgICAgUUdyYXBoaWNzV2ViVmlldyogZ3JhcGhp Y3NWaWV3KCkgY29uc3QgeyByZXR1cm4gbV9pdGVtOyB9CisgICAgdm9pZCBzZXRQYWdlKFFXZWJQ YWdlKiBwYWdlKSB7IG1faXRlbS0+c2V0UGFnZShwYWdlKTsgfQorCitwcml2YXRlOgorICAgIFFH cmFwaGljc1dlYlZpZXcqIG1faXRlbTsKK307CisKIH0KIAogI2VuZGlmCmRpZmYgLS1naXQgYS9X ZWJLaXRUb29scy9TY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzIGIvV2ViS2l0VG9vbHMvU2Ny aXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0cwppbmRleCBhYzczYzAwLi4wMmM5MDY4IDEwMDc1NQot LS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzCisrKyBiL1dlYktp dFRvb2xzL1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMKQEAgLTEzNTgsNiArMTM1OCw3IEBA IHN1YiBvcGVuRHVtcFRvb2woKQogICAgICMgUG9ydCBzcGVzaWZpY3MKICAgICBpZiAoaXNRdCgp KSB7CiAgICAgICAgICRDTEVBTl9FTlZ7UVRXRUJLSVRfUExVR0lOX1BBVEh9ID0gcHJvZHVjdERp cigpIC4gIi9saWIvcGx1Z2lucyI7CisgICAgICAgICRDTEVBTl9FTlZ7UVRfRFJUX1dFQlZJRVdf TU9ERX0gPSAkRU5WeyJRVF9EUlRfV0VCVklFV19NT0RFIn07CiAgICAgfQogICAgIAogICAgIG15 IEBhcmdzID0gKCRkdW1wVG9vbCwgQHRvb2xBcmdzKTsKLS0gCjEuNy4wLjQKCg==