40008 2010-06-01 10:21:52 -0700 Leaks in listDirectory 2010-06-04 03:57:18 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 alex webkit-unassigned oldest_to_newest 232809 0 alex 2010-06-01 10:21:52 -0700 valgrind show a couple of leaks in the file FileSystemGtk.cpp: ==18726== at 0x4C221A7: malloc (vg_replace_malloc.c:195) ==18726== by 0xFF6E816: g_malloc (gmem.c:131) ==18726== by 0xFF78082: g_pattern_spec_new (gpattern.c:268) ==18726== by 0x5955C32: WebCore::listDirectory(WebCore::String const&, WebCore::String const&) (FileSystemGtk.cpp:211) ==18726== at 0x4C221A7: malloc (vg_replace_malloc.c:195) ==18726== by 0xFF6E816: g_malloc (gmem.c:131) ==18726== by 0xFFA3B8F: g_uri_unescape_segment (gurifuncs.c:98) ==18726== by 0xFFA3C88: g_uri_unescape_string (gurifuncs.c:159) ==18726== by 0x59556A5: WebCore::filenameFromString(WebCore::String const&) (FileSystemGtk.cpp:60) ==18726== by 0x5955BEB: WebCore::listDirectory(WebCore::String const&, WebCore::String const&) (FileSystemGtk.cpp:206) 232812 1 57563 alex 2010-06-01 10:25:11 -0700 Created attachment 57563 Proposed patch 232817 2 57563 xan.lopez 2010-06-01 10:27:13 -0700 Comment on attachment 57563 Proposed patch ok 234154 3 alex 2010-06-04 03:57:18 -0700 Landed r60673 57563 2010-06-01 10:25:11 -0700 2010-06-01 10:27:13 -0700 Proposed patch leaks_listdirectory.patch text/plain 1658 alex ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NWExYTZjNC4uMWU2ZTQ3NSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNi0wMSAgQWxlamFuZHJvIEcu IENhc3RybyAgPGFsZXhAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBMZWFrcyBpbiBsaXN0RGlyZWN0b3J5CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDAwOAorCisgICAgICAgIEZpeGVk IGJvdGggbGVha3MuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvRmlsZVN5c3RlbUd0ay5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpsaXN0RGlyZWN0b3J5KToKKwogMjAxMC0wNi0wMSAgWm9sdGFu IEhlcmN6ZWcgIDx6aGVyY3plZ0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERp cmsgU2NodWx6ZS4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0ZpbGVTeXN0ZW1H dGsuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvRmlsZVN5c3RlbUd0ay5jcHAKaW5kZXggZGRj ZjBhYS4uYTAwNWY3YyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvRmlsZVN5c3Rl bUd0ay5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvRmlsZVN5c3RlbUd0ay5jcHAKQEAg LTIwMyw4ICsyMDMsOCBAQCBWZWN0b3I8U3RyaW5nPiBsaXN0RGlyZWN0b3J5KGNvbnN0IFN0cmlu ZyYgcGF0aCwgY29uc3QgU3RyaW5nJiBmaWx0ZXIpCiB7CiAgICAgVmVjdG9yPFN0cmluZz4gZW50 cmllczsKIAotICAgIGdjaGFyKiBmaWxlbmFtZSA9IGZpbGVuYW1lRnJvbVN0cmluZyhwYXRoKTsK LSAgICBHRGlyKiBkaXIgPSBnX2Rpcl9vcGVuKGZpbGVuYW1lLCAwLCAwKTsKKyAgICBHT3duUHRy PGdjaGFyPiBmaWxlbmFtZShmaWxlbmFtZUZyb21TdHJpbmcocGF0aCkpOworICAgIEdEaXIqIGRp ciA9IGdfZGlyX29wZW4oZmlsZW5hbWUuZ2V0KCksIDAsIDApOwogICAgIGlmICghZGlyKQogICAg ICAgICByZXR1cm4gZW50cmllczsKIApAQCAtMjEzLDEyICsyMTMsMTEgQEAgVmVjdG9yPFN0cmlu Zz4gbGlzdERpcmVjdG9yeShjb25zdCBTdHJpbmcmIHBhdGgsIGNvbnN0IFN0cmluZyYgZmlsdGVy KQogICAgICAgICBpZiAoIWdfcGF0dGVybl9tYXRjaF9zdHJpbmcocHNwZWMsIG5hbWUpKQogICAg ICAgICAgICAgY29udGludWU7CiAKLSAgICAgICAgZ2NoYXIqIGVudHJ5ID0gZ19idWlsZF9maWxl bmFtZShmaWxlbmFtZSwgbmFtZSwgTlVMTCk7Ci0gICAgICAgIGVudHJpZXMuYXBwZW5kKGZpbGVu YW1lVG9TdHJpbmcoZW50cnkpKTsKLSAgICAgICAgZ19mcmVlKGVudHJ5KTsKKyAgICAgICAgR093 blB0cjxnY2hhcj4gZW50cnkoZ19idWlsZF9maWxlbmFtZShmaWxlbmFtZS5nZXQoKSwgbmFtZSwg TlVMTCkpOworICAgICAgICBlbnRyaWVzLmFwcGVuZChmaWxlbmFtZVRvU3RyaW5nKGVudHJ5Lmdl dCgpKSk7CiAgICAgfQorICAgIGdfcGF0dGVybl9zcGVjX2ZyZWUocHNwZWMpOwogICAgIGdfZGly X2Nsb3NlKGRpcik7Ci0gICAgZ19mcmVlKGZpbGVuYW1lKTsKIAogICAgIHJldHVybiBlbnRyaWVz OwogfQo=