39971 2010-05-31 15:29:33 -0700 Geolocation broken by r59800 (bug 39393) 2010-06-01 10:49:36 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED DUPLICATE 39434 P2 Normal --- 1 yong.li.webkit webkit-unassigned staikos steveblock oldest_to_newest 232531 0 yong.li.webkit 2010-05-31 15:29:33 -0700 "JSFunction need not be a subclass of InternalFunction" broke things like this: // The spec specifies 'FunctionOnly' for this object. if (!value.inherits(&InternalFunction::info)) { where it's assumed that JSFunction::info inherits from InternalFunction::info. 232533 1 57497 yong.li.webkit 2010-05-31 15:39:42 -0700 Created attachment 57497 the patch 232723 2 steveblock 2010-06-01 06:46:13 -0700 Thanks for the patch, but this is already being addressed in Bug 39434 *** This bug has been marked as a duplicate of bug 39434 *** 57497 2010-05-31 15:39:42 -0700 2010-06-01 10:49:36 -0700 the patch 39971.patch text/plain 1902 yong.li.webkit ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZGUyZGQxYi4uYzg5OWI2MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNS0zMSAgWW9uZyBMaSAgPHlv bGlAcmltLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzk5NzEKKyAgICAg ICAgSlNGdW5jdGlvbjo6aW5mbyBpcyBub3QgYSBzdWJjbGFzcyBvZiBJbnRlcm5hbEZ1bmN0aW9u IGFueSBtb3JlLgorICAgICAgICBXZSBuZWVkIGV4cGxpY2l0bHkgY2hlY2sgZm9yIEpTRnVuY3Rp b246OmluZm8KKworICAgICAgICAqIGJpbmRpbmdzL2pzL0pTR2VvbG9jYXRpb25DdXN0b20uY3Bw OgorICAgICAgICAoV2ViQ29yZTo6Y3JlYXRlUG9zaXRpb25DYWxsYmFjayk6CisgICAgICAgIChX ZWJDb3JlOjpjcmVhdGVQb3NpdGlvbkVycm9yQ2FsbGJhY2spOgorCiAyMDEwLTA1LTI4ICBBZGFt IFRyZWF0ICA8YXRyZWF0QHJpbS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFuaWVsIEJh dGVzLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0dlb2xvY2F0aW9uQ3VzdG9t LmNwcCBiL1dlYkNvcmUvYmluZGluZ3MvanMvSlNHZW9sb2NhdGlvbkN1c3RvbS5jcHAKaW5kZXgg OGJjMzQ4Yy4uMDYzOTU2ZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0dlb2xv Y2F0aW9uQ3VzdG9tLmNwcAorKysgYi9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTR2VvbG9jYXRpb25D dXN0b20uY3BwCkBAIC0zNyw2ICszNyw3IEBACiAjaW5jbHVkZSAiSlNET01XaW5kb3cuaCIKICNp bmNsdWRlICJQb3NpdGlvbk9wdGlvbnMuaCIKICNpbmNsdWRlIDxydW50aW1lL0ludGVybmFsRnVu Y3Rpb24uaD4KKyNpbmNsdWRlIDxydW50aW1lL0pTRnVuY3Rpb24uaD4KIAogdXNpbmcgbmFtZXNw YWNlIEpTQzsKIHVzaW5nIG5hbWVzcGFjZSBzdGQ7CkBAIC00Niw3ICs0Nyw3IEBAIG5hbWVzcGFj ZSBXZWJDb3JlIHsKIHN0YXRpYyBQYXNzUmVmUHRyPFBvc2l0aW9uQ2FsbGJhY2s+IGNyZWF0ZVBv c2l0aW9uQ2FsbGJhY2soRXhlY1N0YXRlKiBleGVjLCBKU0RPTUdsb2JhbE9iamVjdCogZ2xvYmFs T2JqZWN0LCBKU1ZhbHVlIHZhbHVlKQogewogICAgIC8vIFRoZSBzcGVjIHNwZWNpZmllcyAnRnVu Y3Rpb25Pbmx5JyBmb3IgdGhpcyBvYmplY3QuCi0gICAgaWYgKCF2YWx1ZS5pbmhlcml0cygmSW50 ZXJuYWxGdW5jdGlvbjo6aW5mbykpIHsKKyAgICBpZiAoIXZhbHVlLmluaGVyaXRzKCZJbnRlcm5h bEZ1bmN0aW9uOjppbmZvKSAmJiAhdmFsdWUuaW5oZXJpdHMoJkpTRnVuY3Rpb246OmluZm8pKSB7 CiAgICAgICAgIHNldERPTUV4Y2VwdGlvbihleGVjLCBUWVBFX01JU01BVENIX0VSUik7CiAgICAg ICAgIHJldHVybiAwOwogICAgIH0KQEAgLTYyLDcgKzYzLDcgQEAgc3RhdGljIFBhc3NSZWZQdHI8 UG9zaXRpb25FcnJvckNhbGxiYWNrPiBjcmVhdGVQb3NpdGlvbkVycm9yQ2FsbGJhY2soRXhlY1N0 YXRlKgogICAgICAgICByZXR1cm4gMDsKIAogICAgIC8vIFRoZSBzcGVjIHNwZWNpZmllcyAnRnVu Y3Rpb25Pbmx5JyBmb3IgdGhpcyBvYmplY3QuCi0gICAgaWYgKCF2YWx1ZS5pbmhlcml0cygmSW50 ZXJuYWxGdW5jdGlvbjo6aW5mbykpIHsKKyAgICBpZiAoIXZhbHVlLmluaGVyaXRzKCZJbnRlcm5h bEZ1bmN0aW9uOjppbmZvKSAmJiAhdmFsdWUuaW5oZXJpdHMoJkpTRnVuY3Rpb246OmluZm8pKSB7 CiAgICAgICAgIHNldERPTUV4Y2VwdGlvbihleGVjLCBUWVBFX01JU01BVENIX0VSUik7CiAgICAg ICAgIHJldHVybiAwOwogICAgIH0K