39946 2010-05-31 02:42:03 -0700 REGRESSION (r58665): Infinite recursion in Position::getInlineBoxAndOffset() 2010-05-31 19:16:31 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED HasReduction, InRadar, Regression P1 Normal --- 1 tony webkit-unassigned enrica mitz oldest_to_newest 232298 0 57445 tony 2010-05-31 02:42:03 -0700 Created attachment 57445 test case This is a regression caused by a similar fix in http://trac.webkit.org/changeset/58665 Test case attached. I'll investigate tomorrow. 232301 1 tony 2010-05-31 02:43:05 -0700 Originally reported in crbug.com/44051 232407 2 mitz 2010-05-31 09:04:09 -0700 <rdar://problem/8045485> 232570 3 57506 tony 2010-05-31 18:26:12 -0700 Created attachment 57506 Patch 232574 4 57506 mitz 2010-05-31 18:29:46 -0700 Comment on attachment 57506 Patch Thanks for the quick fix! > + r58665 added an infinite recurion check, but didn't take into consideration recursion between two Typo: recurion. 232586 5 tony 2010-05-31 19:16:31 -0700 Committed r60459: <http://trac.webkit.org/changeset/60459> 57445 2010-05-31 02:42:03 -0700 2010-05-31 02:42:03 -0700 test case inline-crash.html text/html 256 tony PGJvZHkgY29udGVudGVkaXRhYmxlPXRydWU+CjxkaXY+c3RhcnQgZHJhZ2dpbmcgaGVyZSBhbmQg ZHJhZyByaWdodDxkaXY+CjxkaXYgc3R5bGU9Ii13ZWJraXQtdXNlci1tb2RpZnk6IHJlYWQtb25s eTsgZGlzcGxheTppbmxpbmUtYmxvY2s7Ij4KICA8ZGl2IHN0eWxlPSJkaXNwbGF5Om5vbmU7Ij5z b21lIHRleHQ8L2Rpdj4KICA8ZGl2IHN0eWxlPSJ3aWR0aDogNTUwcHg7Ij4KICAgIHNwYWNlciB0 ZXh0CiAgPC9kaXY+CjwvZGl2Pgo8L2JvZHk+Cg== 57506 2010-05-31 18:26:12 -0700 2010-05-31 18:29:45 -0700 Patch bug-39946-20100601102610.patch text/plain 4454 tony ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkZmMxMDY4MDQwMGM0MWIyODQ3ODgyMjU1MmEyZjI4ODcwZDQwMDg1Li4wMjNlMDEw YTY4NjE2MzQ3MDliMTU1M2Q5ZGYzNjU5MDQxMjA4NGQ1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMDUtMzEgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSRUdSRVNTSU9OIChyNTg2NjUp OiBJbmZpbml0ZSByZWN1cnNpb24gaW4gUG9zaXRpb246OmdldElubGluZUJveEFuZE9mZnNldCgp CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTk0Ngor CisgICAgICAgICogZWRpdGluZy9zZWxlY3Rpb24vbWl4ZWQtZWRpdGFiaWxpdHktMTItZXhwZWN0 ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBlZGl0aW5nL3NlbGVjdGlvbi9taXhlZC1lZGl0YWJp bGl0eS0xMi5odG1sOiBBZGRlZC4KKwogMjAxMC0wNS0zMSAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3 ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vbWl4ZWQtZWRpdGFiaWxpdHktMTItZXhw ZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vbWl4ZWQtZWRpdGFiaWxp dHktMTItZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmYxZWU5ZGVjMzYwZDFhYzU4ODk0N2Q4ZGFi YTg2M2NhMmUxNWY5ODQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3Nl bGVjdGlvbi9taXhlZC1lZGl0YWJpbGl0eS0xMi1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw1IEBA CitUZXN0IGZvciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzk5NDYg YW5vdGhlciBjYXNlIG9mIGluZmluaXRlIHJlY3Vyc2lvbiBpbiBQb3NpdGlvbjo6Z2V0SW5saW5l Qm94QW5kT2Zmc2V0KCkuIFRoaXMgdGVzdCBwYXNzZXMgaWYgaXQgZG9lcyBub3QgY3Jhc2guCisK K3N0YXJ0IGRyYWdnaW5nIGhlcmUgYW5kIGRyYWcgcmlnaHQKK3NwYWNlciB0ZXh0CisKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL21peGVkLWVkaXRhYmlsaXR5LTEy Lmh0bWwgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9taXhlZC1lZGl0YWJpbGl0eS0x Mi5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAuLjYzYjdkMTMxOGEzMmMzZDUyYjc2OTM1OTNkZWE4ZTZmOTlmZjdj NmUKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9taXhl ZC1lZGl0YWJpbGl0eS0xMi5odG1sCkBAIC0wLDAgKzEsMjEgQEAKKzxib2R5IGNvbnRlbnRlZGl0 YWJsZT10cnVlPgorPHAgY29udGVudGVkaXRhYmxlPWZhbHNlPlRlc3QgZm9yIDxhIGhyZWY9Imh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTk0NiI+aHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5OTQ2PC9hPgorYW5vdGhlciBjYXNlIG9mIGlu ZmluaXRlIHJlY3Vyc2lvbiBpbiBQb3NpdGlvbjo6Z2V0SW5saW5lQm94QW5kT2Zmc2V0KCkuICBU aGlzIHRlc3QgcGFzc2VzIGlmIGl0IGRvZXMgbm90IGNyYXNoLjwvcD4KKzxkaXYgaWQ9InN0YXJ0 Ij5zdGFydCBkcmFnZ2luZyBoZXJlIGFuZCBkcmFnIHJpZ2h0PGRpdj4KKzxkaXYgc3R5bGU9Ii13 ZWJraXQtdXNlci1tb2RpZnk6IHJlYWQtb25seTsgZGlzcGxheTppbmxpbmUtYmxvY2s7Ij4KKyAg PGRpdiBzdHlsZT0iZGlzcGxheTpub25lOyI+c29tZSB0ZXh0PC9kaXY+CisgIDxkaXYgc3R5bGU9 IndpZHRoOiA1NTBweDsiPgorICAgIHNwYWNlciB0ZXh0CisgIDwvZGl2PgorPC9kaXY+Cis8c2Ny aXB0PgorICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgIGxheW91 dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKworICAgIHZhciBzZWxlY3Rpb24gPSBnZXRT ZWxlY3Rpb24oKTsKKyAgICB2YXIgc3RhcnQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgic3Rh cnQiKTsKKyAgICBzZWxlY3Rpb24uc2V0QmFzZUFuZEV4dGVudChzdGFydCwgMSwgc3RhcnQsIDEp OworICAgIHNlbGVjdGlvbi5tb2RpZnkoIm1vdmUiLCAiZm9yd2FyZCIsICJsaW5lIik7CisgICAg c2VsZWN0aW9uLm1vZGlmeSgibW92ZSIsICJiYWNrd2FyZCIsICJjaGFyYWN0ZXIiKTsKKzwvc2Ny aXB0PgorPC9ib2R5PgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhY2E4ODZjZGI2ZjA5MTEyNTJmZmUyYmI3MTZhMWQ0YzBhNjViNzg5Li5i NTQyNmI4MmZjNDI1ZTRlODdkZmU2ODFiMzE3ZGZjZjc0ODY0ZGVjIDEwMDY0NAotLS0gYS9XZWJD b3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisy MDEwLTA1LTMxICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUkVHUkVTU0lPTiAocjU4NjY1KTog SW5maW5pdGUgcmVjdXJzaW9uIGluIFBvc2l0aW9uOjpnZXRJbmxpbmVCb3hBbmRPZmZzZXQoKQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzk5NDYKKyAg ICAgICAgCisgICAgICAgIHI1ODY2NSBhZGRlZCBhbiBpbmZpbml0ZSByZWN1cmlvbiBjaGVjaywg YnV0IGRpZG4ndCB0YWtlIGludG8gY29uc2lkZXJhdGlvbiByZWN1cnNpb24gYmV0d2VlbiB0d28K KyAgICAgICAgUG9zaXRpb25zLiAgVGhpcyBhZGRzIGEgY2hlY2sgZm9yIHdoZW4KKyAgICAgICAg ZG93bnN0cmVhbUlnbm9yaW5nRWRpdGluZ0JvdW5kYXJpZXMocDEpID09IHVwc3RyZWFtSWdub3Jp bmdFZGl0aW5nQm91bmRhcmllcyhwMikKKworICAgICAgICBUZXN0OiBlZGl0aW5nL3NlbGVjdGlv bi9taXhlZC1lZGl0YWJpbGl0eS0xMi5odG1sCisKKyAgICAgICAgKiBkb20vUG9zaXRpb24uY3Bw OgorICAgICAgICAoV2ViQ29yZTo6UG9zaXRpb246OmdldElubGluZUJveEFuZE9mZnNldCk6CisK IDIwMTAtMDUtMzAgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvZG9tL1Bvc2l0aW9u LmNwcCBiL1dlYkNvcmUvZG9tL1Bvc2l0aW9uLmNwcAppbmRleCBkYjllM2M2MWNmMzZiNTJlMWY4 NThlZjJhZTQwMzNiM2VlMWY4MTRmLi43ODYxZmJlMzlmYTBlNGVlNGU2NzQ4MTA3YTcyNTMyNzNh ZGM0YWQxIDEwMDY0NAotLS0gYS9XZWJDb3JlL2RvbS9Qb3NpdGlvbi5jcHAKKysrIGIvV2ViQ29y ZS9kb20vUG9zaXRpb24uY3BwCkBAIC0xMDE4LDEwICsxMDE4LDExIEBAIHZvaWQgUG9zaXRpb246 OmdldElubGluZUJveEFuZE9mZnNldChFQWZmaW5pdHkgYWZmaW5pdHksIFRleHREaXJlY3Rpb24g cHJpbWFyeURpCiAgICAgICAgICAgICAvLyBhbiBlZGl0YWJsZSBibG9jayBidXQgc3Vycm91bmRl ZCBieSBub24tZWRpdGFibGUgcG9zaXRpb25zLiBJdCBhY3RzIHRvIG5lZ2F0ZSB0aGUgbG9naWMg YXQgdGhlIGJlZ2lubmluZwogICAgICAgICAgICAgLy8gb2YgUmVuZGVyT2JqZWN0OjpjcmVhdGVW aXNpYmxlUG9zaXRpb24oKS4KICAgICAgICAgICAgIFBvc2l0aW9uIGVxdWl2YWxlbnQgPSBkb3du c3RyZWFtSWdub3JpbmdFZGl0aW5nQm91bmRhcmllcygqdGhpcyk7Ci0gICAgICAgICAgICBpZiAo ZXF1aXZhbGVudCA9PSAqdGhpcykKKyAgICAgICAgICAgIGlmIChlcXVpdmFsZW50ID09ICp0aGlz KSB7CiAgICAgICAgICAgICAgICAgZXF1aXZhbGVudCA9IHVwc3RyZWFtSWdub3JpbmdFZGl0aW5n Qm91bmRhcmllcygqdGhpcyk7Ci0gICAgICAgICAgICBpZiAoZXF1aXZhbGVudCA9PSAqdGhpcykK LSAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICAgICAgaWYgKGVxdWl2YWxlbnQg PT0gKnRoaXMgfHwgZG93bnN0cmVhbUlnbm9yaW5nRWRpdGluZ0JvdW5kYXJpZXMoZXF1aXZhbGVu dCkgPT0gKnRoaXMpCisgICAgICAgICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAgIH0K IAogICAgICAgICAgICAgZXF1aXZhbGVudC5nZXRJbmxpbmVCb3hBbmRPZmZzZXQoVVBTVFJFQU0s IHByaW1hcnlEaXJlY3Rpb24sIGlubGluZUJveCwgY2FyZXRPZmZzZXQpOwogICAgICAgICAgICAg cmV0dXJuOwo=