39945 2010-05-31 02:12:47 -0700 Compilation error with clang in JSDOMBinding.h 2010-05-31 15:16:44 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ogoffart webkit-unassigned benjamin commit-queue darin ogoffart oliver oldest_to_newest 232289 0 ogoffart 2010-05-31 02:12:47 -0700 webkit/WebCore/bindings/js/JSDOMBinding.h:229:20: error: no viable conversion from 'WebCore::JSNode *' to 'JSC::JSValue' webkit/JavaScriptCore/runtime/JSValue.h:807:21: note: candidate constructor not viable: cannot convert argument of incomplete type 'WebCore::JSNode *' to 'JSC::JSCell *' inline JSValue::JSValue(JSCell* ptr) JSNode is only forward declared at this point. And since neither "wrapper" nor JSValue are type-dependent. Compilers should report errors at the first compilation pass. The fix is to move the conversion the line above, as the call to the function getCachedDOMNodeWrapper is type-dependent, the conversion will happen at template-instantiation time. See also http://llvm.org/bugs/show_bug.cgi?id=7244 232290 1 57441 ogoffart 2010-05-31 02:19:14 -0700 Created attachment 57441 Patch 232291 2 57442 ogoffart 2010-05-31 02:21:00 -0700 Created attachment 57442 Patch 232294 3 benjamin 2010-05-31 02:25:50 -0700 Adding Oliver, he can probably review the patch. 232432 4 57442 oliver 2010-05-31 09:58:42 -0700 Comment on attachment 57442 Patch Why doesn't this fail in gcc or msvc? (i'm removing the r+ to prevent commit bot shenanigans till i understand thwe issue) 232437 5 darin 2010-05-31 10:10:54 -0700 (In reply to comment #4) > Why doesn't this fail in gcc or msvc? (i'm removing the r+ to prevent commit bot shenanigans till i understand thwe issue) Here’s my understanding: The older compilers don't implement as much checking at template-definition time as clang does. These older C++ compilers tended to treat templates more like macros and not do much checking on them until the template was instantiated. But the C++ standard allows (perhaps requires) additional checking at the time the template is defined. On the other hand, I was led to believe that some folks have successfully compiled this code with at least some version of clang, so this may simply be a mistake in a certain version of clang rather than correct behavior. 232458 6 57442 oliver 2010-05-31 10:49:53 -0700 Comment on attachment 57442 Patch r=me as well then 232523 7 57442 commit-queue 2010-05-31 15:16:37 -0700 Comment on attachment 57442 Patch Clearing flags on attachment: 57442 Committed r60451: <http://trac.webkit.org/changeset/60451> 232524 8 commit-queue 2010-05-31 15:16:44 -0700 All reviewed patches have been landed. Closing bug. 57441 2010-05-31 02:19:14 -0700 2010-05-31 02:21:00 -0700 Patch url.txt text/plain 53 ogoffart aHR0cDovL2NvZGVwYXN0ZXItbm9raWEudHJvbGwubm8vP2lkPTI5OTQzJmZvcm1hdD1yYXc= 57442 2010-05-31 02:21:00 -0700 2010-05-31 15:16:37 -0700 Patch patch text/plain 1585 ogoffart ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YWNhODg2Yy4uYTRiY2Y1OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAxMC0wNS0zMSAgT2xpdmllciBHb2Zm YXJ0IDxvbGl2aWVyLmdvZmZhcnRAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtQQVRDSF0gY29tcGlsYXRpb24gZXJyb3Igd2l0aCBj bGFuZyBpbiBKU0RPTUJpbmRpbmcuaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9Mzk5NDUKKworICAgICAgICBKU05vZGUgaXMgb25seSBmb3J3YXJkIGRl Y2xhcmVkIGF0IHRoaXMgcG9pbnQuIEFuZCBzaW5jZSBuZWl0aGVyCisgICAgICAgICJ3cmFwcGVy IiBub3IgSlNWYWx1ZSBhcmUgdHlwZS1kZXBlbmRlbnQuIENvbXBpbGVycyBzaG91bGQgcmVwb3J0 IGVycm9ycworICAgICAgICBhdCB0aGUgZmlyc3QgY29tcGlsYXRpb24gcGFzcy4KKworICAgICAg ICBUaGUgZml4IGlzIHRvIG1vdmUgdGhlIGNvbnZlcnNpb24gdGhlIGxpbmUgYWJvdmUsIGFzIHRo ZSBjYWxsIHRvIHRoZQorICAgICAgICBmdW5jdGlvbiBnZXRDYWNoZWRET01Ob2RlV3JhcHBlciBp cyB0eXBlLWRlcGVuZGVudCwgdGhlIGNvbnZlcnNpb24gd2lsbAorICAgICAgICBoYXBwZW4gYXQg dGVtcGxhdGUtaW5zdGFudGlhdGlvbiB0aW1lLgorCisgICAgICAgIFNlZSBhbHNvIGh0dHA6Ly9s bHZtLm9yZy9idWdzL3Nob3dfYnVnLmNnaT9pZD03MjQ0CisKKyAgICAgICAgKiBiaW5kaW5ncy9q cy9KU0RPTUJpbmRpbmcuaDoKKyAgICAgICAgKFdlYkNvcmU6OmdldERPTU5vZGVXcmFwcGVyKToK KwogMjAxMC0wNS0zMCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAg IFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy9q cy9KU0RPTUJpbmRpbmcuaCBiL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01CaW5kaW5nLmgKaW5k ZXggMjE1ZTA5YS4uM2YyNTAyZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RP TUJpbmRpbmcuaAorKysgYi9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NQmluZGluZy5oCkBAIC0y MjIsNyArMjIyLDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgIHsKICAgICAgICAgaWYgKCFu b2RlKQogICAgICAgICAgICAgcmV0dXJuIEpTQzo6anNOdWxsKCk7Ci0gICAgICAgIGlmIChKU05v ZGUqIHdyYXBwZXIgPSBnZXRDYWNoZWRET01Ob2RlV3JhcHBlcihleGVjLCBub2RlLT5kb2N1bWVu dCgpLCBub2RlKSkKKyAgICAgICAgaWYgKEpTQzo6SlNDZWxsKiB3cmFwcGVyID0gZ2V0Q2FjaGVk RE9NTm9kZVdyYXBwZXIoZXhlYywgbm9kZS0+ZG9jdW1lbnQoKSwgbm9kZSkpCiAgICAgICAgICAg ICByZXR1cm4gd3JhcHBlcjsKICAgICAgICAgcmV0dXJuIGNyZWF0ZURPTU5vZGVXcmFwcGVyPFdy YXBwZXJDbGFzcz4oZXhlYywgZ2xvYmFsT2JqZWN0LCBub2RlKTsKICAgICB9Cg==