3992 2005-07-13 22:05:30 -0700 some elements draw selection when printing 2005-07-26 19:09:36 -0700 1 1 1 Unclassified WebKit Layout and Rendering 412 Mac OS X 10.4 RESOLVED FIXED http://www.nytimes.com/ P2 Normal --- 1 trey trey oldest_to_newest 14616 0 trey 2005-07-13 22:05:30 -0700 Go to nytimes.com. Select All. Print. Choose Preview. The printing output has a large amount of the selection gray drawn all over it. The text elements seem smart enough not to draw selection, but the stuff between the text is all gray. Might be a regression from 1.2, but I'm not positive. 14617 1 trey 2005-07-13 22:05:56 -0700 This is also Radar #4083496 14618 2 2957 trey 2005-07-13 22:13:40 -0700 Created attachment 2957 proposed patch 15178 3 2957 hyatt 2005-07-25 14:34:04 -0700 Comment on attachment 2957 proposed patch r=me It does occur to me, though, that another way to fix this might be to simply not do the PaintActionSelection phase at all when printing. Then none of the code that paints selection in the individual renderobjects would even have to check the printing state. 15218 4 justin.garcia 2005-07-26 19:09:36 -0700 Landing this 2957 2005-07-13 22:13:40 -0700 2005-07-25 14:34:04 -0700 proposed patch 3992.patch text/plain 4397 trey SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViQ29yZS9D aGFuZ2VMb2csdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNDQxOQpkaWZmIC1wIC11IC1yMS40NDE5 IENoYW5nZUxvZwotLS0gQ2hhbmdlTG9nCTIwMDUvMDcvMTQgMDI6MzI6MzAJMS40NDE5CisrKyBD aGFuZ2VMb2cJMjAwNS8wNy8xNCAwNToxMzo0MQpAQCAtMSwzICsxLDIzIEBACisyMDA1LTA3LTEz ICBUcmV5IE1hdHRlc29uICA8dHJleUB1c2EubmV0PgorCisgICAgICAgIFJldmlld2VkIGJ5IGh5 YXR0LgorCisgICAgICAgIEZpeGVkIDxyZGFyOi8vcHJvYmxlbS80MDgzNDk2ID4gc29tZSBlbGVt ZW50cyBkcmF3IHNlbGVjdGlvbiB3aGVuIHByaW50aW5nCisgICAgICAgICAgICBodHRwOi8vYnVn emlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTM5OTIKKworICAgICAgICBTaW1w bHkgYWRkZWQgdGVzdHMgdG8gcHJldmVudCBzZWxlY3Rpb24gZHJhd2luZyB3aGVuIHByaW50aW5n LgorCisgICAgICAgIFRlc3QgY2FzZXMgYWRkZWQ6IChOT05FKQorCisgICAgICAgICoga2h0bWwv cmVuZGVyaW5nL3JlbmRlcl9ibG9jay5jcHA6CisgICAgICAgIChraHRtbDo6UmVuZGVyQmxvY2s6 OnBhaW50T2JqZWN0KToKKyAgICAgICAgKiBraHRtbC9yZW5kZXJpbmcvcmVuZGVyX2NhbnZhc2lt YWdlLmNwcDoKKyAgICAgICAgKFJlbmRlckNhbnZhc0ltYWdlOjpwYWludCk6CisgICAgICAgICog a2h0bWwvcmVuZGVyaW5nL3JlbmRlcl9pbWFnZS5jcHA6CisgICAgICAgIChSZW5kZXJJbWFnZTo6 cGFpbnQpOgorICAgICAgICAqIGtodG1sL3JlbmRlcmluZy9yZW5kZXJfcmVwbGFjZWQuY3BwOgor ICAgICAgICAoUmVuZGVyV2lkZ2V0OjpwYWludCk6CisKIDIwMDUtMDctMTMgIEp1c3RpbiBHYXJj aWEgIDxqdXN0aW4uZ2FyY2lhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBtanMK SW5kZXg6IC4va2h0bWwvcmVuZGVyaW5nL3JlbmRlcl9ibG9jay5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1Mg ZmlsZTogL2N2cy9yb290L1dlYkNvcmUva2h0bWwvcmVuZGVyaW5nL3JlbmRlcl9ibG9jay5jcHAs dgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMTg3CmRpZmYgLXAgLXUgLXIxLjE4NyAuL2todG1sL3Jl bmRlcmluZy9yZW5kZXJfYmxvY2suY3BwCi0tLSAuL2todG1sL3JlbmRlcmluZy9yZW5kZXJfYmxv Y2suY3BwCTIwMDUvMDcvMDkgMjA6MTk6MTcJMS4xODcKKysrIC4va2h0bWwvcmVuZGVyaW5nL3Jl bmRlcl9ibG9jay5jcHAJMjAwNS8wNy8xNCAwNToxMzo1NQpAQCAtMTMwNyw3ICsxMzA3LDggQEAg dm9pZCBSZW5kZXJCbG9jazo6cGFpbnRPYmplY3QoUGFpbnRJbmZvJgogICAgICAgICBwYWludENo aWxkcmVuKGksIHNjcm9sbGVkWCwgc2Nyb2xsZWRZKTsKICAgICAKICAgICAvLyAzLiBwYWludCBz ZWxlY3Rpb24KLSAgICBpZiAoIWlubGluZUZsb3cpCisgICAgYm9vbCBpc1ByaW50aW5nID0gKGku cC0+ZGV2aWNlKCktPmRldlR5cGUoKSA9PSBRSW50ZXJuYWw6OlByaW50ZXIpOworICAgIGlmICgh aW5saW5lRmxvdyAmJiAhaXNQcmludGluZykKICAgICAgICAgcGFpbnRTZWxlY3Rpb24oaSwgc2Ny b2xsZWRYLCBzY3JvbGxlZFkpOyAvLyBGaWxsIGluIGdhcHMgaW4gc2VsZWN0aW9uIG9uIGxpbmVz IGFuZCBiZXR3ZWVuIGJsb2Nrcy4KIAogICAgIC8vIDQuIHBhaW50IGZsb2F0cy4KSW5kZXg6IC4v a2h0bWwvcmVuZGVyaW5nL3JlbmRlcl9jYW52YXNpbWFnZS5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmls ZTogL2N2cy9yb290L1dlYkNvcmUva2h0bWwvcmVuZGVyaW5nL3JlbmRlcl9jYW52YXNpbWFnZS5j cHAsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMTMKZGlmZiAtcCAtdSAtcjEuMTMgLi9raHRtbC9y ZW5kZXJpbmcvcmVuZGVyX2NhbnZhc2ltYWdlLmNwcAotLS0gLi9raHRtbC9yZW5kZXJpbmcvcmVu ZGVyX2NhbnZhc2ltYWdlLmNwcAkyMDA1LzA3LzA5IDIwOjE5OjE3CTEuMTMKKysrIC4va2h0bWwv cmVuZGVyaW5nL3JlbmRlcl9jYW52YXNpbWFnZS5jcHAJMjAwNS8wNy8xNCAwNToxMzo1NQpAQCAt MTY1LDcgKzE2NSw4IEBAIHZvaWQgUmVuZGVyQ2FudmFzSW1hZ2U6OnBhaW50KFBhaW50SW5mbyYK ICAgICBpZiAoIXNob3VsZFBhaW50V2l0aGluUm9vdChpKSkKICAgICAgICAgcmV0dXJuOwogCi0g ICAgYm9vbCBkcmF3U2VsZWN0aW9uVGludCA9IHNlbGVjdGlvblN0YXRlKCkgIT0gU2VsZWN0aW9u Tm9uZTsKKyAgICBib29sIGlzUHJpbnRpbmcgPSAoaS5wLT5kZXZpY2UoKS0+ZGV2VHlwZSgpID09 IFFJbnRlcm5hbDo6UHJpbnRlcik7CisgICAgYm9vbCBkcmF3U2VsZWN0aW9uVGludCA9IChzZWxl Y3Rpb25TdGF0ZSgpICE9IFNlbGVjdGlvbk5vbmUpICYmICFpc1ByaW50aW5nOwogICAgIGlmIChp LnBoYXNlID09IFBhaW50QWN0aW9uU2VsZWN0aW9uKSB7CiAgICAgICAgIGlmIChzZWxlY3Rpb25T dGF0ZSgpID09IFNlbGVjdGlvbk5vbmUpIHsKICAgICAgICAgICAgIHJldHVybjsKSW5kZXg6IC4v a2h0bWwvcmVuZGVyaW5nL3JlbmRlcl9pbWFnZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2 cy9yb290L1dlYkNvcmUva2h0bWwvcmVuZGVyaW5nL3JlbmRlcl9pbWFnZS5jcHAsdgpyZXRyaWV2 aW5nIHJldmlzaW9uIDEuNzkKZGlmZiAtcCAtdSAtcjEuNzkgLi9raHRtbC9yZW5kZXJpbmcvcmVu ZGVyX2ltYWdlLmNwcAotLS0gLi9raHRtbC9yZW5kZXJpbmcvcmVuZGVyX2ltYWdlLmNwcAkyMDA1 LzA3LzA5IDIwOjE5OjE3CTEuNzkKKysrIC4va2h0bWwvcmVuZGVyaW5nL3JlbmRlcl9pbWFnZS5j cHAJMjAwNS8wNy8xNCAwNToxMzo1NgpAQCAtMjQ3LDcgKzI0Nyw4IEBAIHZvaWQgUmVuZGVySW1h Z2U6OnBhaW50KFBhaW50SW5mbyYgaSwgaW4KICAgICAgICAgcmV0dXJuOwogICAgICAgICAKICNp ZiBBUFBMRV9DSEFOR0VTCi0gICAgYm9vbCBkcmF3U2VsZWN0aW9uVGludCA9IHNlbGVjdGlvblN0 YXRlKCkgIT0gU2VsZWN0aW9uTm9uZTsKKyAgICBib29sIGlzUHJpbnRpbmcgPSAoaS5wLT5kZXZp Y2UoKS0+ZGV2VHlwZSgpID09IFFJbnRlcm5hbDo6UHJpbnRlcik7CisgICAgYm9vbCBkcmF3U2Vs ZWN0aW9uVGludCA9IChzZWxlY3Rpb25TdGF0ZSgpICE9IFNlbGVjdGlvbk5vbmUpICYmICFpc1By aW50aW5nOwogICAgIGlmIChpLnBoYXNlID09IFBhaW50QWN0aW9uU2VsZWN0aW9uKSB7CiAgICAg ICAgIGlmIChzZWxlY3Rpb25TdGF0ZSgpID09IFNlbGVjdGlvbk5vbmUpIHsKICAgICAgICAgICAg IHJldHVybjsKSW5kZXg6IC4va2h0bWwvcmVuZGVyaW5nL3JlbmRlcl9yZXBsYWNlZC5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L1dlYkNvcmUva2h0bWwvcmVuZGVyaW5nL3JlbmRl cl9yZXBsYWNlZC5jcHAsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNzkKZGlmZiAtcCAtdSAtcjEu NzkgLi9raHRtbC9yZW5kZXJpbmcvcmVuZGVyX3JlcGxhY2VkLmNwcAotLS0gLi9raHRtbC9yZW5k ZXJpbmcvcmVuZGVyX3JlcGxhY2VkLmNwcAkyMDA1LzA3LzA1IDIzOjIxOjEzCTEuNzkKKysrIC4v a2h0bWwvcmVuZGVyaW5nL3JlbmRlcl9yZXBsYWNlZC5jcHAJMjAwNS8wNy8xNCAwNToxMzo1NgpA QCAtMzk0LDcgKzM5NCw4IEBAIHZvaWQgUmVuZGVyV2lkZ2V0OjpwYWludChQYWludEluZm8mIGks IGkKICAgICBtX3dpZGdldC0+cGFpbnQoaS5wLCBpLnIpOwogICAgIAogICAgIC8vIFBhaW50IGEg cGFydGlhbGx5IHRyYW5zcGFyZW50IHdhc2ggb3ZlciBzZWxlY3RlZCB3aWRnZXRzLgotICAgIGlm IChtX3NlbGVjdGlvblN0YXRlICE9IFNlbGVjdGlvbk5vbmUpIHsKKyAgICBib29sIGlzUHJpbnRp bmcgPSAoaS5wLT5kZXZpY2UoKS0+ZGV2VHlwZSgpID09IFFJbnRlcm5hbDo6UHJpbnRlcik7Cisg ICAgaWYgKG1fc2VsZWN0aW9uU3RhdGUgIT0gU2VsZWN0aW9uTm9uZSAmJiAhaXNQcmludGluZykg ewogICAgICAgICBRQnJ1c2ggYnJ1c2goc2VsZWN0aW9uQ29sb3IoaS5wKSk7CiAgICAgICAgIFFS ZWN0IHNlbFJlY3Qoc2VsZWN0aW9uUmVjdCgpKTsKICAgICAgICAgaS5wLT5maWxsUmVjdChzZWxS ZWN0LngoKSwgc2VsUmVjdC55KCksIHNlbFJlY3Qud2lkdGgoKSwgc2VsUmVjdC5oZWlnaHQoKSwg YnJ1c2gpOwo=