3991 2005-07-13 18:25:34 -0700 JSC doesn't implement Array.prototype.toLocaleString() 2005-08-15 21:11:43 -0700 1 1 1 Unclassified WebKit JavaScriptCore 412 Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 ggaren ggaren oliver oldest_to_newest 14608 0 ggaren 2005-07-13 18:25:34 -0700 ECMA spec: 15.4.4.3 Array.prototype.toLocaleString() The elements of the array are converted to strings using their toLocaleString methods, and these strings are then concatenated, separated by occurrences of a separator string that has been derived in an implementation-defined locale-specific way. The result of calling this function is intended to be analogous to the result of toString, except that the result of this function is intended to be locale-specific. 14609 1 ggaren 2005-07-13 18:26:23 -0700 Causes the following failure: ecma_3/Array/15.4.4.3-1.js 14610 2 2955 ggaren 2005-07-13 18:27:41 -0700 Created attachment 2955 Patch Fix. I think our case structure in this and other code is pretty ugly. Worth redoing? 14611 3 2956 ggaren 2005-07-13 18:32:51 -0700 Created attachment 2956 Patch Oops. Last patch had extra changes that were lingering in my tree. 14636 4 oliver 2005-07-13 23:58:05 -0700 If this gets landed can a comment be put in with bug 3539 as its patch will need to be updated work with this patch 14930 5 2956 mjs 2005-07-19 14:04:53 -0700 Comment on attachment 2956 Patch r=me 2955 2005-07-13 18:27:41 -0700 2005-07-13 18:33:18 -0700 Patch patch.txt text/plain 3583 ggaren PyBXZWJDb3JlL2xheW91dC10ZXN0cy9mYXN0L2pzL29iamVjdC1wcm90b3R5cGUtdG9Mb2NhbGVT dHJpbmcuaHRtbApJbmRleDogSmF2YVNjcmlwdENvcmUva2pzL2FycmF5X29iamVjdC5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L0phdmFTY3JpcHRDb3JlL2tqcy9hcnJheV9vYmpl Y3QuY3BwLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjQzCmRpZmYgLXUgLXIxLjQzIGFycmF5X29i amVjdC5jcHAKLS0tIEphdmFTY3JpcHRDb3JlL2tqcy9hcnJheV9vYmplY3QuY3BwCTMgSnVsIDIw MDUgMTA6NDc6NTIgLTAwMDAJMS40MworKysgSmF2YVNjcmlwdENvcmUva2pzL2FycmF5X29iamVj dC5jcHAJMTQgSnVsIDIwMDUgMDA6NTg6NDEgLTAwMDAKQEAgLTQ0OSw4ICs0NDksNiBAQAogICAK ICAgc3dpdGNoIChpZCkgewogICBjYXNlIFRvTG9jYWxlU3RyaW5nOgotICAgIC8vIFRPRE8gIC0g c2VlIDE1LjQuNC4zCi0gICAgLy8gZmFsbCB0aHJvdWdoCiAgIGNhc2UgVG9TdHJpbmc6CiAKICAg ICBpZiAoIXRoaXNPYmouaW5oZXJpdHMoJkFycmF5SW5zdGFuY2VJbXA6OmluZm8pKSB7CkBAIC00 NjAsNyArNDU4LDYgQEAKICAgICB9CiAKICAgICAvLyBmYWxsIHRocm91Z2gKLQogICBjYXNlIEpv aW46IHsKICAgICBVU3RyaW5nIHNlcGFyYXRvciA9ICIsIjsKICAgICBVU3RyaW5nIHN0ciA9ICIi OwpAQCAtNDcwLDExICs0NjcsMjEgQEAKICAgICBmb3IgKHVuc2lnbmVkIGludCBrID0gMDsgayA8 IGxlbmd0aDsgaysrKSB7CiAgICAgICBpZiAoayA+PSAxKQogICAgICAgICBzdHIgKz0gc2VwYXJh dG9yOwotICAgICAgVmFsdWUgZWxlbWVudCA9IHRoaXNPYmouZ2V0KGV4ZWMsayk7Ci0gICAgICBp ZiAoZWxlbWVudC50eXBlKCkgIT0gVW5kZWZpbmVkVHlwZSAmJiBlbGVtZW50LnR5cGUoKSAhPSBO dWxsVHlwZSkKLSAgICAgICAgc3RyICs9IGVsZW1lbnQudG9TdHJpbmcoZXhlYyk7CisgICAgICAK KyAgICAgIFZhbHVlIGVsZW1lbnQgPSB0aGlzT2JqLmdldChleGVjLCBrKTsKKyAgICAgIGlmIChl bGVtZW50LnR5cGUoKSA9PSBVbmRlZmluZWRUeXBlIHx8IGVsZW1lbnQudHlwZSgpID09IE51bGxU eXBlKQorICAgICAgICBjb250aW51ZTsKKworICAgICAgT2JqZWN0IG8gPSBlbGVtZW50LnRvT2Jq ZWN0KGV4ZWMpOworICAgICAgT2JqZWN0IGNvbnZlcnNpb25GdW5jdGlvbjsKKyAgICAgIGlmIChp ZCA9PSBUb0xvY2FsZVN0cmluZykgeworICAgICAgICBjb252ZXJzaW9uRnVuY3Rpb24gPSBPYmpl Y3Q6OmR5bmFtaWNDYXN0KG8uZ2V0KGV4ZWMsIHRvTG9jYWxlU3RyaW5nUHJvcGVydHlOYW1lKSk7 CisgICAgICB9IGVsc2UgeworICAgICAgICBjb252ZXJzaW9uRnVuY3Rpb24gPSBPYmplY3Q6OmR5 bmFtaWNDYXN0KG8uZ2V0KGV4ZWMsIHRvU3RyaW5nUHJvcGVydHlOYW1lKSk7CisgICAgICB9Cisg ICAgICBzdHIgKz0gY29udmVyc2lvbkZ1bmN0aW9uLmNhbGwoZXhlYywgbywgTGlzdCgpKS50b1N0 cmluZyhleGVjKTsKICAgICAgIGlmICggZXhlYy0+aGFkRXhjZXB0aW9uKCkgKQotCWJyZWFrOwor ICAgICAgICBicmVhazsKICAgICB9CiAgICAgcmVzdWx0ID0gU3RyaW5nKHN0cik7CiAgICAgYnJl YWs7CkluZGV4OiBKYXZhU2NyaXB0Q29yZS9ranMvb2JqZWN0X29iamVjdC5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQpSQ1MgZmlsZTogL2N2cy9yb290L0phdmFTY3JpcHRDb3JlL2tqcy9vYmplY3Rfb2JqZWN0LmNw cCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS45CmRpZmYgLXUgLXIxLjkgb2JqZWN0X29iamVjdC5j cHAKLS0tIEphdmFTY3JpcHRDb3JlL2tqcy9vYmplY3Rfb2JqZWN0LmNwcAkzIEp1bCAyMDA1IDEw OjQ3OjUzIC0wMDAwCTEuOQorKysgSmF2YVNjcmlwdENvcmUva2pzL29iamVjdF9vYmplY3QuY3Bw CTE0IEp1bCAyMDA1IDAwOjU4OjQxIC0wMDAwCkBAIC0zOSw2ICszOSw3IEBACiB7CiAgICAgVmFs dWUgcHJvdGVjdCh0aGlzKTsKICAgICBwdXREaXJlY3QodG9TdHJpbmdQcm9wZXJ0eU5hbWUsIG5l dyBPYmplY3RQcm90b0Z1bmNJbXAoZXhlYyxmdW5jUHJvdG8sT2JqZWN0UHJvdG9GdW5jSW1wOjpU b1N0cmluZywgIDApLCBEb250RW51bSk7CisgICAgcHV0RGlyZWN0KHRvTG9jYWxlU3RyaW5nUHJv cGVydHlOYW1lLCBuZXcgT2JqZWN0UHJvdG9GdW5jSW1wKGV4ZWMsZnVuY1Byb3RvLE9iamVjdFBy b3RvRnVuY0ltcDo6VG9Mb2NhbGVTdHJpbmcsIDApLCBEb250RW51bSk7CiAgICAgcHV0RGlyZWN0 KHZhbHVlT2ZQcm9wZXJ0eU5hbWUsICBuZXcgT2JqZWN0UHJvdG9GdW5jSW1wKGV4ZWMsZnVuY1By b3RvLE9iamVjdFByb3RvRnVuY0ltcDo6VmFsdWVPZiwgICAwKSwgRG9udEVudW0pOwogICAgIHB1 dERpcmVjdCgiaGFzT3duUHJvcGVydHkiLCBuZXcgT2JqZWN0UHJvdG9GdW5jSW1wKGV4ZWMsZnVu Y1Byb3RvLE9iamVjdFByb3RvRnVuY0ltcDo6SGFzT3duUHJvcGVydHksMSksIERvbnRFbnVtKTsK IH0KQEAgLTc0LDYgKzc1LDggQEAKICAgICAgICAgICAgIGJvb2wgZXhpc3RzID0gdGhpc09iai5o YXNPd25Qcm9wZXJ0eShleGVjLCBwcm9wZXJ0eU5hbWUpOwogICAgICAgICAgICAgcmV0dXJuIFZh bHVlKGV4aXN0cyA/IEJvb2xlYW5JbXA6OnN0YXRpY1RydWUgOiBCb29sZWFuSW1wOjpzdGF0aWNG YWxzZSk7CiAgICAgICAgIH0KKyAgICAgICAgY2FzZSBUb0xvY2FsZVN0cmluZzoKKyAgICAgICAg ICByZXR1cm4gdGhpc09iai5pbXAoKS0+dG9TdHJpbmcoZXhlYyk7CiAgICAgICAgIGNhc2UgVG9T dHJpbmc6CiAgICAgICAgIGRlZmF1bHQ6CiAgICAgICAgICAgICByZXR1cm4gU3RyaW5nKCJbb2Jq ZWN0ICIgKyB0aGlzT2JqLmNsYXNzTmFtZSgpICsgIl0iKTsKSW5kZXg6IEphdmFTY3JpcHRDb3Jl L2tqcy9vYmplY3Rfb2JqZWN0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L0phdmFT Y3JpcHRDb3JlL2tqcy9vYmplY3Rfb2JqZWN0LmgsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNgpk aWZmIC11IC1yMS42IG9iamVjdF9vYmplY3QuaAotLS0gSmF2YVNjcmlwdENvcmUva2pzL29iamVj dF9vYmplY3QuaAkzIEp1bCAyMDA1IDEwOjQ3OjUzIC0wMDAwCTEuNgorKysgSmF2YVNjcmlwdENv cmUva2pzL29iamVjdF9vYmplY3QuaAkxNCBKdWwgMjAwNSAwMDo1ODo0MSAtMDAwMApAQCAtNTMs NyArNTMsNyBAQAogICAgIHZpcnR1YWwgYm9vbCBpbXBsZW1lbnRzQ2FsbCgpIGNvbnN0OwogICAg IHZpcnR1YWwgVmFsdWUgY2FsbChFeGVjU3RhdGUgKmV4ZWMsIE9iamVjdCAmdGhpc09iaiwgY29u c3QgTGlzdCAmYXJncyk7CiAKLSAgICBlbnVtIHsgVG9TdHJpbmcsIFZhbHVlT2YsIEhhc093blBy b3BlcnR5IH07CisgICAgZW51bSB7IFRvU3RyaW5nLCBUb0xvY2FsZVN0cmluZywgVmFsdWVPZiwg SGFzT3duUHJvcGVydHkgfTsKICAgcHJpdmF0ZToKICAgICBpbnQgaWQ7CiAgIH07Cg== 2956 2005-07-13 18:32:51 -0700 2005-07-19 14:04:53 -0700 Patch patch.txt text/plain 1552 ggaren SW5kZXg6IGtqcy9hcnJheV9vYmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9v dC9KYXZhU2NyaXB0Q29yZS9ranMvYXJyYXlfb2JqZWN0LmNwcCx2CnJldHJpZXZpbmcgcmV2aXNp b24gMS40MwpkaWZmIC11IC1yMS40MyBhcnJheV9vYmplY3QuY3BwCi0tLSBranMvYXJyYXlfb2Jq ZWN0LmNwcAkzIEp1bCAyMDA1IDEwOjQ3OjUyIC0wMDAwCTEuNDMKKysrIGtqcy9hcnJheV9vYmpl Y3QuY3BwCTE0IEp1bCAyMDA1IDAxOjE3OjQzIC0wMDAwCkBAIC00NDksOCArNDQ5LDYgQEAKICAg CiAgIHN3aXRjaCAoaWQpIHsKICAgY2FzZSBUb0xvY2FsZVN0cmluZzoKLSAgICAvLyBUT0RPICAt IHNlZSAxNS40LjQuMwotICAgIC8vIGZhbGwgdGhyb3VnaAogICBjYXNlIFRvU3RyaW5nOgogCiAg ICAgaWYgKCF0aGlzT2JqLmluaGVyaXRzKCZBcnJheUluc3RhbmNlSW1wOjppbmZvKSkgewpAQCAt NDYwLDcgKzQ1OCw2IEBACiAgICAgfQogCiAgICAgLy8gZmFsbCB0aHJvdWdoCi0KICAgY2FzZSBK b2luOiB7CiAgICAgVVN0cmluZyBzZXBhcmF0b3IgPSAiLCI7CiAgICAgVVN0cmluZyBzdHIgPSAi IjsKQEAgLTQ3MCwxMSArNDY3LDIyIEBACiAgICAgZm9yICh1bnNpZ25lZCBpbnQgayA9IDA7IGsg PCBsZW5ndGg7IGsrKykgewogICAgICAgaWYgKGsgPj0gMSkKICAgICAgICAgc3RyICs9IHNlcGFy YXRvcjsKLSAgICAgIFZhbHVlIGVsZW1lbnQgPSB0aGlzT2JqLmdldChleGVjLGspOwotICAgICAg aWYgKGVsZW1lbnQudHlwZSgpICE9IFVuZGVmaW5lZFR5cGUgJiYgZWxlbWVudC50eXBlKCkgIT0g TnVsbFR5cGUpCi0gICAgICAgIHN0ciArPSBlbGVtZW50LnRvU3RyaW5nKGV4ZWMpOworICAgICAg CisgICAgICBWYWx1ZSBlbGVtZW50ID0gdGhpc09iai5nZXQoZXhlYywgayk7CisgICAgICBpZiAo ZWxlbWVudC50eXBlKCkgPT0gVW5kZWZpbmVkVHlwZSB8fCBlbGVtZW50LnR5cGUoKSA9PSBOdWxs VHlwZSkKKyAgICAgICAgY29udGludWU7CisKKyAgICAgIE9iamVjdCBvID0gZWxlbWVudC50b09i amVjdChleGVjKTsKKyAgICAgIE9iamVjdCBjb252ZXJzaW9uRnVuY3Rpb247CisgICAgICBpZiAo aWQgPT0gVG9Mb2NhbGVTdHJpbmcpIHsKKyAgICAgICAgY29udmVyc2lvbkZ1bmN0aW9uID0gT2Jq ZWN0OjpkeW5hbWljQ2FzdChvLmdldChleGVjLCB0b0xvY2FsZVN0cmluZ1Byb3BlcnR5TmFtZSkp OworICAgICAgfSBlbHNlIHsKKyAgICAgICAgY29udmVyc2lvbkZ1bmN0aW9uID0gT2JqZWN0Ojpk eW5hbWljQ2FzdChvLmdldChleGVjLCB0b1N0cmluZ1Byb3BlcnR5TmFtZSkpOworICAgICAgfQor ICAgICAgc3RyICs9IGNvbnZlcnNpb25GdW5jdGlvbi5jYWxsKGV4ZWMsIG8sIExpc3QoKSkudG9T dHJpbmcoZXhlYyk7CisgICAgICAKICAgICAgIGlmICggZXhlYy0+aGFkRXhjZXB0aW9uKCkgKQot CWJyZWFrOworICAgICAgICBicmVhazsKICAgICB9CiAgICAgcmVzdWx0ID0gU3RyaW5nKHN0cik7 CiAgICAgYnJlYWs7Cg==