<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>39892</bug_id>
          
          <creation_ts>2010-05-28 11:40:56 -0700</creation_ts>
          <short_desc>Make NodeList getters take AtomicString instead of plain String</short_desc>
          <delta_ts>2019-02-06 09:03:38 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>DOM</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>39921</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="anton muhin">antonm</reporter>
          <assigned_to name="anton muhin">antonm</assigned_to>
          <cc>abarth</cc>
    
    <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>darin</cc>
    
    <cc>eric</cc>
    
    <cc>mjs</cc>
    
    <cc>sam</cc>
    
    <cc>xan.lopez</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>231829</commentid>
    <comment_count>0</comment_count>
    <who name="anton muhin">antonm</who>
    <bug_when>2010-05-28 11:40:56 -0700</bug_when>
    <thetext>Make NodeList getters take AtomicString instead of plain String</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>231836</commentid>
    <comment_count>1</comment_count>
      <attachid>57355</attachid>
    <who name="anton muhin">antonm</who>
    <bug_when>2010-05-28 11:46:37 -0700</bug_when>
    <thetext>Created attachment 57355
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>231840</commentid>
    <comment_count>2</comment_count>
    <who name="anton muhin">antonm</who>
    <bug_when>2010-05-28 11:47:41 -0700</bug_when>
    <thetext>Those methods turn String into AtomicString later.  And this conversion is faster if underlying string is already atomic.

That buys a small (~2-3%) speed up for Chromium on Dromaeo DOM Core.  I don&apos;t know if Safari benefits from it.

(Darin, you beat me at changine platform :)  Is there a way to specify those parameters from command line in webkit-patch?)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>231844</commentid>
    <comment_count>3</comment_count>
      <attachid>57355</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2010-05-28 11:49:47 -0700</bug_when>
    <thetext>Comment on attachment 57355
Patch

Would be nice if the change log said why this was a good change instead of just stating what the change is.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>231845</commentid>
    <comment_count>4</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2010-05-28 11:50:18 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; (Darin, you beat me at changine platform :)  Is there a way to specify those parameters from command line in webkit-patch?)

Not that I know of.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>231849</commentid>
    <comment_count>5</comment_count>
      <attachid>57356</attachid>
    <who name="anton muhin">antonm</who>
    <bug_when>2010-05-28 11:53:50 -0700</bug_when>
    <thetext>Created attachment 57356
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>231853</commentid>
    <comment_count>6</comment_count>
    <who name="anton muhin">antonm</who>
    <bug_when>2010-05-28 11:56:18 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; (In reply to comment #2)
&gt; &gt; (Darin, you beat me at changine platform :)  Is there a way to specify those parameters from command line in webkit-patch?)
&gt; 
&gt; Not that I know of.

I see, thanks.

Uploaded a new patch with better message.

I&apos;ll try to upload the next one with correct reviewed to start cq+.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>231854</commentid>
    <comment_count>7</comment_count>
      <attachid>57357</attachid>
    <who name="anton muhin">antonm</who>
    <bug_when>2010-05-28 11:57:55 -0700</bug_when>
    <thetext>Created attachment 57357
with correct reviewed by</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>232095</commentid>
    <comment_count>8</comment_count>
      <attachid>57357</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-05-29 04:18:43 -0700</bug_when>
    <thetext>Comment on attachment 57357
with correct reviewed by

Clearing flags on attachment: 57357

Committed r60405: &lt;http://trac.webkit.org/changeset/60405&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>232096</commentid>
    <comment_count>9</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-05-29 04:18:49 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>232123</commentid>
    <comment_count>10</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-05-29 10:35:21 -0700</bug_when>
    <thetext>Reopening since this was rolled out.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>232159</commentid>
    <comment_count>11</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2010-05-29 20:21:38 -0700</bug_when>
    <thetext>How did this break the build?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>232160</commentid>
    <comment_count>12</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2010-05-29 20:22:58 -0700</bug_when>
    <thetext>Looks to me like the problem with the GTK build was incorrect dependencies in the build system. If that is so, this is going to be an ongoing problem with multiple patches and I don&apos;t think rolling out patches is the right way to deal with it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>232182</commentid>
    <comment_count>13</comment_count>
    <who name="Xan Lopez">xan.lopez</who>
    <bug_when>2010-05-30 07:46:09 -0700</bug_when>
    <thetext>(In reply to comment #12)
&gt; Looks to me like the problem with the GTK build was incorrect dependencies in the build system. If that is so, this is going to be an ongoing problem with multiple patches and I don&apos;t think rolling out patches is the right way to deal with it.

The right way is to fix the bugs, right. I uploaded a patch to bug 39932 that seems to fix things; once that&apos;s in we can try again.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>232341</commentid>
    <comment_count>14</comment_count>
    <who name="anton muhin">antonm</who>
    <bug_when>2010-05-31 06:09:50 -0700</bug_when>
    <thetext>(In reply to comment #13)
&gt; (In reply to comment #12)
&gt; &gt; Looks to me like the problem with the GTK build was incorrect dependencies in the build system. If that is so, this is going to be an ongoing problem with multiple patches and I don&apos;t think rolling out patches is the right way to deal with it.
&gt; 
&gt; The right way is to fix the bugs, right. I uploaded a patch to bug 39932 that seems to fix things; once that&apos;s in we can try again.

Ok, I am trying to cq+ it again.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>232343</commentid>
    <comment_count>15</comment_count>
      <attachid>57357</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-05-31 06:34:58 -0700</bug_when>
    <thetext>Comment on attachment 57357
with correct reviewed by

Clearing flags on attachment: 57357

Committed r60434: &lt;http://trac.webkit.org/changeset/60434&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>232344</commentid>
    <comment_count>16</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-05-31 06:35:06 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1503006</commentid>
    <comment_count>17</comment_count>
    <who name="Lucas Forschler">lforschler</who>
    <bug_when>2019-02-06 09:03:38 -0800</bug_when>
    <thetext>Mass moving XML DOM bugs to the &quot;DOM&quot; Component.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>57355</attachid>
            <date>2010-05-28 11:46:37 -0700</date>
            <delta_ts>2010-05-28 11:53:43 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-39892-20100528224635.patch</filename>
            <type>text/plain</type>
            <size>2388</size>
            <attacher name="anton muhin">antonm</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
ZWFlMGQ5MzRmZTY4YTdkNThjMTg1YzFiZTAwNThkYTc1Njg5Y2Q4OC4uNTJiMDBmYmY1YTY0MWYy
NjVmZGNhM2FlY2E5Y2U4ZjM3MjIwYWY3MiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK
KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNS0yOCAgQW50
b24gTXVoaW4gIDxhbnRvbm1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P
Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2UgTm9kZUxpc3QgZ2V0dGVycyB0YWtlIEF0b21p
Y1N0cmluZyBpbnN0ZWFkIG9mIHBsYWluIFN0cmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Vi
a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzk4OTIKKworICAgICAgICAqIGRvbS9Ob2RlLmNwcDoK
KyAgICAgICAgKFdlYkNvcmU6Ok5vZGU6OmdldEVsZW1lbnRzQnlUYWdOYW1lKToKKyAgICAgICAg
KFdlYkNvcmU6Ok5vZGU6OmdldEVsZW1lbnRzQnlUYWdOYW1lTlMpOgorICAgICAgICAqIGRvbS9O
b2RlLmg6CisKIDIwMTAtMDUtMjggIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCiAg
ICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCmRpZmYgLS1naXQgYS9XZWJDb3JlL2RvbS9O
b2RlLmNwcCBiL1dlYkNvcmUvZG9tL05vZGUuY3BwCmluZGV4IDBkNjcwNmRiYzk2NzQ0OWFiZjdk
ZWFlMTY0OWU1NzhjMTlmOTk4NWYuLjEwMTZmOGUxMWE0MjcyNjRhMjMyZGVkZmYwODc3YzRhYzUz
OTIyNTEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvZG9tL05vZGUuY3BwCisrKyBiL1dlYkNvcmUvZG9t
L05vZGUuY3BwCkBAIC0xNTYxLDEyICsxNTYxLDEyIEBAIGJvb2wgTm9kZTo6aW5TYW1lQ29udGFp
bmluZ0Jsb2NrRmxvd0VsZW1lbnQoTm9kZSAqbikKIAogLy8gRklYTUU6IEVuZCBvZiBvYnZpb3Vz
bHkgbWlzcGxhY2VkIEhUTUwgZWRpdGluZyBmdW5jdGlvbnMuICBUcnkgdG8gbW92ZSB0aGVzZSBv
dXQgb2YgTm9kZS4KIAotUGFzc1JlZlB0cjxOb2RlTGlzdD4gTm9kZTo6Z2V0RWxlbWVudHNCeVRh
Z05hbWUoY29uc3QgU3RyaW5nJiBuYW1lKQorUGFzc1JlZlB0cjxOb2RlTGlzdD4gTm9kZTo6Z2V0
RWxlbWVudHNCeVRhZ05hbWUoY29uc3QgQXRvbWljU3RyaW5nJiBuYW1lKQogewogICAgIHJldHVy
biBnZXRFbGVtZW50c0J5VGFnTmFtZU5TKHN0YXJBdG9tLCBuYW1lKTsKIH0KICAKLVBhc3NSZWZQ
dHI8Tm9kZUxpc3Q+IE5vZGU6OmdldEVsZW1lbnRzQnlUYWdOYW1lTlMoY29uc3QgQXRvbWljU3Ry
aW5nJiBuYW1lc3BhY2VVUkksIGNvbnN0IFN0cmluZyYgbG9jYWxOYW1lKQorUGFzc1JlZlB0cjxO
b2RlTGlzdD4gTm9kZTo6Z2V0RWxlbWVudHNCeVRhZ05hbWVOUyhjb25zdCBBdG9taWNTdHJpbmcm
IG5hbWVzcGFjZVVSSSwgY29uc3QgQXRvbWljU3RyaW5nJiBsb2NhbE5hbWUpCiB7CiAgICAgaWYg
KGxvY2FsTmFtZS5pc051bGwoKSkKICAgICAgICAgcmV0dXJuIDA7CmRpZmYgLS1naXQgYS9XZWJD
b3JlL2RvbS9Ob2RlLmggYi9XZWJDb3JlL2RvbS9Ob2RlLmgKaW5kZXggMzhjZmE2Y2QwYjA5OGU5
NDY0Y2EyYjVmZjMzOWNhYzQzM2FjNTUyYi4uZmQ1YjM3ZjU2ZGEzOTExNThkM2RmYjA5MzdmY2I4
MmUyOWZlOTg1ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9kb20vTm9kZS5oCisrKyBiL1dlYkNvcmUv
ZG9tL05vZGUuaApAQCAtNTMzLDggKzUzMyw4IEBAIHB1YmxpYzoKICAgICB2b2lkIHJlbW92ZUNh
Y2hlZFRhZ05vZGVMaXN0KFRhZ05vZGVMaXN0KiwgY29uc3QgUXVhbGlmaWVkTmFtZSYpOwogICAg
IHZvaWQgcmVtb3ZlQ2FjaGVkTGFiZWxzTm9kZUxpc3QoRHluYW1pY05vZGVMaXN0Kik7CiAgICAg
Ci0gICAgUGFzc1JlZlB0cjxOb2RlTGlzdD4gZ2V0RWxlbWVudHNCeVRhZ05hbWUoY29uc3QgU3Ry
aW5nJik7Ci0gICAgUGFzc1JlZlB0cjxOb2RlTGlzdD4gZ2V0RWxlbWVudHNCeVRhZ05hbWVOUyhj
b25zdCBBdG9taWNTdHJpbmcmIG5hbWVzcGFjZVVSSSwgY29uc3QgU3RyaW5nJiBsb2NhbE5hbWUp
OworICAgIFBhc3NSZWZQdHI8Tm9kZUxpc3Q+IGdldEVsZW1lbnRzQnlUYWdOYW1lKGNvbnN0IEF0
b21pY1N0cmluZyYpOworICAgIFBhc3NSZWZQdHI8Tm9kZUxpc3Q+IGdldEVsZW1lbnRzQnlUYWdO
YW1lTlMoY29uc3QgQXRvbWljU3RyaW5nJiBuYW1lc3BhY2VVUkksIGNvbnN0IEF0b21pY1N0cmlu
ZyYgbG9jYWxOYW1lKTsKICAgICBQYXNzUmVmUHRyPE5vZGVMaXN0PiBnZXRFbGVtZW50c0J5TmFt
ZShjb25zdCBTdHJpbmcmIGVsZW1lbnROYW1lKTsKICAgICBQYXNzUmVmUHRyPE5vZGVMaXN0PiBn
ZXRFbGVtZW50c0J5Q2xhc3NOYW1lKGNvbnN0IFN0cmluZyYgY2xhc3NOYW1lcyk7CiAK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>57356</attachid>
            <date>2010-05-28 11:53:50 -0700</date>
            <delta_ts>2010-05-28 11:57:48 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-39892-20100528225348.patch</filename>
            <type>text/plain</type>
            <size>2656</size>
            <attacher name="anton muhin">antonm</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
ZWFlMGQ5MzRmZTY4YTdkNThjMTg1YzFiZTAwNThkYTc1Njg5Y2Q4OC4uNTI3MzYzY2MxN2EzMTJl
NWU0OWM2OGQzNjdlODczNzczZjUxZDRmYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK
KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0wNS0yOCAgQW50
b24gTXVoaW4gIDxhbnRvbm1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P
Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2UgTm9kZUxpc3QgZ2V0dGVycyB0YWtlIEF0b21p
Y1N0cmluZyBpbnN0ZWFkIG9mIHBsYWluIFN0cmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Vi
a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzk4OTIKKworICAgICAgICBUaG9zZSBtZXRob2RzIHR1
cm4gU3RyaW5nIGludG8gQXRvbWljU3RyaW5nIGxhdGVyLiAgQW5kIHRoaXMgY29udmVyc2lvbgor
ICAgICAgICBpcyBmYXN0ZXIgaWYgdW5kZXJseWluZyBzdHJpbmcgaXMgYWxyZWFkeSBhdG9taWMu
CisgICAgICAgIFRoYXQgYnV5cyBzbWFsbCAofjItMyUpIHNwZWVkIHVwIGZvciBDaHJvbWl1bSBv
biBEcm9tYWVvIERPTSBDb3JlLgorICAgICAgICBJIGRvbid0IGtub3cgaWYgU2FmYXJpIGJlbmVm
aXRzIGZyb20gaXQuCisKKyAgICAgICAgKiBkb20vTm9kZS5jcHA6CisgICAgICAgIChXZWJDb3Jl
OjpOb2RlOjpnZXRFbGVtZW50c0J5VGFnTmFtZSk6CisgICAgICAgIChXZWJDb3JlOjpOb2RlOjpn
ZXRFbGVtZW50c0J5VGFnTmFtZU5TKToKKyAgICAgICAgKiBkb20vTm9kZS5oOgorCiAyMDEwLTA1
LTI4ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi
eSBBZGFtIEJhcnRoLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9kb20vTm9kZS5jcHAgYi9XZWJDb3Jl
L2RvbS9Ob2RlLmNwcAppbmRleCAwZDY3MDZkYmM5Njc0NDlhYmY3ZGVhZTE2NDllNTc4YzE5Zjk5
ODVmLi4xMDE2ZjhlMTFhNDI3MjY0YTIzMmRlZGZmMDg3N2M0YWM1MzkyMjUxIDEwMDY0NAotLS0g
YS9XZWJDb3JlL2RvbS9Ob2RlLmNwcAorKysgYi9XZWJDb3JlL2RvbS9Ob2RlLmNwcApAQCAtMTU2
MSwxMiArMTU2MSwxMiBAQCBib29sIE5vZGU6OmluU2FtZUNvbnRhaW5pbmdCbG9ja0Zsb3dFbGVt
ZW50KE5vZGUgKm4pCiAKIC8vIEZJWE1FOiBFbmQgb2Ygb2J2aW91c2x5IG1pc3BsYWNlZCBIVE1M
IGVkaXRpbmcgZnVuY3Rpb25zLiAgVHJ5IHRvIG1vdmUgdGhlc2Ugb3V0IG9mIE5vZGUuCiAKLVBh
c3NSZWZQdHI8Tm9kZUxpc3Q+IE5vZGU6OmdldEVsZW1lbnRzQnlUYWdOYW1lKGNvbnN0IFN0cmlu
ZyYgbmFtZSkKK1Bhc3NSZWZQdHI8Tm9kZUxpc3Q+IE5vZGU6OmdldEVsZW1lbnRzQnlUYWdOYW1l
KGNvbnN0IEF0b21pY1N0cmluZyYgbmFtZSkKIHsKICAgICByZXR1cm4gZ2V0RWxlbWVudHNCeVRh
Z05hbWVOUyhzdGFyQXRvbSwgbmFtZSk7CiB9CiAgCi1QYXNzUmVmUHRyPE5vZGVMaXN0PiBOb2Rl
OjpnZXRFbGVtZW50c0J5VGFnTmFtZU5TKGNvbnN0IEF0b21pY1N0cmluZyYgbmFtZXNwYWNlVVJJ
LCBjb25zdCBTdHJpbmcmIGxvY2FsTmFtZSkKK1Bhc3NSZWZQdHI8Tm9kZUxpc3Q+IE5vZGU6Omdl
dEVsZW1lbnRzQnlUYWdOYW1lTlMoY29uc3QgQXRvbWljU3RyaW5nJiBuYW1lc3BhY2VVUkksIGNv
bnN0IEF0b21pY1N0cmluZyYgbG9jYWxOYW1lKQogewogICAgIGlmIChsb2NhbE5hbWUuaXNOdWxs
KCkpCiAgICAgICAgIHJldHVybiAwOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9kb20vTm9kZS5oIGIv
V2ViQ29yZS9kb20vTm9kZS5oCmluZGV4IDM4Y2ZhNmNkMGIwOThlOTQ2NGNhMmI1ZmYzMzljYWM0
MzNhYzU1MmIuLmZkNWIzN2Y1NmRhMzkxMTU4ZDNkZmIwOTM3ZmNiODJlMjlmZTk4NWQgMTAwNjQ0
Ci0tLSBhL1dlYkNvcmUvZG9tL05vZGUuaAorKysgYi9XZWJDb3JlL2RvbS9Ob2RlLmgKQEAgLTUz
Myw4ICs1MzMsOCBAQCBwdWJsaWM6CiAgICAgdm9pZCByZW1vdmVDYWNoZWRUYWdOb2RlTGlzdChU
YWdOb2RlTGlzdCosIGNvbnN0IFF1YWxpZmllZE5hbWUmKTsKICAgICB2b2lkIHJlbW92ZUNhY2hl
ZExhYmVsc05vZGVMaXN0KER5bmFtaWNOb2RlTGlzdCopOwogICAgIAotICAgIFBhc3NSZWZQdHI8
Tm9kZUxpc3Q+IGdldEVsZW1lbnRzQnlUYWdOYW1lKGNvbnN0IFN0cmluZyYpOwotICAgIFBhc3NS
ZWZQdHI8Tm9kZUxpc3Q+IGdldEVsZW1lbnRzQnlUYWdOYW1lTlMoY29uc3QgQXRvbWljU3RyaW5n
JiBuYW1lc3BhY2VVUkksIGNvbnN0IFN0cmluZyYgbG9jYWxOYW1lKTsKKyAgICBQYXNzUmVmUHRy
PE5vZGVMaXN0PiBnZXRFbGVtZW50c0J5VGFnTmFtZShjb25zdCBBdG9taWNTdHJpbmcmKTsKKyAg
ICBQYXNzUmVmUHRyPE5vZGVMaXN0PiBnZXRFbGVtZW50c0J5VGFnTmFtZU5TKGNvbnN0IEF0b21p
Y1N0cmluZyYgbmFtZXNwYWNlVVJJLCBjb25zdCBBdG9taWNTdHJpbmcmIGxvY2FsTmFtZSk7CiAg
ICAgUGFzc1JlZlB0cjxOb2RlTGlzdD4gZ2V0RWxlbWVudHNCeU5hbWUoY29uc3QgU3RyaW5nJiBl
bGVtZW50TmFtZSk7CiAgICAgUGFzc1JlZlB0cjxOb2RlTGlzdD4gZ2V0RWxlbWVudHNCeUNsYXNz
TmFtZShjb25zdCBTdHJpbmcmIGNsYXNzTmFtZXMpOwogCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>57357</attachid>
            <date>2010-05-28 11:57:55 -0700</date>
            <delta_ts>2010-05-31 06:34:58 -0700</delta_ts>
            <desc>with correct reviewed by</desc>
            <filename>bug-39892-20100528225753.patch</filename>
            <type>text/plain</type>
            <size>2653</size>
            <attacher name="anton muhin">antonm</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
ZWFlMGQ5MzRmZTY4YTdkNThjMTg1YzFiZTAwNThkYTc1Njg5Y2Q4OC4uZGQzZGViN2VlMjQ2NThk
OWU2M2IzZWE4ZTZmODNmZGZhMTQ2YjFiNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK
KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0wNS0yOCAgQW50
b24gTXVoaW4gIDxhbnRvbm1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IERh
cmluIEFkbGVyLgorCisgICAgICAgIE1ha2UgTm9kZUxpc3QgZ2V0dGVycyB0YWtlIEF0b21pY1N0
cmluZyBpbnN0ZWFkIG9mIHBsYWluIFN0cmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzk4OTIKKworICAgICAgICBUaG9zZSBtZXRob2RzIHR1cm4g
U3RyaW5nIGludG8gQXRvbWljU3RyaW5nIGxhdGVyLiAgQW5kIHRoaXMgY29udmVyc2lvbgorICAg
ICAgICBpcyBmYXN0ZXIgaWYgdW5kZXJseWluZyBzdHJpbmcgaXMgYWxyZWFkeSBhdG9taWMuCisg
ICAgICAgIFRoYXQgYnV5cyBzbWFsbCAofjItMyUpIHNwZWVkIHVwIGZvciBDaHJvbWl1bSBvbiBE
cm9tYWVvIERPTSBDb3JlLgorICAgICAgICBJIGRvbid0IGtub3cgaWYgU2FmYXJpIGJlbmVmaXRz
IGZyb20gaXQuCisKKyAgICAgICAgKiBkb20vTm9kZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpO
b2RlOjpnZXRFbGVtZW50c0J5VGFnTmFtZSk6CisgICAgICAgIChXZWJDb3JlOjpOb2RlOjpnZXRF
bGVtZW50c0J5VGFnTmFtZU5TKToKKyAgICAgICAgKiBkb20vTm9kZS5oOgorCiAyMDEwLTA1LTI4
ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBB
ZGFtIEJhcnRoLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9kb20vTm9kZS5jcHAgYi9XZWJDb3JlL2Rv
bS9Ob2RlLmNwcAppbmRleCAwZDY3MDZkYmM5Njc0NDlhYmY3ZGVhZTE2NDllNTc4YzE5Zjk5ODVm
Li4xMDE2ZjhlMTFhNDI3MjY0YTIzMmRlZGZmMDg3N2M0YWM1MzkyMjUxIDEwMDY0NAotLS0gYS9X
ZWJDb3JlL2RvbS9Ob2RlLmNwcAorKysgYi9XZWJDb3JlL2RvbS9Ob2RlLmNwcApAQCAtMTU2MSwx
MiArMTU2MSwxMiBAQCBib29sIE5vZGU6OmluU2FtZUNvbnRhaW5pbmdCbG9ja0Zsb3dFbGVtZW50
KE5vZGUgKm4pCiAKIC8vIEZJWE1FOiBFbmQgb2Ygb2J2aW91c2x5IG1pc3BsYWNlZCBIVE1MIGVk
aXRpbmcgZnVuY3Rpb25zLiAgVHJ5IHRvIG1vdmUgdGhlc2Ugb3V0IG9mIE5vZGUuCiAKLVBhc3NS
ZWZQdHI8Tm9kZUxpc3Q+IE5vZGU6OmdldEVsZW1lbnRzQnlUYWdOYW1lKGNvbnN0IFN0cmluZyYg
bmFtZSkKK1Bhc3NSZWZQdHI8Tm9kZUxpc3Q+IE5vZGU6OmdldEVsZW1lbnRzQnlUYWdOYW1lKGNv
bnN0IEF0b21pY1N0cmluZyYgbmFtZSkKIHsKICAgICByZXR1cm4gZ2V0RWxlbWVudHNCeVRhZ05h
bWVOUyhzdGFyQXRvbSwgbmFtZSk7CiB9CiAgCi1QYXNzUmVmUHRyPE5vZGVMaXN0PiBOb2RlOjpn
ZXRFbGVtZW50c0J5VGFnTmFtZU5TKGNvbnN0IEF0b21pY1N0cmluZyYgbmFtZXNwYWNlVVJJLCBj
b25zdCBTdHJpbmcmIGxvY2FsTmFtZSkKK1Bhc3NSZWZQdHI8Tm9kZUxpc3Q+IE5vZGU6OmdldEVs
ZW1lbnRzQnlUYWdOYW1lTlMoY29uc3QgQXRvbWljU3RyaW5nJiBuYW1lc3BhY2VVUkksIGNvbnN0
IEF0b21pY1N0cmluZyYgbG9jYWxOYW1lKQogewogICAgIGlmIChsb2NhbE5hbWUuaXNOdWxsKCkp
CiAgICAgICAgIHJldHVybiAwOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9kb20vTm9kZS5oIGIvV2Vi
Q29yZS9kb20vTm9kZS5oCmluZGV4IDM4Y2ZhNmNkMGIwOThlOTQ2NGNhMmI1ZmYzMzljYWM0MzNh
YzU1MmIuLmZkNWIzN2Y1NmRhMzkxMTU4ZDNkZmIwOTM3ZmNiODJlMjlmZTk4NWQgMTAwNjQ0Ci0t
LSBhL1dlYkNvcmUvZG9tL05vZGUuaAorKysgYi9XZWJDb3JlL2RvbS9Ob2RlLmgKQEAgLTUzMyw4
ICs1MzMsOCBAQCBwdWJsaWM6CiAgICAgdm9pZCByZW1vdmVDYWNoZWRUYWdOb2RlTGlzdChUYWdO
b2RlTGlzdCosIGNvbnN0IFF1YWxpZmllZE5hbWUmKTsKICAgICB2b2lkIHJlbW92ZUNhY2hlZExh
YmVsc05vZGVMaXN0KER5bmFtaWNOb2RlTGlzdCopOwogICAgIAotICAgIFBhc3NSZWZQdHI8Tm9k
ZUxpc3Q+IGdldEVsZW1lbnRzQnlUYWdOYW1lKGNvbnN0IFN0cmluZyYpOwotICAgIFBhc3NSZWZQ
dHI8Tm9kZUxpc3Q+IGdldEVsZW1lbnRzQnlUYWdOYW1lTlMoY29uc3QgQXRvbWljU3RyaW5nJiBu
YW1lc3BhY2VVUkksIGNvbnN0IFN0cmluZyYgbG9jYWxOYW1lKTsKKyAgICBQYXNzUmVmUHRyPE5v
ZGVMaXN0PiBnZXRFbGVtZW50c0J5VGFnTmFtZShjb25zdCBBdG9taWNTdHJpbmcmKTsKKyAgICBQ
YXNzUmVmUHRyPE5vZGVMaXN0PiBnZXRFbGVtZW50c0J5VGFnTmFtZU5TKGNvbnN0IEF0b21pY1N0
cmluZyYgbmFtZXNwYWNlVVJJLCBjb25zdCBBdG9taWNTdHJpbmcmIGxvY2FsTmFtZSk7CiAgICAg
UGFzc1JlZlB0cjxOb2RlTGlzdD4gZ2V0RWxlbWVudHNCeU5hbWUoY29uc3QgU3RyaW5nJiBlbGVt
ZW50TmFtZSk7CiAgICAgUGFzc1JlZlB0cjxOb2RlTGlzdD4gZ2V0RWxlbWVudHNCeUNsYXNzTmFt
ZShjb25zdCBTdHJpbmcmIGNsYXNzTmFtZXMpOwogCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>