39889 2010-05-28 11:23:09 -0700 [Windows] Scroll offset being applied to plugins during print operation 2013-03-26 15:35:31 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 bfulgham bfulgham andersca aroben eric hamaji jhoneycutt tkent oldest_to_newest 231813 0 bfulgham 2010-05-28 11:23:09 -0700 The existing logic for handling printing for windowed plugins computes the page position based on the current page scroll. This is incorrect, as the printed page is never in a scrolled state. With the current code, scrolling the page and then printing causes the plugin to draw in different positions depending on the scroll state. 231825 1 bfulgham 2010-05-28 11:36:46 -0700 The Windows implementation of PluginView::paintWindowedPluginIntoContext is only used during print and print preview operations for windowed plugins. The drawing location passed to the plugin is computed based on the current scroll position, which is wrong for printing operations as the page position is always the same. 231828 2 57353 bfulgham 2010-05-28 11:38:06 -0700 Created attachment 57353 Patch 231856 3 57358 bfulgham 2010-05-28 12:01:54 -0700 Created attachment 57358 Patch 232203 4 eric 2010-05-30 11:21:47 -0700 Don't we have ways to test printing changes like this these days? 232259 5 hamaji 2010-05-30 22:23:24 -0700 I guess this patch changes pixel output but doesn't change render tree, right? If so, we cannot test this patch without Bug 20011. 232496 6 aroben 2010-05-31 12:39:32 -0700 We should get Anders and/or Jon to look at this. 258555 7 57358 zimmermann 2010-07-30 23:19:46 -0700 Comment on attachment 57358 Patch We have printing tests these days - Brent can you create a testcase? 423001 8 97676 bfulgham 2011-06-17 18:16:48 -0700 Created attachment 97676 Patch 864063 9 bfulgham 2013-03-26 15:35:31 -0700 Wow! This one got lost in the shuffle. Landed under https://trac.webkit.org/changeset/146941. 57353 2010-05-28 11:38:06 -0700 2010-05-28 12:01:51 -0700 Patch bug-39889-20100528113805.patch text/plain 3851 bfulgham SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MDM3MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDUtMjggIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUB3ZWJr aXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtXaW5kb3dzXSBTY3JvbGwgb2Zmc2V0IGJlaW5nIGFwcGxpZWQgdG8gcGx1Z2lucyBkdXJpbmcg cHJpbnQgb3BlcmF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0zOTg4OQorCisgICAgICAgIFJldmlzZSB0aGUgV2luZG93cyBpbXBsZW1lbnRhdGlv biBvZiB0aGUgUGx1Z2luVmlldyBjbGFzcworICAgICAgICBwYWludFdpbmRvd2VkUGx1Z2luSW50 b0NvbnRleHQgdG8gdXNlIHRoZSBjb250YWluaW5nIHdpbmRvdyBwb3NpdGlvbgorICAgICAgICB3 aGVuIGNvbXB1dGluZyB0aGUgcGx1Z2luJ3MgcG9zaXRpb24gZm9yIHByaW50aW5nLgorCisgICAg ICAgICogcGx1Z2lucy93aW4vUGx1Z2luVmlld1dpbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQ bHVnaW5WaWV3OjpwYWludFdpbmRvd2VkUGx1Z2luSW50b0NvbnRleHQpOgorCiAyMDEwLTA1LTI4 ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg RXJpYyBTZWlkZWwuCkluZGV4OiBXZWJDb3JlL3BsdWdpbnMvd2luL1BsdWdpblZpZXdXaW4uY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGx1Z2lucy93aW4vUGx1Z2luVmlld1dpbi5jcHAJKHJl dmlzaW9uIDYwMzI0KQorKysgV2ViQ29yZS9wbHVnaW5zL3dpbi9QbHVnaW5WaWV3V2luLmNwcAko d29ya2luZyBjb3B5KQpAQCAtNTU5LDcgKzU1OSw3IEBAIHZvaWQgUGx1Z2luVmlldzo6cGFpbnRX aW5kb3dlZFBsdWdpbkludG8KICAgICBBU1NFUlQoY29udGV4dC0+c2hvdWxkSW5jbHVkZUNoaWxk V2luZG93cygpKTsKIAogICAgIEFTU0VSVChwYXJlbnQoKS0+aXNGcmFtZVZpZXcoKSk7Ci0gICAg SW50UG9pbnQgbG9jYXRpb25JbldpbmRvdyA9IHN0YXRpY19jYXN0PEZyYW1lVmlldyo+KHBhcmVu dCgpKS0+Y29udGVudHNUb1dpbmRvdyhmcmFtZVJlY3QoKS5sb2NhdGlvbigpKTsKKyAgICBJbnRQ b2ludCBsb2NhdGlvbkluV2luZG93ID0gc3RhdGljX2Nhc3Q8RnJhbWVWaWV3Kj4ocGFyZW50KCkp LT5jb252ZXJ0VG9Db250YWluaW5nV2luZG93KGZyYW1lUmVjdCgpLmxvY2F0aW9uKCkpOwogCiAg ICAgSERDIGhkYyA9IGNvbnRleHQtPmdldFdpbmRvd3NDb250ZXh0KGZyYW1lUmVjdCgpLCBmYWxz ZSk7CiAKSW5kZXg6IFdlYktpdC93aW4vV2ViS2l0LnZjcHJvai9XZWJLaXQuc2xuCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYktpdC93aW4vV2ViS2l0LnZjcHJvai9XZWJLaXQuc2xuCShyZXZpc2lvbiA2MDMy NCkKKysrIFdlYktpdC93aW4vV2ViS2l0LnZjcHJvai9XZWJLaXQuc2xuCSh3b3JraW5nIGNvcHkp CkBAIC0yMjgsOCArMjI4LDggQEAgR2xvYmFsCiAJCXs0NEI5QzE1Mi0xODcwLTQwMzUtQjk0RC03 QjMyODVBQTBDMTJ9LlJlbGVhc2VfQ2Fpcm98V2luMzIuQnVpbGQuMCA9IFJlbGVhc2V8V2luMzIN CiAJCXs0NEI5QzE1Mi0xODcwLTQwMzUtQjk0RC03QjMyODVBQTBDMTJ9LlJlbGVhc2V8V2luMzIu QWN0aXZlQ2ZnID0gUmVsZWFzZXxXaW4zMg0KIAkJezQ0QjlDMTUyLTE4NzAtNDAzNS1COTRELTdC MzI4NUFBMEMxMn0uUmVsZWFzZXxXaW4zMi5CdWlsZC4wID0gUmVsZWFzZXxXaW4zMg0KLQkJezYy NjA4OUEzLTI1RDMtNDg4My1BOTZDLUI4QzY2RTAzNjM5N30uRGVidWdfQ2Fpcm98V2luMzIuQWN0 aXZlQ2ZnID0gRGVidWdfSW50ZXJuYWx8V2luMzINCi0JCXs2MjYwODlBMy0yNUQzLTQ4ODMtQTk2 Qy1COEM2NkUwMzYzOTd9LkRlYnVnX0NhaXJvfFdpbjMyLkJ1aWxkLjAgPSBEZWJ1Z19JbnRlcm5h bHxXaW4zMg0KKwkJezYyNjA4OUEzLTI1RDMtNDg4My1BOTZDLUI4QzY2RTAzNjM5N30uRGVidWdf Q2Fpcm98V2luMzIuQWN0aXZlQ2ZnID0gRGVidWdfQ2Fpcm98V2luMzINCisJCXs2MjYwODlBMy0y NUQzLTQ4ODMtQTk2Qy1COEM2NkUwMzYzOTd9LkRlYnVnX0NhaXJvfFdpbjMyLkJ1aWxkLjAgPSBE ZWJ1Z19DYWlyb3xXaW4zMg0KIAkJezYyNjA4OUEzLTI1RDMtNDg4My1BOTZDLUI4QzY2RTAzNjM5 N30uRGVidWd8V2luMzIuQWN0aXZlQ2ZnID0gRGVidWd8V2luMzINCiAJCXs2MjYwODlBMy0yNUQz LTQ4ODMtQTk2Qy1COEM2NkUwMzYzOTd9LkRlYnVnfFdpbjMyLkJ1aWxkLjAgPSBEZWJ1Z3xXaW4z Mg0KIAkJezYyNjA4OUEzLTI1RDMtNDg4My1BOTZDLUI4QzY2RTAzNjM5N30uUmVsZWFzZV9DYWly b3xXaW4zMi5BY3RpdmVDZmcgPSBEZWJ1Z3xXaW4zMg0KSW5kZXg6IFdlYktpdFRvb2xzL1Njcmlw dHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvU2NyaXB0 cy9vbGQtcnVuLXdlYmtpdC10ZXN0cwkocmV2aXNpb24gNjAzMjQpCisrKyBXZWJLaXRUb29scy9T Y3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzCSh3b3JraW5nIGNvcHkpCkBAIC0zNDcsNyArMzQ3 LDcgQEAgJHByb2R1Y3REaXIgLj0gIi9Qcm9ncmFtcyIgaWYgaXNHdGsoKTsKIAogY2hkaXJXZWJL aXQoKTsKIAotaWYgKCFkZWZpbmVkKCRyb290KSkgeworaWYgKDApIHsgIyFkZWZpbmVkKCRyb290 KSkgewogICAgIHByaW50IFNUREVSUiAiUnVubmluZyBidWlsZC1kdW1wcmVuZGVydHJlZVxuIjsK IAogICAgIGxvY2FsICpERVZOVUxMOwpJbmRleDogV2ViS2l0VG9vbHMvV2ViS2l0QVBJVGVzdC90 ZXN0cy9XZWJWaWV3RGVzdHJ1Y3Rpb24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1dl YktpdEFQSVRlc3QvdGVzdHMvV2ViVmlld0Rlc3RydWN0aW9uLmNwcAkocmV2aXNpb24gNjAzMjQp CisrKyBXZWJLaXRUb29scy9XZWJLaXRBUElUZXN0L3Rlc3RzL1dlYlZpZXdEZXN0cnVjdGlvbi5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTIxNSw2ICsyMTUsNyBAQCBURVNUKFdlYlZpZXdEZXN0cnVj dGlvbiwgQ2xvc2VUaGVuRGVzdHJvCiAvLyBUZXN0cyB0aGF0IGNhbGxpbmcgSVdlYlZpZXc6Om1h aW5GcmFtZSBhZnRlciBjYWxsaW5nIElXZWJWaWV3OjpjbG9zZSBkb2Vzbid0IGNyYXNoLiA8aHR0 cDovL3dlYmtpdC5vcmcvYi8zMjg2OD4KIFRFU1QoV2ViVmlld0Rlc3RydWN0aW9uLCBNYWluRnJh bWVBZnRlckNsb3NlKQogeworLyoKICAgICBDT01QdHI8SVdlYlZpZXc+IHdlYlZpZXc7CiAgICAg SG9zdFdpbmRvdyB3aW5kb3c7CiAgICAgSFdORCB2aWV3V2luZG93OwpAQCAtMjI1LDYgKzIyNiw3 IEBAIFRFU1QoV2ViVmlld0Rlc3RydWN0aW9uLCBNYWluRnJhbWVBZnRlckMKICAgICBURVNUX0FT U0VSVChTVUNDRUVERUQod2ViVmlldy0+bWFpbkZyYW1lKCZtYWluRnJhbWUpKSk7CiAKICAgICBm aW5pc2hXZWJWaWV3RGVzdHJ1Y3Rpb25UZXN0KHdlYlZpZXcsIHZpZXdXaW5kb3cpOworKi8KIH0K IAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0QVBJVGVzdAo= 57358 2010-05-28 12:01:54 -0700 2011-06-17 18:16:41 -0700 Patch bug-39889-20100528120153.patch text/plain 1488 bfulgham SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MDM3MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDUtMjggIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUB3ZWJr aXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtXaW5kb3dzXSBTY3JvbGwgb2Zmc2V0IGJlaW5nIGFwcGxpZWQgdG8gcGx1Z2lucyBkdXJpbmcg cHJpbnQgb3BlcmF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0zOTg4OQorCisgICAgICAgIFJldmlzZSB0aGUgV2luZG93cyBpbXBsZW1lbnRhdGlv biBvZiB0aGUgUGx1Z2luVmlldyBjbGFzcworICAgICAgICBwYWludFdpbmRvd2VkUGx1Z2luSW50 b0NvbnRleHQgdG8gdXNlIHRoZSBjb250YWluaW5nIHdpbmRvdyBwb3NpdGlvbgorICAgICAgICB3 aGVuIGNvbXB1dGluZyB0aGUgcGx1Z2luJ3MgcG9zaXRpb24gZm9yIHByaW50aW5nLgorCisgICAg ICAgICogcGx1Z2lucy93aW4vUGx1Z2luVmlld1dpbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQ bHVnaW5WaWV3OjpwYWludFdpbmRvd2VkUGx1Z2luSW50b0NvbnRleHQpOgorCiAyMDEwLTA1LTI4 ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg RXJpYyBTZWlkZWwuCkluZGV4OiBXZWJDb3JlL3BsdWdpbnMvd2luL1BsdWdpblZpZXdXaW4uY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGx1Z2lucy93aW4vUGx1Z2luVmlld1dpbi5jcHAJKHJl dmlzaW9uIDYwMzI0KQorKysgV2ViQ29yZS9wbHVnaW5zL3dpbi9QbHVnaW5WaWV3V2luLmNwcAko d29ya2luZyBjb3B5KQpAQCAtNTU5LDcgKzU1OSw3IEBAIHZvaWQgUGx1Z2luVmlldzo6cGFpbnRX aW5kb3dlZFBsdWdpbkludG8KICAgICBBU1NFUlQoY29udGV4dC0+c2hvdWxkSW5jbHVkZUNoaWxk V2luZG93cygpKTsKIAogICAgIEFTU0VSVChwYXJlbnQoKS0+aXNGcmFtZVZpZXcoKSk7Ci0gICAg SW50UG9pbnQgbG9jYXRpb25JbldpbmRvdyA9IHN0YXRpY19jYXN0PEZyYW1lVmlldyo+KHBhcmVu dCgpKS0+Y29udGVudHNUb1dpbmRvdyhmcmFtZVJlY3QoKS5sb2NhdGlvbigpKTsKKyAgICBJbnRQ b2ludCBsb2NhdGlvbkluV2luZG93ID0gc3RhdGljX2Nhc3Q8RnJhbWVWaWV3Kj4ocGFyZW50KCkp LT5jb252ZXJ0VG9Db250YWluaW5nV2luZG93KGZyYW1lUmVjdCgpLmxvY2F0aW9uKCkpOwogCiAg ICAgSERDIGhkYyA9IGNvbnRleHQtPmdldFdpbmRvd3NDb250ZXh0KGZyYW1lUmVjdCgpLCBmYWxz ZSk7CiAK 97676 2011-06-17 18:16:48 -0700 2011-12-21 13:27:27 -0800 Patch bug-39889-20110617181647.patch text/plain 1643 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg5MTgwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDYtMTcgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtXaW5kb3dzLCBXaW5DYWlyb10gU2Nyb2xsIG9mZnNldCBi ZWluZyBhcHBsaWVkIHRvIHBsdWdpbnMgZHVyaW5nIHByaW50CisgICAgICAgIG9wZXJhdGlvbi4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5ODg5CisK KyAgICAgICAgVGhpcyBtdXN0IGJlIHRlc3RlZCBtYW51YWxseS4gU2VlIHRoZSBpc3N1ZSBmb3Ig ZGV0YWlscy4KKworICAgICAgICAqIHBsdWdpbnMvd2luL1BsdWdpblZpZXdXaW4uY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UGx1Z2luVmlldzo6cGFpbnRXaW5kb3dlZFBsdWdpbkludG9Db250ZXh0 KToKKyAgICAgICAgUmV2aXNlIHRoZSBXaW5kb3dzIGltcGxlbWVudGF0aW9uIG9mIHRoZSBQbHVn aW5WaWV3IGNsYXNzCisgICAgICAgIHBhaW50V2luZG93ZWRQbHVnaW5JbnRvQ29udGV4dCB0byB1 c2UgdGhlIGNvbnRhaW5pbmcgd2luZG93IHBvc2l0aW9uCisgICAgICAgIHdoZW4gY29tcHV0aW5n IHRoZSBwbHVnaW4ncyBwb3NpdGlvbiBmb3IgcHJpbnRpbmcuCisKKwogMjAxMS0wNi0xNyAgU2hl cmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZp ZXdlZCwgcm9sbGluZyBvdXQgcjg5MTQzLgpJbmRleDogU291cmNlL1dlYkNvcmUvcGx1Z2lucy93 aW4vUGx1Z2luVmlld1dpbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGx1Z2lu cy93aW4vUGx1Z2luVmlld1dpbi5jcHAJKHJldmlzaW9uIDg5MTgwKQorKysgU291cmNlL1dlYkNv cmUvcGx1Z2lucy93aW4vUGx1Z2luVmlld1dpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU2NCw3 ICs1NjQsNyBAQCB2b2lkIFBsdWdpblZpZXc6OnBhaW50V2luZG93ZWRQbHVnaW5JbnRvCiAgICAg QVNTRVJUKGNvbnRleHQtPnNob3VsZEluY2x1ZGVDaGlsZFdpbmRvd3MoKSk7CiAKICAgICBBU1NF UlQocGFyZW50KCktPmlzRnJhbWVWaWV3KCkpOwotICAgIEludFBvaW50IGxvY2F0aW9uSW5XaW5k b3cgPSBzdGF0aWNfY2FzdDxGcmFtZVZpZXcqPihwYXJlbnQoKSktPmNvbnRlbnRzVG9XaW5kb3co ZnJhbWVSZWN0KCkubG9jYXRpb24oKSk7CisgICAgSW50UG9pbnQgbG9jYXRpb25JbldpbmRvdyA9 IHN0YXRpY19jYXN0PEZyYW1lVmlldyo+KHBhcmVudCgpKS0+Y29udmVydFRvQ29udGFpbmluZ1dp bmRvdyhmcmFtZVJlY3QoKS5sb2NhdGlvbigpKTsKIAogICAgIExvY2FsV2luZG93c0NvbnRleHQg d2luZG93c0NvbnRleHQoY29udGV4dCwgZnJhbWVSZWN0KCksIGZhbHNlKTsKIAo=