39887 2010-05-28 10:57:17 -0700 [chromium] Add isXHTMLDocument() to Chromium's WebKit::WebDocument 2010-06-01 15:22:35 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 aa webkit-unassigned ap dglazkov eric fishd ojan webkit.review.bot oldest_to_newest 231794 0 aa 2010-05-28 10:57:17 -0700 Add isXHTMLDocument() to Chromium's WebKit::WebDocument 231796 1 57345 aa 2010-05-28 11:01:07 -0700 Created attachment 57345 Patch 231850 2 webkit.review.bot 2010-05-28 11:54:27 -0700 Attachment 57345 did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/2644039 231873 3 aa 2010-05-28 12:34:13 -0700 Whoops. Please hold for better patch. 231887 4 57364 aa 2010-05-28 12:55:55 -0700 Created attachment 57364 Patch 231916 5 57364 fishd 2010-05-28 13:49:35 -0700 Comment on attachment 57364 Patch WebCore/ChangeLog:5 + Added isXHTMLDocument() to WebCore::Document. nit: add bug link WebKit/chromium/ChangeLog:5 + Add isXHTMLDocument() to WebDocument. nit: add bug link 231978 6 aa 2010-05-28 15:43:15 -0700 Committed r60377: <http://trac.webkit.org/changeset/60377> 231979 7 eric 2010-05-28 15:44:50 -0700 Why would you want this? Don't you want to know if it's XML vs. HTML? I can't remember if there is a difference between an XHTML document and an SVG document. Then again, all of this is going to change in HTML5. 231980 8 eric 2010-05-28 15:46:10 -0700 WebCore currently has 3 types of documents: HTMLDocument (exposes things like document.body) Document (generic XML, no .body) SVGDocument (<svg> root, exposes a couple SVG-specific things). HTML5 has opinions on all of this. I think all interfaces are exposed on all document types in HTML5. 231986 9 aa 2010-05-28 15:51:34 -0700 I want to know whether the document has things like a body node. When I debugged through it Document::isHTMLDocument() is not currently true for XHTML documents. m_xhtml is true, but m_html is false. So I added this method so that I could catch the XHTML case. Is there a better fix? 231992 10 eric 2010-05-28 15:57:20 -0700 Well, the real fix is HTML5. :) But I'm surprised you don't just check document.body and if that fails, check document.documentElement.firstChild. It's lame that our XHTML documents don't have a .body (even though no spec until HTML5 said they should), but the .documentElement is a pretty common workaround. Again, all of this will go away when we move to HTML5's document structure (I don't know when that will be). We should just design whatever API so that it is future compatible. 232002 11 aa 2010-05-28 16:26:54 -0700 You are right, that is a better fix. I'm going to rollback this change and submit one just checking document.documentElement's node name is HTML, which is close enough to what I'm after, and more forward compatible. 232967 12 ap 2010-06-01 15:18:18 -0700 > It's lame that our XHTML documents don't have a .body (even though > no spec until HTML5 said they should) They do, and have done for a long time. Implemented in bug 12628. 232968 13 ap 2010-06-01 15:22:35 -0700 > SVGDocument (<svg> root, exposes a couple SVG-specific things). It seems that the only difference is how document.title works - as you mentioned, all documents expose all interfaces in HTML5. 57345 2010-05-28 11:01:07 -0700 2010-05-28 12:39:34 -0700 Patch bug-39887-20100528110106.patch text/plain 1677 aa ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGJhMzZiNWYuLmRjMDY4MzAgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDEzIEBACisyMDEwLTA1LTI4ICBBYXJvbiBCb29kbWFuICA8YWFAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBpc1hIVE1M RG9jdW1lbnQoKSB0byBXZWJEb2N1bWVudC4KKworICAgICAgICAqIHB1YmxpYy9XZWJEb2N1bWVu dC5oOiBBZGQgaXNYSFRNTERvY3VtZW50KCkuCisgICAgICAgICogc3JjL1dlYkRvY3VtZW50LmNw cDogZGl0dG8uCisgICAgICAgIChXZWJLaXQ6OldlYkRvY3VtZW50Ojppc1hIVE1MRG9jdW1lbnQp OiBkaXR0b3JhbWEuCisKIDIwMTAtMDQtMTQgIEFhcm9uIEJvb2RtYW4gIDxhYUBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2aW4uCmRpZmYgLS1naXQgYS9XZWJL aXQvY2hyb21pdW0vcHVibGljL1dlYkRvY3VtZW50LmggYi9XZWJLaXQvY2hyb21pdW0vcHVibGlj L1dlYkRvY3VtZW50LmgKaW5kZXggMWYwOTY1My4uYzA5M2M1OCAxMDA2NDQKLS0tIGEvV2ViS2l0 L2Nocm9taXVtL3B1YmxpYy9XZWJEb2N1bWVudC5oCisrKyBiL1dlYktpdC9jaHJvbWl1bS9wdWJs aWMvV2ViRG9jdW1lbnQuaApAQCAtNjIsNiArNjIsNyBAQCBwdWJsaWM6CiAgICAgLy8gUmV0dXJu cyB0aGUgZnJhbWUgdGhlIGRvY3VtZW50IGJlbG9uZ3MgdG8gb3IgMCBpZiB0aGUgZG9jdW1lbnQg aXMgZnJhbWVsZXNzLgogICAgIFdFQktJVF9BUEkgV2ViRnJhbWUqIGZyYW1lKCkgY29uc3Q7CiAg ICAgV0VCS0lUX0FQSSBib29sIGlzSFRNTERvY3VtZW50KCkgY29uc3Q7CisgICAgV0VCS0lUX0FQ SSBib29sIGlzWEhUTUxEb2N1bWVudCgpIGNvbnN0OwogICAgIFdFQktJVF9BUEkgYm9vbCBpc1Bs dWdpbkRvY3VtZW50KCkgY29uc3Q7CiAgICAgV0VCS0lUX0FQSSBXZWJVUkwgYmFzZVVSTCgpIGNv bnN0OwogICAgIFdFQktJVF9BUEkgV2ViVVJMIGZpcnN0UGFydHlGb3JDb29raWVzKCkgY29uc3Q7 CmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkRvY3VtZW50LmNwcCBiL1dlYktp dC9jaHJvbWl1bS9zcmMvV2ViRG9jdW1lbnQuY3BwCmluZGV4IDIxZTJiYjguLjU5MWQyOTYgMTAw NjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRG9jdW1lbnQuY3BwCisrKyBiL1dlYktp dC9jaHJvbWl1bS9zcmMvV2ViRG9jdW1lbnQuY3BwCkBAIC02Miw2ICs2MiwxMSBAQCBib29sIFdl YkRvY3VtZW50Ojppc0hUTUxEb2N1bWVudCgpIGNvbnN0CiAgICAgcmV0dXJuIGNvbnN0VW53cmFw PERvY3VtZW50PigpLT5pc0hUTUxEb2N1bWVudCgpOwogfQogCitib29sIFdlYkRvY3VtZW50Ojpp c1hIVE1MRG9jdW1lbnQoKSBjb25zdAoreworICAgIHJldHVybiBjb25zdFVud3JhcDxEb2N1bWVu dD4oKS0+aXNYSFRNTERvY3VtZW50KCk7Cit9CisgIAogYm9vbCBXZWJEb2N1bWVudDo6aXNQbHVn aW5Eb2N1bWVudCgpIGNvbnN0CiB7ICAKICAgICByZXR1cm4gY29uc3RVbndyYXA8RG9jdW1lbnQ+ KCktPmlzUGx1Z2luRG9jdW1lbnQoKTsK 57364 2010-05-28 12:55:55 -0700 2010-05-28 13:49:35 -0700 Patch bug-39887-20100528125554.patch text/plain 2619 aa ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YjBlZDY2ZC4uMmM0NDc4NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0wNS0yOCAgQWFyb24gQm9vZG1h biAgPGFhQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBZGRlZCBpc1hIVE1MRG9jdW1lbnQoKSB0byBXZWJDb3JlOjpEb2N1bWVu dC4KKworICAgICAgICAqIGRvbS9Eb2N1bWVudC5oOiBBZGQgaXNYSFRNTERvY3VtZW50KCkuCisg ICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6aXNYSFRNTERvY3VtZW50KTogRGl0dG8uCisKIDIw MTAtMDQtMTQgIEFhcm9uIEJvb2RtYW4gIDxhYUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgRGF2aWQgTGV2aW4uCmRpZmYgLS1naXQgYS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5o IGIvV2ViQ29yZS9kb20vRG9jdW1lbnQuaAppbmRleCA5ZmUyZTAxLi5iYjI1ZjgwIDEwMDY0NAot LS0gYS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCisrKyBiL1dlYkNvcmUvZG9tL0RvY3VtZW50LmgK QEAgLTM2Miw2ICszNjIsNyBAQCBwdWJsaWM6CiAKICAgICAvLyBPdGhlciBtZXRob2RzIChub3Qg cGFydCBvZiBET00pCiAgICAgYm9vbCBpc0hUTUxEb2N1bWVudCgpIGNvbnN0IHsgcmV0dXJuIG1f aXNIVE1MOyB9CisgICAgYm9vbCBpc1hIVE1MRG9jdW1lbnQoKSBjb25zdCB7IHJldHVybiBtX2lz WEhUTUw7IH0KICAgICB2aXJ0dWFsIGJvb2wgaXNJbWFnZURvY3VtZW50KCkgY29uc3QgeyByZXR1 cm4gZmFsc2U7IH0KICNpZiBFTkFCTEUoU1ZHKQogICAgIHZpcnR1YWwgYm9vbCBpc1NWR0RvY3Vt ZW50KCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1 bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4IGJhMzZiNWYuLmRj MDY4MzAgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0 L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEwLTA1LTI4ICBBYXJvbiBC b29kbWFuICA8YWFAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEFkZCBpc1hIVE1MRG9jdW1lbnQoKSB0byBXZWJEb2N1bWVudC4K KworICAgICAgICAqIHB1YmxpYy9XZWJEb2N1bWVudC5oOiBBZGQgaXNYSFRNTERvY3VtZW50KCku CisgICAgICAgICogc3JjL1dlYkRvY3VtZW50LmNwcDogZGl0dG8uCisgICAgICAgIChXZWJLaXQ6 OldlYkRvY3VtZW50Ojppc1hIVE1MRG9jdW1lbnQpOiBkaXR0b3JhbWEuCisKIDIwMTAtMDQtMTQg IEFhcm9uIEJvb2RtYW4gIDxhYUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg RGF2aWQgTGV2aW4uCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkRvY3Vt ZW50LmggYi9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkRvY3VtZW50LmgKaW5kZXggMWYwOTY1 My4uYzA5M2M1OCAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJEb2N1bWVu dC5oCisrKyBiL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRG9jdW1lbnQuaApAQCAtNjIsNiAr NjIsNyBAQCBwdWJsaWM6CiAgICAgLy8gUmV0dXJucyB0aGUgZnJhbWUgdGhlIGRvY3VtZW50IGJl bG9uZ3MgdG8gb3IgMCBpZiB0aGUgZG9jdW1lbnQgaXMgZnJhbWVsZXNzLgogICAgIFdFQktJVF9B UEkgV2ViRnJhbWUqIGZyYW1lKCkgY29uc3Q7CiAgICAgV0VCS0lUX0FQSSBib29sIGlzSFRNTERv Y3VtZW50KCkgY29uc3Q7CisgICAgV0VCS0lUX0FQSSBib29sIGlzWEhUTUxEb2N1bWVudCgpIGNv bnN0OwogICAgIFdFQktJVF9BUEkgYm9vbCBpc1BsdWdpbkRvY3VtZW50KCkgY29uc3Q7CiAgICAg V0VCS0lUX0FQSSBXZWJVUkwgYmFzZVVSTCgpIGNvbnN0OwogICAgIFdFQktJVF9BUEkgV2ViVVJM IGZpcnN0UGFydHlGb3JDb29raWVzKCkgY29uc3Q7CmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYkRvY3VtZW50LmNwcCBiL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRG9jdW1lbnQu Y3BwCmluZGV4IDIxZTJiYjguLjU5MWQyOTYgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViRG9jdW1lbnQuY3BwCisrKyBiL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRG9jdW1lbnQu Y3BwCkBAIC02Miw2ICs2MiwxMSBAQCBib29sIFdlYkRvY3VtZW50Ojppc0hUTUxEb2N1bWVudCgp IGNvbnN0CiAgICAgcmV0dXJuIGNvbnN0VW53cmFwPERvY3VtZW50PigpLT5pc0hUTUxEb2N1bWVu dCgpOwogfQogCitib29sIFdlYkRvY3VtZW50Ojppc1hIVE1MRG9jdW1lbnQoKSBjb25zdAorewor ICAgIHJldHVybiBjb25zdFVud3JhcDxEb2N1bWVudD4oKS0+aXNYSFRNTERvY3VtZW50KCk7Cit9 CisgIAogYm9vbCBXZWJEb2N1bWVudDo6aXNQbHVnaW5Eb2N1bWVudCgpIGNvbnN0CiB7ICAKICAg ICByZXR1cm4gY29uc3RVbndyYXA8RG9jdW1lbnQ+KCktPmlzUGx1Z2luRG9jdW1lbnQoKTsK