39859 2010-05-27 18:55:26 -0700 ScrollView::setFrameRect should not call contentsResized when there is a fixed layout size 2010-05-28 11:52:50 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 manyoso webkit-unassigned abarth eric webkit.review.bot oldest_to_newest 231530 0 manyoso 2010-05-27 18:55:26 -0700 Layout is not dependent upon the frameRect when using fixed layout size therefore we should not cause a layout with this 231787 1 57343 manyoso 2010-05-28 10:47:14 -0700 Created attachment 57343 Patch 231791 2 57343 dbates 2010-05-28 10:53:22 -0700 Comment on attachment 57343 Patch > diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog > index a63213f..7c99717 100644 > --- a/WebCore/ChangeLog > +++ b/WebCore/ChangeLog > @@ -1,3 +1,15 @@ > +2010-05-28 Adam Treat <atreat@rim.com> > + > + Reviewed by Daniel Bates. > + > + Bug #293 and https://bugs.webkit.org/show_bug.cgi?id=39859 > + > + Layout is not dependent upon ScrollView::frameRect when useFixedLayout > + is true. No reason to set the needs layout flag in this case. > + > + * platform/ScrollView.cpp: > + (WebCore::ScrollView::wheelEvent): This change log disagrees with both the patch and the description since ScrollView::wheelEven was not modified. Looks sane to me. r=me. 231793 3 manyoso 2010-05-28 10:56:32 -0700 Landed with r60367 231842 4 webkit.review.bot 2010-05-28 11:47:51 -0700 http://trac.webkit.org/changeset/60367 might have broken Tiger Intel Release The following changes are on the blame list: http://trac.webkit.org/changeset/60368 http://trac.webkit.org/changeset/60369 http://trac.webkit.org/changeset/60370 http://trac.webkit.org/changeset/60366 http://trac.webkit.org/changeset/60367 231847 5 abarth 2010-05-28 11:52:50 -0700 cfleizach fixed the break in http://trac.webkit.org/changeset/60372 57343 2010-05-28 10:47:14 -0700 2010-05-28 10:53:21 -0700 Patch 39859.patch text/plain 1158 manyoso ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTYzMjEzZi4uN2M5OTcxNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNS0yOCAgQWRhbSBUcmVhdCAg PGF0cmVhdEByaW0uY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IERhbmllbCBCYXRlcy4KKwor ICAgICAgICBCdWcgIzI5MyBhbmQgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTM5ODU5CisKKyAgICAgICAgTGF5b3V0IGlzIG5vdCBkZXBlbmRlbnQgdXBvbiBTY3JvbGxW aWV3OjpmcmFtZVJlY3Qgd2hlbiB1c2VGaXhlZExheW91dAorICAgICAgICBpcyB0cnVlLiAgTm8g cmVhc29uIHRvIHNldCB0aGUgbmVlZHMgbGF5b3V0IGZsYWcgaW4gdGhpcyBjYXNlLgorCisgICAg ICAgICogcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxW aWV3Ojp3aGVlbEV2ZW50KToKKwogMjAxMC0wNS0yOCAgTWlraGFpbCBOYWdhbm92ICA8bW5hZ2Fu b3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIFJldmVydCA2MDM1MyAtLSBp bW1hdHVyZS4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHAgYi9X ZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCmluZGV4IDlhZWJhOTguLjI5MWM0NDkgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHAKKysrIGIvV2ViQ29yZS9w bGF0Zm9ybS9TY3JvbGxWaWV3LmNwcApAQCAtNjg0LDcgKzY4NCw4IEBAIHZvaWQgU2Nyb2xsVmll dzo6c2V0RnJhbWVSZWN0KGNvbnN0IEludFJlY3QmIG5ld1JlY3QpCiAgICAgCiAgICAgaWYgKG5l d1JlY3Qud2lkdGgoKSAhPSBvbGRSZWN0LndpZHRoKCkgfHwgbmV3UmVjdC5oZWlnaHQoKSAhPSBv bGRSZWN0LmhlaWdodCgpKSB7CiAgICAgICAgIHVwZGF0ZVNjcm9sbGJhcnMobV9zY3JvbGxPZmZz ZXQpOwotICAgICAgICBjb250ZW50c1Jlc2l6ZWQoKTsKKyAgICAgICAgaWYgKCFtX3VzZUZpeGVk TGF5b3V0KQorICAgICAgICAgICAgY29udGVudHNSZXNpemVkKCk7CiAgICAgfQogCiAgICAgZnJh bWVSZWN0c0NoYW5nZWQoKTsK