39852 2010-05-27 11:35:10 -0700 [Qt] fast/encoding/yentest.html fails 2011-05-18 16:35:58 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All Linux RESOLVED FIXED Qt, QtTriaged P3 Normal --- 60786 1 ap s.mathur benjamin commit-queue cshu hamaji hausmann ossy s.mathur oldest_to_newest 231404 0 ap 2010-05-27 11:35:10 -0700 fast/encoding/yentest.html and fast/encoding/yentest2.html are new tests that fail on Qt. -two backslashes external: \ -two backslashes inline: \ +two backslashes external: ¥¥ +two backslashes inline: ¥¥ 231406 1 ap 2010-05-27 11:38:19 -0700 Disabled the tests in r60314. This looks like either a Qt DRT deficiency, or a pretty bad bug that would break most JavaScript code on pages with certain Japanese encodings. 311052 2 ap 2010-11-18 13:06:18 -0800 Or perhaps Qt just doesn't recognize charset name "shift-jis" (as opposed to canonical Shift_JIS). 404353 3 hausmann 2011-05-16 01:22:30 -0700 This is actually difference between Qt's shift-jis codec implementation and ICU. The intention of changing this is Qt is now tracked at http://bugreports.qt.nokia.com/browse/QTBUG-19335 405952 4 93968 s.mathur 2011-05-18 12:37:42 -0700 Created attachment 93968 Patch 405957 5 cshu 2011-05-18 12:42:54 -0700 LGTM. I also ran the tests and they are passing. :) 406016 6 93968 s.mathur 2011-05-18 14:10:47 -0700 Comment on attachment 93968 Patch Forgot to cq? it before review. Hope this leads to a commit by the cq. :) 406017 7 93968 webkit.review.bot 2011-05-18 14:11:28 -0700 Comment on attachment 93968 Patch Rejecting attachment 93968 from commit-queue. siddharth.mathur@nokia.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 406089 8 93968 commit-queue 2011-05-18 16:35:05 -0700 Comment on attachment 93968 Patch Clearing flags on attachment: 93968 Committed r86803: <http://trac.webkit.org/changeset/86803> 406090 9 commit-queue 2011-05-18 16:35:10 -0700 All reviewed patches have been landed. Closing bug. 406093 10 commit-queue 2011-05-18 16:35:58 -0700 The commit-queue encountered the following flaky tests while processing attachment 93968: http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com) The commit-queue is continuing to process your patch. 93968 2011-05-18 12:37:42 -0700 2011-05-18 16:35:05 -0700 Patch bug-39852-20110518153738.patch text/plain 1130 s.mathur SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDg2NzgwKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDUtMTggIFNpZGRoYXJ0aCBNYXRodXIg IDxzaWRkaGFydGgubWF0aHVyQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIGZhc3QvZW5jb2RpbmcveWVudGVzdC5odG1sIGFu ZCB5ZW50ZXN0Mi5odG1sIGZhaWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTM5ODUyCisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9Ta2lwcGVkOiBVbnNr aXAgcGFzc2luZyB0ZXN0cy4KKwogMjAxMS0wNS0xOCAgQ2hhbmcgU2h1ICA8Y3NodUB3ZWJraXQu b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IENzYWJhIE9zenRyb2dvbsOhYy4KSW5kZXg6IExh eW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv cGxhdGZvcm0vcXQvU2tpcHBlZAkocmV2aXNpb24gODY3NzMpCisrKyBMYXlvdXRUZXN0cy9wbGF0 Zm9ybS9xdC9Ta2lwcGVkCSh3b3JraW5nIGNvcHkpCkBAIC0xMzEwLDEwICsxMzEwLDYgQEAgZmFz dC9tdWx0aWNvbC9oaXQtdGVzdC1hYm92ZS1vci1iZWxvdy5odAogIyBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc2OTcKIGZhc3QvdXJsL2hvc3QuaHRtbAogCi0jIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTg1MgotZmFzdC9lbmNvZGlu Zy95ZW50ZXN0Lmh0bWwKLWZhc3QvZW5jb2RpbmcveWVudGVzdDIuaHRtbAotCiAjIC0tIGZhaWwg d2l0aCAtLXBsYXRmb3JtIG1hYyAtLWlnbm9yZS1tZXRyaWNzCiBmYXN0L2JveC1zaXppbmcvcGVy Y2VudGFnZS1oZWlnaHQuaHRtbAogZmFzdC9jc3MvYWNpZDItcGl4ZWwuaHRtbAo=